linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	"David S . Miller" <davem@davemloft.net>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Lukas Wunner <lukas@wunner.de>, Rob Herring <robh@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
	David Lechner <david@lechnology.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Lunn <andrew@lunn.ch>, Jonathan Corbet <corbet@lwn.net>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	netdev@vger.kernel.org,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH v3 17/18] ARM: davinci: sffsdr: use device properties for at24 eeprom
Date: Thu, 28 Jun 2018 16:32:43 +0200	[thread overview]
Message-ID: <20180628143244.4561-18-brgl@bgdev.pl> (raw)
In-Reply-To: <20180628143244.4561-1-brgl@bgdev.pl>

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

We want to work towards phasing out the at24_platform_data structure.
There are few users and its contents can be represented using generic
device properties. Using device properties only will allow us to
significantly simplify the at24 configuration code.

Remove the at24_platform_data structure and replace it with an array
of property entries. Drop the byte_len/size property, as the model name
already implies the EEPROM's size.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 arch/arm/mach-davinci/board-sffsdr.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/arch/arm/mach-davinci/board-sffsdr.c b/arch/arm/mach-davinci/board-sffsdr.c
index f6a4d094cbc3..680e5d7628a8 100644
--- a/arch/arm/mach-davinci/board-sffsdr.c
+++ b/arch/arm/mach-davinci/board-sffsdr.c
@@ -26,7 +26,7 @@
 #include <linux/init.h>
 #include <linux/platform_device.h>
 #include <linux/i2c.h>
-#include <linux/platform_data/at24.h>
+#include <linux/property.h>
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/rawnand.h>
 #include <linux/mtd/partitions.h>
@@ -92,16 +92,15 @@ static struct platform_device davinci_sffsdr_nandflash_device = {
 	.resource	= davinci_sffsdr_nandflash_resource,
 };
 
-static struct at24_platform_data eeprom_info = {
-	.byte_len	= (64*1024) / 8,
-	.page_size	= 32,
-	.flags		= AT24_FLAG_ADDR16,
+static const struct property_entry eeprom_properties[] = {
+	PROPERTY_ENTRY_U32("pagesize", 32),
+	{ },
 };
 
 static struct i2c_board_info __initdata i2c_info[] =  {
 	{
 		I2C_BOARD_INFO("24c64", 0x50),
-		.platform_data	= &eeprom_info,
+		.properties = eeprom_properties,
 	},
 	/* Other I2C devices:
 	 * MSP430,  addr 0x23 (not used)
-- 
2.17.1


  parent reply	other threads:[~2018-06-28 14:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-28 14:32 [PATCH v3 00/18] ARM: davinci: step towards removing at24_platform_data Bartosz Golaszewski
2018-06-28 14:32 ` [PATCH v3 01/18] nvmem: add support for cell lookups Bartosz Golaszewski
2018-06-28 14:32 ` [PATCH v3 02/18] Documentation: nvmem: document lookup entries Bartosz Golaszewski
2018-06-28 14:32 ` [PATCH v3 03/18] ARM: davinci: dm365-evm: use nvmem lookup for mac address Bartosz Golaszewski
2018-06-28 14:32 ` [PATCH v3 04/18] ARM: davinci: dm644-evm: " Bartosz Golaszewski
2018-06-28 14:32 ` [PATCH v3 05/18] ARM: davinci: dm646x-evm: " Bartosz Golaszewski
2018-06-28 14:32 ` [PATCH v3 06/18] ARM: davinci: da830-evm: " Bartosz Golaszewski
2018-06-28 14:32 ` [PATCH v3 07/18] ARM: davinci: mityomapl138: add nvmem cells lookup entries Bartosz Golaszewski
2018-06-28 14:32 ` [PATCH v3 08/18] net: davinci_emac: potentially get the MAC address from MTD Bartosz Golaszewski
2018-06-28 14:32 ` [PATCH v3 09/18] ARM: davinci: da850-evm: remove dead MTD code Bartosz Golaszewski
2018-06-28 14:32 ` [PATCH v3 10/18] net: davinci_emac: use nvmem to retrieve the mac address Bartosz Golaszewski
2018-06-28 14:32 ` [PATCH v3 11/18] ARM: davinci: mityomapl138: don't read the MAC address from machine code Bartosz Golaszewski
2018-06-28 14:32 ` [PATCH v3 12/18] ARM: davinci: dm365-evm: use device properties for at24 eeprom Bartosz Golaszewski
2018-06-28 14:32 ` [PATCH v3 13/18] ARM: davinci: da830-evm: " Bartosz Golaszewski
2018-06-28 14:32 ` [PATCH v3 14/18] ARM: davinci: dm644x-evm: " Bartosz Golaszewski
2018-06-28 14:32 ` [PATCH v3 15/18] ARM: davinci: dm646x-evm: " Bartosz Golaszewski
2018-06-28 14:32 ` [PATCH v3 16/18] ARM: davinci: sffsdr: fix the at24 eeprom device name Bartosz Golaszewski
2018-06-28 14:32 ` Bartosz Golaszewski [this message]
2018-06-28 14:32 ` [PATCH v3 18/18] ARM: davinci: remove dead code related to MAC address reading Bartosz Golaszewski
2018-06-29  9:42 ` [PATCH v3 00/18] ARM: davinci: step towards removing at24_platform_data Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180628143244.4561-18-brgl@bgdev.pl \
    --to=brgl@bgdev.pl \
    --cc=andrew@lunn.ch \
    --cc=bgolaszewski@baylibre.com \
    --cc=corbet@lwn.net \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=david@lechnology.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=grygorii.strashko@ti.com \
    --cc=ivan.khoronzhuk@linaro.org \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=lukas@wunner.de \
    --cc=netdev@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=robh@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).