From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Bart Dorsey <echo@thebucket.org>
Cc: linux-kernel@vger.kernel.org, mid@auk.cx, phillim@amtrak.com,
alan@redhat.com, Linus Torvalds <torvalds@transmeta.com>
Subject: [PATCH] Re: Problem with Madge Tokenring (abyss.o) in 2.4.1-pre10
Date: Tue, 23 Jan 2001 10:23:35 -0500 [thread overview]
Message-ID: <3A6DA1F7.9169C3BD@mandrakesoft.com> (raw)
In-Reply-To: <Pine.LNX.4.21.0101230832550.25107-100000@www>
[-- Attachment #1: Type: text/plain, Size: 696 bytes --]
Bart Dorsey wrote:
> I constantly get this message on the console while using a Madge Smart
> 16/4 PCI Mk2 (Abyss) token ring card.
>
> kernel: Warning: kfree_skb on hard IRQ d08cfea9
The attached patch, against 2.4.1-pre10, should fix things. tms380tr,
the base module that abyss driver uses, needed to be updated to use
special IRQ versions of the dev_kfree_skb function.
Linus (and others), the patch also adds a missing dev->last_rx
assignment (which records the time of last packet reception).
--
Jeff Garzik | "You see, in this world there's two kinds of
Building 1024 | people, my friend: Those with loaded guns
MandrakeSoft | and those who dig. You dig." --Blondie
[-- Attachment #2: tms380tr.patch --]
[-- Type: text/plain, Size: 1342 bytes --]
Index: linux_2_4/drivers/net/tokenring/tms380tr.c
diff -u linux_2_4/drivers/net/tokenring/tms380tr.c:1.1.1.3 linux_2_4/drivers/net/tokenring/tms380tr.c:1.1.1.3.76.2
--- linux_2_4/drivers/net/tokenring/tms380tr.c:1.1.1.3 Sun Oct 22 14:56:23 2000
+++ linux_2_4/drivers/net/tokenring/tms380tr.c Tue Jan 23 07:19:16 2001
@@ -1977,7 +1977,7 @@
printk(KERN_INFO "Cancel tx (%08lXh).\n", (unsigned long)tpl);
- dev_kfree_skb(tpl->Skb);
+ dev_kfree_skb_any(tpl->Skb);
}
for(;;)
@@ -1986,7 +1986,7 @@
if(skb == NULL)
break;
tp->QueueSkb++;
- dev_kfree_skb(skb);
+ dev_kfree_skb_any(skb);
}
return;
@@ -2053,7 +2053,7 @@
}
tp->MacStat.tx_packets++;
- dev_kfree_skb(tpl->Skb);
+ dev_kfree_skb_irq(tpl->Skb);
tpl->BusyFlag = 0; /* "free" TPL */
}
@@ -2127,7 +2127,7 @@
printk(KERN_INFO "%s: Received my own frame\n",
dev->name);
if(rpl->Skb != NULL)
- dev_kfree_skb(rpl->Skb);
+ dev_kfree_skb_irq(rpl->Skb);
}
else
#endif
@@ -2171,13 +2171,14 @@
skb_trim(skb,Length);
skb->protocol = tr_type_trans(skb,dev);
netif_rx(skb);
+ dev->last_rx = jiffies;
}
}
}
else /* Invalid frame */
{
if(rpl->Skb != NULL)
- dev_kfree_skb(rpl->Skb);
+ dev_kfree_skb_irq(rpl->Skb);
/* Skip list. */
if(rpl->Status & RX_START_FRAME)
next prev parent reply other threads:[~2001-01-23 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-23 14:42 Problem with Madge Tokenring (abyss.o) in 2.4.1-pre10 Bart Dorsey
2001-01-23 15:23 ` Jeff Garzik [this message]
2001-01-23 23:14 ` Adam Fritzler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A6DA1F7.9169C3BD@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=alan@redhat.com \
--cc=echo@thebucket.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mid@auk.cx \
--cc=phillim@amtrak.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).