From: Douglas Anderson <dianders@chromium.org>
To: hminas@synopsys.com, gregkh@linuxfoundation.org
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Bruno Herrera <bruherrera@gmail.com>,
Douglas Anderson <dianders@chromium.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFT PATCH 2/4] usb: dwc2: Turn on uframe_sched on "his" platforms
Date: Fri, 6 Jul 2018 09:21:52 -0700 [thread overview]
Message-ID: <20180706162154.196345-3-dianders@chromium.org> (raw)
In-Reply-To: <20180706162154.196345-1-dianders@chromium.org>
There's no reason to have the uframe scheduler off on dwc2. Running
with uframe_sched = False is equivalent to saying "I don't want to run
the correct code, I want to run the old and incorrect code".
The uframe scheduler has been off on HiSilicon since commit
37dd9d65cc41 ("usb: dwc2: add support of hi6220"). Since then there
have been many many improvements, notably the commit 9f9f09b048f5
("usb: dwc2: host: Totally redo the microframe scheduler")
Presumably if everyone is good w/ the uframe_sched turned back on we
can kill all the old and crufty non-uframe sched code.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/usb/dwc2/params.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index 14b8742e62fa..db97bb16ecc4 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -67,7 +67,6 @@ static void dwc2_set_his_params(struct dwc2_hsotg *hsotg)
p->reload_ctl = false;
p->ahbcfg = GAHBCFG_HBSTLEN_INCR16 <<
GAHBCFG_HBSTLEN_SHIFT;
- p->uframe_sched = false;
p->change_speed_quirk = true;
p->power_down = false;
}
--
2.18.0.399.gad0ab374a1-goog
next prev parent reply other threads:[~2018-07-06 16:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 16:21 [RFT PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere Douglas Anderson
2018-07-06 16:21 ` [RFT PATCH 1/4] usb: dwc2: Turn on uframe_sched on "bcm" platforms Douglas Anderson
2018-07-06 16:21 ` Douglas Anderson [this message]
2018-07-10 23:34 ` [RFT PATCH 2/4] usb: dwc2: Turn on uframe_sched on "his" platforms John Stultz
2018-07-06 16:21 ` [RFT PATCH 3/4] usb: dwc2: Turn on uframe_sched on "amlogic" platforms Douglas Anderson
2018-07-06 16:21 ` [RFT PATCH 4/4] usb: dwc2: Turn on uframe_sched on "stm32f4x9_fsotg" platforms Douglas Anderson
2018-07-26 10:59 ` [RFT PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere Felipe Balbi
2018-07-26 20:11 ` Doug Anderson
2018-07-27 6:55 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180706162154.196345-3-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=bruherrera@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=jbrunet@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).