From: Richard Weinberger <richard@nod.at>
To: linux-mtd@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, Richard Weinberger <richard@nod.at>
Subject: [PATCH 1/5] ubifs: Turn two ubifs_assert() into a WARN_ON()
Date: Thu, 12 Jul 2018 13:01:56 +0200 [thread overview]
Message-ID: <20180712110200.13054-2-richard@nod.at> (raw)
In-Reply-To: <20180712110200.13054-1-richard@nod.at>
We are going to pass struct ubifs_info to ubifs_assert()
but while unloading the UBIFS module we don't have the info
struct anymore.
Therefore replace the asserts by a regular WARN_ON().
Signed-off-by: Richard Weinberger <richard@nod.at>
---
fs/ubifs/super.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index c5466c70d620..90ebfcc8a8ea 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -2304,8 +2304,8 @@ late_initcall(ubifs_init);
static void __exit ubifs_exit(void)
{
- ubifs_assert(list_empty(&ubifs_infos));
- ubifs_assert(atomic_long_read(&ubifs_clean_zn_cnt) == 0);
+ WARN_ON(list_empty(&ubifs_infos));
+ WARN_ON(atomic_long_read(&ubifs_clean_zn_cnt) == 0);
dbg_debugfs_exit();
ubifs_compressors_exit();
--
2.18.0
next prev parent reply other threads:[~2018-07-12 11:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 11:01 [PATCH 0/5] ubifs: Rework assert code Richard Weinberger
2018-07-12 11:01 ` Richard Weinberger [this message]
2018-07-12 11:01 ` [PATCH 2/5] ubifs: Pass struct ubifs_info to ubifs_assert() Richard Weinberger
2018-07-12 11:01 ` [PATCH 3/5] ubifs: Rework ubifs_assert() Richard Weinberger
2018-07-12 11:01 ` [PATCH 4/5] ubifs: Allow setting assert action as mount parameter Richard Weinberger
2018-07-12 11:02 ` [PATCH 5/5] ubifs: Set default assert action to read-only Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712110200.13054-2-richard@nod.at \
--to=richard@nod.at \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).