From: Corentin Labbe <clabbe@baylibre.com>
To: hdegoede@redhat.com, tj@kernel.org
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Corentin Labbe <clabbe@baylibre.com>
Subject: [PATCH 3/3] ata: ahci_platform: convert kcalloc to devm_kcalloc
Date: Thu, 12 Jul 2018 11:41:31 +0000 [thread overview]
Message-ID: <1531395691-4653-4-git-send-email-clabbe@baylibre.com> (raw)
In-Reply-To: <1531395691-4653-1-git-send-email-clabbe@baylibre.com>
Like phys, target_pwrs could be allocated with devm_ function
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
drivers/ata/libahci_platform.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
index be9f54423a9b..fe8939e161ea 100644
--- a/drivers/ata/libahci_platform.c
+++ b/drivers/ata/libahci_platform.c
@@ -271,8 +271,6 @@ static void ahci_platform_put_resources(struct device *dev, void *res)
for (c = 0; c < hpriv->nports; c++)
if (hpriv->target_pwrs && hpriv->target_pwrs[c])
regulator_put(hpriv->target_pwrs[c]);
-
- kfree(hpriv->target_pwrs);
}
static int ahci_platform_get_phy(struct ahci_host_priv *hpriv, u32 port,
@@ -408,7 +406,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
rc = -ENOMEM;
goto err_out;
}
- hpriv->target_pwrs = kcalloc(hpriv->nports, sizeof(*hpriv->target_pwrs), GFP_KERNEL);
+ hpriv->target_pwrs = devm_kcalloc(dev, hpriv->nports, sizeof(*hpriv->target_pwrs), GFP_KERNEL);
if (!hpriv->target_pwrs) {
rc = -ENOMEM;
goto err_out;
--
2.16.4
next prev parent reply other threads:[~2018-07-12 11:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 11:41 [PATCH 0/3] ata: ahci_platform: minor fixes Corentin Labbe
2018-07-12 11:41 ` [PATCH 1/3] ata: ahci_platform: correct parameter documentation for ahci_platform_shutdown Corentin Labbe
2018-07-12 11:41 ` [PATCH 2/3] ata: ahci_platform: convert kzallloc to kcalloc Corentin Labbe
2018-07-12 11:41 ` Corentin Labbe [this message]
2018-07-12 12:15 ` [PATCH 0/3] ata: ahci_platform: minor fixes Hans de Goede
2018-07-12 20:03 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531395691-4653-4-git-send-email-clabbe@baylibre.com \
--to=clabbe@baylibre.com \
--cc=hdegoede@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).