[v2,RESEND] cachefiles: avoid deprecated get_seconds()
diff mbox series

Message ID 20180713142753.3139243-1-arnd@arndb.de
State Accepted
Commit 34e06fe4d05bd120556a95d5ebf1bcc97b0a1ca0
Headers show
  • [v2,RESEND] cachefiles: avoid deprecated get_seconds()
Related show

Commit Message

Arnd Bergmann July 13, 2018, 2:27 p.m. UTC
get_seconds() returns an unsigned long can overflow on some architectures
and is deprecated because of that. In cachefs, we cast that number to
a a 32-bit integer, which will overflow in year 2106 on all architectures.

As confirmed by David Howells, the overflow probably isn't harmful
in the end, since the timestamps are only used to make the file names
unique, but they don't strictly have to be in monotonically increasing
order since the files only exist in order to be deleted as quickly
as possible.

Moving to ktime_get_real_seconds() avoids the deprecated interface.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
v2: only change to ktime_get_real_seconds() without printing the
    extra leading digits

    Originally submitted this on June 20, but got no reply.
    Resending this in case it got lost somewhere on the way.
    David, can you pick this up?
 fs/cachefiles/namei.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

diff --git a/fs/cachefiles/namei.c b/fs/cachefiles/namei.c
index ab0bbe93b398..0a38978b8cd3 100644
--- a/fs/cachefiles/namei.c
+++ b/fs/cachefiles/namei.c
@@ -337,7 +337,7 @@  static int cachefiles_bury_object(struct cachefiles_cache *cache,
 	/* first step is to make up a grave dentry in the graveyard */
 	sprintf(nbuffer, "%08x%08x",
-		(uint32_t) get_seconds(),
+		(uint32_t) ktime_get_real_seconds(),
 		(uint32_t) atomic_inc_return(&cache->gravecounter));
 	/* do the multiway lock magic */