From: Alexey Khoroshilov <khoroshilov@ispras.ru>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org
Subject: [PATCH] Input: pxrc - fix leak of usb_device
Date: Fri, 13 Jul 2018 23:07:57 +0300 [thread overview]
Message-ID: <1531512477-31981-1-git-send-email-khoroshilov@ispras.ru> (raw)
pxrc_probe() calls usb_get_dev(), but there is no usb_put_dev()
anywhere in the driver.
The patch adds one to error handling code and to pxrc_disconnect().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
drivers/input/joystick/pxrc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/joystick/pxrc.c b/drivers/input/joystick/pxrc.c
index 07a0dbd3ced2..0a31de63ac8e 100644
--- a/drivers/input/joystick/pxrc.c
+++ b/drivers/input/joystick/pxrc.c
@@ -221,6 +221,7 @@ static int pxrc_probe(struct usb_interface *intf,
usb_free_urb(pxrc->urb);
error:
+ usb_put_dev(pxrc->udev);
return retval;
}
@@ -229,6 +230,7 @@ static void pxrc_disconnect(struct usb_interface *intf)
struct pxrc *pxrc = usb_get_intfdata(intf);
usb_free_urb(pxrc->urb);
+ usb_put_dev(pxrc->udev);
usb_set_intfdata(intf, NULL);
}
--
2.7.4
next reply other threads:[~2018-07-13 20:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 20:07 Alexey Khoroshilov [this message]
2018-07-14 8:09 ` [PATCH] Input: pxrc - fix leak of usb_device Marcus Folkesson
2018-07-14 8:51 ` Dmitry Torokhov
2018-07-15 7:42 ` Marcus Folkesson
2018-07-15 10:06 ` Dmitry Torokhov
2018-07-15 10:12 ` Greg Kroah-Hartman
2018-07-15 10:18 ` Dmitry Torokhov
2018-07-15 19:58 ` Alexey Khoroshilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531512477-31981-1-git-send-email-khoroshilov@ispras.ru \
--to=khoroshilov@ispras.ru \
--cc=dmitry.torokhov@gmail.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).