From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
Colin Ian King <colin.king@canonical.com>,
Johan Hovold <johan@kernel.org>
Subject: [PATCH 1/2] gnss: ubx: make struct ubx_gserial_ops static
Date: Mon, 16 Jul 2018 12:42:02 +0200 [thread overview]
Message-ID: <20180716104203.28440-2-johan@kernel.org> (raw)
In-Reply-To: <20180716104203.28440-1-johan@kernel.org>
From: Colin Ian King <colin.king@canonical.com>
The structure ubx_gserial_ops is local to the source and does not need
to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'ubx_gserial_ops' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/gnss/ubx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gnss/ubx.c b/drivers/gnss/ubx.c
index 902b6854b7db..12568aebb7f6 100644
--- a/drivers/gnss/ubx.c
+++ b/drivers/gnss/ubx.c
@@ -59,7 +59,7 @@ static int ubx_set_power(struct gnss_serial *gserial,
return -EINVAL;
}
-const struct gnss_serial_ops ubx_gserial_ops = {
+static const struct gnss_serial_ops ubx_gserial_ops = {
.set_power = ubx_set_power,
};
--
2.18.0
next prev parent reply other threads:[~2018-07-16 10:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 10:42 [PATCH 0/2] gnss: fixes for char-misc-next Johan Hovold
2018-07-16 10:42 ` Johan Hovold [this message]
2018-07-16 10:42 ` [PATCH 2/2] gnss: fix potential error pointer dereference Johan Hovold
2018-07-16 10:48 ` [PATCH 0/2] gnss: fixes for char-misc-next Greg Kroah-Hartman
2018-07-16 12:16 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716104203.28440-2-johan@kernel.org \
--to=johan@kernel.org \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).