linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, robh@kernel.org,
	mathieu.poirier@linaro.org, sudeep.holla@arm.com,
	frowand.list@gmail.com, devicetree@vger.kernel.org,
	mark.rutland@arm.com, matt.sealey@arm.com,
	charles.garcia-tobin@arm.com, coresight@lists.linaro.org,
	john.horley@arm.com, mike.leach@linaro.org,
	Suzuki K Poulose <suzuki.poulose@arm.com>
Subject: [PATCH v2 03/10] coresight: platform: Fix refcounting for graph nodes
Date: Thu, 19 Jul 2018 11:55:07 +0100	[thread overview]
Message-ID: <1531997715-6767-4-git-send-email-suzuki.poulose@arm.com> (raw)
In-Reply-To: <1531997715-6767-1-git-send-email-suzuki.poulose@arm.com>

The coresight driver doesn't drop the references on the
remote endpoint/port nodes. Add the missing of_node_put()
calls.

Reported-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
Changes since v1:
 - Splitted from of_node recounting fix, part 2
---
 drivers/hwtracing/coresight/of_coresight.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c
index 68faaf8..6c2f95a 100644
--- a/drivers/hwtracing/coresight/of_coresight.c
+++ b/drivers/hwtracing/coresight/of_coresight.c
@@ -167,6 +167,11 @@ static int of_coresight_parse_endpoint(struct device *dev,
 		(*i)++;
 	} while (0);
 
+	if (rparent)
+		of_node_put(rparent);
+	if (rport)
+		of_node_put(rport);
+
 	return ret;
 }
 
-- 
2.7.4


  parent reply	other threads:[~2018-07-19 10:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19 10:55 [PATCH v2 00/10] coresight: Update device tree bindings Suzuki K Poulose
2018-07-19 10:55 ` [PATCH v2 01/10] coresight: Document error handling in coresight_register Suzuki K Poulose
2018-07-19 10:55 ` [PATCH v2 02/10] coresight: platform: Refactor graph endpoint parsing Suzuki K Poulose
2018-07-24 21:30   ` Mathieu Poirier
2018-07-24 21:34     ` Mathieu Poirier
2018-07-25  9:01       ` Suzuki K Poulose
2018-07-25 14:38         ` Mathieu Poirier
2018-07-19 10:55 ` Suzuki K Poulose [this message]
2018-07-19 10:55 ` [PATCH v2 04/10] coresight: platform: Fix leaking device reference Suzuki K Poulose
2018-07-19 10:55 ` [PATCH v2 05/10] coresight: Fix remote endpoint parsing Suzuki K Poulose
2018-07-19 10:55 ` [PATCH v2 06/10] coresight: Add helper to check if the endpoint is input Suzuki K Poulose
2018-07-19 10:55 ` [PATCH v2 07/10] coresight: platform: Cleanup coresight connection handling Suzuki K Poulose
2018-07-19 10:55 ` [PATCH v2 08/10] coresight: dts: Document usage of graph bindings Suzuki K Poulose
2018-07-19 10:55 ` [PATCH v2 09/10] coresight: Cleanup coresight DT bindings Suzuki K Poulose
2018-07-25 16:09   ` Rob Herring
2018-07-25 16:14     ` Suzuki K Poulose
2018-07-25 17:24       ` Rob Herring
2018-07-25 19:25   ` Mathieu Poirier
2018-07-19 10:55 ` [PATCH v2 10/10] dts: juno: Update coresight bindings for hw port Suzuki K Poulose
2018-07-19 11:01   ` Suzuki K Poulose
2018-07-19 10:55 ` [PATCH v2 10/10] dts: juno: Update coresight bindings Suzuki K Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1531997715-6767-4-git-send-email-suzuki.poulose@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=charles.garcia-tobin@arm.com \
    --cc=coresight@lists.linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=john.horley@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=matt.sealey@arm.com \
    --cc=mike.leach@linaro.org \
    --cc=robh@kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).