From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, rostedt@goodmis.org,
linux-rt-users@vger.kernel.org,
Marc Zyngier <marc.zyngier@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
linux-efi@vger.kernel.org,
Anna-Maria Gleixner <anna-maria@linutronix.de>
Subject: [PATCH RT] rtc: Disable RTC_DRV_EFI on RT
Date: Thu, 26 Jul 2018 11:04:49 +0200 [thread overview]
Message-ID: <20180726090449.hfvtey3ruzzhzdaz@linutronix.de> (raw)
Based on measurements the EFI functions get_variable /
get_next_variable take up to 2us. The functions get_time, set_time take
around 10ms. Those 10ms are too much. Even one ms would be too much.
The funny part is that EFI is invoked with enabled interrupts.
According to my tracing I see the interrupt almost 10ms later which
indicates that EFI is disabling interrupts while doing its thing.
This was observed on "EFI v2.60 by SoftIron Overdrive 1000". I don't say
that every EFI implementation does this but given that it has to access a
slow bus like I2C/SPI it is expected.
Disable EFI's RTC driver on RT.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
drivers/rtc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index a2ba5db36145..248d72711650 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1087,7 +1087,7 @@ config RTC_DRV_DA9063
config RTC_DRV_EFI
tristate "EFI RTC"
- depends on EFI && !X86
+ depends on EFI && !X86 && !PREEMPT_RT_BASE
help
If you say yes here you will get support for the EFI
Real Time Clock.
--
2.18.0
next reply other threads:[~2018-07-26 9:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 9:04 Sebastian Andrzej Siewior [this message]
2018-07-26 9:15 ` [PATCH RT] rtc: Disable RTC_DRV_EFI on RT Ard Biesheuvel
2018-07-26 12:15 ` Sebastian Andrzej Siewior
2018-07-26 12:26 ` Ard Biesheuvel
2018-07-26 12:46 ` Sebastian Andrzej Siewior
2018-07-26 12:52 ` Ard Biesheuvel
2018-07-26 13:13 ` Sebastian Andrzej Siewior
2018-07-26 13:14 ` Sebastian Andrzej Siewior
2018-07-26 16:01 ` Ard Biesheuvel
2018-07-26 16:04 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726090449.hfvtey3ruzzhzdaz@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=ard.biesheuvel@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).