From: Rasmus Andersen <rasmus@jaquet.dk>
To: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drivers/scsi/u14-35f.c: check_region -> request_region (241p9)
Date: Tue, 23 Jan 2001 23:44:24 +0100 [thread overview]
Message-ID: <20010123234424.B9514@jaquet.dk> (raw)
(Too fast again and forgot to cc the lists. If anyone replies to this
mail, please cc ballabio_dario@emc.com. Thanks.)
----- Forwarded message from Rasmus Andersen <rasmus@jaquet.dk> -----
Hi.
The following patch makes drivers/scsi/u14-35f.c drop check_region in
favour of checking the return code from request_region. It applies
cleanly against ac10 and 241p9.
Comments?
--- linux-ac10-clean/drivers/scsi/u14-34f.c Tue Nov 28 02:49:00 2000
+++ linux-ac10/drivers/scsi/u14-34f.c Mon Jan 22 00:01:10 2001
@@ -729,7 +729,9 @@
sprintf(name, "%s%d", driver_name, j);
- if(check_region(port_base, REGION_SIZE)) {
+ /* Register the I/O space that we use */
+
+ if(!request_region(port_base, REGION_SIZE, driver_name)) {
#if defined(DEBUG_DETECT)
printk("%s: address 0x%03lx in use, skipping probe.\n", name, port_base);
#endif
@@ -804,9 +806,6 @@
/* If BIOS is disabled, force enable interrupts */
if (sh[j]->base == 0) outb(CMD_ENA_INTR, sh[j]->io_port + REG_SYS_MASK);
-
- /* Register the I/O space that we use */
- request_region(sh[j]->io_port, sh[j]->n_io_port, driver_name);
memset(HD(j), 0, sizeof(struct hostdata));
HD(j)->heads = mapping_table[config_2.mapping_mode].heads;
--
Regards,
Rasmus(rasmus@jaquet.dk)
Good judgement comes from experience. Experience comes from bad judgement.
-- Jim Horning
----- End forwarded message -----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
reply other threads:[~2001-01-23 22:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010123234424.B9514@jaquet.dk \
--to=rasmus@jaquet.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).