From: Matthias Kaehlcke <mka@chromium.org>
To: Vinayak Holikatti <vinholikatti@gmail.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Subhash Jadavani <subhashj@codeaurora.org>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Evan Green <evgreen@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Stephen Boyd <sboyd@kernel.org>,
Matthias Kaehlcke <mka@chromium.org>
Subject: [PATCH] scsi: ufs: Suspend clock scaling only once in ufshcd_hba_exit()
Date: Wed, 1 Aug 2018 16:31:45 -0700 [thread overview]
Message-ID: <20180801233145.65049-1-mka@chromium.org> (raw)
Commit 401f1e4490ee ("scsi: ufs: don't suspend clock scaling during
clock gating") introduced a check in ufshcd_hba_exit() to suspend
clock scaling only when the controller supports clock scaling.
However the unconditional call to ufshcd_suspend_clkscaling() was
also left in place, so that it is now called twice when clock
scaling is supported and still once when the controller doesn't
support it. Remove the unconditional call.
Fixes: 401f1e4490ee ("scsi: ufs: don't suspend clock scaling during clock gating")
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
drivers/scsi/ufs/ufshcd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 397081d320b1..dca7525af696 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -7186,7 +7186,6 @@ static void ufshcd_hba_exit(struct ufs_hba *hba)
if (hba->is_powered) {
ufshcd_variant_hba_exit(hba);
ufshcd_setup_vreg(hba, false);
- ufshcd_suspend_clkscaling(hba);
if (ufshcd_is_clkscaling_supported(hba)) {
if (hba->devfreq)
ufshcd_suspend_clkscaling(hba);
--
2.18.0.597.ga71716f1ad-goog
next reply other threads:[~2018-08-01 23:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 23:31 Matthias Kaehlcke [this message]
2018-08-07 17:22 ` [PATCH] scsi: ufs: Suspend clock scaling only once in ufshcd_hba_exit() Evan Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801233145.65049-1-mka@chromium.org \
--to=mka@chromium.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sboyd@kernel.org \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).