From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: broonie@kernel.org, lgirdwood@gmail.com, alsa-devel@alsa-project.org
Cc: perex@perex.cz, tiwai@suse.com, vkoul@kernel.org,
linux-kernel@vger.kernel.org, rohitkr@codeaurora.org,
bgoswami@codeaurora.org, stefan.wahren@i2se.com,
guillaume.tucker@collabora.com,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: [PATCH 1/3] ASoC: apq8096: remove auto rebinding
Date: Thu, 2 Aug 2018 16:03:36 +0100 [thread overview]
Message-ID: <20180802150338.24538-2-srinivas.kandagatla@linaro.org> (raw)
In-Reply-To: <20180802150338.24538-1-srinivas.kandagatla@linaro.org>
Remove auto rebinding support, as component framework can deadlock
in few usecases if we are trying to add new/remove component within
a bind/unbind callbacks.
Card rebinding is ASoC core feature so all the previous component
framework stuff in q6dsp remains removed.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
sound/soc/qcom/apq8096.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/qcom/apq8096.c b/sound/soc/qcom/apq8096.c
index 1e4a90d59228..6ee7e66cbaaa 100644
--- a/sound/soc/qcom/apq8096.c
+++ b/sound/soc/qcom/apq8096.c
@@ -48,7 +48,6 @@ static int apq8096_platform_probe(struct platform_device *pdev)
return -ENOMEM;
card->dev = dev;
- card->auto_bind = true;
dev_set_drvdata(dev, card);
ret = qcom_snd_parse_of(card);
if (ret) {
@@ -74,7 +73,6 @@ static int apq8096_platform_remove(struct platform_device *pdev)
{
struct snd_soc_card *card = dev_get_drvdata(&pdev->dev);
- card->auto_bind = false;
snd_soc_unregister_card(card);
kfree(card->dai_link);
kfree(card);
--
2.16.2
next prev parent reply other threads:[~2018-08-02 15:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 15:03 [PATCH 0/3] ASoC: core: remove support for card rebind using component framework Srinivas Kandagatla
2018-08-02 15:03 ` Srinivas Kandagatla [this message]
2018-08-02 16:21 ` Applied "ASoC: apq8096: remove auto rebinding" to the asoc tree Mark Brown
2018-08-02 15:03 ` [PATCH 2/3] ASoC: smd845: remove auto rebinding Srinivas Kandagatla
2018-08-02 16:20 ` Applied "ASoC: smd845: remove auto rebinding" to the asoc tree Mark Brown
2018-08-02 15:03 ` [PATCH 3/3] ASoC: core: remove support for card rebind using component framework Srinivas Kandagatla
2018-08-02 16:20 ` Applied "ASoC: core: remove support for card rebind using component framework" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802150338.24538-2-srinivas.kandagatla@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=guillaume.tucker@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rohitkr@codeaurora.org \
--cc=stefan.wahren@i2se.com \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).