From: Adrian Bunk <bunk@kernel.org>
To: Sam Ravnborg <sam@ravnborg.org>,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch] x86: revert X86_HT semantics change
Date: Thu, 15 Nov 2007 17:17:03 +0100 [thread overview]
Message-ID: <20071115161703.GR4250@stusta.de> (raw)
The x86 unification resulted in CONFIG_X86_HT no longer being
set if (X86_32 && MK8).
After grep'ing through the tree I think the problem is that different
places have different assumptions about the semantics of CONFIG_X86_HT,
either:
- hyperthreading or
- multicore
and the SCHED_SMT and SCHED_MC dependencies are just one of the
symptoms.
This should be sorted out properly, but until then we should keep the
2.6.23 status quo.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
arch/x86/Kconfig | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
18fef247715449d36438fe4de59fdf430f1b5c37
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 1eb5997..2c357f0 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -148,7 +148,8 @@ config X86_SMP
config X86_HT
bool
- depends on SMP && !(X86_VISWS || X86_VOYAGER || MK8)
+ depends on SMP
+ depends on (X86_32 && !(X86_VISWS || X86_VOYAGER)) || (X86_64 && !MK8)
default y
config X86_BIOS_REBOOT
@@ -476,7 +477,7 @@ config NR_CPUS
config SCHED_SMT
bool "SMT (Hyperthreading) scheduler support"
- depends on (X86_64 && SMP) || (X86_32 && X86_HT)
+ depends on X86_HT
help
SMT scheduler support improves the CPU scheduler's decision making
when dealing with Intel Pentium 4 chips with HyperThreading at a
@@ -485,7 +486,7 @@ config SCHED_SMT
config SCHED_MC
bool "Multi-core scheduler support"
- depends on (X86_64 && SMP) || (X86_32 && X86_HT)
+ depends on X86_HT
default y
help
Multi-core scheduler support improves the CPU scheduler's decision
next reply other threads:[~2007-11-15 16:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 16:17 Adrian Bunk [this message]
2007-11-15 18:04 ` [2.6 patch] x86: revert X86_HT semantics change Sam Ravnborg
2007-11-15 18:07 ` Thomas Gleixner
2007-11-15 18:19 ` Adrian Bunk
2007-12-04 13:29 ` Ingo Molnar
2007-12-04 13:55 ` Adrian Bunk
2007-11-15 18:42 ` Sam Ravnborg
2007-11-15 18:48 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071115161703.GR4250@stusta.de \
--to=bunk@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).