From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com>,
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Subject: [RFC][PATCH v2 09/24] tools/lib/traceevent, tools/perf: Rename pevent_register_* APIs
Date: Wed, 08 Aug 2018 14:02:54 -0400 [thread overview]
Message-ID: <20180808180700.948980691@goodmis.org> (raw)
In-Reply-To: 20180808180245.352784763@goodmis.org
From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
In order to make libtraceevent into a proper library, variables, data
structures and functions require a unique prefix to prevent name space
conflicts. That prefix will be "tep_" and not "pevent_". This changes
APIs: pevent_register_comm, pevent_register_print_string
Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
tools/lib/traceevent/event-parse.c | 10 +++++-----
tools/lib/traceevent/event-parse.h | 6 +++---
tools/lib/traceevent/plugin_sched_switch.c | 2 +-
tools/perf/util/trace-event-parse.c | 4 ++--
4 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 4220b15781c8..cab411b99087 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -288,7 +288,7 @@ static int add_new_comm(struct tep_handle *pevent, const char *comm, int pid)
}
/**
- * pevent_register_comm - register a pid / comm mapping
+ * tep_register_comm - register a pid / comm mapping
* @pevent: handle for the pevent
* @comm: the command line to register
* @pid: the pid to map the command line to
@@ -296,7 +296,7 @@ static int add_new_comm(struct tep_handle *pevent, const char *comm, int pid)
* This adds a mapping to search for command line names with
* a given pid. The comm is duplicated.
*/
-int pevent_register_comm(struct tep_handle *pevent, const char *comm, int pid)
+int tep_register_comm(struct tep_handle *pevent, const char *comm, int pid)
{
struct cmdline_list *item;
@@ -685,7 +685,7 @@ find_printk(struct tep_handle *pevent, unsigned long long addr)
}
/**
- * pevent_register_print_string - register a string by its address
+ * tep_register_print_string - register a string by its address
* @pevent: handle for the pevent
* @fmt: the string format to register
* @addr: the address the string was located at
@@ -693,8 +693,8 @@ find_printk(struct tep_handle *pevent, unsigned long long addr)
* This registers a string by the address it was stored in the kernel.
* The @fmt passed in is duplicated.
*/
-int pevent_register_print_string(struct tep_handle *pevent, const char *fmt,
- unsigned long long addr)
+int tep_register_print_string(struct tep_handle *pevent, const char *fmt,
+ unsigned long long addr)
{
struct printk_list *item = malloc(sizeof(*item));
char *p;
diff --git a/tools/lib/traceevent/event-parse.h b/tools/lib/traceevent/event-parse.h
index 58d9f0dedf05..399dea66b80e 100644
--- a/tools/lib/traceevent/event-parse.h
+++ b/tools/lib/traceevent/event-parse.h
@@ -618,12 +618,12 @@ enum trace_flag_type {
int pevent_set_function_resolver(struct tep_handle *pevent,
tep_func_resolver_t *func, void *priv);
void pevent_reset_function_resolver(struct tep_handle *pevent);
-int pevent_register_comm(struct tep_handle *pevent, const char *comm, int pid);
+int tep_register_comm(struct tep_handle *pevent, const char *comm, int pid);
int pevent_register_trace_clock(struct tep_handle *pevent, const char *trace_clock);
int pevent_register_function(struct tep_handle *pevent, char *name,
unsigned long long addr, char *mod);
-int pevent_register_print_string(struct tep_handle *pevent, const char *fmt,
- unsigned long long addr);
+int tep_register_print_string(struct tep_handle *pevent, const char *fmt,
+ unsigned long long addr);
int pevent_pid_is_registered(struct tep_handle *pevent, int pid);
void tep_print_event_task(struct tep_handle *pevent, struct trace_seq *s,
diff --git a/tools/lib/traceevent/plugin_sched_switch.c b/tools/lib/traceevent/plugin_sched_switch.c
index 90d2ef293cf9..4d8eaab6ac15 100644
--- a/tools/lib/traceevent/plugin_sched_switch.c
+++ b/tools/lib/traceevent/plugin_sched_switch.c
@@ -61,7 +61,7 @@ static void write_and_save_comm(struct format_field *field,
comm = &s->buffer[len];
/* Help out the comm to ids. This will handle dups */
- pevent_register_comm(field->event->pevent, comm, pid);
+ tep_register_comm(field->event->pevent, comm, pid);
}
static int sched_wakeup_handler(struct trace_seq *s,
diff --git a/tools/perf/util/trace-event-parse.c b/tools/perf/util/trace-event-parse.c
index a0e2b2c54567..920b1d58a068 100644
--- a/tools/perf/util/trace-event-parse.c
+++ b/tools/perf/util/trace-event-parse.c
@@ -157,7 +157,7 @@ void parse_ftrace_printk(struct tep_handle *pevent,
/* fmt still has a space, skip it */
printk = strdup(fmt+1);
line = strtok_r(NULL, "\n", &next);
- pevent_register_print_string(pevent, printk, addr);
+ tep_register_print_string(pevent, printk, addr);
}
}
@@ -172,7 +172,7 @@ void parse_saved_cmdline(struct tep_handle *pevent,
line = strtok_r(file, "\n", &next);
while (line) {
sscanf(line, "%d %ms", &pid, &comm);
- pevent_register_comm(pevent, comm, pid);
+ tep_register_comm(pevent, comm, pid);
free(comm);
line = strtok_r(NULL, "\n", &next);
}
--
2.18.0
next prev parent reply other threads:[~2018-08-08 18:07 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 18:02 [RFC][PATCH v2 00/24] tools lib traceevent: Rename pevent to tep for preparation for library Steven Rostedt
2018-08-08 18:02 ` [RFC][PATCH v2 01/24] tools/lib/traceevent, tools/perf: Rename struct pevent to struct tep_handle Steven Rostedt
2018-08-18 11:43 ` [tip:perf/urgent] tools lib traceevent, perf tools: " tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:02 ` [RFC][PATCH v2 02/24] tools/lib/traceevent, tools/perf: Rename struct pevent_record to struct tep_record Steven Rostedt
2018-08-18 11:44 ` [tip:perf/urgent] tools lib traceevent, perf tools: Rename 'struct pevent_record' to 'struct tep_record' tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:02 ` [RFC][PATCH v2 03/24] tools/lib/traceevent, tools/perf: Rename pevent plugin related APIs Steven Rostedt
2018-08-18 11:44 ` [tip:perf/urgent] tools lib traceevent, perf tools: " tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:02 ` [RFC][PATCH v2 04/24] tools/lib/traceevent, tools/perf: Rename pevent alloc / free APIs Steven Rostedt
2018-08-18 11:45 ` [tip:perf/urgent] tools lib traceevent, perf tools: " tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:02 ` [RFC][PATCH v2 05/24] tools/lib/traceevent, tools/perf: Rename pevent find APIs Steven Rostedt
2018-08-18 11:45 ` [tip:perf/urgent] tools lib traceevent, perf tools: " tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:02 ` [RFC][PATCH v2 06/24] tools/lib/traceevent, tools/perf: Rename pevent parse APIs Steven Rostedt
2018-08-18 11:46 ` [tip:perf/urgent] tools lib traceevent, perf tools: " tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:02 ` [RFC][PATCH v2 07/24] tools/lib/traceevent, tools/perf: Rename pevent print APIs Steven Rostedt
2018-08-18 11:46 ` [tip:perf/urgent] tools lib traceevent, perf tools: " tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:02 ` [RFC][PATCH v2 08/24] tools/lib/traceevent, tools/perf: Rename pevent_read_number_* APIs Steven Rostedt
2018-08-18 11:47 ` [tip:perf/urgent] tools lib traceevent, perf tools: " tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:02 ` Steven Rostedt [this message]
2018-08-18 11:47 ` [tip:perf/urgent] tools lib traceevent, perf tools: Rename pevent_register_* APIs tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:02 ` [RFC][PATCH v2 10/24] tools/lib/traceevent, tools/perf: Rename pevent_set_* APIs Steven Rostedt
2018-08-18 11:48 ` [tip:perf/urgent] tools lib traceevent, perf tools: " tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:02 ` [RFC][PATCH v2 11/24] tools/lib/traceevent, tools/perf: Rename traceevent_* APIs Steven Rostedt
2018-08-18 11:48 ` [tip:perf/urgent] tools lib traceevent, perf tools: " tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:02 ` [RFC][PATCH v2 12/24] tools/lib/traceevent, tools/perf: Rename enum pevent_flag to enum tep_flag Steven Rostedt
2018-08-18 11:49 ` [tip:perf/urgent] tools lib traceevent, perf tools: Rename 'enum pevent_flag' to 'enum tep_flag' tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:02 ` [RFC][PATCH v2 13/24] tools/lib/traceevent, tools/lib/lockdep/: Rename enunm pevent_errno to enum tep_errno Steven Rostedt
2018-08-18 11:49 ` [tip:perf/urgent] tools lib traceevent, tools lib lockdep: Rename 'enum pevent_errno' to 'enum tep_errno' tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:02 ` [RFC][PATCH v2 14/24] tools/lib/traceevent: Rename pevent_function* APIs Steven Rostedt
2018-08-18 11:50 ` [tip:perf/urgent] tools lib traceevent: " tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:03 ` [RFC][PATCH v2 15/24] tools/lib/traceevent, tools/perf: Rename traceevent_plugin_* APIs Steven Rostedt
2018-08-18 11:50 ` [tip:perf/urgent] tools lib traceevent, perf tools: " tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:03 ` [RFC][PATCH v2 16/24] tools/lib/traceevent: Rename pevent_filter* APIs Steven Rostedt
2018-08-18 11:51 ` [tip:perf/urgent] tools lib traceevent: " tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:03 ` [RFC][PATCH v2 17/24] tools/lib/traceevent: Rename pevent_register / unregister APIs Steven Rostedt
2018-08-18 11:51 ` [tip:perf/urgent] tools lib traceevent: " tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:03 ` [RFC][PATCH v2 18/24] tools/lib/traceevent: Rename pevent_data_ APIs Steven Rostedt
2018-08-18 11:52 ` [tip:perf/urgent] tools lib traceevent: " tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:03 ` [RFC][PATCH v2 19/24] tools/lib/traceevent: Rename pevent field APIs Steven Rostedt
2018-08-18 11:52 ` [tip:perf/urgent] tools lib traceevent: " tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:03 ` [RFC][PATCH v2 20/24] tools/lib/traceevent: Rename pevent_find_* APIs Steven Rostedt
2018-08-18 11:53 ` [tip:perf/urgent] tools lib traceevent: " tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:03 ` [RFC][PATCH v2 21/24] tools/lib/traceevent: Rename various pevent get/set/is APIs Steven Rostedt
2018-08-18 11:53 ` [tip:perf/urgent] tools lib traceevent: " tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-22 14:36 ` Steven Rostedt
2018-08-23 13:59 ` Arnaldo Carvalho de Melo
2018-08-08 18:03 ` [RFC][PATCH v2 22/24] tools/lib/traceevent: Rename internal parser related APIs Steven Rostedt
2018-08-18 11:54 ` [tip:perf/urgent] tools lib traceevent: " tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:03 ` [RFC][PATCH v2 23/24] tools/lib/traceevent: Rename various pevent APIs Steven Rostedt
2018-08-18 11:54 ` [tip:perf/urgent] tools lib traceevent: " tip-bot for Tzvetomir Stoyanov (VMware)
2018-08-08 18:03 ` [RFC][PATCH v2 24/24] tools/lib/traceevent: Rename static variables and functions in event-parse.c Steven Rostedt
2018-08-18 11:55 ` [tip:perf/urgent] tools lib traceevent: " tip-bot for Tzvetomir Stoyanov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808180700.948980691@goodmis.org \
--to=rostedt@goodmis.org \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tz.stoyanov@gmail.com \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).