From: Stig Brautaset <stig@brautaset.org>
To: linux-kernel@vger.kernel.org
Subject: [patch] 2.5.41: mii breakage in xircom_tulip_cb
Date: Mon, 7 Oct 2002 23:07:53 +0100 [thread overview]
Message-ID: <20021007220752.GA471@arwen.brautaset.org> (raw)
I use the xircom_tulip_cb driver with 2.4.19, because it is mii-enabled,
and the new driver isn't.
In 2.5.41 (and .40, at least) the mii-capabilities is not there, I have
not tested earlier development kernels. The changes between the driver
in 2.4.19 and 2.5.41 are miniscule, so I was able to make mii work
again (this is my first attempt at kernel hacking; don't laugh :). It's
most definately _not_ the correct fix, it is just a revert from 2.4.19
that makes mii work for me again in 2.5.
--- drivers/net/tulip/xircom_tulip_cb.c.orig Mon Oct 7 22:53:22 2002
+++ drivers/net/tulip/xircom_tulip_cb.c Mon Oct 7 22:31:45 2002
@@ -1469,18 +1469,21 @@
/* Legacy mii-diag interface */
case SIOCGMIIPHY: /* Get address of MII PHY in use. */
+ case SIOCDEVPRIVATE: /* for binary compat, remove in 2.5 */
if (tp->mii_cnt)
data[0] = phy;
else
return -ENODEV;
return 0;
case SIOCGMIIREG: /* Read MII PHY register. */
+ case SIOCDEVPRIVATE+1: /* for binary compat, remove in 2.5 */
save_flags(flags);
cli();
data[3] = mdio_read(dev, data[0] & 0x1f, data[1] & 0x1f);
restore_flags(flags);
return 0;
case SIOCSMIIREG: /* Write MII PHY register. */
+ case SIOCDEVPRIVATE+2: /* for binary compat, remove in 2.5 */
if (!capable(CAP_NET_ADMIN))
return -EPERM;
save_flags(flags);
Stig
--
brautaset.org
next reply other threads:[~2002-10-07 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-07 22:07 Stig Brautaset [this message]
2002-10-08 12:04 ` [patch] 2.5.41: mii breakage in xircom_tulip_cb Felipe W Damasio
2002-10-10 18:42 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021007220752.GA471@arwen.brautaset.org \
--to=stig@brautaset.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).