From: Chao Yu <yuchao0@huawei.com>
To: <jaegeuk@kernel.org>
Cc: <linux-f2fs-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>, <chao@kernel.org>,
Chao Yu <yuchao0@huawei.com>
Subject: [PATCH 1/2] f2fs: set 4KB discard granularity by default
Date: Fri, 10 Aug 2018 18:08:05 +0800 [thread overview]
Message-ID: <20180810100806.9298-1-yuchao0@huawei.com> (raw)
Small granularity (size < 64K) fragmentation will cause f2fs suspending
all pending discards, result in performance regression, so let's set
4KB discard granularity by default.
So that without fstrim, we also have the ability to avoid any performance
regression caused by non-alignment mapping between fs and flash device.
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
fs/f2fs/f2fs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 58431b9bfd8f..273ffdaf4891 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -248,7 +248,7 @@ struct discard_entry {
};
/* default discard granularity of inner discard thread, unit: block count */
-#define DEFAULT_DISCARD_GRANULARITY 16
+#define DEFAULT_DISCARD_GRANULARITY 1
/* max discard pend list number */
#define MAX_PLIST_NUM 512
--
2.18.0.rc1
next reply other threads:[~2018-08-10 10:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 10:08 Chao Yu [this message]
2018-08-10 10:08 ` [PATCH 2/2] f2fs: tune discard speed with storage usage rate Chao Yu
2018-08-14 4:19 ` Jaegeuk Kim
2018-08-14 7:41 ` Chao Yu
2018-08-14 17:23 ` Jaegeuk Kim
2018-08-15 1:46 ` Chao Yu
2018-08-15 2:33 ` Jaegeuk Kim
2018-08-15 2:51 ` Chao Yu
2018-08-15 2:56 ` Jaegeuk Kim
2018-08-15 3:01 ` Chao Yu
2018-08-15 3:20 ` Jaegeuk Kim
2018-08-15 3:30 ` Chao Yu
[not found] ` <CAD14+f1MoAjEuXwGSmL3=0ROX_f=9jZVmvNsU9gnTP=UNxsTrg@mail.gmail.com>
2018-08-16 1:23 ` [f2fs-dev] " Jaegeuk Kim
2018-08-16 11:25 ` Chao Yu
2018-08-17 18:30 ` Jaegeuk Kim
2018-08-14 4:13 ` [PATCH 1/2] f2fs: set 4KB discard granularity by default Jaegeuk Kim
2018-08-14 7:08 ` Chao Yu
2018-09-04 14:36 ` [f2fs-dev] " Ju Hyung Park
2018-09-05 2:33 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180810100806.9298-1-yuchao0@huawei.com \
--to=yuchao0@huawei.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).