From: Takashi Iwai <tiwai@suse.de>
To: Borislav Petkov <bp@alien8.de>
Cc: Tim Small <tim@buttersideup.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] EDAC: i82443bxgx: Fix invalid memory type assignment
Date: Fri, 10 Aug 2018 16:15:20 +0200 [thread overview]
Message-ID: <20180810141520.8993-1-tiwai@suse.de> (raw)
The i82443bxgx_edac driver assigns an invalid negative value when an
unknown DRAM type is detected. Drop the unnecessary '-' that brings
misbehavior.
Fixes: 5a2c675c8919 ("drivers/edac: new i82443bxgz MC driver")
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
drivers/edac/i82443bxgx_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/i82443bxgx_edac.c b/drivers/edac/i82443bxgx_edac.c
index a2ca929e2168..1638f288fa47 100644
--- a/drivers/edac/i82443bxgx_edac.c
+++ b/drivers/edac/i82443bxgx_edac.c
@@ -273,7 +273,7 @@ static int i82443bxgx_edacmc_probe1(struct pci_dev *pdev, int dev_idx)
break;
default:
edac_dbg(0, "Unknown/reserved DRAM type value in DRAMC register!\n");
- mtype = -MEM_UNKNOWN;
+ mtype = MEM_UNKNOWN;
}
if ((mtype == MEM_SDR) || (mtype == MEM_RDR))
--
2.18.0
next reply other threads:[~2018-08-10 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 14:15 Takashi Iwai [this message]
2018-08-15 15:57 ` [PATCH] EDAC: i82443bxgx: Fix invalid memory type assignment Borislav Petkov
2018-08-15 16:01 ` Takashi Iwai
2018-08-15 16:12 ` Borislav Petkov
2018-08-27 16:45 ` [PATCH] EDAC: Remove the i82443bxgx_edac driver Borislav Petkov
2018-08-27 19:30 ` Tim Small
2018-08-28 8:59 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180810141520.8993-1-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=tim@buttersideup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).