From: osalvador@techadventures.net
To: akpm@linux-foundation.org
Cc: mhocko@suse.com, dan.j.williams@intel.com, jglisse@redhat.com,
rafael@kernel.org, david@redhat.com, yasu.isimatu@gmail.com,
logang@deltatee.com, dave.jiang@intel.com,
Jonathan.Cameron@huawei.com, vbabka@suse.cz, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Oscar Salvador <osalvador@suse.de>
Subject: [PATCH v2 2/3] mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes
Date: Mon, 13 Aug 2018 17:46:38 +0200 [thread overview]
Message-ID: <20180813154639.19454-3-osalvador@techadventures.net> (raw)
In-Reply-To: <20180813154639.19454-1-osalvador@techadventures.net>
From: Oscar Salvador <osalvador@suse.de>
Before calling to unregister_mem_sect_under_nodes(),
remove_memory_section() already checks if we got a valid
memory_block.
No need to check that again in unregister_mem_sect_under_nodes().
Signed-off-by: Oscar Salvador <osalvador@suse.de>
---
drivers/base/node.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/base/node.c b/drivers/base/node.c
index 1ac4c36e13bb..dd3bdab230b2 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -455,10 +455,6 @@ int unregister_mem_sect_under_nodes(struct memory_block *mem_blk,
NODEMASK_ALLOC(nodemask_t, unlinked_nodes, GFP_KERNEL);
unsigned long pfn, sect_start_pfn, sect_end_pfn;
- if (!mem_blk) {
- NODEMASK_FREE(unlinked_nodes);
- return -EFAULT;
- }
if (!unlinked_nodes)
return -ENOMEM;
nodes_clear(*unlinked_nodes);
--
2.13.6
next prev parent reply other threads:[~2018-08-13 15:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 15:46 [PATCH v2 0/3] Refactoring for remove_memory_section/unregister_mem_sect_under_nodes osalvador
2018-08-13 15:46 ` [PATCH v2 1/3] mm/memory-hotplug: Drop unused args from remove_memory_section osalvador
2018-08-14 9:29 ` David Hildenbrand
2018-08-13 15:46 ` osalvador [this message]
2018-08-14 9:30 ` [PATCH v2 2/3] mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes David Hildenbrand
2018-08-14 9:36 ` Oscar Salvador
2018-08-14 9:44 ` David Hildenbrand
2018-08-14 10:06 ` Oscar Salvador
2018-08-14 10:09 ` David Hildenbrand
2018-08-14 12:36 ` Oscar Salvador
2018-08-13 15:46 ` [PATCH v2 3/3] mm/memory_hotplug: Refactor unregister_mem_sect_under_nodes osalvador
2018-08-14 9:39 ` David Hildenbrand
2018-08-14 9:55 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813154639.19454-3-osalvador@techadventures.net \
--to=osalvador@techadventures.net \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=david@redhat.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=rafael@kernel.org \
--cc=vbabka@suse.cz \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).