From: Salil Mehta <salil.mehta@huawei.com>
To: <davem@davemloft.net>
Cc: <salil.mehta@huawei.com>, <yisen.zhuang@huawei.com>,
<lipeng321@huawei.com>, <mehta.salil.lnk@gmail.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@huawei.com>, Xi Wang <wangxi11@huawei.com>
Subject: [PATCH V2 net-next 2/8] net: hns3: Fix for command format parsing error in hclge_is_all_function_id_zero
Date: Tue, 14 Aug 2018 17:13:13 +0100 [thread overview]
Message-ID: <20180814161319.16392-3-salil.mehta@huawei.com> (raw)
In-Reply-To: <20180814161319.16392-1-salil.mehta@huawei.com>
From: Xi Wang <wangxi11@huawei.com>
According to the functional specification of hardware, the first
descriptor of response from command 'lookup vlan talbe' is not valid.
Currently, the first descriptor is parsed as normal value, which will
cause an expected error.
This patch fixes this problem by skipping the first descriptor.
Fixes: 46a3df9f9718 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support")
Signed-off-by: Xi Wang <wangxi11@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
index 9209122..5f30ea4 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
@@ -3930,7 +3930,7 @@ static bool hclge_is_all_function_id_zero(struct hclge_desc *desc)
#define HCLGE_FUNC_NUMBER_PER_DESC 6
int i, j;
- for (i = 0; i < HCLGE_DESC_NUMBER; i++)
+ for (i = 1; i < HCLGE_DESC_NUMBER; i++)
for (j = 0; j < HCLGE_FUNC_NUMBER_PER_DESC; j++)
if (desc[i].data[j])
return false;
--
2.7.4
next prev parent reply other threads:[~2018-08-14 16:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 16:13 [PATCH V2 net-next 0/8] Misc bug fixes & small enhancements for HNS3 Driver Salil Mehta
2018-08-14 16:13 ` [PATCH V2 net-next 1/8] net: hns3: Add support for serdes loopback selftest Salil Mehta
2018-08-14 16:13 ` Salil Mehta [this message]
2018-08-14 16:13 ` [PATCH V2 net-next 3/8] net: hns3: Fix for information of phydev lost problem when down/up Salil Mehta
2018-08-14 16:13 ` [PATCH V2 net-next 4/8] net: hns3: Fix for phy link issue when using marvell phy driver Salil Mehta
2018-08-14 16:13 ` [PATCH V2 net-next 5/8] net: hns3: Fix desc num set to default when setting channel Salil Mehta
2018-08-14 16:13 ` [PATCH V2 net-next 6/8] net: hns3: Remove tx ring BD len register in hns3_enet Salil Mehta
2018-08-14 16:13 ` [PATCH V2 net-next 7/8] net: hns3: Set tx ring' tc info when netdev is up Salil Mehta
2018-08-14 16:13 ` [PATCH V2 net-next 8/8] net: hns3: Add vlan filter setting by ethtool command -K Salil Mehta
2018-08-14 16:58 ` [PATCH V2 net-next 0/8] Misc bug fixes & small enhancements for HNS3 Driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180814161319.16392-3-salil.mehta@huawei.com \
--to=salil.mehta@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=mehta.salil.lnk@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=wangxi11@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).