[PATCH 1/1] Preventive patch in the proc file-system to handle NULL check.

From: Srikanth K H <srikanth.h@samsung.com>
To: mcgrof@kernel.org, keescook@chromium.org, adobriyan@gmail.com,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: srikanth.h@samsung.com
Subject: [PATCH 1/1] Preventive patch in the proc file-system to handle NULL check.
Date: Thu, 16 Aug 2018 15:04:13 +0530	[thread overview]
Message-ID: <1534412053-22457-1-git-send-email-srikanth.h@samsung.com> (raw)
In-Reply-To: CGME20180816093424epcas2p25ede075fec715ad31108360ddca9cce8@epcas2p2.samsung.com

If the make directory for "sys" interface fail's then its
dereferenced without even checking for its validity which
will lead to crash, hence added preventive code to check
for NULL and accordingly dereference.

Signed-off-by: Srikanth K H <srikanth.h@samsung.com>
---
 fs/proc/proc_sysctl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
index 89921a0..320884b 100644
--- a/fs/proc/proc_sysctl.c
+++ b/fs/proc/proc_sysctl.c
@@ -1692,6 +1692,8 @@ int __init proc_sys_init(void)
 	struct proc_dir_entry *proc_sys_root;
 
 	proc_sys_root = proc_mkdir("sys", NULL);
+	if (!proc_sys_root)
+		return -ENOMEM;
 	proc_sys_root->proc_iops = &proc_sys_dir_operations;
 	proc_sys_root->proc_fops = &proc_sys_dir_file_operations;
 	proc_sys_root->nlink = 0;
-- 
1.9.1

