From: Heiko Stuebner <heiko@sntech.de>
To: thierry.reding@gmail.com
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
seanpaul@chromium.org, briannorris@chromium.org,
hl@rock-chips.com, nickey.yang@rock-chips.com,
Heiko Stuebner <heiko@sntech.de>
Subject: [PATCH] drm/panel: p079zca: unconditionally remove the panel on removal
Date: Thu, 16 Aug 2018 16:09:20 +0200 [thread overview]
Message-ID: <20180816140920.5009-1-heiko@sntech.de> (raw)
There is no need to check innolux->base.dev when trying to remove
the panel, as that variable is always set directly before the panel
gets added and will still be available on panel_remove.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
drivers/gpu/drm/panel/panel-innolux-p079zca.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
index 72edb334d997..ca4ae45dd307 100644
--- a/drivers/gpu/drm/panel/panel-innolux-p079zca.c
+++ b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
@@ -506,8 +506,7 @@ static int innolux_panel_add(struct mipi_dsi_device *dsi,
static void innolux_panel_del(struct innolux_panel *innolux)
{
- if (innolux->base.dev)
- drm_panel_remove(&innolux->base);
+ drm_panel_remove(&innolux->base);
}
static int innolux_panel_probe(struct mipi_dsi_device *dsi)
--
2.17.0
next reply other threads:[~2018-08-16 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 14:09 Heiko Stuebner [this message]
2018-08-16 14:40 ` [PATCH] drm/panel: p079zca: unconditionally remove the panel on removal Philipp Zabel
2018-09-27 12:05 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180816140920.5009-1-heiko@sntech.de \
--to=heiko@sntech.de \
--cc=briannorris@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hl@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickey.yang@rock-chips.com \
--cc=seanpaul@chromium.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).