linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Harshit Jain <harshitjain6751@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Harshit Jain <harshitjain6751@gmail.com>,
	Tony Finch <dot@dotat.at>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] scripts: unifdef: fix stringop-truncation warning
Date: Fri, 17 Aug 2018 22:20:38 +0200	[thread overview]
Message-ID: <20180817202038.27257-1-harshitjain6751@gmail.com> (raw)

While compiling the mainline kernel in android env with latest gcc 8 the compiler threw this warning Thanks to the advantage of improved static analysis in newer gcc we are now able to
see this warning this patch resolves the detected compiler warnings.

Signed-off-by: Harshit Jain <harshitjain6751@gmail.com>
---
 scripts/unifdef.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/unifdef.c b/scripts/unifdef.c
index 7493c0ee51cc..985649805cdd 100644
--- a/scripts/unifdef.c
+++ b/scripts/unifdef.c
@@ -450,7 +450,7 @@ static void Idrop (void) { Fdrop();  ignoreon(); }
 static void Itrue (void) { Ftrue();  ignoreon(); }
 static void Ifalse(void) { Ffalse(); ignoreon(); }
 /* modify this line */
-static void Mpass (void) { strncpy(keyword, "if  ", 4); Pelif(); }
+static void Mpass (void) { memcpy(keyword, "if  ", 4); Pelif(); }
 static void Mtrue (void) { keywordedit("else");  state(IS_TRUE_MIDDLE); }
 static void Melif (void) { keywordedit("endif"); state(IS_FALSE_TRAILER); }
 static void Melse (void) { keywordedit("endif"); state(IS_FALSE_ELSE); }
-- 
2.18.0


             reply	other threads:[~2018-08-17 20:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-17 20:20 Harshit Jain [this message]
2018-08-21 15:13 ` [PATCH] scripts: unifdef: fix stringop-truncation warning Tony Finch
     [not found]   ` <CAA47fTLj32cf=p5LUwZDrtKvXebHDNxz9ozEz9YCoCFP0NRgng@mail.gmail.com>
2018-08-23 11:42     ` Tony Finch
2018-09-14 10:44 Harshit Jain
2018-09-14 17:12 ` Miguel Ojeda
2018-09-14 17:18   ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180817202038.27257-1-harshitjain6751@gmail.com \
    --to=harshitjain6751@gmail.com \
    --cc=dot@dotat.at \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).