From: Tony Luck <tony.luck@intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Tony Luck <tony.luck@intel.com>,
linux-ia64@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Boris Brezillon <boris.brezillon@bootlin.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Sinan Kaya <okaya@codeaurora.org>,
Tomasz Nowicki <tn@semihalf.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: [PATCH] ia64: Fix kernel BUG at lib/ioremap.c:72!
Date: Mon, 20 Aug 2018 09:31:04 -0700 [thread overview]
Message-ID: <20180820163104.12879-1-tony.luck@intel.com> (raw)
In-Reply-To: <CAK8P3a0Jk_Q-9c7PizRF4HteigfiOprRszpaV9SCk-6tUYfVVQ@mail.gmail.com>
Commit:
0bbf47eab469 ("ia64: use asm-generic/io.h")
results in a BUG while booting ia64. This is because
asm-generic/io.h defines PCI_IOBASE, which results in
the function acpi_pci_root_remap_iospace() doing a lot
of unnecessary (and wrong) things.
I'd suggested an #if !CONFIG_IA64 in the functon, but Arnd
suggested keeping the fix inside the arch/ia64 tree.
Fixes: 0bbf47eab469 ("ia64: use asm-generic/io.h")
Suggested-by: Arnd Bergman <arnd@arndb.de>
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
arch/ia64/include/asm/io.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/ia64/include/asm/io.h b/arch/ia64/include/asm/io.h
index 6f952171abf9..1e6fef69bb01 100644
--- a/arch/ia64/include/asm/io.h
+++ b/arch/ia64/include/asm/io.h
@@ -454,6 +454,7 @@ extern void memset_io(volatile void __iomem *s, int c, long n);
#define xlate_dev_kmem_ptr xlate_dev_kmem_ptr
#define xlate_dev_mem_ptr xlate_dev_mem_ptr
#include <asm-generic/io.h>
+#undef PCI_IOBASE
# endif /* __KERNEL__ */
--
2.17.1
next prev parent reply other threads:[~2018-08-20 16:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 20:45 how to fix acpi_pci_root_remap_iospace? Luck, Tony
2018-08-16 21:10 ` Arnd Bergmann
2018-08-16 23:26 ` Luck, Tony
2018-08-17 8:47 ` Arnd Bergmann
2018-08-17 8:55 ` Boris Brezillon
2018-08-17 15:56 ` Luck, Tony
2018-08-17 16:20 ` Boris Brezillon
2018-08-17 19:01 ` Arnd Bergmann
2018-08-20 16:31 ` Tony Luck [this message]
2018-08-20 19:23 ` [PATCH] ia64: Fix kernel BUG at lib/ioremap.c:72! Linus Torvalds
2018-08-17 11:24 ` how to fix acpi_pci_root_remap_iospace? Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180820163104.12879-1-tony.luck@intel.com \
--to=tony.luck@intel.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=boris.brezillon@bootlin.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=okaya@codeaurora.org \
--cc=tn@semihalf.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).