From: Nick Desaulniers <ndesaulniers@google.com>
To: ard.biesheuvel@linaro.org
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] arm64/crypto: remove non-standard notation
Date: Mon, 20 Aug 2018 15:40:32 -0700 [thread overview]
Message-ID: <20180820224032.53194-1-ndesaulniers@google.com> (raw)
It seems that:
ldr q8, =0x30000000200000001
is a GNU as convience notation for:
ldr q8, .Lconstant
.Lconstant
.word 0x00000001
.word 0x00000002
.word 0x00000003
.word 0x00000000
based on this comment in binutils' source [0]. I've asked for this
non-standard convience notation to be added to other assemblers [1], but
until then, we can remove it and get equivalent disassembly:
before:
00000000000009d4 <neon_aes_ctr_encrypt>:
...
a48: 9c000ac8 ldr q8, ba0 <neon_aes_ctr_encrypt+0x1cc>
...
ba0: 00000001 .word 0x00000001
ba4: 00000002 .word 0x00000002
ba8: 00000003 .word 0x00000003
bac: 00000000 .word 0x00000000
after:
00000000000009d4 <neon_aes_ctr_encrypt>:
...
a48: 9c000aa8 ldr q8, b9c <neon_aes_ctr_encrypt+0x1c8>
...
b9c: 00000001 .word 0x00000001
ba0: 00000002 .word 0x00000002
ba4: 00000003 .word 0x00000003
ba8: 00000000 .word 0x00000000
[0] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gas/testsuite/gas/aarch64/programmer-friendly.s;h=6254c6476efdc848648b05068be0574e7addc85d;hb=HEAD#l11
[1] https://bugs.llvm.org/show_bug.cgi?id=38642
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
arch/arm64/crypto/aes-modes.S | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/crypto/aes-modes.S b/arch/arm64/crypto/aes-modes.S
index 483a7130cf0e..9288c5b0eca2 100644
--- a/arch/arm64/crypto/aes-modes.S
+++ b/arch/arm64/crypto/aes-modes.S
@@ -232,7 +232,7 @@ AES_ENTRY(aes_ctr_encrypt)
bmi .Lctr1x
cmn w6, #4 /* 32 bit overflow? */
bcs .Lctr1x
- ldr q8, =0x30000000200000001 /* addends 1,2,3[,0] */
+ ldr q8, .Laddends /* addends 1,2,3[,0] */
dup v7.4s, w6
mov v0.16b, v4.16b
add v7.4s, v7.4s, v8.4s
@@ -295,6 +295,12 @@ AES_ENTRY(aes_ctr_encrypt)
rev x7, x7
ins v4.d[0], x7
b .Lctrcarrydone
+
+.Laddends:
+ .word 0x00000001
+ .word 0x00000002
+ .word 0x00000003
+ .word 0x00000000
AES_ENDPROC(aes_ctr_encrypt)
.ltorg
--
2.18.0.865.gffc8e1a3cd6-goog
next reply other threads:[~2018-08-20 22:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 22:40 Nick Desaulniers [this message]
2018-08-20 22:43 ` [PATCH] arm64/crypto: remove non-standard notation Nick Desaulniers
2018-08-21 0:04 ` Will Deacon
2018-08-21 12:23 ` Ard Biesheuvel
2018-08-21 16:50 ` Nick Desaulniers
2018-08-21 17:00 ` Ard Biesheuvel
2018-08-21 17:25 ` Robin Murphy
2018-08-21 18:13 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180820224032.53194-1-ndesaulniers@google.com \
--to=ndesaulniers@google.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).