From: Peng Li <lipeng321@huawei.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@huawei.com>, <yisen.zhuang@huawei.com>,
<salil.mehta@huawei.com>, <lipeng321@huawei.com>
Subject: [PATCH NET 3/3] net: hns: add configuration constraints for 1000M half
Date: Fri, 24 Aug 2018 11:42:23 +0800 [thread overview]
Message-ID: <1535082143-122281-4-git-send-email-lipeng321@huawei.com> (raw)
In-Reply-To: <1535082143-122281-1-git-send-email-lipeng321@huawei.com>
Hisilicon hip05 and hip06 board network card do not support
1000M half configuration. Driver can not config gmac as
1000M half.
Signed-off-by: Peng Li <lipeng321@huawei.com>
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c
index 09e4061..c1d062e 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c
@@ -272,6 +272,11 @@ static int hns_gmac_adjust_link(void *mac_drv, enum mac_speed speed,
{
struct mac_driver *drv = (struct mac_driver *)mac_drv;
+ if (full_duplex == DUPLEX_HALF && speed == MAC_SPEED_1000) {
+ dev_err(drv->dev, "HW do not support 1000M half\n");
+ return -EINVAL;
+ }
+
dsaf_set_dev_bit(drv, GMAC_DUPLEX_TYPE_REG,
GMAC_DUPLEX_TYPE_B, !!full_duplex);
--
2.9.3
next prev parent reply other threads:[~2018-08-24 3:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 3:42 [PATCH net 0/3] net: hns: fix some bugs about speed and duplex change Peng Li
2018-08-24 3:42 ` [PATCH NET 1/3] net: hns: add the code for cleaning pkt in chip Peng Li
2018-08-24 3:42 ` [PATCH NET 2/3] net: hns: add netif_carrier_off before change speed and duplex Peng Li
2018-08-24 3:42 ` Peng Li [this message]
2018-08-24 3:41 ` [PATCH NET 3/3] net: hns: add configuration constraints for 1000M half Andrew Lunn
2018-08-24 6:39 ` lipeng (Y)
2018-08-24 13:28 ` Andrew Lunn
2018-08-25 1:21 ` lipeng (Y)
2018-08-25 18:07 ` Andrew Lunn
2018-08-27 1:08 ` lipeng (Y)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535082143-122281-4-git-send-email-lipeng321@huawei.com \
--to=lipeng321@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).