From: Punit Agrawal <punit.agrawal@arm.com>
To: bhelgaas@google.com
Cc: Punit Agrawal <punit.agrawal@arm.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
will.deacon@arm.com, x86@kernel.org,
linux-arm-kernel@lists.infradead.org, lorenzo.pieralisi@arm.com,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH 2/2] x86/PCI: Remove node-local allocation when initialising host controller
Date: Tue, 28 Aug 2018 16:05:13 +0100 [thread overview]
Message-ID: <20180828150513.32458-3-punit.agrawal@arm.com> (raw)
In-Reply-To: <20180828150513.32458-1-punit.agrawal@arm.com>
Memory for host controller data structures is allocated local to the
node to which the controller is associated with. This has been the
behaviour since 965cd0e4a5e5 ("x86, PCI, ACPI: Use kmalloc_node() to
optimize for performance") where the node local allocation was added
without additional context.
Drop the node local allocation as there is no benefit from doing so -
the usage of these structures is independent from where the controller
is located.
Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
---
arch/x86/pci/acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/pci/acpi.c b/arch/x86/pci/acpi.c
index 5559dcaddd5e..948656069cdd 100644
--- a/arch/x86/pci/acpi.c
+++ b/arch/x86/pci/acpi.c
@@ -356,7 +356,7 @@ struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root)
} else {
struct pci_root_info *info;
- info = kzalloc_node(sizeof(*info), GFP_KERNEL, node);
+ info = kzalloc(sizeof(*info), GFP_KERNEL);
if (!info)
dev_err(&root->device->dev,
"pci_bus %04x:%02x: ignored (out of memory)\n",
--
2.18.0
next prev parent reply other threads:[~2018-08-28 15:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 15:05 [PATCH 0/2] Drop node-local allocation during host controller initialisation Punit Agrawal
2018-08-28 15:05 ` [PATCH 1/2] arm64: PCI: Remove node-local allocations when initialising host controller Punit Agrawal
2018-08-28 16:45 ` Will Deacon
2018-08-28 15:05 ` Punit Agrawal [this message]
2018-09-04 13:24 ` [PATCH 0/2] Drop node-local allocation during host controller initialisation Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180828150513.32458-3-punit.agrawal@arm.com \
--to=punit.agrawal@arm.com \
--cc=bhelgaas@google.com \
--cc=hpa@zytor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).