linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Icenowy Zheng <icenowy@aosc.io>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Jernej Skrabec <jernej.skrabec@siol.net>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-sunxi@googlegroups.com, Icenowy Zheng <icenowy@aosc.io>
Subject: [PATCH v4 01/11] clk: sunxi-ng: a64: Add minimal rate for video PLLs
Date: Tue,  4 Sep 2018 12:40:43 +0800	[thread overview]
Message-ID: <20180904044053.15425-2-icenowy@aosc.io> (raw)
In-Reply-To: <20180904044053.15425-1-icenowy@aosc.io>

From: Jagan Teki <jagan@amarulasolutions.com>

According to documentation and experience with other similar SoCs, video
PLLs don't work stable if their output frequency is set below 192 MHz.

Because of that, set minimal rate to both A64 video PLLs to 192 MHz.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net>
---
Changes for v3..v4:
- none 
Changes for v2:
- New patch

 drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 46 ++++++++++++++-------------
 1 file changed, 24 insertions(+), 22 deletions(-)

diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c
index ee9c12cf3f08..d0e30192f0cf 100644
--- a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c
+++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c
@@ -64,17 +64,18 @@ static SUNXI_CCU_NM_WITH_GATE_LOCK(pll_audio_base_clk, "pll-audio-base",
 				   BIT(28),	/* lock */
 				   CLK_SET_RATE_UNGATE);
 
-static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK(pll_video0_clk, "pll-video0",
-					"osc24M", 0x010,
-					8, 7,		/* N */
-					0, 4,		/* M */
-					BIT(24),	/* frac enable */
-					BIT(25),	/* frac select */
-					270000000,	/* frac rate 0 */
-					297000000,	/* frac rate 1 */
-					BIT(31),	/* gate */
-					BIT(28),	/* lock */
-					CLK_SET_RATE_UNGATE);
+static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN(pll_video0_clk, "pll-video0",
+					    "osc24M", 0x010,
+					    192000000,	/* Minimum rate */
+					    8, 7,		/* N */
+					    0, 4,		/* M */
+					    BIT(24),	/* frac enable */
+					    BIT(25),	/* frac select */
+					    270000000,	/* frac rate 0 */
+					    297000000,	/* frac rate 1 */
+					    BIT(31),	/* gate */
+					    BIT(28),	/* lock */
+					    CLK_SET_RATE_UNGATE);
 
 static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK(pll_ve_clk, "pll-ve",
 					"osc24M", 0x018,
@@ -125,17 +126,18 @@ static struct ccu_nk pll_periph1_clk = {
 	},
 };
 
-static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK(pll_video1_clk, "pll-video1",
-					"osc24M", 0x030,
-					8, 7,		/* N */
-					0, 4,		/* M */
-					BIT(24),	/* frac enable */
-					BIT(25),	/* frac select */
-					270000000,	/* frac rate 0 */
-					297000000,	/* frac rate 1 */
-					BIT(31),	/* gate */
-					BIT(28),	/* lock */
-					CLK_SET_RATE_UNGATE);
+static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN(pll_video1_clk, "pll-video1",
+					    "osc24M", 0x030,
+					    192000000,	/* Minimum rate */
+					    8, 7,		/* N */
+					    0, 4,		/* M */
+					    BIT(24),	/* frac enable */
+					    BIT(25),	/* frac select */
+					    270000000,	/* frac rate 0 */
+					    297000000,	/* frac rate 1 */
+					    BIT(31),	/* gate */
+					    BIT(28),	/* lock */
+					    CLK_SET_RATE_UNGATE);
 
 static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK(pll_gpu_clk, "pll-gpu",
 					"osc24M", 0x038,
-- 
2.18.0


  reply	other threads:[~2018-09-04  4:41 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04  4:40 [PATCH v4 00/11] arm64: allwinner: Add A64 DE2 HDMI support Icenowy Zheng
2018-09-04  4:40 ` Icenowy Zheng [this message]
2018-09-05  7:16   ` [PATCH v4 01/11] clk: sunxi-ng: a64: Add minimal rate for video PLLs Maxime Ripard
2018-09-04  4:40 ` [PATCH v4 02/11] clk: sunxi-ng: a64: Add max. rate constraint to " Icenowy Zheng
2018-09-05  7:16   ` Maxime Ripard
2018-09-05 10:22     ` Sergey Suloev
2018-09-04  4:40 ` [PATCH v4 03/11] dt-bindings: display: Add compatible for A64 DE2 display pipeline Icenowy Zheng
2018-09-05  7:20   ` Maxime Ripard
2018-09-04  4:40 ` [PATCH v4 04/11] drm/sun4i: Add support for A64 mixers Icenowy Zheng
2018-09-05  7:21   ` Maxime Ripard
2018-09-04  4:40 ` [PATCH v4 05/11] drm/sun4i: Add support for A64 display engine Icenowy Zheng
2018-09-05  7:21   ` Maxime Ripard
2018-09-04  4:40 ` [PATCH v4 06/11] dt-bindings: display: Add compatible for A64 HDMI Icenowy Zheng
2018-09-05  7:21   ` Maxime Ripard
2018-09-04  4:40 ` [PATCH v4 07/11] dt-bindings: clock: sun50i-a64-ccu: Add PLL_VIDEO0 macro Icenowy Zheng
2018-09-05  7:21   ` Maxime Ripard
2018-09-04  4:40 ` [PATCH v4 08/11] arm64: dts: allwinner: a64: Add display pipeline Icenowy Zheng
2018-09-05  7:50   ` Maxime Ripard
2018-09-07  4:13     ` Jagan Teki
2018-09-07  8:21       ` Maxime Ripard
2018-09-06  6:18   ` [linux-sunxi] " Jagan Teki
2018-09-06  6:19     ` Icenowy Zheng
2018-09-04  4:40 ` [PATCH v4 09/11] dt-bindings: sun4i-drm: add HDMI VCC supply property for sun8i-dw-hdmi Icenowy Zheng
2018-09-05  7:22   ` Maxime Ripard
2018-09-04  4:40 ` [PATCH v4 10/11] drm/sun4i: Add support for HDMI voltage regulator Icenowy Zheng
2018-09-05  7:22   ` Maxime Ripard
2018-09-04  4:40 ` [PATCH v4 11/11] arm64: dts: allwinner: a64: Enable HDMI output on A64 boards w/ HDMI Icenowy Zheng
2018-09-05  7:26   ` [linux-sunxi] " Jagan Teki
2018-09-05  7:51     ` Maxime Ripard
2018-09-05  7:57       ` Jagan Teki
2018-09-05 22:53         ` Vasily Khoruzhick
2018-09-06  4:12           ` Vasily Khoruzhick
2018-09-06  5:07         ` Jernej Škrabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180904044053.15425-2-icenowy@aosc.io \
    --to=icenowy@aosc.io \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jagan@amarulasolutions.com \
    --cc=jernej.skrabec@siol.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).