ARM: qcom_defconfig: Enable MAILBOX
diff mbox series

Message ID 1536295488-12296-1-git-send-email-frowand.list@gmail.com
State New, archived
Headers show
Series
  • ARM: qcom_defconfig: Enable MAILBOX
Related show

Commit Message

Frank Rowand Sept. 7, 2018, 4:44 a.m. UTC
From: Frank Rowand <frank.rowand@sony.com>

Problem:
ab460a2e72da ("rpmsg: qcom_smd: Access APCS through mailbox framework"
added a "depends on MAILBOX") to RPMSG_QCOM_SMD, thus RPMSG_QCOM_SMD
becomes unset since MAILBOX was not enabled in qcom_defconfig and is
not otherwise selected for the dragonboard.  When the resulting
kernel is booted the mmc device which contains the root file system
is not available.

Fix:
add CONFIG_MAILBOX to qcom_defconfig

Fixes: ab460a2e72da ("rpmsg: qcom_smd: Access APCS through mailbox framework"
added a "depends on MAILBOX")

Signed-off-by: Frank Rowand <frank.rowand@sony.com>
---

Bjorn suggested that multi_v7_defconfig might need this same fix
but I don't have a target to test on so I have not included that
change in this patch

Tested on Qualcomm APQ8074 Dragonboard

 arch/arm/configs/qcom_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Bjorn Andersson Sept. 7, 2018, 4:51 p.m. UTC | #1
On Thu 06 Sep 21:44 PDT 2018, frowand.list@gmail.com wrote:

> From: Frank Rowand <frank.rowand@sony.com>
> 
> Problem:
> ab460a2e72da ("rpmsg: qcom_smd: Access APCS through mailbox framework"
> added a "depends on MAILBOX") to RPMSG_QCOM_SMD, thus RPMSG_QCOM_SMD
> becomes unset since MAILBOX was not enabled in qcom_defconfig and is
> not otherwise selected for the dragonboard.  When the resulting
> kernel is booted the mmc device which contains the root file system
> is not available.
> 
> Fix:
> add CONFIG_MAILBOX to qcom_defconfig
> 
> Fixes: ab460a2e72da ("rpmsg: qcom_smd: Access APCS through mailbox framework"
> added a "depends on MAILBOX")
> 
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---
> 
> Bjorn suggested that multi_v7_defconfig might need this same fix
> but I don't have a target to test on so I have not included that
> change in this patch
> 

multi_v7_defconfig should boot on 8974 as well, but I would not be a
surprise if there are other things missing there.

Regards,
Bjorn

> Tested on Qualcomm APQ8074 Dragonboard
> 
>  arch/arm/configs/qcom_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig
> index 6aa7046fb91f..bd6440f23493 100644
> --- a/arch/arm/configs/qcom_defconfig
> +++ b/arch/arm/configs/qcom_defconfig
> @@ -207,6 +207,7 @@ CONFIG_MSM_MMCC_8974=y
>  CONFIG_MSM_IOMMU=y
>  CONFIG_HWSPINLOCK=y
>  CONFIG_HWSPINLOCK_QCOM=y
> +CONFIG_MAILBOX=y
>  CONFIG_REMOTEPROC=y
>  CONFIG_QCOM_ADSP_PIL=y
>  CONFIG_QCOM_Q6V5_PIL=y
> -- 
> Frank Rowand <frank.rowand@sony.com>
>

Patch
diff mbox series

diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig
index 6aa7046fb91f..bd6440f23493 100644
--- a/arch/arm/configs/qcom_defconfig
+++ b/arch/arm/configs/qcom_defconfig
@@ -207,6 +207,7 @@  CONFIG_MSM_MMCC_8974=y
 CONFIG_MSM_IOMMU=y
 CONFIG_HWSPINLOCK=y
 CONFIG_HWSPINLOCK_QCOM=y
+CONFIG_MAILBOX=y
 CONFIG_REMOTEPROC=y
 CONFIG_QCOM_ADSP_PIL=y
 CONFIG_QCOM_Q6V5_PIL=y