From: Tom Zanussi <zanussi@kernel.org>
To: rostedt@goodmis.org
Cc: tglx@linutronix.de, mhiramat@kernel.org, namhyung@kernel.org,
vedang.patel@intel.com, bigeasy@linutronix.de,
joel@joelfernandes.org, mathieu.desnoyers@efficios.com,
julia@ni.com, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org
Subject: [PATCH v4 5/8] tracing: Move hist trigger key printing into a separate function
Date: Mon, 10 Sep 2018 14:10:43 -0500 [thread overview]
Message-ID: <897f8a4bea8b632b886bf755c811e35e4d9698f2.1536605847.git.tom.zanussi@linux.intel.com> (raw)
In-Reply-To: <cover.1536605847.git.tom.zanussi@linux.intel.com>
In-Reply-To: <cover.1536605847.git.tom.zanussi@linux.intel.com>
From: Tom Zanussi <tom.zanussi@linux.intel.com>
Future patches will want to print a histogram key outside a histogram
- add and use hist_trigger_print_key() for that purpose.
Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
---
kernel/trace/trace_events_hist.c | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
index 3712200dc670..5ec462cb7672 100644
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -4849,10 +4849,10 @@ static void hist_trigger_stacktrace_print(struct seq_file *m,
}
}
-static void
-hist_trigger_entry_print(struct seq_file *m,
- struct hist_trigger_data *hist_data, void *key,
- struct tracing_map_elt *elt)
+static void hist_trigger_print_key(struct seq_file *m,
+ struct hist_trigger_data *hist_data,
+ void *key,
+ struct tracing_map_elt *elt)
{
struct hist_field *key_field;
char str[KSYM_SYMBOL_LEN];
@@ -4928,6 +4928,17 @@ hist_trigger_entry_print(struct seq_file *m,
seq_puts(m, " ");
seq_puts(m, "}");
+}
+
+static void hist_trigger_entry_print(struct seq_file *m,
+ struct hist_trigger_data *hist_data,
+ void *key,
+ struct tracing_map_elt *elt)
+{
+ const char *field_name;
+ unsigned int i;
+
+ hist_trigger_print_key(m, hist_data, key, elt);
seq_printf(m, " hitcount: %10llu",
tracing_map_read_sum(elt, HITCOUNT_IDX));
--
2.14.1
next prev parent reply other threads:[~2018-09-10 19:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 19:10 [PATCH v4 0/8] tracing: Hist trigger snapshot and onchange additions Tom Zanussi
2018-09-10 19:10 ` [PATCH v4 1/8] tracing: Refactor hist trigger action code Tom Zanussi
2018-09-10 19:10 ` [PATCH v4 2/8] tracing: Split up onmatch action data Tom Zanussi
2018-09-10 19:10 ` [PATCH v4 3/8] tracing: Generalize hist trigger onmax and save action Tom Zanussi
2018-09-10 19:10 ` [PATCH v4 4/8] tracing: Add conditional snapshot Tom Zanussi
2018-09-10 19:10 ` Tom Zanussi [this message]
2018-09-10 19:10 ` [PATCH v4 6/8] tracing: Add snapshot action Tom Zanussi
2018-09-10 19:10 ` [PATCH v4 7/8] tracing: Add hist trigger onchange() handler Tom Zanussi
2018-09-10 19:10 ` [PATCH v4 8/8] trace: Add alternative synthetic event trace action syntax Tom Zanussi
2018-09-18 18:54 ` Masami Hiramatsu
2018-09-18 19:16 ` Tom Zanussi
2018-09-18 23:54 ` Masami Hiramatsu
2018-09-19 16:33 ` Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=897f8a4bea8b632b886bf755c811e35e4d9698f2.1536605847.git.tom.zanussi@linux.intel.com \
--to=zanussi@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=joel@joelfernandes.org \
--cc=julia@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vedang.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).