selinux: ss: use match_string() helper to simplify the code
diff mbox series

Message ID 1536936852-30893-1-git-send-email-zhongjiang@huawei.com
State New
Headers show
Series
  • selinux: ss: use match_string() helper to simplify the code
Related show

Commit Message

zhong jiang Sept. 14, 2018, 2:54 p.m. UTC
match_string() returns the index of an array for a matching string,
which can be used intead of open coded implementation.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
 security/selinux/ss/services.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Patch
diff mbox series

diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
index 12e4143..aa9fc35 100644
--- a/security/selinux/ss/services.c
+++ b/security/selinux/ss/services.c
@@ -1461,14 +1461,14 @@  static int security_context_to_sid_core(struct selinux_state *state,
 		return -ENOMEM;
 
 	if (!state->initialized) {
-		int i;
+		int index;
 
-		for (i = 1; i < SECINITSID_NUM; i++) {
-			if (!strcmp(initial_sid_to_string[i], scontext2)) {
-				*sid = i;
-				goto out;
-			}
+		index = match_string(initial_sid_to_string, SECINITSID_NUM, scontext2);
+		if (index >= 0) {
+			*sid = index;
+			goto out;
 		}
+
 		*sid = SECINITSID_KERNEL;
 		goto out;
 	}