From: Yang Shi <yang.shi@linux.alibaba.com>
To: mhocko@kernel.org, willy@infradead.org,
ldufour@linux.vnet.ibm.com, vbabka@suse.cz, kirill@shutemov.name,
akpm@linux-foundation.org
Cc: dave.hansen@intel.com, oleg@redhat.com,
srikar@linux.vnet.ibm.com, yang.shi@linux.alibaba.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [RFC v10 PATCH 2/3] mm: unmap VM_HUGETLB mappings with optimized path
Date: Sat, 15 Sep 2018 04:34:58 +0800 [thread overview]
Message-ID: <1536957299-43536-3-git-send-email-yang.shi@linux.alibaba.com> (raw)
In-Reply-To: <1536957299-43536-1-git-send-email-yang.shi@linux.alibaba.com>
When unmapping VM_HUGETLB mappings, vm flags need to be updated. Since
the vmas have been detached, so it sounds safe to update vm flags with
read mmap_sem.
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
---
mm/mmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/mmap.c b/mm/mmap.c
index 2879b19..991e066 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -2777,7 +2777,7 @@ static int __do_munmap(struct mm_struct *mm, unsigned long start, size_t len,
* update vm_flags.
*/
if (downgrade &&
- (tmp->vm_flags & (VM_HUGETLB | VM_PFNMAP)))
+ (tmp->vm_flags & VM_PFNMAP))
downgrade = false;
tmp = tmp->vm_next;
--
1.8.3.1
next prev parent reply other threads:[~2018-09-14 20:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 20:34 [RFC v10 PATCH 0/3] mm: zap pages with read mmap_sem in munmap for large mapping Yang Shi
2018-09-14 20:34 ` [RFC v10 PATCH 1/3] mm: mmap: zap pages with read mmap_sem in munmap Yang Shi
2018-09-15 9:21 ` Matthew Wilcox
2018-09-17 19:49 ` Yang Shi
2018-09-14 20:34 ` Yang Shi [this message]
2018-09-15 9:44 ` [RFC v10 PATCH 2/3] mm: unmap VM_HUGETLB mappings with optimized path Matthew Wilcox
2018-09-14 20:34 ` [RFC v10 PATCH 3/3] mm: unmap VM_PFNMAP " Yang Shi
2018-09-15 9:45 ` Matthew Wilcox
2018-09-15 10:10 ` [RFC v10 PATCH 0/3] mm: zap pages with read mmap_sem in munmap for large mapping Matthew Wilcox
2018-09-17 20:00 ` Yang Shi
2018-09-18 10:37 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536957299-43536-3-git-send-email-yang.shi@linux.alibaba.com \
--to=yang.shi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=kirill@shutemov.name \
--cc=ldufour@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=oleg@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).