From: "Leonardo Brás" <leobras.c@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] kbuild: Optimize tests and remove shadowed local variable.
Date: Tue, 18 Sep 2018 20:00:02 -0300 [thread overview]
Message-ID: <20180918230002.GA7572@WindFlash> (raw)
Removes an unnecessary shadowed local variable (start).
Optimize test of isdigit:
- If isalpha returns true, isdigit will return false, so no need to test.
Signed-off-by: Leonardo Brás <leobras.c@gmail.com>
---
scripts/asn1_compiler.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/asn1_compiler.c b/scripts/asn1_compiler.c
index c146020fc783..a0056df4e358 100644
--- a/scripts/asn1_compiler.c
+++ b/scripts/asn1_compiler.c
@@ -413,7 +413,7 @@ static void tokenise(char *buffer, char *end)
/* Handle string tokens */
if (isalpha(*p)) {
- const char **dir, *start = p;
+ const char **dir;
/* Can be a directive, type name or element
* name. Find the end of the name.
@@ -454,10 +454,10 @@ static void tokenise(char *buffer, char *end)
tokens[tix++].token_type = TOKEN_TYPE_NAME;
continue;
- }
- /* Handle numbers */
- if (isdigit(*p)) {
+ } else if (isdigit(*p)) {
+ /* Handle numbers */
+
/* Find the end of the number */
q = p + 1;
while (q < nl && (isdigit(*q)))
--
2.19.0
next reply other threads:[~2018-09-18 23:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 23:00 Leonardo Brás [this message]
2018-09-19 7:10 ` [PATCH 1/1] kbuild: Optimize tests and remove shadowed local variable Masahiro Yamada
2018-10-05 2:29 ` Leonardo Bras
2018-10-06 19:49 ` Masahiro Yamada
2018-10-10 1:02 ` Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918230002.GA7572@WindFlash \
--to=leobras.c@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).