From: Lianbo Jiang <lijiang@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: kexec@lists.infradead.org, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org, akpm@linux-foundation.org,
dan.j.williams@intel.com, thomas.lendacky@amd.com,
bhelgaas@google.com, baiyaowei@cmss.chinamobile.com,
tiwai@suse.de, bp@suse.de, brijesh.singh@amd.com,
dyoung@redhat.com
Subject: [PATCH 1/3 v2] resource: fix an error which walks through iomem resources
Date: Wed, 19 Sep 2018 20:52:49 +0800 [thread overview]
Message-ID: <20180919125251.8181-2-lijiang@redhat.com> (raw)
In-Reply-To: <20180919125251.8181-1-lijiang@redhat.com>
When we walk through iomem resources by calling walk_iomem_res_desc(),
the values of the function parameter may be modified in the while loop
of __walk_iomem_res_desc(), which will cause us to not get the desired
result in some cases.
At present, it only restores the original value of res->end, but it
doesn't restore the original value of res->flags in the while loop of
__walk_iomem _res_desc(). Whenever the find_next_iomem_res() finds a
resource and returns the result, the original values of this resource
will be modified, which might lead to an error in the next loop. For
example:
The original value of resource flags is:
res->flags=0x80000200(initial value)
p->flags _ 0x81000200 _ _ 0x80000200 _
/ \ / \
|________|_______A________|____|_....._|______B_________|..........___|
0 0xffffffff
(memory address ranges)
Note: if ((p->flags & res->flags) != res->flags) continue;
When the resource A is found, the original value of this resource flags
will be changed to 0x81000200(res->flags=0x81000200), and continue to
look for the next resource, when the loop reaches resource B, it can not
get the resource B any more(you can refer to the for loop of find_next
_iomem_res()), because the value of conditional expression will become
true and will also jump the resource B.
In fact, we should get the resource A and B when we walk through the
whole tree, but it only gets the resource A, the resource B is missed.
Signed-off-by: Dave Young <dyoung@redhat.com>
Signed-off-by: Lianbo Jiang <lijiang@redhat.com>
---
kernel/resource.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/resource.c b/kernel/resource.c
index 30e1bc68503b..f5d9fc70a04c 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -375,6 +375,7 @@ static int __walk_iomem_res_desc(struct resource *res, unsigned long desc,
int (*func)(struct resource *, void *))
{
u64 orig_end = res->end;
+ u64 orig_flags = res->flags;
int ret = -1;
while ((res->start < res->end) &&
@@ -385,6 +386,7 @@ static int __walk_iomem_res_desc(struct resource *res, unsigned long desc,
res->start = res->end + 1;
res->end = orig_end;
+ res->flags = orig_flags;
}
return ret;
--
2.17.1
next prev parent reply other threads:[~2018-09-19 12:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 12:52 [PATCH 0/3 v2] add reserved e820 ranges to the kdump kernel e820 table Lianbo Jiang
2018-09-19 12:52 ` Lianbo Jiang [this message]
2018-09-19 13:29 ` [PATCH 1/3 v2] resource: fix an error which walks through iomem resources Borislav Petkov
2018-09-20 6:39 ` lijiang
2018-09-20 6:59 ` Dave Young
2018-09-19 12:52 ` [PATCH 2/3 v2] x86/kexec_file: add e820 entry in case e820 type string matches to io resource name Lianbo Jiang
2018-09-19 12:52 ` [PATCH 3/3 v2] x86/kexec_file: add reserved e820 ranges to kdump kernel e820 table Lianbo Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180919125251.8181-2-lijiang@redhat.com \
--to=lijiang@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=baiyaowei@cmss.chinamobile.com \
--cc=bhelgaas@google.com \
--cc=bp@suse.de \
--cc=brijesh.singh@amd.com \
--cc=dan.j.williams@intel.com \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tiwai@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).