From: srinivas.kandagatla@linaro.org
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: [PATCH 22/26] nvmem: use EOPNOTSUPP instead of ENOSYS
Date: Fri, 21 Sep 2018 06:40:22 -0700 [thread overview]
Message-ID: <20180921134026.4596-23-srinivas.kandagatla@linaro.org> (raw)
In-Reply-To: <20180921134026.4596-1-srinivas.kandagatla@linaro.org>
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Checkpatch emits warnings when using ENOSYS. Some of the frameworks
started using EOPNOTSUPP as return values for API functions when given
subsystem is disabled in Kconfig.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
include/linux/nvmem-consumer.h | 30 +++++++++++++++---------------
include/linux/nvmem-provider.h | 5 ++---
2 files changed, 17 insertions(+), 18 deletions(-)
diff --git a/include/linux/nvmem-consumer.h b/include/linux/nvmem-consumer.h
index e17617fa034f..312bfa5efd80 100644
--- a/include/linux/nvmem-consumer.h
+++ b/include/linux/nvmem-consumer.h
@@ -93,13 +93,13 @@ int nvmem_unregister_notifier(struct notifier_block *nb);
static inline struct nvmem_cell *nvmem_cell_get(struct device *dev,
const char *id)
{
- return ERR_PTR(-ENOSYS);
+ return ERR_PTR(-EOPNOTSUPP);
}
static inline struct nvmem_cell *devm_nvmem_cell_get(struct device *dev,
const char *id)
{
- return ERR_PTR(-ENOSYS);
+ return ERR_PTR(-EOPNOTSUPP);
}
static inline void devm_nvmem_cell_put(struct device *dev,
@@ -113,31 +113,31 @@ static inline void nvmem_cell_put(struct nvmem_cell *cell)
static inline void *nvmem_cell_read(struct nvmem_cell *cell, size_t *len)
{
- return ERR_PTR(-ENOSYS);
+ return ERR_PTR(-EOPNOTSUPP);
}
static inline int nvmem_cell_write(struct nvmem_cell *cell,
const char *buf, size_t len)
{
- return -ENOSYS;
+ return -EOPNOTSUPP;
}
static inline int nvmem_cell_read_u32(struct device *dev,
const char *cell_id, u32 *val)
{
- return -ENOSYS;
+ return -EOPNOTSUPP;
}
static inline struct nvmem_device *nvmem_device_get(struct device *dev,
const char *name)
{
- return ERR_PTR(-ENOSYS);
+ return ERR_PTR(-EOPNOTSUPP);
}
static inline struct nvmem_device *devm_nvmem_device_get(struct device *dev,
const char *name)
{
- return ERR_PTR(-ENOSYS);
+ return ERR_PTR(-EOPNOTSUPP);
}
static inline void nvmem_device_put(struct nvmem_device *nvmem)
@@ -153,28 +153,28 @@ static inline ssize_t nvmem_device_cell_read(struct nvmem_device *nvmem,
struct nvmem_cell_info *info,
void *buf)
{
- return -ENOSYS;
+ return -EOPNOTSUPP;
}
static inline int nvmem_device_cell_write(struct nvmem_device *nvmem,
struct nvmem_cell_info *info,
void *buf)
{
- return -ENOSYS;
+ return -EOPNOTSUPP;
}
static inline int nvmem_device_read(struct nvmem_device *nvmem,
unsigned int offset, size_t bytes,
void *buf)
{
- return -ENOSYS;
+ return -EOPNOTSUPP;
}
static inline int nvmem_device_write(struct nvmem_device *nvmem,
unsigned int offset, size_t bytes,
void *buf)
{
- return -ENOSYS;
+ return -EOPNOTSUPP;
}
static inline const char *nvmem_dev_name(struct nvmem_device *nvmem)
@@ -189,12 +189,12 @@ nvmem_del_cell_lookups(struct nvmem_cell_lookup *entries, size_t nentries) {}
static inline int nvmem_register_notifier(struct notifier_block *nb)
{
- return -ENOSYS;
+ return -EOPNOTSUPP;
}
static inline int nvmem_unregister_notifier(struct notifier_block *nb)
{
- return -ENOSYS;
+ return -EOPNOTSUPP;
}
#endif /* CONFIG_NVMEM */
@@ -208,13 +208,13 @@ struct nvmem_device *of_nvmem_device_get(struct device_node *np,
static inline struct nvmem_cell *of_nvmem_cell_get(struct device_node *np,
const char *id)
{
- return ERR_PTR(-ENOSYS);
+ return ERR_PTR(-EOPNOTSUPP);
}
static inline struct nvmem_device *of_nvmem_device_get(struct device_node *np,
const char *name)
{
- return ERR_PTR(-ENOSYS);
+ return ERR_PTR(-EOPNOTSUPP);
}
#endif /* CONFIG_NVMEM && CONFIG_OF */
diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h
index 8ae012f6545a..1e3283c2af77 100644
--- a/include/linux/nvmem-provider.h
+++ b/include/linux/nvmem-provider.h
@@ -100,7 +100,7 @@ void nvmem_del_cell_table(struct nvmem_cell_table *table);
static inline struct nvmem_device *nvmem_register(const struct nvmem_config *c)
{
- return ERR_PTR(-ENOSYS);
+ return ERR_PTR(-EOPNOTSUPP);
}
static inline void nvmem_unregister(struct nvmem_device *nvmem) {}
@@ -114,8 +114,7 @@ devm_nvmem_register(struct device *dev, const struct nvmem_config *c)
static inline int
devm_nvmem_unregister(struct device *dev, struct nvmem_device *nvmem)
{
- return -ENOSYS;
-
+ return -EOPNOTSUPP;
}
static inline void nvmem_add_cell_table(struct nvmem_cell_table *table) {}
--
2.19.0
next prev parent reply other threads:[~2018-09-21 13:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 13:40 [PATCH 00/26] nvmem: patches for 4.20 srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 01/26] eeprom: eeprom_93xx46: use resource management srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 02/26] eeprom: at25: use devm_nvmem_register() srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 03/26] nvmem: provide nvmem_dev_name() srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 04/26] nvmem: remove the name field from struct nvmem_device srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 05/26] nvmem: use list_for_each_entry_safe in nvmem_device_remove_all_cells() srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 06/26] nvmem: remove a stray newline srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 07/26] nvmem: check the return value of nvmem_add_cells() srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 08/26] nvmem: use kref srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 09/26] nvmem: sunxi_sid: return -ENOMEM if kzalloc() fails srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 10/26] nvmem: sunxi_sid: use devm_nvmem_register() srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 11/26] nvmem: lpc18xx_eeprom: " srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 12/26] nvmem: mxs-ocotp: " srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 13/26] nvmem: change the signature of nvmem_unregister() srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 14/26] nvmem: remove the global cell list srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 15/26] nvmem: add support for cell info srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 16/26] nvmem: resolve cells from DT at registration time srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 17/26] nvmem: add support for cell lookups from machine code srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 18/26] Documentation: nvmem: document cell tables and lookup entries srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 19/26] nvmem: add a notifier chain srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 20/26] nvmem: use SPDX license identifiers srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 21/26] nvmem: make the naming of arguments in nvmem_cell_get() consistent srinivas.kandagatla
2018-09-21 13:40 ` srinivas.kandagatla [this message]
2018-09-21 13:40 ` [PATCH 23/26] nvmem: fix commenting style srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 24/26] nvmem: use octal permissions instead of constants srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 25/26] nvmem: sunxi_sid: remove unused variable in probe srinivas.kandagatla
2018-09-21 13:40 ` [PATCH 26/26] nvmem: make nvmem_add_cells() static srinivas.kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921134026.4596-23-srinivas.kandagatla@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).