From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Arend van Spriel <aspriel@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Robin Murphy <robin.murphy@arm.com>,
Joe Perches <joe@perches.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Michal Hocko <mhocko@suse.com>, Al Viro <viro@zeniv.linux.org.uk>,
Jonathan Corbet <corbet@lwn.net>, Roman Gushchin <guro@fb.com>,
Huang Ying <ying.huang@intel.com>,
Kees Cook <keescook@chromium.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Bartosz Golaszewski <brgl@bgdev.pl>
Subject: [PATCH v3 4/4] clk: pmc-atom: use devm_kstrdup_const()
Date: Mon, 24 Sep 2018 12:11:50 +0200 [thread overview]
Message-ID: <20180924101150.23349-5-brgl@bgdev.pl> (raw)
In-Reply-To: <20180924101150.23349-1-brgl@bgdev.pl>
Use devm_kstrdup_const() in the pmc-atom driver. This mostly serves as
an example of how to use this new routine to shrink driver code.
While we're at it: replace a call to kcalloc() with devm_kcalloc().
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/clk/x86/clk-pmc-atom.c | 19 ++++---------------
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/clk/x86/clk-pmc-atom.c b/drivers/clk/x86/clk-pmc-atom.c
index d977193842df..239197799ea3 100644
--- a/drivers/clk/x86/clk-pmc-atom.c
+++ b/drivers/clk/x86/clk-pmc-atom.c
@@ -247,14 +247,6 @@ static void plt_clk_unregister_fixed_rate_loop(struct clk_plt_data *data,
plt_clk_unregister_fixed_rate(data->parents[i]);
}
-static void plt_clk_free_parent_names_loop(const char **parent_names,
- unsigned int i)
-{
- while (i--)
- kfree_const(parent_names[i]);
- kfree(parent_names);
-}
-
static void plt_clk_unregister_loop(struct clk_plt_data *data,
unsigned int i)
{
@@ -280,8 +272,8 @@ static const char **plt_clk_register_parents(struct platform_device *pdev,
if (!data->parents)
return ERR_PTR(-ENOMEM);
- parent_names = kcalloc(nparents, sizeof(*parent_names),
- GFP_KERNEL);
+ parent_names = devm_kcalloc(&pdev->dev, nparents,
+ sizeof(*parent_names), GFP_KERNEL);
if (!parent_names)
return ERR_PTR(-ENOMEM);
@@ -294,7 +286,8 @@ static const char **plt_clk_register_parents(struct platform_device *pdev,
err = PTR_ERR(data->parents[i]);
goto err_unreg;
}
- parent_names[i] = kstrdup_const(clks[i].name, GFP_KERNEL);
+ parent_names[i] = devm_kstrdup_const(&pdev->dev,
+ clks[i].name, GFP_KERNEL);
}
data->nparents = nparents;
@@ -302,7 +295,6 @@ static const char **plt_clk_register_parents(struct platform_device *pdev,
err_unreg:
plt_clk_unregister_fixed_rate_loop(data, i);
- plt_clk_free_parent_names_loop(parent_names, i);
return ERR_PTR(err);
}
@@ -352,8 +344,6 @@ static int plt_clk_probe(struct platform_device *pdev)
goto err_drop_mclk;
}
- plt_clk_free_parent_names_loop(parent_names, data->nparents);
-
platform_set_drvdata(pdev, data);
return 0;
@@ -362,7 +352,6 @@ static int plt_clk_probe(struct platform_device *pdev)
err_unreg_clk_plt:
plt_clk_unregister_loop(data, i);
plt_clk_unregister_parents(data);
- plt_clk_free_parent_names_loop(parent_names, data->nparents);
return err;
}
--
2.18.0
next prev parent reply other threads:[~2018-09-24 10:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 10:11 [PATCH v3 0/4] devres: provide and use devm_kstrdup_const() Bartosz Golaszewski
2018-09-24 10:11 ` [PATCH v3 1/4] devres: constify p in devm_kfree() Bartosz Golaszewski
2018-09-24 10:11 ` [PATCH v3 2/4] mm: move is_kernel_rodata() to asm-generic/sections.h Bartosz Golaszewski
2018-09-24 10:31 ` Mike Rapoport
2018-09-24 10:11 ` [PATCH v3 3/4] devres: provide devm_kstrdup_const() Bartosz Golaszewski
2018-09-24 10:32 ` Mike Rapoport
2018-09-26 23:13 ` Kees Cook
2018-09-27 8:53 ` Bartosz Golaszewski
2018-09-27 10:55 ` Rasmus Villemoes
2018-09-27 11:01 ` Geert Uytterhoeven
2018-09-27 11:30 ` Rasmus Villemoes
2018-09-24 10:11 ` Bartosz Golaszewski [this message]
2018-09-24 11:23 ` [PATCH v3 4/4] clk: pmc-atom: use devm_kstrdup_const() Andy Shevchenko
2018-09-24 11:44 ` Bartosz Golaszewski
2018-09-24 12:11 ` Andy Shevchenko
2018-09-24 11:16 ` [PATCH v3 0/4] devres: provide and " Andy Shevchenko
2018-09-24 11:20 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924101150.23349-5-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=aspriel@gmail.com \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=guro@fb.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mturquette@baylibre.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robin.murphy@arm.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=viro@zeniv.linux.org.uk \
--cc=vivek.gautam@codeaurora.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).