From: Sasha Levin <Alexander.Levin@microsoft.com>
To: "stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Jon Kuhn <jkuhn@barracuda.com>,
Steven French <Steven.French@microsoft.com>,
Sasha Levin <Alexander.Levin@microsoft.com>
Subject: [PATCH AUTOSEL 3.18 08/13] fs/cifs: don't translate SFM_SLASH (U+F026) to backslash
Date: Mon, 24 Sep 2018 14:50:11 +0000 [thread overview]
Message-ID: <20180924144959.164754-8-alexander.levin@microsoft.com> (raw)
In-Reply-To: <20180924144959.164754-1-alexander.levin@microsoft.com>
From: Jon Kuhn <jkuhn@barracuda.com>
[ Upstream commit c15e3f19a6d5c89b1209dc94b40e568177cb0921 ]
When a Mac client saves an item containing a backslash to a file server
the backslash is represented in the CIFS/SMB protocol as as U+F026.
Before this change, listing a directory containing an item with a
backslash in its name will return that item with the backslash
represented with a true backslash character (U+005C) because
convert_sfm_character mapped U+F026 to U+005C when interpretting the
CIFS/SMB protocol response. However, attempting to open or stat the
path using a true backslash will result in an error because
convert_to_sfm_char does not map U+005C back to U+F026 causing the
CIFS/SMB request to be made with the backslash represented as U+005C.
This change simply prevents the U+F026 to U+005C conversion from
happenning. This is analogous to how the code does not do any
translation of UNI_SLASH (U+F000).
Signed-off-by: Jon Kuhn <jkuhn@barracuda.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
---
fs/cifs/cifs_unicode.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/cifs/cifs_unicode.c b/fs/cifs/cifs_unicode.c
index 4c7752639067..a39cb5c01fcf 100644
--- a/fs/cifs/cifs_unicode.c
+++ b/fs/cifs/cifs_unicode.c
@@ -136,9 +136,6 @@ convert_sfm_char(const __u16 src_char, char *target)
case SFM_LESSTHAN:
*target = '<';
break;
- case SFM_SLASH:
- *target = '\\';
- break;
case SFM_SPACE:
*target = ' ';
break;
--
2.17.1
next prev parent reply other threads:[~2018-09-24 14:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 14:50 [PATCH AUTOSEL 3.18 01/13] KVM: PPC: Book3S HV: Don't truncate HPTE index in xlate function Sasha Levin
2018-09-24 14:50 ` [PATCH AUTOSEL 3.18 02/13] mac80211: correct use of IEEE80211_VHT_CAP_RXSTBC_X Sasha Levin
2018-09-24 14:50 ` [PATCH AUTOSEL 3.18 03/13] gpio: adp5588: Fix sleep-in-atomic-context bug Sasha Levin
2018-09-24 14:50 ` [PATCH AUTOSEL 3.18 04/13] cfg80211: nl80211_update_ft_ies() to validate NL80211_ATTR_IE Sasha Levin
2018-09-24 14:50 ` [PATCH AUTOSEL 3.18 05/13] RAID10 BUG_ON in raise_barrier when force is true and conf->barrier is 0 Sasha Levin
2018-09-24 14:50 ` [PATCH AUTOSEL 3.18 06/13] net: ethernet: cpsw-phy-sel: prefer phandle for phy sel Sasha Levin
2018-09-24 14:50 ` [PATCH AUTOSEL 3.18 07/13] net: cadence: Fix a sleep-in-atomic-context bug in macb_halt_tx() Sasha Levin
2018-09-24 14:50 ` Sasha Levin [this message]
2018-09-24 14:50 ` [PATCH AUTOSEL 3.18 09/13] mac80211: fix a race between restart and CSA flows Sasha Levin
2018-09-24 14:50 ` [PATCH AUTOSEL 3.18 10/13] mac80211: Fix station bandwidth setting after channel switch Sasha Levin
2018-09-24 14:50 ` [PATCH AUTOSEL 3.18 11/13] mac80211: shorten the IBSS debug messages Sasha Levin
2018-09-24 14:50 ` [PATCH AUTOSEL 3.18 13/13] tools/vm/page-types.c: fix "defined but not used" warning Sasha Levin
2018-09-24 14:50 ` [PATCH AUTOSEL 3.18 12/13] tools/vm/slabinfo.c: fix sign-compare warning Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924144959.164754-8-alexander.levin@microsoft.com \
--to=alexander.levin@microsoft.com \
--cc=Steven.French@microsoft.com \
--cc=jkuhn@barracuda.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).