From: "Eric W. Biederman" <ebiederm@xmission.com>
To: linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org, Guan Xuetao <gxt@pku.edu.cn>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: [REVIEW][PATCH 1/3] signal/unicore32: Use send_sig_fault where appropriate
Date: Mon, 24 Sep 2018 17:25:35 +0200 [thread overview]
Message-ID: <20180924152537.19515-1-ebiederm@xmission.com> (raw)
In-Reply-To: <87lg7q2a2w.fsf@xmission.com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---
arch/unicore32/kernel/fpu-ucf64.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/arch/unicore32/kernel/fpu-ucf64.c b/arch/unicore32/kernel/fpu-ucf64.c
index 8594b168f25e..fc5dad32a982 100644
--- a/arch/unicore32/kernel/fpu-ucf64.c
+++ b/arch/unicore32/kernel/fpu-ucf64.c
@@ -54,14 +54,6 @@
*/
void ucf64_raise_sigfpe(struct pt_regs *regs)
{
- siginfo_t info;
-
- clear_siginfo(&info);
-
- info.si_signo = SIGFPE;
- info.si_code = FPE_FLTUNK;
- info.si_addr = (void __user *)(instruction_pointer(regs) - 4);
-
/*
* This is the same as NWFPE, because it's not clear what
* this is used for
@@ -69,7 +61,9 @@ void ucf64_raise_sigfpe(struct pt_regs *regs)
current->thread.error_code = 0;
current->thread.trap_no = 6;
- send_sig_info(SIGFPE, &info, current);
+ send_sig_fault(SIGFPE, FPE_FLTUNK,
+ (void __user *)(instruction_pointer(regs) - 4),
+ current);
}
/*
--
2.17.1
next prev parent reply other threads:[~2018-09-24 15:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 15:23 [REVIEW][PATCH 0/3] signal/unicore32: siginfo cleanups Eric W. Biederman
2018-09-24 15:25 ` Eric W. Biederman [this message]
2018-09-24 15:25 ` [REVIEW][PATCH 2/3] signal/unicore32: Generate siginfo in ucs32_notify_die Eric W. Biederman
2018-09-24 15:25 ` [REVIEW][PATCH 3/3] signal/unicore32: Use force_sig_fault where appropriate Eric W. Biederman
2018-09-29 13:18 ` [REVIEW][PATCH 0/3] signal/unicore32: siginfo cleanups Guan Xuetao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924152537.19515-1-ebiederm@xmission.com \
--to=ebiederm@xmission.com \
--cc=gxt@pku.edu.cn \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).