From: Aymen Qader <qader.aymen@gmail.com>
To: Scott Branden <scott.branden@broadcom.com>
Cc: Aymen Qader <qader.aymen@gmail.com>,
Eric Anholt <eric@anholt.net>,
Stefan Wahren <stefan.wahren@i2se.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2] staging: vc04_services: Update TODO re: arm64
Date: Tue, 25 Sep 2018 00:34:26 +0100 [thread overview]
Message-ID: <20180924233426.32609-1-qader.aymen@gmail.com> (raw)
In-Reply-To: <20180924224835.32539-1-qader.aymen@gmail.com>
Remove the TODO item to remove manual cache flushing from bulk_receive.
This was previously done in this commit:
(7e8dbdea) staging: bcm2835-camera: Remove explicit cache flush
operations
Also remove the unnecessary asm/cacheflush.h header.
Signed-off-by: Aymen Qader <qader.aymen@gmail.com>
---
v2: Make commit message clearer
drivers/staging/vc04_services/bcm2835-camera/TODO | 6 ------
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 -
2 files changed, 7 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-camera/TODO b/drivers/staging/vc04_services/bcm2835-camera/TODO
index cefce72d814f..6c2b4ffe4996 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/TODO
+++ b/drivers/staging/vc04_services/bcm2835-camera/TODO
@@ -15,9 +15,3 @@ padding in the V4L2 spec, but that padding doesn't match what the
hardware can do. If we exposed the native padding requirements
through the V4L2 "multiplanar" formats, the firmware would have one
less copy it needed to do.
-
-3) Port to ARM64
-
-The bulk_receive() does some manual cache flushing that are 32-bit ARM
-only, which we should convert to proper cross-platform APIs.
-
diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
index 51e5b04ff0f5..6e5c1d4ee122 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
@@ -21,7 +21,6 @@
#include <linux/slab.h>
#include <linux/completion.h>
#include <linux/vmalloc.h>
-#include <asm/cacheflush.h>
#include <media/videobuf2-vmalloc.h>
#include "mmal-common.h"
--
2.17.1
next prev parent reply other threads:[~2018-09-24 23:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 22:48 [PATCH] staging: vc04_services: Update TODO re: arm64 Aymen Qader
2018-09-24 23:02 ` Scott Branden
2018-09-24 23:34 ` Aymen Qader [this message]
2018-09-25 7:12 ` [PATCH v2] " Stefan Wahren
2018-09-25 8:33 ` [PATCH v3 0/2] staging: bcm2835-camera: Clean up completed TODO Aymen Qader
2018-09-25 8:33 ` [PATCH v3 1/2] staging: bcm2835-camera: Update TODO Aymen Qader
2018-09-25 8:33 ` [PATCH v3 2/2] staging: bcm2835-camera: Remove unused header Aymen Qader
2018-09-25 8:33 ` [PATCH v3 0/2] staging: bcm2835-camera: Clean up completed TODO Aymen Qader
2018-09-26 0:31 ` Scott Branden
2018-09-25 8:33 ` [PATCH v3 1/2] staging: bcm2835-camera: Update TODO Aymen Qader
2018-09-25 8:34 ` [PATCH v3 2/2] staging: bcm2835-camera: Remove unused header Aymen Qader
2018-09-25 20:39 ` [PATCH v3 0/2] staging: bcm2835-camera: Clean up completed TODO Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924233426.32609-1-qader.aymen@gmail.com \
--to=qader.aymen@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=scott.branden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).