From: zhong jiang <zhongjiang@huawei.com>
To: <broonie@kernel.org>
Cc: <joe@perches.com>, <perex@perex.cz>, <tiwai@suse.com>,
<lgirdwood@gmail.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] ASoC: wm8731: Fix a unused function gcc warning
Date: Sun, 30 Sep 2018 10:33:56 +0800 [thread overview]
Message-ID: <1538274836-26057-1-git-send-email-zhongjiang@huawei.com> (raw)
Fix the following compile warning:
sound/soc/codecs/wm8731.c:575:12: warning: 'wm8731_request_supplies' defined but not used [-Wunused-function]
sound/soc/codecs/wm8731.c:600:12: warning: 'wm8731_hw_init' defined but not used [-Wunused-function]
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
v1->v2:
- Move the declaration of wm8731_supply_names into the #if block
unused function has been wrapped to decrease the #if block definition.
sound/soc/codecs/wm8731.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c
index 7c8fad8..9399103 100644
--- a/sound/soc/codecs/wm8731.c
+++ b/sound/soc/codecs/wm8731.c
@@ -36,12 +36,6 @@
#include "wm8731.h"
#define WM8731_NUM_SUPPLIES 4
-static const char *wm8731_supply_names[WM8731_NUM_SUPPLIES] = {
- "AVDD",
- "HPVDD",
- "DCVDD",
- "DBVDD",
-};
/* codec private data */
struct wm8731_priv {
@@ -572,6 +566,14 @@ static int wm8731_startup(struct snd_pcm_substream *substream,
.symmetric_rates = 1,
};
+#if defined(CONFIG_I2C) || defined(CONFIG_SPI_MASTER)
+static const char *wm8731_supply_names[WM8731_NUM_SUPPLIES] = {
+ "AVDD",
+ "HPVDD",
+ "DCVDD",
+ "DBVDD",
+};
+
static int wm8731_request_supplies(struct device *dev,
struct wm8731_priv *wm8731)
{
@@ -627,6 +629,7 @@ static int wm8731_hw_init(struct device *dev, struct wm8731_priv *wm8731)
return ret;
}
+#endif
static const struct snd_soc_component_driver soc_component_dev_wm8731 = {
.set_bias_level = wm8731_set_bias_level,
--
1.7.12.4
next reply other threads:[~2018-09-30 2:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-30 2:33 zhong jiang [this message]
2018-09-30 5:33 ` [PATCH v2] ASoC: wm8731: Fix a unused function gcc warning kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538274836-26057-1-git-send-email-zhongjiang@huawei.com \
--to=zhongjiang@huawei.com \
--cc=broonie@kernel.org \
--cc=joe@perches.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).