From: Andreas Kemnade <andreas@kemnade.info>
To: t-kristo@ti.com, mturquette@baylibre.com, sboyd@kernel.org,
linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, paul@pwsan.com, tony@atomide.com,
letux-kernel@openphoenux.org
Cc: Andreas Kemnade <andreas@kemnade.info>
Subject: [PATCH RFC 2/2] arm: mach-omap2: setup iclk autoidle according to flags
Date: Thu, 4 Oct 2018 07:51:47 +0200 [thread overview]
Message-ID: <20181004055147.23048-3-andreas@kemnade.info> (raw)
In-Reply-To: <20181004055147.23048-1-andreas@kemnade.info>
Deny autoidle for hwmods with the OCPIF_SWSUP_IDLE flag,
that makes hwmods working properly which cannot handle
autoidle properly in lower power states.
Affected is e. g. the omap_hdq.
It also disables CM_AUTOIDLE_DSS. Need to check if
that is wanted or not.
Note: Autoidle is not enabled explicitly because there
might be clocks which do not support that operation and
it is enabled afterwards in arm/mach-omap2/pm.c anyways.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/mach-omap2/omap_hwmod.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index bb641e6c93d0..6f9687a4f421 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -131,6 +131,7 @@
#include <linux/errno.h>
#include <linux/io.h>
#include <linux/clk.h>
+#include <linux/clk/ti.h>
#include <linux/clk-provider.h>
#include <linux/delay.h>
#include <linux/err.h>
@@ -2410,9 +2411,12 @@ static void __init _setup_iclk_autoidle(struct omap_hwmod *oh)
continue;
if (os->flags & OCPIF_SWSUP_IDLE) {
- /* XXX omap_iclk_deny_idle(c); */
+ omap2_clk_deny_idle(os->_clk);
} else {
- /* XXX omap_iclk_allow_idle(c); */
+ /*
+ * no allow_idle here since there is
+ * later an allow idle in pm.c
+ */
clk_enable(os->_clk);
}
}
--
2.11.0
next prev parent reply other threads:[~2018-10-04 5:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 5:51 [PATCH RFC 0/2] mach-omap2: handle autoidle denial Andreas Kemnade
2018-10-04 5:51 ` [PATCH RFC 1/2] clk: ti: add a usecount for autoidle Andreas Kemnade
2018-10-04 14:40 ` Tero Kristo
2018-10-04 19:34 ` Andreas Kemnade
2018-10-04 5:51 ` Andreas Kemnade [this message]
2018-10-04 14:25 ` [PATCH RFC 0/2] mach-omap2: handle autoidle denial Tony Lindgren
2018-10-04 14:42 ` Tero Kristo
2018-10-04 15:07 ` Tony Lindgren
2018-10-04 15:48 ` Tero Kristo
2018-10-04 16:08 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004055147.23048-3-andreas@kemnade.info \
--to=andreas@kemnade.info \
--cc=letux-kernel@openphoenux.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=paul@pwsan.com \
--cc=sboyd@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).