From: YueHaibing <yuehaibing@huawei.com>
To: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Devang Panchal <devang.panchal@softnautics.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Rob Herring <robh@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: YueHaibing <yuehaibing@huawei.com>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: [PATCH -next] eeprom: at25: remove unneeded 'at25_remove'
Date: Fri, 5 Oct 2018 06:19:12 +0000 [thread overview]
Message-ID: <1538720352-85691-1-git-send-email-yuehaibing@huawei.com> (raw)
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/misc/eeprom/at25.c: In function 'at25_remove':
drivers/misc/eeprom/at25.c:384:20: warning:
variable 'at25' set but not used [-Wunused-but-set-variable]
Since commit 96d08fb43e30 ("eeprom: at25: use devm_nvmem_register()"),
at25_remove is do nothing, so can be removed.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/misc/eeprom/at25.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c
index d874df7..99de693 100644
--- a/drivers/misc/eeprom/at25.c
+++ b/drivers/misc/eeprom/at25.c
@@ -379,15 +379,6 @@ static int at25_probe(struct spi_device *spi)
return 0;
}
-static int at25_remove(struct spi_device *spi)
-{
- struct at25_data *at25;
-
- at25 = spi_get_drvdata(spi);
-
- return 0;
-}
-
/*-------------------------------------------------------------------------*/
static const struct of_device_id at25_of_match[] = {
@@ -402,7 +393,6 @@ static int at25_remove(struct spi_device *spi)
.of_match_table = at25_of_match,
},
.probe = at25_probe,
- .remove = at25_remove,
};
module_spi_driver(at25_driver);
next reply other threads:[~2018-10-05 6:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 6:19 YueHaibing [this message]
2018-10-05 6:55 ` [PATCH -next] eeprom: at25: remove unneeded 'at25_remove' Geert Uytterhoeven
2018-10-05 7:43 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538720352-85691-1-git-send-email-yuehaibing@huawei.com \
--to=yuehaibing@huawei.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=devang.panchal@softnautics.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).