From: Herbert Xu <herbert@gondor.apana.org.au>
To: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: akpm@linux-foundation.org, jgarzik@pobox.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
davem@davemloft.net, den@openvz.org, xemul@openvz.org
Subject: [PACKET]: Fix /proc/net/packet crash due to bogus private pointer
Date: Sun, 16 Dec 2007 11:41:20 +0800 [thread overview]
Message-ID: <20071216034119.GA1491@gondor.apana.org.au> (raw)
In-Reply-To: <E1J3jqN-0000Jq-00@gondolin.me.apana.org.au>
On Sun, Dec 16, 2007 at 11:07:07AM +0800, Herbert Xu wrote:
>
> I suspect namespace borkage. But just because you pin-pointed
> my patch I'll try to track it down :)
Surprise surprise. The namespace seq patch missed two spots in
AF_PACKET.
[PACKET]: Fix /proc/net/packet crash due to bogus private pointer
The seq_open_net patch changed the meaning of seq->private.
Unfortunately it missed two spots in AF_PACKET, which still
used the old way of dereferencing seq->private, thus causing
weird and wonderful crashes when reading /proc/net/packet.
This patch fixes them.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index 485af56..43e49f4 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -1878,7 +1878,7 @@ static void *packet_seq_start(struct seq_file *seq, loff_t *pos)
static void *packet_seq_next(struct seq_file *seq, void *v, loff_t *pos)
{
- struct net *net = seq->private;
+ struct net *net = seq_file_net(seq);
++*pos;
return (v == SEQ_START_TOKEN)
? sk_head(&net->packet.sklist)
@@ -1887,7 +1887,7 @@ static void *packet_seq_next(struct seq_file *seq, void *v, loff_t *pos)
static void packet_seq_stop(struct seq_file *seq, void *v)
{
- struct net *net = seq->private;
+ struct net *net = seq_file_net(seq);
read_unlock(&net->packet.sklist_lock);
}
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2007-12-16 3:41 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 10:40 2.6.24-rc5-mm1 Andrew Morton
2007-12-13 11:59 ` 2.6.24-rc5-mm1 kobject changes broken with hvcs driver on powerpc - regression Kamalesh Babulal
2007-12-13 16:22 ` Greg KH
2007-12-13 12:28 ` 2.6.24-rc5-mm1 Gautham R Shenoy
2007-12-13 21:15 ` 2.6.24-rc5-mm1 Andrew Morton
2007-12-14 9:49 ` 2.6.24-rc5-mm1 Andrew Morton
2007-12-14 13:15 ` 2.6.24-rc5-mm1 Gregory Haskins
2007-12-13 14:18 ` 2.6.24-rc5-mm1 Pierre Peiffer
2007-12-13 15:01 ` 2.6.24-rc5-mm1 Benjamin Thery
2007-12-13 16:07 ` 2.6.24-rc5-mm1 Borislav Petkov
2007-12-13 17:54 ` 2.6.24-rc5-mm1 Adrian Bunk
2007-12-13 17:45 ` 2.6.24-rc5-mm1 David Miller
2007-12-14 2:08 ` 2.6.24-rc5-mm1 Herbert Xu
2007-12-14 19:26 ` 2.6.24-rc5-mm1 David Miller
2007-12-13 14:56 ` 2.6.24-rc5-mm1 regression - kernel warning on tcp_fastretrans_alert() Kamalesh Babulal
2007-12-13 19:55 ` Andrew Morton
2007-12-13 15:16 ` 2.6.24-rc5-mm1 - build failures due to kobject changes Kamalesh Babulal
2007-12-13 16:21 ` Greg KH
2007-12-13 17:46 ` (was Re: 2.6.24-rc5-mm1) crypto/authenc.c select symbol in Kconfig Borislav Petkov
2007-12-14 8:53 ` Herbert Xu
2007-12-14 5:32 ` 2.6.24-rc5-mm1 Dave Young
2007-12-14 15:44 ` 2.6.24-rc5-mm1 Alan Stern
2007-12-17 1:14 ` 2.6.24-rc5-mm1 Dave Young
2007-12-19 7:49 ` 2.6.24-rc5-mm1 Dave Young
2007-12-19 16:07 ` 2.6.24-rc5-mm1 Alan Stern
2007-12-20 0:43 ` 2.6.24-rc5-mm1 Dave Young
2007-12-20 3:34 ` 2.6.24-rc5-mm1 Alan Stern
2007-12-20 4:32 ` 2.6.24-rc5-mm1 Dave Young
2007-12-14 14:08 ` 2.6.24-rc5-mm1 Dhaval Giani
2007-12-15 19:20 ` 2.6.24-rc5-mm1 Alexey Dobriyan
2007-12-16 9:10 ` 2.6.24-rc5-mm1 Andrew Morton
2007-12-15 23:59 ` broken suspend, sometimes (drm related) [Was: 2.6.24-rc5-mm1] Jiri Slaby
2007-12-17 16:55 ` Jesse Barnes
2007-12-16 0:18 ` 2.6.24-rc5-mm1: cat /proc/net/packet -> oops Mariusz Kozlowski
2007-12-16 3:07 ` Herbert Xu
2007-12-16 3:41 ` Herbert Xu [this message]
2007-12-16 10:48 ` [PACKET]: Fix /proc/net/packet crash due to bogus private pointer Mariusz Kozlowski
2007-12-16 22:04 ` David Miller
2007-12-16 10:11 ` 2.6.24-rc5-mm1: problems with cat /proc/kpageflags Mariusz Kozlowski
2007-12-16 10:14 ` Mariusz Kozlowski
2007-12-16 10:41 ` Mariusz Kozlowski
2007-12-16 11:40 ` Mariusz Kozlowski
2007-12-16 18:27 ` Matt Mackall
2007-12-16 18:48 ` Mariusz Kozlowski
2007-12-16 19:10 ` Mariusz Kozlowski
2007-12-17 2:11 ` Matt Mackall
2007-12-17 4:26 ` David Miller
2007-12-17 6:39 ` Andrew Morton
2007-12-17 14:55 ` Matt Mackall
2007-12-20 12:53 ` David Miller
2007-12-20 17:45 ` Matt Mackall
2007-12-20 19:47 ` Mariusz Kozlowski
2007-12-21 0:17 ` David Miller
2007-12-21 1:06 ` Matt Mackall
2007-12-21 3:15 ` David Miller
2007-12-21 21:51 ` Mariusz Kozlowski
2007-12-22 5:00 ` Andrew Morton
2007-12-17 19:05 ` Mariusz Kozlowski
2007-12-17 22:44 ` 2.6.24-rc5-mm1 - wonky disk cache and CDROM behavior Valdis.Kletnieks
2007-12-17 22:56 ` Andrew Morton
2007-12-18 2:07 ` Valdis.Kletnieks
2007-12-18 2:37 ` Dave Young
2007-12-18 2:52 ` Andrew Morton
2007-12-18 5:52 ` Valdis.Kletnieks
2007-12-19 1:22 ` David Howells
2007-12-19 1:33 ` Dave Young
2007-12-19 2:04 ` Andrew Morton
2007-12-19 3:30 ` Jeff Dike
2007-12-18 6:10 ` 2.6.24-rc5-mm1 - IPv6 throws section mismatches Valdis.Kletnieks
2007-12-18 15:12 ` Daniel Lezcano
2007-12-20 16:55 ` 2.6.24-rc5-mm1 Jason Wessel
2007-12-20 23:11 ` 2.6.24-rc5-mm1 Andrew Morton
2007-12-21 13:46 ` 2.6.24-rc5-mm1 Jason Wessel
2007-12-20 20:57 ` 2.6.24-rc5-mm1 - SCSI/blkdev probing hang Rik van Riel
2007-12-20 21:22 ` Andrew Morton
2007-12-24 15:12 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071216034119.GA1491@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=den@openvz.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.kozlowski@tuxland.pl \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).