[v3,09/11] arch/x86: Introduce new config parameter AMD_QOS
diff mbox series

Message ID 20181011203223.18157-10-babu.moger@amd.com
State New
Headers show
Series
  • arch/x86: AMD QoS support
Related show

Commit Message

Moger, Babu Oct. 11, 2018, 8:33 p.m. UTC
Introduces the new config parameter AMD_QOS. This parameter will be
used to enable cache and memory bandwidth allocation and monitoring
features on AMD processors. This will enable common config parameter
RESCTRL if selected.

Signed-off-by: Babu Moger <babu.moger@amd.com>
---
 arch/x86/Kconfig | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

Comments

Borislav Petkov Oct. 11, 2018, 10:02 p.m. UTC | #1
On Thu, Oct 11, 2018 at 08:33:35PM +0000, Moger, Babu wrote:
> Introduces the new config parameter AMD_QOS. This parameter will be
> used to enable cache and memory bandwidth allocation and monitoring
> features on AMD processors. This will enable common config parameter
> RESCTRL if selected.
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
>  arch/x86/Kconfig | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 91a703ebdc04..5cef55935a5a 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -458,9 +458,24 @@ config INTEL_RDT
>  
>  	  Say N if unsure.
>  
> +config AMD_QOS
> +	bool "AMD Quality of Service support"
> +	default n
> +	depends on X86 && CPU_SUP_AMD

Why the X86 dependency too? CPU_SUP_AMD is x86-specific and indirectly
implies X86, I'd say.
Moger, Babu Oct. 12, 2018, 2:40 p.m. UTC | #2
Boris,

On 10/11/2018 05:02 PM, Borislav Petkov wrote:
> On Thu, Oct 11, 2018 at 08:33:35PM +0000, Moger, Babu wrote:
>> Introduces the new config parameter AMD_QOS. This parameter will be
>> used to enable cache and memory bandwidth allocation and monitoring
>> features on AMD processors. This will enable common config parameter
>> RESCTRL if selected.
>>
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> ---
>>  arch/x86/Kconfig | 17 ++++++++++++++++-
>>  1 file changed, 16 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 91a703ebdc04..5cef55935a5a 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -458,9 +458,24 @@ config INTEL_RDT
>>  
>>  	  Say N if unsure.
>>  
>> +config AMD_QOS
>> +	bool "AMD Quality of Service support"
>> +	default n
>> +	depends on X86 && CPU_SUP_AMD
> 
> Why the X86 dependency too? CPU_SUP_AMD is x86-specific and indirectly
> implies X86, I'd say.

That is correct. CPU_SUP_AMD implicitly means x86.
To be more specific, I will change it to
"depends on X86_64 && CPU_SUP_AMD" as this feature is for X86_64 only.
Thanks
Borislav Petkov Oct. 12, 2018, 2:43 p.m. UTC | #3
On Fri, Oct 12, 2018 at 02:40:50PM +0000, Moger, Babu wrote:
> That is correct. CPU_SUP_AMD implicitly means x86.
> To be more specific, I will change it to
> "depends on X86_64 && CPU_SUP_AMD" as this feature is for X86_64 only.

No, what I'm saying is, make it dependent *only* on CPU_SUP_AMD.
Moger, Babu Oct. 12, 2018, 6:32 p.m. UTC | #4
On 10/12/2018 09:43 AM, Borislav Petkov wrote:
> On Fri, Oct 12, 2018 at 02:40:50PM +0000, Moger, Babu wrote:
>> That is correct. CPU_SUP_AMD implicitly means x86.
>> To be more specific, I will change it to
>> "depends on X86_64 && CPU_SUP_AMD" as this feature is for X86_64 only.
> 
> No, what I'm saying is, make it dependent *only* on CPU_SUP_AMD.

Sure. Will do in next revision. Thanks

Patch
diff mbox series

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 91a703ebdc04..5cef55935a5a 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -458,9 +458,24 @@  config INTEL_RDT
 
 	  Say N if unsure.
 
+config AMD_QOS
+	bool "AMD Quality of Service support"
+	default n
+	depends on X86 && CPU_SUP_AMD
+	select KERNFS
+	help
+	  Select to enable cache and memory bandwidth enforcement and monitoring
+	  features of AMD processors. These features are intended to provide
+	  support for the monitoring of the usage of certain system resources
+	  by one or more processors and for the separate allocation and
+	  enforcement of limits on the use of certain system resources by one or
+	  more processors.
+
+	  Say N if unsure.
+
 config RESCTRL
 	def_bool y
-	depends on X86 && INTEL_RDT
+	depends on X86 && (INTEL_RDT || AMD_QOS)
 
 if X86_32
 config X86_BIGSMP