[driver-core,v3,5/5] PM core: Use new async_schedule_dev command
diff mbox series

Message ID 20181011220944.1408.39823.stgit@localhost.localdomain
State New
Headers show
Series
  • Add NUMA aware async_schedule calls
Related show

Commit Message

Alexander Duyck Oct. 11, 2018, 10:09 p.m. UTC
This change makes it so that we use the device specific version of the
async_schedule commands to defer various tasks related to power management.
By doing this we should see a slight improvement in performance as any
device that is sensitive to latency/locality in the setup will now be
initializing on the node closest to the device.

Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
---
 drivers/base/power/main.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Rafael J. Wysocki Oct. 12, 2018, 7:53 a.m. UTC | #1
On Fri, Oct 12, 2018 at 12:10 AM Alexander Duyck
<alexander.h.duyck@linux.intel.com> wrote:
>
> This change makes it so that we use the device specific version of the
> async_schedule commands to defer various tasks related to power management.
> By doing this we should see a slight improvement in performance as any
> device that is sensitive to latency/locality in the setup will now be
> initializing on the node closest to the device.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

> ---
>  drivers/base/power/main.c |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
> index a690fd400260..ebb8b61b52e9 100644
> --- a/drivers/base/power/main.c
> +++ b/drivers/base/power/main.c
> @@ -726,7 +726,7 @@ void dpm_noirq_resume_devices(pm_message_t state)
>                 reinit_completion(&dev->power.completion);
>                 if (is_async(dev)) {
>                         get_device(dev);
> -                       async_schedule(async_resume_noirq, dev);
> +                       async_schedule_dev(async_resume_noirq, dev);
>                 }
>         }
>
> @@ -883,7 +883,7 @@ void dpm_resume_early(pm_message_t state)
>                 reinit_completion(&dev->power.completion);
>                 if (is_async(dev)) {
>                         get_device(dev);
> -                       async_schedule(async_resume_early, dev);
> +                       async_schedule_dev(async_resume_early, dev);
>                 }
>         }
>
> @@ -1047,7 +1047,7 @@ void dpm_resume(pm_message_t state)
>                 reinit_completion(&dev->power.completion);
>                 if (is_async(dev)) {
>                         get_device(dev);
> -                       async_schedule(async_resume, dev);
> +                       async_schedule_dev(async_resume, dev);
>                 }
>         }
>
> @@ -1366,7 +1366,7 @@ static int device_suspend_noirq(struct device *dev)
>
>         if (is_async(dev)) {
>                 get_device(dev);
> -               async_schedule(async_suspend_noirq, dev);
> +               async_schedule_dev(async_suspend_noirq, dev);
>                 return 0;
>         }
>         return __device_suspend_noirq(dev, pm_transition, false);
> @@ -1569,7 +1569,7 @@ static int device_suspend_late(struct device *dev)
>
>         if (is_async(dev)) {
>                 get_device(dev);
> -               async_schedule(async_suspend_late, dev);
> +               async_schedule_dev(async_suspend_late, dev);
>                 return 0;
>         }
>
> @@ -1833,7 +1833,7 @@ static int device_suspend(struct device *dev)
>
>         if (is_async(dev)) {
>                 get_device(dev);
> -               async_schedule(async_suspend, dev);
> +               async_schedule_dev(async_suspend, dev);
>                 return 0;
>         }
>
>

Patch
diff mbox series

diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
index a690fd400260..ebb8b61b52e9 100644
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -726,7 +726,7 @@  void dpm_noirq_resume_devices(pm_message_t state)
 		reinit_completion(&dev->power.completion);
 		if (is_async(dev)) {
 			get_device(dev);
-			async_schedule(async_resume_noirq, dev);
+			async_schedule_dev(async_resume_noirq, dev);
 		}
 	}
 
@@ -883,7 +883,7 @@  void dpm_resume_early(pm_message_t state)
 		reinit_completion(&dev->power.completion);
 		if (is_async(dev)) {
 			get_device(dev);
-			async_schedule(async_resume_early, dev);
+			async_schedule_dev(async_resume_early, dev);
 		}
 	}
 
@@ -1047,7 +1047,7 @@  void dpm_resume(pm_message_t state)
 		reinit_completion(&dev->power.completion);
 		if (is_async(dev)) {
 			get_device(dev);
-			async_schedule(async_resume, dev);
+			async_schedule_dev(async_resume, dev);
 		}
 	}
 
@@ -1366,7 +1366,7 @@  static int device_suspend_noirq(struct device *dev)
 
 	if (is_async(dev)) {
 		get_device(dev);
-		async_schedule(async_suspend_noirq, dev);
+		async_schedule_dev(async_suspend_noirq, dev);
 		return 0;
 	}
 	return __device_suspend_noirq(dev, pm_transition, false);
@@ -1569,7 +1569,7 @@  static int device_suspend_late(struct device *dev)
 
 	if (is_async(dev)) {
 		get_device(dev);
-		async_schedule(async_suspend_late, dev);
+		async_schedule_dev(async_suspend_late, dev);
 		return 0;
 	}
 
@@ -1833,7 +1833,7 @@  static int device_suspend(struct device *dev)
 
 	if (is_async(dev)) {
 		get_device(dev);
-		async_schedule(async_suspend, dev);
+		async_schedule_dev(async_suspend, dev);
 		return 0;
 	}