From: Peng Hao <peng.hao2@zte.com.cn>
To: mingo@redhat.com, peterz@infradead.org
Cc: rostedt@goodmis.org, andrea.parri@amarulasolutions.com,
linux-kernel@vger.kernel.org, juri.lelli@gmail.com,
Peng Hao <peng.hao2@zte.com.cn>
Subject: [PATCH v2] sched/dl: Reduce push_dl_task() retries
Date: Tue, 16 Oct 2018 03:42:46 +0800 [thread overview]
Message-ID: <1539632566-4440-1-git-send-email-peng.hao2@zte.com.cn> (raw)
Improve push_dl_task() by propagating the double_lock_balance()
usage from find_lock_later_rq(), thereby reducing the number
of cases where we have to assume rq->lock was dropped.
Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
---
kernel/sched/deadline.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 997ea7b..8e875ec 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1979,7 +1979,7 @@ static struct rq *find_lock_later_rq(struct task_struct *task, struct rq *rq)
!dl_task(task) ||
!task_on_rq_queued(task))) {
double_unlock_balance(rq, later_rq);
- later_rq = NULL;
+ later_rq = RETRY_TASK;
break;
}
}
@@ -2063,7 +2063,9 @@ static int push_dl_task(struct rq *rq)
/* Will lock the rq it'll find */
later_rq = find_lock_later_rq(next_task, rq);
- if (!later_rq) {
+ if (!later_rq)
+ goto out;
+ if (later_rq == RETRY_TASK) {
struct task_struct *task;
/*
--
1.8.3.1
reply other threads:[~2018-10-15 11:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539632566-4440-1-git-send-email-peng.hao2@zte.com.cn \
--to=peng.hao2@zte.com.cn \
--cc=andrea.parri@amarulasolutions.com \
--cc=juri.lelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).