From: Niklas Cassel <niklas.cassel@linaro.org>
To: srinivas.kandagatla@linaro.org, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, Niklas Cassel <niklas.cassel@linaro.org>
Subject: [PATCH v2] slimbus: ngd: QCOM_QMI_HELPERS has to be selected
Date: Mon, 15 Oct 2018 21:44:41 +0200 [thread overview]
Message-ID: <20181015194441.10475-1-niklas.cassel@linaro.org> (raw)
In-Reply-To: <20181015183218.GA16900@kroah.com>
QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is
to select it, not depend upon it.
Because of this change, we now also need to depend on the same
Kconfigs as QCOM_QMI_HELPERS depends on.
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
---
Hello Greg, Srini,
I'm sorry for this.
(Although I'm a bit curious why 0-day test bot didn't catch this.)
Considering that I've just changed QCOM_QMI_HELPERS in:
ccfb464cd106 ("soc: qcom: Allow COMPILE_TEST of qcom SoC Kconfigs")
which is currently in linux-next, and that this Kconfig should
depend on the same Kconfigs as QCOM_QMI_HELPERS depends on,
I chose to have this Kconfig match the QCOM_QMI_HELPERS that is
currently in linux-next.
drivers/slimbus/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig
index 9d73ad806698..8cd595148d17 100644
--- a/drivers/slimbus/Kconfig
+++ b/drivers/slimbus/Kconfig
@@ -22,8 +22,9 @@ config SLIM_QCOM_CTRL
config SLIM_QCOM_NGD_CTRL
tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
- depends on QCOM_QMI_HELPERS
- depends on HAS_IOMEM && DMA_ENGINE
+ depends on HAS_IOMEM && DMA_ENGINE && NET
+ depends on ARCH_QCOM || COMPILE_TEST
+ select QCOM_QMI_HELPERS
help
Select driver if Qualcomm's SLIMbus Satellite Non-Generic Device
Component is programmed using Linux kernel.
--
2.17.2
next prev parent reply other threads:[~2018-10-15 19:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 17:52 [PATCH] slimbus: ngd: QCOM_QMI_HELPERS has to be selected Srinivas Kandagatla
2018-10-15 18:32 ` Greg KH
2018-10-15 19:44 ` Niklas Cassel [this message]
2018-10-16 9:35 ` [PATCH v2] " Srinivas Kandagatla
2018-11-07 13:59 ` Greg KH
2018-11-07 14:15 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015194441.10475-1-niklas.cassel@linaro.org \
--to=niklas.cassel@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).