From patchwork Wed Jul 1 12:46:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1266281 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09E9AC433DF for ; Wed, 1 Jul 2020 12:47:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D987120702 for ; Wed, 1 Jul 2020 12:47:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yk+r9H6l" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730635AbgGAMrP (ORCPT ); Wed, 1 Jul 2020 08:47:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730544AbgGAMrK (ORCPT ); Wed, 1 Jul 2020 08:47:10 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C8FDC03E979 for ; Wed, 1 Jul 2020 05:47:10 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id l17so22275301wmj.0 for ; Wed, 01 Jul 2020 05:47:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=x8xCKIw9Ld5Xa//V32cpz9QyqhlFaWmoKz6kDT+w1CQ=; b=yk+r9H6lX2Cc5i0dlDYZHeHh6IaafXhdA3+cx+ukukxwN0QSjnW3v7AJbxYJahc1rJ It9z0lJpzuNfcP/Ch9oXRsRIl0RTjxEwgK1d4Xrlul48VRVT2oRTZEMpcxQchBYCm4Hf 0hSQ5kknJI7Gvwga0UCeFY1HqgqXDCC3WO9BLFuinxIrTAniduRmJTwp79YNdRxttxsp lbNiJkrLQOfUSvm+Ogb6yMaDLjrp8D6Ycy+5+Va5hhDZ7wVSQS8LKtRXxnBYkXXx5Q62 zR8Wan38GVVfXHBnLw8enlCYUQGkcw2kVwfFXLl8d7WTBo9JwwfLavhTIdmUIsfz6ql3 DZYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=x8xCKIw9Ld5Xa//V32cpz9QyqhlFaWmoKz6kDT+w1CQ=; b=cA4+kGxVLsRwh7KXpl84eMKQ50if76OlqXgM/oy8UONBuSe2wHNDTAeEYZaLW3o90A PlwPBsr/oZoNOSIV2sUGCT5mB/MpMWr8fjg8ksBqxjNLIRbG0d7r2GrjbQ8J6B+dHWsW gKV/fQQxiAb8VX4xsXPtg3lt7jZUdWI3p/BqABjzMW/HMDjYwrUWTSCL5KRS4dmNlxWu XlfUFU0krd9doH7/hv412LYbTmmotWjJeCQ66ClGzFbJxK0n9eevYlnPGpiiWtJ+W753 Al01Qr5lkJSY3jcD52TGcTxbGPt8MHrdT681RNFMhcbhWBqwFj+M21uuEFdzR2bhJZrN YtBg== X-Gm-Message-State: AOAM531HmZrRZDwu9faPhDWatwImImzplHlPv7oUY6JfYp/IILGiQgCT v26M5tuEmIIy8CgLa4SlHqSe4g== X-Google-Smtp-Source: ABdhPJxQ+Yg6i9TIajip46TH3pID9Y8RjLR+RANFA+2ocxzD+PQpg4Nb+WF2voDLYQGI8AIzZdylRg== X-Received: by 2002:a1c:7209:: with SMTP id n9mr26663783wmc.150.1593607628056; Wed, 01 Jul 2020 05:47:08 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:07 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Andrei Warkentin , Martin Mares Subject: [PATCH 01/15] mmc: core: quirks: Mark fixups as __maybe_unused Date: Wed, 1 Jul 2020 13:46:48 +0100 Message-Id: <20200701124702.908713-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Not all source files which include quirks.h make use of the all of the available fixup information. When this happens the compiler complains that some constant variables are defined by never used. We can fix this by telling the compiler that this intentional by simply marking them as __maybe_unused. Fixes the following W=1 kernel build warnings: In file included from drivers/mmc/core/sdio.c:22: drivers/mmc/core/quirks.h:105:31: warning: ‘mmc_ext_csd_fixups’ defined but not used [-Wunused-const-variable=] 105 | static const struct mmc_fixup mmc_ext_csd_fixups[] = { | ^~~~~~~~~~~~~~~~~~ drivers/mmc/core/quirks.h:17:31: warning: ‘mmc_blk_fixups’ defined but not used [-Wunused-const-variable=] 17 | static const struct mmc_fixup mmc_blk_fixups[] = { | ^~~~~~~~~~~~~~ In file included from drivers/mmc/core/mmc.c:25: drivers/mmc/core/quirks.h:123:31: warning: ‘sdio_fixup_methods’ defined but not used [-Wunused-const-variable=] 123 | static const struct mmc_fixup sdio_fixup_methods[] = { | ^~~~~~~~~~~~~~~~~~ drivers/mmc/core/quirks.h:17:31: warning: ‘mmc_blk_fixups’ defined but not used [-Wunused-const-variable=] 17 | static const struct mmc_fixup mmc_blk_fixups[] = { | ^~~~~~~~~~~~~~ Cc: Andrei Warkentin Cc: Martin Mares Signed-off-by: Lee Jones --- drivers/mmc/core/quirks.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h index 472fa2fdcf139..d68e6e513a4f4 100644 --- a/drivers/mmc/core/quirks.h +++ b/drivers/mmc/core/quirks.h @@ -14,7 +14,7 @@ #include "card.h" -static const struct mmc_fixup mmc_blk_fixups[] = { +static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = { #define INAND_CMD38_ARG_EXT_CSD 113 #define INAND_CMD38_ARG_ERASE 0x00 #define INAND_CMD38_ARG_TRIM 0x01 @@ -102,7 +102,7 @@ static const struct mmc_fixup mmc_blk_fixups[] = { END_FIXUP }; -static const struct mmc_fixup mmc_ext_csd_fixups[] = { +static const struct mmc_fixup __maybe_unused mmc_ext_csd_fixups[] = { /* * Certain Hynix eMMC 4.41 cards might get broken when HPI feature * is used so disable the HPI feature for such buggy cards. @@ -120,7 +120,7 @@ static const struct mmc_fixup mmc_ext_csd_fixups[] = { }; -static const struct mmc_fixup sdio_fixup_methods[] = { +static const struct mmc_fixup __maybe_unused sdio_fixup_methods[] = { SDIO_FIXUP(SDIO_VENDOR_ID_TI_WL1251, SDIO_DEVICE_ID_TI_WL1251, add_quirk, MMC_QUIRK_NONSTD_FUNC_IF), From patchwork Wed Jul 1 12:46:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1266282 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8E3AC433E0 for ; Wed, 1 Jul 2020 12:47:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5CE720702 for ; Wed, 1 Jul 2020 12:47:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="e2u2YFLp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730646AbgGAMrR (ORCPT ); Wed, 1 Jul 2020 08:47:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730622AbgGAMrK (ORCPT ); Wed, 1 Jul 2020 08:47:10 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4400FC03E97A for ; Wed, 1 Jul 2020 05:47:10 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id z13so23668061wrw.5 for ; Wed, 01 Jul 2020 05:47:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jvkMg3srHyqJh6fgDfE889EmXjO6nBv1Rtq+H+tpC1c=; b=e2u2YFLpA8LpvDLvaHlAIRYF4TjmLrKeAmTHVJZcWeakRJrp85FcAGANacHaeC43IE GwT0zARyiqQqJkx2Z0jikJGsiPsqyVH6E6KLJN3pF7P+VJ6Boi9Bw2GF7/CYiIeZb1gm yAuuqSK20elxyeP0Nlf612iMeF7pF+IeCeAo8RRLLm05q9EF5rHY8bH+hhUcOr/LOOoE ChoJFEuj9WxUbgNvpCUXTY3AxUIt43te77sTOfpALDyw8aU4ycLu8q/k6yLPD/1A5i4H G1YxImumTxqHp8cEv/qHa1thvJ7T1IcJQ9dCxQwSWR8BABPukm8QzuVXPU4l/W766fZS 7pyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jvkMg3srHyqJh6fgDfE889EmXjO6nBv1Rtq+H+tpC1c=; b=VHlfJV9dmeD6QAkSUGzJymg75NryqnC3PIR89fg1w18z/5N0gSLjarOVlhLmjcevxO nsOMTm9/UINxXto7cOE6fn/aBjnotkVKB0fohXRvu8Jhn6Dd5Xr1URjQQOO304FKVS0m kxmasDxWdTLQPFiFCghKqi8o6K7KUB8ttluhBjwPcI0dyc3O6NUdcC9LqySesAtlZwok XK4uK7aBvmGd8aN4Aopz/au5++Nq3TIZUsdZUy0k8Qpc89L3zR+eiO4GyzZ2tbWIEJG1 9SVcrlMxCxPvjzWWk/ZH4cnKuTkwyAXginx06lfx9Acq1Mqh335EedRo46nlTZ2STAxe 4P4Q== X-Gm-Message-State: AOAM531wjVwB4vjemJCqp4dwWfsxYHmSHBxBUHzOUp4ezORlEDvujs5k mBbq1OTZ6K4h1l9uAABlsa1c7kqyrPs= X-Google-Smtp-Source: ABdhPJwDlLXVXyGj9D0oFqPhwo60exrY7bLbST3n/Wr+UX1G4tJFRxrcFA/CqPK08eQzMC2jmrnXiA== X-Received: by 2002:a5d:6a90:: with SMTP id s16mr25932837wru.8.1593607628989; Wed, 01 Jul 2020 05:47:08 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:08 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Pierre Ossman Subject: [PATCH 02/15] mmc: core: sdio_io: Provide description for sdio_set_host_pm_flags()'s 'flag' arg Date: Wed, 1 Jul 2020 13:46:49 +0100 Message-Id: <20200701124702.908713-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add missing kerneldoc entry for sdio_set_host_pm_flags()'s 'flag' function argument. Fixes the following W=1 kernel build warning: kernel/drivers/mmc/core/sdio_io.c:722: warning: Function parameter or member 'flags' not described in 'sdio_set_host_pm_flags' Cc: Pierre Ossman Signed-off-by: Lee Jones --- drivers/mmc/core/sdio_io.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/core/sdio_io.c b/drivers/mmc/core/sdio_io.c index 2ba00acf64e64..b5dd893bbcb6f 100644 --- a/drivers/mmc/core/sdio_io.c +++ b/drivers/mmc/core/sdio_io.c @@ -709,6 +709,7 @@ EXPORT_SYMBOL_GPL(sdio_get_host_pm_caps); /** * sdio_set_host_pm_flags - set wanted host power management capabilities * @func: SDIO function attached to host + * @flags: Power Management flags to set * * Set a capability bitmask corresponding to wanted host controller * power management features for the upcoming suspend state. From patchwork Wed Jul 1 12:46:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1266295 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42065C433E0 for ; Wed, 1 Jul 2020 12:48:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14F712080D for ; Wed, 1 Jul 2020 12:48:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vT5SNW2n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730785AbgGAMsK (ORCPT ); Wed, 1 Jul 2020 08:48:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730623AbgGAMrL (ORCPT ); Wed, 1 Jul 2020 08:47:11 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 670B9C03E97B for ; Wed, 1 Jul 2020 05:47:11 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id z15so12391049wrl.8 for ; Wed, 01 Jul 2020 05:47:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9fX3YQmu/TyZUi/gCUeVKqHWnQBcFQjsTJlFycXl+A4=; b=vT5SNW2nj2xlct7B5oFAEKNrAmdAYt9aa/C2EsvoZj3iCmWBfwGimRErcQG+WPVnXv XzjOj6noAaG6pXKH01vGd/aIyT0vJVDNQdn3UV+QOSyKvOTW4tRTlsf9IOsX7r0p4hLZ lg5e3peRTHdOPdw9roQqCIQ2Lh9lnDDtNIoHGkQKydRIQy8bwrbNcyNH7J8t0iOBOpkk uZfR4cpYEi3tZXnNA4LyYnYNzRHQreXLLFSrepfwCP3BU6CXtF5CBaJPW2XRBTiteXFl X76nU0olPK0OHVw74/pUz7g2eurHSfAQt1GXqbLePth2UiMhlC+mJYBtY6/ztU6Gw2QG MaFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9fX3YQmu/TyZUi/gCUeVKqHWnQBcFQjsTJlFycXl+A4=; b=njyEDTJTYKDFLb0MeFz7TASF9NvLWK/s8TP5zmaumYYjK1EjKU2l1kaHqxn2gvpRLq gg25sydiRL7fpGwFp0sS6weER2yvbiqc39mXjEUNktTuzW02Lva+JZ7vWGbnB2qdeTPO B07V22JYqaRL0Oav+Ab3UI8lftu+rpNkjfaw4EuDHyBI+YbnGcTn8lv+W/FEH6jZ64uI 4VA6zJ3r7P8elLfPCW4H/O8rsLcR7mHX8ZKgHnAGgQ8p5ZNX/iZX7RKL5Sgl6QYnUdtg GVlmNI4QixqKCg6vfT5kr++Rk+/qFAvL9HAmhoR/J+Cp+KtPN8nI2mgAHb7A3ZZdLOlt PV5Q== X-Gm-Message-State: AOAM532GfitkTIPF7H7PtAzhCT8mLea5G2330XwSxBk/nQiIGxq96kaD 64DYTzd5MspXOn8TUAnqf7GtZg== X-Google-Smtp-Source: ABdhPJzZIumZWDrMmq5PludRvlVmmwImG5o9AgYWwJ5Q0weSLLiLqzjnRp1cub8VUmYgSnRRyLb3Og== X-Received: by 2002:a5d:6a07:: with SMTP id m7mr27093821wru.324.1593607630155; Wed, 01 Jul 2020 05:47:10 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:09 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones Subject: [PATCH 03/15] mmc: core: regulator: Add missing documetation for 'mmc' and 'ios' Date: Wed, 1 Jul 2020 13:46:50 +0100 Message-Id: <20200701124702.908713-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remainder of the kerneldoc descriptions look present and correct. Fixes the following W=1 kernel build warnings: drivers/mmc/core/regulator.c:178: warning: Function parameter or member 'mmc' not described in 'mmc_regulator_set_vqmmc' drivers/mmc/core/regulator.c:178: warning: Function parameter or member 'ios' not described in 'mmc_regulator_set_vqmmc' Signed-off-by: Lee Jones --- drivers/mmc/core/regulator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/core/regulator.c b/drivers/mmc/core/regulator.c index 96b1d15045d60..609201a467ef9 100644 --- a/drivers/mmc/core/regulator.c +++ b/drivers/mmc/core/regulator.c @@ -159,6 +159,8 @@ static int mmc_regulator_set_voltage_if_supported(struct regulator *regulator, /** * mmc_regulator_set_vqmmc - Set VQMMC as per the ios + * @mmc: the host to regulate + * @ios: io bus settings * * For 3.3V signaling, we try to match VQMMC to VMMC as closely as possible. * That will match the behavior of old boards where VQMMC and VMMC were supplied From patchwork Wed Jul 1 12:46:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1266294 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E6D1C433DF for ; Wed, 1 Jul 2020 12:48:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3907720702 for ; Wed, 1 Jul 2020 12:48:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PjiRPFC2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730778AbgGAMsE (ORCPT ); Wed, 1 Jul 2020 08:48:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730632AbgGAMrO (ORCPT ); Wed, 1 Jul 2020 08:47:14 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE028C03E979 for ; Wed, 1 Jul 2020 05:47:12 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id q5so23654998wru.6 for ; Wed, 01 Jul 2020 05:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CbNGlX0G5Ov7FT75iCw50EDu+qwZ/8J7t3LRBNdlSbA=; b=PjiRPFC2+ne1JlGgsc0KpJefm6lvkyRsu+EM+8TXu7yFTsA+q9615YF7ZDoGByGVaA QzIJ0Ny5ocQIQXGLjETMjLTXZkb0S0RYf8k4sh/YGGanFkW1YH7EXKpJ4wCv3GyyvwNp XUZBH+7325vbu6YVK2DFMOYYKnRpozd4ENmvm8mBXAsd/18hWr5L+b/wmMtI/EfBHx0C WK4UMad91alCJ1Eu6G47jzTP96yrOF93Z7YUPcBkS49rzZ4sybvwiHpB8j/7ulafXijB SfEcPSCU1uRCLW8yJj6ouzi6dHUy3dXkwlrEUs3oeOmnnu2UgjKGe6FRs/JWurPC4fNo T4Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CbNGlX0G5Ov7FT75iCw50EDu+qwZ/8J7t3LRBNdlSbA=; b=J6K3nRqWdxNqjJQzPQmqDcewbAUoxgkV9evteXDihensgInjgbIfnEWgZTj4giDDm5 AuLnTnrCpCd94gSvf6kyLCC1CKTV8QPvqn2rYS+9WLY1P24J8+GO+DaX0JAsiDAbDpyn cvpr19L9NJi9gEwfiNdBhGUY9IFE81IIjZu7qIm/z684FLju7Sg1HCbeCn6AmVw+Q0Ug V2TD803bAoq7nzAGpuQmrRANJ5szpw99tsaPs/nJCLYyeWBdnL9UwQFpeLAUbE5MTMWp iwiWOI5b118Cav7dnEVwlgit2rK5i/TTquOvD6rO6fSZV3zuIiBOwxi5LNqpxnWJsmt/ pDng== X-Gm-Message-State: AOAM533VfMAE7VSI6hw3T3hH9Sw+9MG0HZs1xpqit410v5vAktHQyTU1 3NpXacCvBn7Dt8jNR+zYbgDbqQ== X-Google-Smtp-Source: ABdhPJyR/yX50DpfFq9R2u3R16L2+L4q61pYf7cMIGM739hqYmJOThTTybjRR20yzg25Z+WZLrDNYA== X-Received: by 2002:a5d:474f:: with SMTP id o15mr23624823wrs.306.1593607631728; Wed, 01 Jul 2020 05:47:11 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:10 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Adrian Hunter , Ben Dooks , Jaehoon Chung Subject: [PATCH 04/15] mmc: host: sdhci-s3c: Provide documentation for missing struct properties Date: Wed, 1 Jul 2020 13:46:51 +0100 Message-Id: <20200701124702.908713-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Describe properties; ext_cd_irq, clk_rates and no_divider (x2). Squashes the following W=1 kernel build warnings: drivers/mmc/host/sdhci-s3c.c:126: warning: Function parameter or member 'ext_cd_irq' not described in 'sdhci_s3c' drivers/mmc/host/sdhci-s3c.c:126: warning: Function parameter or member 'clk_rates' not described in 'sdhci_s3c' drivers/mmc/host/sdhci-s3c.c:126: warning: Function parameter or member 'no_divider' not described in 'sdhci_s3c' drivers/mmc/host/sdhci-s3c.c:139: warning: Function parameter or member 'no_divider' not described in 'sdhci_s3c_drv_data' Cc: Adrian Hunter Cc: Ben Dooks Cc: Jaehoon Chung Signed-off-by: Lee Jones Reviewed-by: Jaehoon Chung --- drivers/mmc/host/sdhci-s3c.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 64200c78e90dc..9194bb73e601b 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -107,8 +107,11 @@ * @ioarea: The resource created when we claimed the IO area. * @pdata: The platform data for this controller. * @cur_clk: The index of the current bus clock. + * @ext_cd_irq: External card detect interrupt. * @clk_io: The clock for the internal bus interface. + * @clk_rates: Clock frequencies. * @clk_bus: The clocks that are available for the SD/MMC bus clock. + * @no_divider: No or non-standard internal clock divider. */ struct sdhci_s3c { struct sdhci_host *host; @@ -128,6 +131,7 @@ struct sdhci_s3c { /** * struct sdhci_s3c_driver_data - S3C SDHCI platform specific driver data * @sdhci_quirks: sdhci host specific quirks. + * @no_divider: no or non-standard internal clock divider. * * Specifies platform specific configuration of sdhci controller. * Note: A structure for driver specific platform data is used for future From patchwork Wed Jul 1 12:46:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1266293 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 712BFC433E0 for ; Wed, 1 Jul 2020 12:48:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FBC920702 for ; Wed, 1 Jul 2020 12:48:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NkxOWXIN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730768AbgGAMsC (ORCPT ); Wed, 1 Jul 2020 08:48:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730633AbgGAMrO (ORCPT ); Wed, 1 Jul 2020 08:47:14 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 039F2C03E97A for ; Wed, 1 Jul 2020 05:47:14 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id j18so22261957wmi.3 for ; Wed, 01 Jul 2020 05:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sJPW3QXOhHs7zWGK9W13Qhww3wag5wL/K8qzQE+aHP4=; b=NkxOWXINSEGLHqpysGjU6l/aLOB9D1RBUt6a9Cv/cmC44LR032HJ/q+z+4snhCTNaW PdMMvGuAtO6Ujsk4aFY5+ggkapbI0y8vbr63jnUFJyXL86NW5J8CQGij61gyCDHXbUvz q0ZXV3do+vtPoNt8BgF/Jqn4PdF42fkgGAD0WiII26VZNos1Zz4ezvQGo2YuQ6UVBJDV LjbxniUTQMcgraMb0BQXgE7a+gMVTa48nOSq35qfFocyo8c0E6lg3HCVEfXt60C77tY6 reC6aeGYzXZElVG8Ik/hDOwn7VmhUGcSH3jWARgSvgWiATkKl6mXLwuzriMC6WwSkV18 Tz5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sJPW3QXOhHs7zWGK9W13Qhww3wag5wL/K8qzQE+aHP4=; b=G4pzMgDJvnuf4LNwS/zGckDEA62y/3K4kdce8sG+uvZ/tOCNWsghxrMVCTdkpVXsJu 8pX0IQvhlcgV+PsIHh35+Dd/mAsX97LKXC5/F8nKK+0xs/Q9Uz9QEy3/J2L+C+olq4ZZ zN7nI12Rd48h53rLi6QqWeOxSpuoZdb+ih+NvXnhQSrSR9ZDGkbdWx7hxQX5awkHTEFG /jPmGTbyluh36R9RTEcIenF3vSuEwpGrZEO4eX63h5ky5MrJ4S4swawKErMraLZ0gOEl 1qVAt7PaLpuHypvCQSRMQvnpfpf8acXrXyovqMY99/kT98mHcK76ePb/AeCfkwR0vln0 wDFA== X-Gm-Message-State: AOAM530WJdFcTM+9dfIl0CVzMrfpXywk5EMxnhHbVuW7BFJ0Mm/o3WB/ ipixY6ZZC6v7uQfmdyQ0cXIe/A== X-Google-Smtp-Source: ABdhPJxnFAAMJptNueVPmlk8boLIXJmBHNOeNDTpH4SZs6YyRbzwAScqFRsTswPCfpzS6+CQ/Dp17w== X-Received: by 2002:a1c:6006:: with SMTP id u6mr26009722wmb.111.1593607632721; Wed, 01 Jul 2020 05:47:12 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:12 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Chaotian Jing , Matthias Brugger , linux-mediatek@lists.infradead.org Subject: [PATCH 05/15] mmc: host: mtk-sd: Demote msdc_recheck_sdio_irq() function header Date: Wed, 1 Jul 2020 13:46:52 +0100 Message-Id: <20200701124702.908713-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No other function in the file is documented using kerneldoc and no effort to document the function arguments have been made. It's a bit of an oddity to say the least. Let's downgrade it from kerneldoc to a standard comment block instead. Fixes the following W=1 kernel build warning: drivers/mmc/host/mtk-sd.c:1030: warning: Function parameter or member 'host' not described in 'msdc_recheck_sdio_irq' Cc: Chaotian Jing Cc: Matthias Brugger Cc: linux-mediatek@lists.infradead.org Signed-off-by: Lee Jones Reviewed-by: Matthias Brugger --- drivers/mmc/host/mtk-sd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 39e7fc54c438f..49ac802ebbfeb 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -1018,13 +1018,12 @@ static int msdc_auto_cmd_done(struct msdc_host *host, int events, return cmd->error; } -/** +/* * msdc_recheck_sdio_irq - recheck whether the SDIO irq is lost * * Host controller may lost interrupt in some special case. * Add SDIO irq recheck mechanism to make sure all interrupts * can be processed immediately - * */ static void msdc_recheck_sdio_irq(struct msdc_host *host) { From patchwork Wed Jul 1 12:46:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1266292 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 631AAC433E0 for ; Wed, 1 Jul 2020 12:48:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B6A520702 for ; Wed, 1 Jul 2020 12:48:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ya78GGdR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730759AbgGAMsA (ORCPT ); Wed, 1 Jul 2020 08:48:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730637AbgGAMrP (ORCPT ); Wed, 1 Jul 2020 08:47:15 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 394C8C03E97B for ; Wed, 1 Jul 2020 05:47:15 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id b6so23636977wrs.11 for ; Wed, 01 Jul 2020 05:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4HmkZgMMnNokIcxpC5qsgSTpETcgy+guvTGIOYd3vjA=; b=ya78GGdRIDBQGK8B84BfpjUHk69NCx0tP8mmoMldCAn5FHcrT/VhqMAXQF6V/OVicR FMY6bg9H1UVELQAZDu4fCvqgDKIKWO4S9wzT4m3AteUDzvlZOK4/MtjhiCd+KXmKMb1L F1TtQ/2H7zYbSMx2RxkB8Qz1Gr21YJj+SLdsFpOqYnZSQUbS93IXbdEXgX9sf6HweKB0 TNVjzis0NXV8fJMHzzSeFbiEixlXlbJBV2nY8NiHHWlwBss2KBdZAh0ig6sPaccKPpN9 +cviagir9w82XUTR6EHMNr+NxvILSikRpvq1WwLaBLKCHbd8OhUghVvGmfhwHjUneWS0 WzGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4HmkZgMMnNokIcxpC5qsgSTpETcgy+guvTGIOYd3vjA=; b=YQue7iPrTknXvrA521ssWdyjrvh/2xmLi3oNgQk1z7DmQZxcCw/Sw6NlKsCwrrGVOY GIE/WGymRuSexMrOSeu25w1EacRYvGMb2JbwOPln8XrxtaDC3V+bE+yeQ4W465f072j2 6imlskZ3CDNJD52ZbzoJjdkFVAFOhbQiDo75sI9TRIulTh/j4QouUXzCHr/utB+VhAVz RrBmR8bQ4JP/Wzf4A4O5xkLby3fZ52ZEaknmWDXyXIbulc3DamBgik0dGOMJI0JI7KXt JTxPuZT8C2ZJ8yi0wwZilpkcGUdYGS+8GSUcslHSB7ELAdX3oVzGcl200V4wNi5Y3NtE 8luA== X-Gm-Message-State: AOAM532bR7aJFp5CMrEBGkkRksmRsNjuse2UUiypjtVRO7O4/PSmdRqY uNymQQNNPVPCd8GFCuAXuneCeQ== X-Google-Smtp-Source: ABdhPJx5sdyemoJCIEKPCxf8WbgcrVsCh6V9mQezCi/IiAds/ZoliLC+HT1ZY95I0UsHrI8WiYDixg== X-Received: by 2002:adf:ecce:: with SMTP id s14mr26836949wro.154.1593607633908; Wed, 01 Jul 2020 05:47:13 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:13 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni Subject: [PATCH 06/15] mmc: host: atmel-mci: Provide 2 new and correct 1 existing property description Date: Wed, 1 Jul 2020 13:46:53 +0100 Message-Id: <20200701124702.908713-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'sg_len' and 'dma_conf' are missing correct kerneldoc documentation and 'buf_phys_addr' was misspelled. Correcting these issues fixes the following W=1 kernel build issues: mmc/host/atmel-mci.c:352: warning: Function parameter or member 'sg_len' not described in 'atmel_mci' mmc/host/atmel-mci.c:352: warning: Function parameter or member 'buf_phys_addr' not described in 'atmel_mci' mmc/host/atmel-mci.c:352: warning: Function parameter or member 'dma_conf' not described in 'atmel_mci' Cc: Ludovic Desroches Cc: Nicolas Ferre Cc: Alexandre Belloni Signed-off-by: Lee Jones --- drivers/mmc/host/atmel-mci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c index 5cb6926876981..300901415aa20 100644 --- a/drivers/mmc/host/atmel-mci.c +++ b/drivers/mmc/host/atmel-mci.c @@ -225,12 +225,13 @@ struct atmel_mci_dma { * @lock: Spinlock protecting the queue and associated data. * @regs: Pointer to MMIO registers. * @sg: Scatterlist entry currently being processed by PIO or PDC code. + * @sg_len: Size of the scatterlist * @pio_offset: Offset into the current scatterlist entry. * @buffer: Buffer used if we don't have the r/w proof capability. We * don't have the time to switch pdc buffers so we have to use only * one buffer for the full transaction. * @buf_size: size of the buffer. - * @phys_buf_addr: buffer address needed for pdc. + * @buf_phys_addr: buffer address needed for pdc. * @cur_slot: The slot which is currently using the controller. * @mrq: The request currently being processed on @cur_slot, * or NULL if the controller is idle. @@ -240,6 +241,7 @@ struct atmel_mci_dma { * @data_size: just data->blocks * data->blksz. * @dma: DMA client state. * @data_chan: DMA channel being used for the current data transfer. + * @dma_conf: Configuration for the DMA slave * @cmd_status: Snapshot of SR taken upon completion of the current * command. Only valid when EVENT_CMD_COMPLETE is pending. * @data_status: Snapshot of SR taken upon completion of the current From patchwork Wed Jul 1 12:46:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1266284 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C48CC433E0 for ; Wed, 1 Jul 2020 12:47:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3550C20702 for ; Wed, 1 Jul 2020 12:47:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JQJdL1or" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730679AbgGAMrX (ORCPT ); Wed, 1 Jul 2020 08:47:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730647AbgGAMrR (ORCPT ); Wed, 1 Jul 2020 08:47:17 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29880C03E979 for ; Wed, 1 Jul 2020 05:47:16 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id b6so23637032wrs.11 for ; Wed, 01 Jul 2020 05:47:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=phaHepEqEbU60VSdrxFqwpC3YbwLDxmZYay7m2R57bw=; b=JQJdL1orTD6yrnvu+G+Eb/HXTwwA1BYCd5yp8o/2fk74PgM7jUblE5zVqfHqU3Swq7 EnCEMIFQOVslHGPA3VVxtzqf50unu1X/ugYbWoRwdC2gV8eLP194tZwfLF3qdwhMqiFC XuW41gKAyIJu/cpdbgQOOiGHnPuS7UP3a7vc8kC1P/O2/4VyLf1l+mZfUR2zrhp1/n9M UB7CHbqjd0FS0AytCmPJ8qTC0izQZsLz/vA6FYkp5RESKM1pgkjbWCafgr78ZiIIi2BK 4GAoFq2K2JGd0y83LhXd8gmI4GDS7sNs/TacfyBk/2+G9VMK3lvuLTwVgcf6Lrq/13xl qpug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=phaHepEqEbU60VSdrxFqwpC3YbwLDxmZYay7m2R57bw=; b=R0HLfBsx4W/UDYzKVLODUx7wYXJrDMDtI1NsRxltYAPheRzd6WqTK81j+Mvwgytq/5 /AmaFSU5vbxQD4X0H2yNbIT2zgdq73SSZYYeICDQyHSQc4lgncHW909AyxQIeMub4Qto d++Thux8N1SWgNuErAZrd6b/rdmjHzR1kY3O6aQ7Iv/OjeALjIP9ELkg09dF/Z1x2MVb 9vdWzEuY/V/uy9pjHTXDrYEKBT2KOEEtsM6F6hZNH04TCaV4cOjwRFxisN+PeH+Aui1O vppIRzECUVRFLqFOksw10WW8s3SRdDdYTx5EX+AK5lkiIXI6cOheNpEYnqDOZGD4tbwx mnAQ== X-Gm-Message-State: AOAM530ToXSBncIkauTqLE0DGcnSswjrRQrfngEuFce7o2XjrrmF9gze dEaHYsjNv+uyQbR7LLzBETJ7Ow== X-Google-Smtp-Source: ABdhPJwgwINDi8Vx2k78e0LUbFfG5zxBt7MBPPGrr1Hcrg1wwapdPMMvrt5k5hC8U/MQ7E7z0g1dog== X-Received: by 2002:adf:e701:: with SMTP id c1mr27181289wrm.350.1593607634878; Wed, 01 Jul 2020 05:47:14 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:14 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones Subject: [PATCH 07/15] mmc: core: queue: Correct misspelling of 'mq' in mmc_init_request()'s docs Date: Wed, 1 Jul 2020 13:46:54 +0100 Message-Id: <20200701124702.908713-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Correcting this misspelling squashes the following W=1 build warning(s): mmc/core/queue.c:212: warning: Function parameter or member 'mq' not described in '__mmc_init_request' mmc/core/queue.c:212: warning: Excess function parameter 'q' description in '__mmc_init_request' Signed-off-by: Lee Jones --- drivers/mmc/core/queue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c index 4b1eb89b401d9..6c022ef0f84d7 100644 --- a/drivers/mmc/core/queue.c +++ b/drivers/mmc/core/queue.c @@ -203,7 +203,7 @@ static unsigned int mmc_get_max_segments(struct mmc_host *host) /** * mmc_init_request() - initialize the MMC-specific per-request data - * @q: the request queue + * @mq: the request queue * @req: the request * @gfp: memory allocation policy */ From patchwork Wed Jul 1 12:46:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1266283 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74C5BC433E0 for ; Wed, 1 Jul 2020 12:47:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DCD920772 for ; Wed, 1 Jul 2020 12:47:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="c9lB95Zl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730661AbgGAMrU (ORCPT ); Wed, 1 Jul 2020 08:47:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730622AbgGAMrS (ORCPT ); Wed, 1 Jul 2020 08:47:18 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C18DC03E97A for ; Wed, 1 Jul 2020 05:47:17 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id o11so23669076wrv.9 for ; Wed, 01 Jul 2020 05:47:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Yd63tKAD8TEw//9s1TXw4/kd8gj1ZByx7XV4rk7dLd0=; b=c9lB95ZlSkCDr8FrC6iJ4ySeiJo/PwpxEuvTW8mPxbMi7ihPg/iN9Ag0/siQ+aqpIN lJhnsv+KPo9I9zWCV2sxE1dhJLOJGFRNycvWH0auT6M8XZ7Mm/CEmwTqIi/r6BvFoFbn ZF67z9oamZZJ9uq+qhic/shA3dVgWeBSmdEv+aV9UMhqA1T2lxOnICn52HaGh14Z8zLs JlM+mZTh/a6C65EV3n2CX9SPSXdqj7qDRm8JgZVHxNSzK4s2KBtcxSMAE3tkpiwImxEL DLIl0Ew6S3oRNZnBNegDJAc0B6jWmDJxM/kmE9KyRsqZ+dUn1sLkGLyi21Q94OtsfMI6 T5RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Yd63tKAD8TEw//9s1TXw4/kd8gj1ZByx7XV4rk7dLd0=; b=Jlx9ZgVwyFg4neYuPkLs4SsaHHCYbFU08JRTHjraSflfGOZOEZT+rF3Fqz5U3GvipP tXhcY0w3Fh1Ee62J5Zy6rhUr6lYjaUl262lS8xjCWhSYsOvkuzN0c8f6LaO5uFJQrB9P q1V0zjLIpy42Kp3ANIU64006polG88K0VCUOww+osejgAN3Kn4GeeQFgcTfr+shBTCbt iV2TJAa+h/Q+AgQRRsqnDj/GOWOgllPHBa17HcWCakX0c8FMxq99lZfNr2/4Bf6O2WQs x7bvr5fILb0niJq152AnZj2P8x9JSr0CN2MOP5W76i+2KJhySEsh//qdhBpqIYb+zBcX dRKA== X-Gm-Message-State: AOAM533RXudR6BpfLh2NjqJ8yB7yHIFeitCGMZlXBKre8ofEthPdE/jb G+BQI2dOXkjrrR8VUzo7XKhlnw== X-Google-Smtp-Source: ABdhPJwshEQk22UxiuotqnoaKHFLuGrVwcP2gpb1t5Bt9UatQsrYDEIsRgMqxO9yunUFcwD7M//wEQ== X-Received: by 2002:a5d:420b:: with SMTP id n11mr26559514wrq.91.1593607636400; Wed, 01 Jul 2020 05:47:16 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:15 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Jaehoon Chung , Kukjin Kim , Krzysztof Kozlowski , Thomas Abraham , linux-samsung-soc@vger.kernel.org Subject: [PATCH 08/15] mmc: host: dw_mmc-exynos: Add kerneldoc descriptions of for 'dev' args Date: Wed, 1 Jul 2020 13:46:55 +0100 Message-Id: <20200701124702.908713-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Provide missing documentation for dw_mci_exynos_suspend_noirq() and dw_mci_exynos_resume_noirq() function headers. Fixes the following W=1 kernel build warnings: drivers/mmc/host/dw_mmc-exynos.c:184: warning: Function parameter or member 'dev' not described in 'dw_mci_exynos_suspend_noirq' drivers/mmc/host/dw_mmc-exynos.c:200: warning: Function parameter or member 'dev' not described in 'dw_mci_exynos_resume_noirq' Cc: Jaehoon Chung Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: Thomas Abraham Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Jaehoon Chung --- drivers/mmc/host/dw_mmc-exynos.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c index 5e3d95b636769..bd59186f59b39 100644 --- a/drivers/mmc/host/dw_mmc-exynos.c +++ b/drivers/mmc/host/dw_mmc-exynos.c @@ -176,6 +176,7 @@ static int dw_mci_exynos_runtime_resume(struct device *dev) #ifdef CONFIG_PM_SLEEP /** * dw_mci_exynos_suspend_noirq - Exynos-specific suspend code + * @dev: Device to suspend (this device) * * This ensures that device will be in runtime active state in * dw_mci_exynos_resume_noirq after calling pm_runtime_force_resume() @@ -188,6 +189,7 @@ static int dw_mci_exynos_suspend_noirq(struct device *dev) /** * dw_mci_exynos_resume_noirq - Exynos-specific resume code + * @dev: Device to resume (this device) * * On exynos5420 there is a silicon errata that will sometimes leave the * WAKEUP_INT bit in the CLKSEL register asserted. This bit is 1 to indicate From patchwork Wed Jul 1 12:46:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1266291 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAFD0C433DF for ; Wed, 1 Jul 2020 12:47:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9AC5D20702 for ; Wed, 1 Jul 2020 12:47:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hvlv+tX5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730748AbgGAMrx (ORCPT ); Wed, 1 Jul 2020 08:47:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730651AbgGAMrT (ORCPT ); Wed, 1 Jul 2020 08:47:19 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A41AC03E979 for ; Wed, 1 Jul 2020 05:47:18 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id z2so1402933wrp.2 for ; Wed, 01 Jul 2020 05:47:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=N515jYO+XViE4rxUKT5HCQLZtJJRT/LcfFcciYDmBeM=; b=hvlv+tX5KbtfpPHuAr/9nPcfbWbt2OM+cAiArO7rBU+Y2+hvUnLaSo0jEyJTSCNtqf /BDU4lYL9oLCcqTop/giUBCPoSMdBObVhCbOzDajIg7Xy6OW+ZanytcIK27fFPUGoSVU 2HU2a9hqOlOZrJOszUR6SdV2AyaDNo6lSEkB+ew6DMnwFNMd/BNLqTiFAHq1aJUyK533 vZApsJFvDH9s4cvNsik/dIsdQTNB9Xgck4l+CjFOQg+hSyhnw/3cQ4TbqOVFFZ9q5zuU Hx3f33mBeGd2YAWoPZsDHGAAQN8Ba5WzdLuFqKRs0IHGKbASYvKxZqTge82v1stAPd6T vuAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=N515jYO+XViE4rxUKT5HCQLZtJJRT/LcfFcciYDmBeM=; b=NmMe37MpYalPfVjEFuvuJhxcoqz3G/frUYCaLfZvImwXtFsaqbL1j8Nfj75HQXovck IzHj2WBZrblBDQ8YIejrFD4CidOhR58rUJefW3vWrPY9utNig6HNFDcxNvqhGSORuXyu HSkc2j54SabVLmy/O64Qjh+FXaF2Tt62rttT/07Q9R0BUdumsySkh9H+ycT5roMGs416 qSf5yZR0MwMRknSOWUNPI/2It/PQhOf6/5rLZMMp5onGv1M7Ex4yAZGu+yQJGpjf9aFm /wA7SSjT8cfjfCyRVz+152F2sufp4Cuifjkr2Ex5ZuLWYQXM+dycuHsyKL0ldSXo6YOx iroQ== X-Gm-Message-State: AOAM5339xqGC9PiRqTu+Tr18h+sdhSa0U2Vd4YYIdPaS+zYWdZoZjM+O BS5OqM/eHRTQhmyHE2BhMJlygw== X-Google-Smtp-Source: ABdhPJzwL6sUJakVeaCCVt1EjUi0Pfn7s08Z72vAPl3BEm+TB/R6hwjCzAdHY66m8bbVha8qFfoZlg== X-Received: by 2002:adf:8168:: with SMTP id 95mr27049461wrm.104.1593607637328; Wed, 01 Jul 2020 05:47:17 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:16 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Wei WANG Subject: [PATCH 09/15] mmc: host: rtsx_pci_sdmmc: Remove set but unused variable 'err' Date: Wed, 1 Jul 2020 13:46:56 +0100 Message-Id: <20200701124702.908713-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Seeing as sd_wait_data_idle() returns void and only a very specific read value is checked, there doesn't seem to be a good reason to check the return value of rtsx_pci_read_register(). So remove the assignment and definition of 'err'. Squashes the following W=1 kernel build warning: drivers/mmc/host/rtsx_pci_sdmmc.c: In function ‘sd_wait_data_idle’: drivers/mmc/host/rtsx_pci_sdmmc.c:678:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable] 678 | int err, i; | ^~~ Cc: Wei WANG Signed-off-by: Lee Jones --- drivers/mmc/host/rtsx_pci_sdmmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c index 5a71f6678fd3a..dc0dbd64a2a78 100644 --- a/drivers/mmc/host/rtsx_pci_sdmmc.c +++ b/drivers/mmc/host/rtsx_pci_sdmmc.c @@ -675,11 +675,11 @@ static u8 sd_search_final_phase(struct realtek_pci_sdmmc *host, u32 phase_map) static void sd_wait_data_idle(struct realtek_pci_sdmmc *host) { - int err, i; + int i; u8 val = 0; for (i = 0; i < 100; i++) { - err = rtsx_pci_read_register(host->pcr, SD_DATA_STATE, &val); + rtsx_pci_read_register(host->pcr, SD_DATA_STATE, &val); if (val & SD_DATA_IDLE) return; From patchwork Wed Jul 1 12:46:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1266289 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 932B8C433DF for ; Wed, 1 Jul 2020 12:47:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68C9520702 for ; Wed, 1 Jul 2020 12:47:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Vmuk3iCY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730740AbgGAMrp (ORCPT ); Wed, 1 Jul 2020 08:47:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730660AbgGAMrU (ORCPT ); Wed, 1 Jul 2020 08:47:20 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5E29C03E97B for ; Wed, 1 Jul 2020 05:47:19 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id w3so10635248wmi.4 for ; Wed, 01 Jul 2020 05:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dBwifa0ZuoxuR9zanjCi/SQC3HxVrP+0TUYJWPy9rp0=; b=Vmuk3iCY78/WlEtcAdEexKWZcshcQ4CAc2QtQlIooAG1Sjzo7f922rZ5uu3Btw42mG pof4skzNtKjDAQ2V7hlvDc8qTUDRiAuUwOspjGY68c8ASAmQJZzYuw1DqpPM8TI+tbYk GA04r/sV9cy1DJ0+stgXKyLbOfzThikzkPVRIvV6m9L9IDgbCUeUCf5TPNOjaSYqNQDt /gJn0pdOlKPAceJRAr9sgb4pG0FQSmGa7l9+UIMmmI63BXVj+eiObd+MyXCYC2uFsXEb eSkxfH1EoY2oa1tfhAac2VmwXB4gICM7NLjLUlvi4MHodiQa5hiCYFQ+KVUpjcjAR7OV YM4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dBwifa0ZuoxuR9zanjCi/SQC3HxVrP+0TUYJWPy9rp0=; b=HK69b2FQaniqnO+QcwNi7gs/u50BDdqv1BUoUra8H58kOpJfrKN/tLWkih+Mu0sff+ oi6kOkrNOFh1EtmgymgxpI3HAQPeeaZ9eTVW/vBkSGUnNm3lPUJo3Du6pQkAzncFwSie IQaZnwhTOAvOFLhjZ5LNTx25nXxW+K0JNyd6WjZ8yDVkohpE+ceCYRudt+5wFrwTlFdx 79tT98SGft+EBcJluEFlqrvi1eQ2YCXh/d/HOA5ejivrXF5L12y/8FHF/koyIieHcX1g JRy40QhfIYjCj9HgJ8JgyBhyHbLzrZV220Hvu0LhAlatO65AaJiNTNRnbtl11cKdzX4A ZMoA== X-Gm-Message-State: AOAM531xE6Ix3qwEMO6zvwH7DuxEQ5sud2++HzRjVq1IqEOI7ko462AV xjKdGu1Oe2ZI6o6JeRQ9vn8vFw== X-Google-Smtp-Source: ABdhPJyRlpTGWtkkPDEX2Kbq6J1uY8YesgkaBwFXFyeaq+IHUPNxOc1d79VYpEMGSjz+hU5Plde7oA== X-Received: by 2002:a1c:f301:: with SMTP id q1mr26418165wmq.110.1593607638527; Wed, 01 Jul 2020 05:47:18 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:17 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Roger Tseng Subject: [PATCH 10/15] mmc: host: rtsx_usb_sdmmc: Remove set but unused variable 'err' Date: Wed, 1 Jul 2020 13:46:57 +0100 Message-Id: <20200701124702.908713-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Seeing as sd_wait_data_idle() returns void and only a very specific read value is checked, there doesn't seem to be a good reason to check the return value of rtsx_pci_read_register(). So remove the assignment and definition of 'err'. Squashes the following W=1 kernel build warning: drivers/mmc/host/rtsx_usb_sdmmc.c: In function ‘sd_wait_data_idle’: drivers/mmc/host/rtsx_usb_sdmmc.c:657:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable] 657 | int err, i; | ^~~ Cc: Roger Tseng Signed-off-by: Lee Jones --- drivers/mmc/host/rtsx_usb_sdmmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_sdmmc.c index a7084c50ad65f..7225d9312af8c 100644 --- a/drivers/mmc/host/rtsx_usb_sdmmc.c +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c @@ -654,12 +654,11 @@ static u8 sd_search_final_phase(struct rtsx_usb_sdmmc *host, u32 phase_map) static void sd_wait_data_idle(struct rtsx_usb_sdmmc *host) { - int err, i; + int i; u8 val = 0; for (i = 0; i < 100; i++) { - err = rtsx_usb_ep0_read_register(host->ucr, - SD_DATA_STATE, &val); + rtsx_usb_ep0_read_register(host->ucr, SD_DATA_STATE, &val); if (val & SD_DATA_IDLE) return; From patchwork Wed Jul 1 12:46:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1266290 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E677EC433E1 for ; Wed, 1 Jul 2020 12:47:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C21C820772 for ; Wed, 1 Jul 2020 12:47:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HWrA80RX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730731AbgGAMro (ORCPT ); Wed, 1 Jul 2020 08:47:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730663AbgGAMrV (ORCPT ); Wed, 1 Jul 2020 08:47:21 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE585C03E97A for ; Wed, 1 Jul 2020 05:47:20 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id l2so21602761wmf.0 for ; Wed, 01 Jul 2020 05:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wrIyNI5ZF/KUj1ZtT7jKpZfKmT6HM/rM07zicowUN5s=; b=HWrA80RXIAqmo5CKdWTISZJHmseFSX+3Dyz3Ow1WhDW5QxMOYcgIY6wdeztm6ESucb Bm/J9GT1TDSzZ8gPQVE/FDr23Dp5jiDD1gHJD7RDTKJMdDq6hV0aLQfzYnkwZXaJXYCx lLt9OjNCVFiEVXjv0OyqtuQSXOF7Y70KV0ReaL9HJXcX0PXwm0S3VPJ/qUke3nn+sn/v P3m69z3xKwOK9IuXhP/xxiNZ6+vk0Maggv/Ze/Hlwl8I6LL5mP6el3w1fNIXesCUrFye 1xghHvJgE8hIUQxPXccn0sFsIIKe9pKGOn/+6rzOAf4VIeyH4aoH0TZXq1f0/5uLccsl 36yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wrIyNI5ZF/KUj1ZtT7jKpZfKmT6HM/rM07zicowUN5s=; b=cBhJoqcY6qTXJiDZlrjCxQrMTWEe65/sBSxeAM6jqwRoQAR9b7wD4UunBJzajbPwHA o0qQS+GFvysJ4pmTw6qxGpXvwjUGzH+O/mKMMALWbYH4IuV9M+5JT1w/6CeJEMs1k8p2 DdFCFlTohMwYv9TynD8LOE8rjT5OvTGrz9eFmxbnTf7whebJ7Ex/N15yp+59C/dX9mWP e8FAIWaztV4APPkDg8oXYM4I83Z/oeXhQO5s1DduVoHHD+DI4B/oy7/n9vE6Ppq6CHXE hg1+CHZ3ByIC6se45TDEq6qiL58OVAqceliQDHYhXjtVIaD3z65WqN9ScIEH2xvdCiLq 2d0A== X-Gm-Message-State: AOAM532oxFVRW7iHOqmsxSzNFBd6vsc6sJl/SAlb58tq06oSp9dXCjUs 67G7G33mh/5GKNWtvme8dQKM8A== X-Google-Smtp-Source: ABdhPJxrkgYBUNiXUPxL6R2LO6yk68bXOYLtPWMdEp987Bhj7XPp0ZSAKkOf3hcOpVV/xo1vAf6y1w== X-Received: by 2002:a1c:3bc2:: with SMTP id i185mr26946217wma.33.1593607639564; Wed, 01 Jul 2020 05:47:19 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:18 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Adrian Hunter , Michal Simek , Xiaobo Xie , Anton Vorontsov , Soeren Brinkmann Subject: [PATCH 11/15] mmc: host: sdhci-of-arasan: Correct formatting and provide missing function arg(s) Date: Wed, 1 Jul 2020 13:46:58 +0100 Message-Id: <20200701124702.908713-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kerneldoc expects arg descriptions to be in the format '@.*: '. If either the '@' or the ':' is omitted then kerneldoc complains that the description is missing. Add the missing ':' here and provide a new description for 'value'. Fixes the following kernel build W=1 warnings: drivers/mmc/host/sdhci-of-arasan.c:1394: warning: Function parameter or member 'host' not described in 'sdhci_arasan_update_support64b' drivers/mmc/host/sdhci-of-arasan.c:1394: warning: Function parameter or member 'value' not described in 'sdhci_arasan_update_support64b' drivers/mmc/host/sdhci-msm.c:1887:6: warning: no previous prototype for ‘sdhci_msm_dump_vendor_regs’ [-Wmissing-prototypes] Cc: Adrian Hunter Cc: Michal Simek Cc: Xiaobo Xie Cc: Anton Vorontsov Cc: Soeren Brinkmann Signed-off-by: Lee Jones Acked-by: Michal Simek --- drivers/mmc/host/sdhci-of-arasan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index db9b544465cda..260e06e238f7e 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -1388,7 +1388,8 @@ static void sdhci_arasan_unregister_sdclk(struct device *dev) * - For Keem Bay, it is required to clear this bit. Its default value is 1'b1. * Keem Bay does not support 64-bit access. * - * @host The sdhci_host + * @host: The sdhci_host + * @value: The value to write */ static void sdhci_arasan_update_support64b(struct sdhci_host *host, u32 value) { From patchwork Wed Jul 1 12:46:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1266285 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F754C433DF for ; Wed, 1 Jul 2020 12:47:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D58F20702 for ; Wed, 1 Jul 2020 12:47:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HJ/om3la" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730690AbgGAMr1 (ORCPT ); Wed, 1 Jul 2020 08:47:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730668AbgGAMrW (ORCPT ); Wed, 1 Jul 2020 08:47:22 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21E68C08C5C1 for ; Wed, 1 Jul 2020 05:47:22 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id k6so23680673wrn.3 for ; Wed, 01 Jul 2020 05:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8hbNAtKSwUso7F6/Zo5X4haYX63XDsD/59rYslLWqBM=; b=HJ/om3laTlqrN4tbJ+hATe0qObMhqatwVBMmZnGQmvTJIYTLVQz8MxOl73Hvp4WjqF xqUHLf7YHf1hvrtoxKkTPx5vx4baewW61qxzhFuZVeIya9axCarl7l2dViHxrkwleodH dqRvX57EYA4mWlnOc3UXl84JE1fw1eqzsYGqhZglttgGNgeyeTENotbaLBbM3ZJAO6RO W6wL7H1TlNKqrdzCh8F+/x99y+cE9x8koVt002NOvQeOPt78Usfk5Y/7tdSB2HeTaHRe 5DHEEFclRVMMEY0UmZNQW+FvRnf4tsOiigh1L7ZLqnBfpOrsVbnL6LlOLwWrq5rZCYS4 IJAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8hbNAtKSwUso7F6/Zo5X4haYX63XDsD/59rYslLWqBM=; b=NBA993f8mkteJMd/w1eLzKuKoljPeD0Wh6B5LljeOuDPmrEobX1Rh9/EVRbQVdSSNu 8xjBfMp4WmX8aqDjXntkpYqfqw72/+qxsFeQpr3Kyl5+15basqUlPFDQJqPWf/lpmMs3 ZAKHCUT7CYN2R0AoZ7xpLIRJObuauR1pN/SsKBDmzpmZnuYEa/2pEcDHrbIf/H++JkBC +/OkarHe2FVI2oQkCie+P616KuLGhYyooal6XZosr8JNc1Gk9dSI+TpC+db4lMCstymJ pHRn5wW5E3uiExGB00WWBinaj2kd/xpxFqzRYOjnrOSQRPU3DWFBmi0Cin6C9LiZR32H LfIw== X-Gm-Message-State: AOAM5319FSHZdyiDOhk20YriTRor952M55KpY5mJMcs4TR2pdjO89aer FTL3vLum8RSyx8cqu1QL57CJuA== X-Google-Smtp-Source: ABdhPJxaxL/KUxiM37mz4pmYxkZ8JcArmoV2r74oObuQZwBjWSDWoMwdJUFYimiGE/2fmaa9tY0rNA== X-Received: by 2002:a5d:6a07:: with SMTP id m7mr27094488wru.324.1593607640839; Wed, 01 Jul 2020 05:47:20 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:20 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Adrian Hunter , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org Subject: [PATCH 12/15] mmc: host: sdhci-msm: Staticify local function sdhci_msm_dump_vendor_regs() Date: Wed, 1 Jul 2020 13:46:59 +0100 Message-Id: <20200701124702.908713-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sdhci_msm_dump_vendor_regs() is only used via the .dump_vendor_regs() call-back. It is never exported nor used externally, so it can be static. Squashes the following W=1 kernel build warning: drivers/mmc/host/sdhci-msm.c:1887:6: warning: no previous prototype for ‘sdhci_msm_dump_vendor_regs’ [-Wmissing-prototypes] 1887 | void sdhci_msm_dump_vendor_regs(struct sdhci_host *host) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Adrian Hunter Cc: Andy Gross Cc: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org Signed-off-by: Lee Jones --- drivers/mmc/host/sdhci-msm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index b277dd7fbdb5d..0c02f8a2d11ab 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -1884,7 +1884,7 @@ static void sdhci_msm_reset(struct sdhci_host *host, u8 mask) #define SDHCI_MSM_DUMP(f, x...) \ pr_err("%s: " DRIVER_NAME ": " f, mmc_hostname(host->mmc), ## x) -void sdhci_msm_dump_vendor_regs(struct sdhci_host *host) +static void sdhci_msm_dump_vendor_regs(struct sdhci_host *host) { struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); struct sdhci_msm_host *msm_host = sdhci_pltfm_priv(pltfm_host); From patchwork Wed Jul 1 12:47:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1266286 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8B56C433E0 for ; Wed, 1 Jul 2020 12:47:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E43320780 for ; Wed, 1 Jul 2020 12:47:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xIDiEYkl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730699AbgGAMr3 (ORCPT ); Wed, 1 Jul 2020 08:47:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730678AbgGAMrX (ORCPT ); Wed, 1 Jul 2020 08:47:23 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E44EC03E97A for ; Wed, 1 Jul 2020 05:47:23 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id k6so23680742wrn.3 for ; Wed, 01 Jul 2020 05:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RppFHH3LPgV9Fbxkc7EFxUD1a+LbYIuGU1AKsrw/uFk=; b=xIDiEYklS6lSZpP6D9pgP0igi/DuLWfHQtgqSxQrazIxDKzatFbofzd5A2lxZECBRp xgjtQ9qigjPm2I9PvVxfMtgVOIO3zEMvCEvi853x8QO6KLsAr0R7mmgVIfL4RruJlql+ xtvfOzVAj5ODP/aWq4ks/9xr7+uRNHZiDwRvvbfKMAlEFVGgBJ4MP7BztMTQk9lB1cy6 pO6NX2PcayLNiR9Ei7AhrqSWZWqG5xjsk2bCLWAueBI1qbYBzRjjcpWOaGChQi+lfluF 84QFziwLTyWWS1h3rphJzHL8TLCaYECg1Le1+RLbeX02xJMNoPAV4Pdm4iq52qPR7Z5X eakw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RppFHH3LPgV9Fbxkc7EFxUD1a+LbYIuGU1AKsrw/uFk=; b=D235dMOaN6xoQr7qwDSg0kwiq9dOncmgNVusWeEg2wHZIfVxT+XiO3T6gcTA2tVjvT c+AudKF+AEttbLmsc0W2t4wu0L4EJGzgUp8tWaB84u70aXte/sGEoOn5OLIl611Mq0rb kivfyO+NQ+XWSd+pvDRMzE35L7mlCJlpT0XtCAuPmRLurja01jJahNQuhv60u1Q2WjXU Ryvr7CufHXcG6Q4SEKrdfJieVqDClflxMHbbpxa/l+lUfXWLyihiiBGxTE7ziQZaWNxU YWrf0fWXdT/AQLDZf0Oo0EBxhFMZoOZ662MGifAgz9qB4WoCUdh0+vXT/Ay0L41SE5ZN ja0g== X-Gm-Message-State: AOAM5308nLeiU2RZJPScD+ydJjlkRkGRVZB9TabYHk5q5fJGzhtqg3ML obBXxVWQXFJClE4ABJtdbfAvkg== X-Google-Smtp-Source: ABdhPJyC8rXxEDpXbOyCSZxcsN81UfnduDOhMYWpILYzv9Y/zpJP7ApdbBjcGjp+fUgrrteEcjr51Q== X-Received: by 2002:a5d:6907:: with SMTP id t7mr26577073wru.329.1593607641927; Wed, 01 Jul 2020 05:47:21 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:21 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Adrian Hunter , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org Subject: [PATCH 13/15] mmc: host: sdhci-msm: Demote faux kerneldoc header down to basic comment block Date: Wed, 1 Jul 2020 13:47:00 +0100 Message-Id: <20200701124702.908713-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org __sdhci_msm_set_clock()'s function header is the only one in kerneldoc format. Which seems odd as it's not part of an external API and isn't referenced anywhere else. Seeing as there has also been no attempt to describe the expected function arguments either, we're going to assume that this is not actually a bona fide kerneldoc use-case. Fixes the following W=1 kernel build warnings: drivers/mmc/host/sdhci-msm.c:1595: warning: Function parameter or member 'host' not described in '__sdhci_msm_set_clock' drivers/mmc/host/sdhci-msm.c:1595: warning: Function parameter or member 'clock' not described in '__sdhci_msm_set_clock' Cc: Adrian Hunter Cc: Andy Gross Cc: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org Signed-off-by: Lee Jones --- drivers/mmc/host/sdhci-msm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index 0c02f8a2d11ab..7a574fc7635c4 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -1583,7 +1583,7 @@ static unsigned int sdhci_msm_get_min_clock(struct sdhci_host *host) return SDHCI_MSM_MIN_CLOCK; } -/** +/* * __sdhci_msm_set_clock - sdhci_msm clock control. * * Description: From patchwork Wed Jul 1 12:47:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1266287 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6CB3C433E0 for ; Wed, 1 Jul 2020 12:47:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C359120702 for ; Wed, 1 Jul 2020 12:47:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Igf8FH8P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730725AbgGAMrh (ORCPT ); Wed, 1 Jul 2020 08:47:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730680AbgGAMrY (ORCPT ); Wed, 1 Jul 2020 08:47:24 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D93AC03E97B for ; Wed, 1 Jul 2020 05:47:24 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id r12so23600909wrj.13 for ; Wed, 01 Jul 2020 05:47:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/gJoWFYQiS/u+V7Ey4cmwChdFCLsRE9Rx9263Z1oots=; b=Igf8FH8P6hdkKsVgk8CXs7RoyZeMUEAvTEJYQNZTp+t1LZgNAkLAKn1BdcIPG5ZX+l rscNT7GY/DyCGgRlpTTWOdkLo4LYCl5AlyBQlbjLGBfXsj67ylvJikQahonpLj2+TQha uGBfi+wjKp90MOfhsiMWYRykE3LoUQTwgn6t/1qoYt3cyVOAexgadrj38SqB/FGtO1gQ QoQcTgXLOTl8lEbQsPCii0mmEt4TA4/XesunG6isjLxX+Zwy2Y4t4fkNu8Nky1qAxPK7 BJZG7JB8EMZX6mj1Wi0VDor+x6Cg/whhx+TytTWoqbboaEQAa91Ca+0mUl4Dapdbwzu0 Tj7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/gJoWFYQiS/u+V7Ey4cmwChdFCLsRE9Rx9263Z1oots=; b=oiSKHVIhuaXmF45PUN9X+YO7mLND8zATw4VZSjon+LuxzgVlP8Jz1Ul8Q18OUWQr4c 6O5RqMvmJacuQfHWzYND6kXaBqZxA4ulkBMzjdhkDbaBxHskfTEUQrbatxQMhdYJ+H2O XAsgEHYCk7kPySpvOyA91AQpvNt4mK2cAGbbA2DPIc4C3vseLBxYFvTDlDHo5fDCQOzM 5V45xNd1z4LNPOANre7ogfWjSeKlNIFFomMhkhxolGcJBRPoFPUb09HTbqZaimtFFQi2 I0T5Ge8Aj4MLZBpYTJAVus/DOxoqA35cHijqaVUi4OuANICLiDvBjRwoezX3s6atb7Lc uraA== X-Gm-Message-State: AOAM533PVb8jy9RjLYxqok6VopeHgPtwSbEW3tym69EApZyBYjA0pDzu fMgjma9FyWMR4xzrV4IsAD2SeA== X-Google-Smtp-Source: ABdhPJxRDPkGlJlU4XJGQ/sleeyke1ZZuspWu101J6VUjlcK6F+a1bbhWf8+qWg+jb+I/TlCTyJOJA== X-Received: by 2002:a5d:6846:: with SMTP id o6mr26809049wrw.370.1593607643127; Wed, 01 Jul 2020 05:47:23 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:22 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Adrian Hunter , Ritesh Harjani , Asutosh Das , Venkat Gopalakrishnan Subject: [PATCH 14/15] mmc: host: cqhci: Demote faux kerneldoc header down to basic comment block Date: Wed, 1 Jul 2020 13:47:01 +0100 Message-Id: <20200701124702.908713-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cqhci_host_alloc_tdl()'s function header is the only one in kerneldoc format. Which seems odd as it's not part of an external API and isn't referenced anywhere else. Seeing as there has also been no attempt to describe the expected function arguments either, we're going to assume that this is not actually a bona fide kerneldoc use-case. Fixes the following W=1 kernel build warning: drivers/mmc/host/cqhci.c:163: warning: Function parameter or member 'cq_host' not described in 'cqhci_host_alloc_tdl' Cc: Adrian Hunter Cc: Ritesh Harjani Cc: Asutosh Das Cc: Venkat Gopalakrishnan Signed-off-by: Lee Jones Acked-by: Adrian Hunter --- drivers/mmc/host/cqhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c index 75934f3c117eb..8cc277b4ffe9e 100644 --- a/drivers/mmc/host/cqhci.c +++ b/drivers/mmc/host/cqhci.c @@ -144,7 +144,7 @@ static void cqhci_dumpregs(struct cqhci_host *cq_host) CQHCI_DUMP(": ===========================================\n"); } -/** +/* * The allocated descriptor table for task, link & transfer descritors * looks like: * |----------| From patchwork Wed Jul 1 12:47:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1266288 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EADB6C433E0 for ; Wed, 1 Jul 2020 12:47:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C817420702 for ; Wed, 1 Jul 2020 12:47:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eQGVEx2G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730714AbgGAMrf (ORCPT ); Wed, 1 Jul 2020 08:47:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730681AbgGAMrZ (ORCPT ); Wed, 1 Jul 2020 08:47:25 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90CDCC03E979 for ; Wed, 1 Jul 2020 05:47:25 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id a6so23670523wrm.4 for ; Wed, 01 Jul 2020 05:47:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QnLoeRbMIPawtLY45ADcQqoBmyPKvpQnROp2LZuEcEU=; b=eQGVEx2G9CgwJoaRiyytD3bAeayvmzMigNnaekh5vAFlUA245DSA0g6cw2hlGXXkTW TyXV6XLQMx3AoT3HoWGV2eQt8JGbxSJYRGy6qwhA2IgBrXDA/cdo4z/50HewPsSMFm+t JNWVg4jGv5mg5JOQlU238F13Xkb08XZScJTD9CM0tJUIW02s5q2Pa9EyJBJCNoOzGJiq loqHBKaYCEOPdf0wmPEJH9cCl3zy09Dj/BryXCfKdY6ysjjer/LebryJb+oYNAb90VPR 6BCSlv5KNWiLYdSwH7TWohviN3hVdnIN4oyA3MgHfAW1epC7QosHmfSpUQCYffrkdL7P 10LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QnLoeRbMIPawtLY45ADcQqoBmyPKvpQnROp2LZuEcEU=; b=CaF4BdlgGaCgf/8a0MsKSWKyPtoORtjlIiwxyFN62UkJQr9A1ICgCfBituukM7arvv 0dC8F6RZX71Shz5SdOD/CxEVaoP7XWUREugH5+KlfrTJzK3Z2b5IavlAxQ4VCcDm8y8R zGZm88ga5BjzhBH6przBkBluMEyT6IibgXmBOY76OA3YInyCQcpSE+mmm3QjLwm0rg2f dL/B509MYs+mM3u0tZmkk3Y+DUimIydK51FXU4Uhl2ALk5viGsUkdRLax30F/v3mpkPc F8M3TGamy31w6oyQUHFdCGeY/T8zQa1hIeoYL3M3Qas/WDLj+lDdrnJ2Dmvkn0yLeqtv CSqg== X-Gm-Message-State: AOAM532AyETqxBOre8qfs7X7WnqiRJQhbh3FJyaKtTs0T/nTG/9BnsxL AWUW4wmRdL7EDrXwuQN+DczyzQ== X-Google-Smtp-Source: ABdhPJx5ZJux5WyOu9icq74PEEkDq20mynj0osGwxVYFvb5SgcZMFB2L8zQjL3GioB4vEN4RkmzRwA== X-Received: by 2002:adf:ecce:: with SMTP id s14mr26837602wro.154.1593607644283; Wed, 01 Jul 2020 05:47:24 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:23 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Adrian Hunter , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com Subject: [PATCH 15/15] mmc: host: sdhci-iproc: Tell the compiler that ACPI functions may not be used Date: Wed, 1 Jul 2020 13:47:02 +0100 Message-Id: <20200701124702.908713-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ... as is the case when !CONFIG_ACPI. Fixes the following W=1 kernel build warning: mmc/host/sdhci-iproc.c:297:36: warning: ‘sdhci_iproc_acpi_ids’ defined but not used [-Wunused-const-variable=] Cc: Adrian Hunter Cc: Ray Jui Cc: Scott Branden Cc: bcm-kernel-feedback-list@broadcom.com Signed-off-by: Lee Jones --- drivers/mmc/host/sdhci-iproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c index 225603148d7de..9c7d130205edd 100644 --- a/drivers/mmc/host/sdhci-iproc.c +++ b/drivers/mmc/host/sdhci-iproc.c @@ -294,7 +294,7 @@ static const struct of_device_id sdhci_iproc_of_match[] = { }; MODULE_DEVICE_TABLE(of, sdhci_iproc_of_match); -static const struct acpi_device_id sdhci_iproc_acpi_ids[] = { +static const struct acpi_device_id __maybe_unused sdhci_iproc_acpi_ids[] = { { .id = "BRCM5871", .driver_data = (kernel_ulong_t)&iproc_cygnus_data }, { .id = "BRCM5872", .driver_data = (kernel_ulong_t)&iproc_data }, { /* sentinel */ }