From patchwork Fri Jan 15 18:12:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366108 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F618C433DB for ; Fri, 15 Jan 2021 18:14:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7125223A58 for ; Fri, 15 Jan 2021 18:14:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732223AbhAOSOB (ORCPT ); Fri, 15 Jan 2021 13:14:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726541AbhAOSN7 (ORCPT ); Fri, 15 Jan 2021 13:13:59 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27042C061793 for ; Fri, 15 Jan 2021 10:13:19 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id 7so2965445wrz.0 for ; Fri, 15 Jan 2021 10:13:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i/V01bC2aUdNKYNoe3MIVez12Kd/PhheE7jFqPPyQbE=; b=tdtp5zVrXSZ9xCEWq4wDPWmDszIKiusvcCkT6+xOPlHugBuesmhOgr3x1e4Z1OvImt YBwqb6DRNCPOoNnezFV4nQx8TcVWfiHyn1lz8M4xrPH4DJi5oPAofFeKZcXTlbkFMiYC uiVEGcGwGl2hIiDmeJ1sB2lVCBzc5Yi12NMoCTclsFDsYOwl3ulgHNosfoEeFZtm4Ept TK4A8V+lCzJV4yhbrKF3ikkh+h3v2S370L1myjRFFVbW1/TKrLROLVRXtwlkevNxDDLK VonyoP1VxEhoJbflJ3z5jzdRX9JPjqbg5KlCZ0aBbZTT6bSh50NemXefSKW21TW3Fig1 8leg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i/V01bC2aUdNKYNoe3MIVez12Kd/PhheE7jFqPPyQbE=; b=ZCkbrFmCNGfIZCS/sxycQ8kiwgLGVtvYBP5filba/Z0SqpYeikGaucygqufGB1oM8z XRAbIqTwti/8QUgZqOQnaWcOGqQjhmpvfScSIyyT2QzgR0/uc4dmZ0wT0NVyRz2RenxP 3aVvLA6XscU/M19flvPcXa3XpZrR03fyE8I+I8LHl0vLbryvnpYYattHgRhiIVYYD/vZ RHWbg2PnumWzbfPlFqKlNZN1F09dl8kqYfeRV+JJ60f/iiWY5IWral7ozxI5EcFLPtW4 qeu787uPkfUDECbM51ST4SrwJ0TwYOSDObXGFosAPqjmPaUzC87CjdMEdZPYhWNFzB0f e1iQ== X-Gm-Message-State: AOAM531vB174M3KQsxum2zF8AhHfdhG4krPatu26jSphTkO56Do1kQcU togsl8YYNmWCysZEPkwwTUuhdA== X-Google-Smtp-Source: ABdhPJz8O7H223OuzeVo01mBK9mVPgrtOxBxrFaN8ZeUyDOApOAOrP68CCOYVdTVyzjFpfZ3U0kzcg== X-Received: by 2002:a5d:4307:: with SMTP id h7mr14649674wrq.353.1610734397874; Fri, 15 Jan 2021 10:13:17 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:17 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 01/40] drm/r128/r128_ioc32: Document headers do not make good kernel-doc candidates Date: Fri, 15 Jan 2021 18:12:34 +0000 Message-Id: <20210115181313.3431493-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/r128/r128_ioc32.c:2: warning: Cannot understand * file r128_ioc32.c Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/r128/r128_ioc32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/r128/r128_ioc32.c b/drivers/gpu/drm/r128/r128_ioc32.c index 6ac71755c22dd..187bdc435cb54 100644 --- a/drivers/gpu/drm/r128/r128_ioc32.c +++ b/drivers/gpu/drm/r128/r128_ioc32.c @@ -1,4 +1,4 @@ -/** +/* * \file r128_ioc32.c * * 32-bit ioctl compatibility routines for the R128 DRM. From patchwork Fri Jan 15 18:12:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366109 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2517C433E9 for ; Fri, 15 Jan 2021 18:14:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A73A23A6C for ; Fri, 15 Jan 2021 18:14:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733059AbhAOSOD (ORCPT ); Fri, 15 Jan 2021 13:14:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729312AbhAOSOA (ORCPT ); Fri, 15 Jan 2021 13:14:00 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 349C1C061794 for ; Fri, 15 Jan 2021 10:13:20 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id a9so6746400wrt.5 for ; Fri, 15 Jan 2021 10:13:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jZXgyLMN5uQO65wHWj6R5etzWm7XSdTARLD88YxZwNc=; b=Xu1ET1nmvjXAUY6crjgaR39cbqwSVmVo2ScDDgeSRVpgynPUOLLekfR/OCdafkS4hP bfhZawflBkkwYwH2VwzGuWy7DCzAd4ZXKoH/q6aLI5a8/rpVnORkJKn+QZaWpKiLlMre 9miXu/DVCub/uSXDfBagraPMWIufaRC8UzzkiGX+Z9/fOFXq0TU6jnlEkURMsIBcpd4+ cQ2RbBCZlLwZp9dPYyyKEg8yKxrNT9cAur22wGnT0TZe5xSCwkEk+9mlbIt1w5G0eexA PzPxXN5op6KJ5MhfYL7nfl0Ig7vQzhqQh3mPBU42Ge7Vdg8v6svlDSlCkajtjaeqjW5C m+DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jZXgyLMN5uQO65wHWj6R5etzWm7XSdTARLD88YxZwNc=; b=L6m1K9WdL0VuBJiB6+z8yRy/SrfpAM0zdjv4HzheOSa2vPVJsibo2XZ9V+ncXjYf2L FYiC7S1l1Tqm+zNz/hmYXYZN+Jy+3051nmqxujut13drZRjM/PFcVi1IOzhyvFSqh81Y nlpUhFMb56IrPAxgLgF7P/J2kX5uDz5d6+VmheShrp++uDbAQHarqeYHZFs4qbSgtX9A CgD1JH6nTmearB2zCwwClE/WSu0e1Rr1KdpmCVsrQbPSUqzYFqJS6iU6VhRWYZP2KKe1 a5bfXu3Bc1cjwCKEDpUxmIHni+m2RqaAm5noGyBHmTvlWaMhvIutn3JNEs3E2JZvdDic zX8g== X-Gm-Message-State: AOAM531nD7N0UUs0eaX5DXMSbEnOdxbLCGFglvsMBg66QyMMcmqmaSLR fG4fs4plEn4u9zyf7WLF1SUHey9DCE8zHs+u X-Google-Smtp-Source: ABdhPJwbDsoDCLQH6olNPLchaH7rNB+XAw15Ic2HNzwGJh633jpa3gffPWKcpLeztoyVrz5qULb4Pg== X-Received: by 2002:a5d:6a4c:: with SMTP id t12mr14481400wrw.249.1610734399016; Fri, 15 Jan 2021 10:13:19 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:18 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 02/40] drm/mga/mga_ioc32: Document headers do not make good kernel-doc candidates Date: Fri, 15 Jan 2021 18:12:35 +0000 Message-Id: <20210115181313.3431493-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/mga/mga_ioc32.c:2: warning: Cannot understand * file mga_ioc32.c Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/mga/mga_ioc32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mga/mga_ioc32.c b/drivers/gpu/drm/mga/mga_ioc32.c index 6ccd270789c6b..fd2160ea71fe1 100644 --- a/drivers/gpu/drm/mga/mga_ioc32.c +++ b/drivers/gpu/drm/mga/mga_ioc32.c @@ -1,4 +1,4 @@ -/** +/* * \file mga_ioc32.c * * 32-bit ioctl compatibility routines for the MGA DRM. From patchwork Fri Jan 15 18:12:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366112 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1DF2C433E0 for ; Fri, 15 Jan 2021 18:14:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A614A23A9C for ; Fri, 15 Jan 2021 18:14:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733135AbhAOSOI (ORCPT ); Fri, 15 Jan 2021 13:14:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728704AbhAOSOH (ORCPT ); Fri, 15 Jan 2021 13:14:07 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96A5FC061796 for ; Fri, 15 Jan 2021 10:13:21 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id y17so10189138wrr.10 for ; Fri, 15 Jan 2021 10:13:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AAulnEPH2cuzAQ+QE1skPa/vRaGeTOHaeG3APrLY8jg=; b=HWECHTiznfSDEFUnhR6yHMWFXZkOVsFdiCtVUsuRrlYB81kcXzwAYL/dwDStIkFQbq w51jc8DJRNf/zRNcDUz7Qp/4WyP5zAYg/fpQSHyDxtJItXwVBbykBTSEY16yGtHgNYmq WDXERBDxRky0v3qiA1GPoyPOHMfR1EIdghWZQChS8XWjPRnY54Tqjd70ZMF0QQT0+lyD gwvbHGqvPixJKyuEACIczrLieROzmeO0OwuSn7VJh6paOjfC+Zg1qBJLdAv0RqmcDVAn MHGs4liNHWHLfPsxNAGmfOFqwC+/Ymvm4e48P6OFyYlUp7TWoiT1E1dne1FTl4oG1nyM j18g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AAulnEPH2cuzAQ+QE1skPa/vRaGeTOHaeG3APrLY8jg=; b=CT6vAUgKvm2VgFyrC2qJLxDDg6o2ItJ6efsFqJvZU9qo+O91gzMJk7rxNBgUfuTpLS Pw9fcV7KktUXzmMlUM7w3TfnmHbfi1ja2vPncsDk5bHXELr0Ay4gmNlHfeqMdb1Mqwdm gr8OLNYRrqcr7tv82YBMJlbIfFkZ7evWxIBgI8GSTtxJDdyrBLbo5sCY//vQ/DcO1+lQ OuCZB7Q9xRLtPHdExI1z6wIGKqDSHzithzyjT9OyQzKBiEX0GmR51QtEJX4bSCMrYh3s 90bwNnJH3R4uyp/OnNlzRe7mEcRheU9jpPTi4PAThBETHanTZGpkW35DF7S0fwz8K++J RkPw== X-Gm-Message-State: AOAM530trRQGjbsJO8mnUAtXagA4fy/YdlQLE2r2x5vdJnquKlCR9hn1 bzj9B1YBCCC4Q8/z9guUK9Jphw== X-Google-Smtp-Source: ABdhPJxS5DDz/LrbHmVTRLmNNrAP1IxGxPNtOjay7UALuZFFZxw7VAsR+DZe5/ZFYW30mbDBKfoydw== X-Received: by 2002:a5d:6cd4:: with SMTP id c20mr14443657wrc.57.1610734400384; Fri, 15 Jan 2021 10:13:20 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:19 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH 03/40] drm/vmwgfx/vmwgfx_execbuf: Fix some kernel-doc related issues Date: Fri, 15 Jan 2021 18:12:36 +0000 Message-Id: <20210115181313.3431493-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:89: warning: Enum value 'vmw_res_rel_max' not described in enum 'vmw_resource_relocation_type' drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:136: warning: Function parameter or member 'func' not described in 'vmw_cmd_entry' drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:136: warning: Function parameter or member 'cmd_name' not described in 'vmw_cmd_entry' drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:212: warning: Function parameter or member 'res' not described in 'vmw_cmd_ctx_first_setup' drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:523: warning: Function parameter or member 'sw_context' not described in 'vmw_resource_relocation_add' drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:523: warning: Excess function parameter 'list' description in 'vmw_resource_relocation_add' drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:653: warning: Function parameter or member 'p_res' not described in 'vmw_cmd_res_check' drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:653: warning: Excess function parameter 'p_val' description in 'vmw_cmd_res_check' drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:1716: warning: Function parameter or member 'res' not described in 'vmw_cmd_res_switch_backup' drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:1716: warning: Excess function parameter 'val_node' description in 'vmw_cmd_res_switch_backup' drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3757: warning: Function parameter or member 'file_priv' not described in 'vmw_execbuf_fence_commands' drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3757: warning: Function parameter or member 'dev_priv' not described in 'vmw_execbuf_fence_commands' drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3757: warning: Function parameter or member 'p_fence' not described in 'vmw_execbuf_fence_commands' drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3757: warning: Function parameter or member 'p_handle' not described in 'vmw_execbuf_fence_commands' drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3954: warning: Function parameter or member 'kernel_commands' not described in 'vmw_execbuf_cmdbuf' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c index 462f173207085..7a24196f92c38 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c @@ -80,7 +80,8 @@ struct vmw_relocation { * with a NOP. * @vmw_res_rel_cond_nop: Conditional NOP relocation. If the resource id after * validation is -1, the command is replaced with a NOP. Otherwise no action. - */ + * @vmw_res_rel_max: Last value in the enum - used for error checking +*/ enum vmw_resource_relocation_type { vmw_res_rel_normal, vmw_res_rel_nop, @@ -122,9 +123,11 @@ struct vmw_ctx_validation_info { /** * struct vmw_cmd_entry - Describe a command for the verifier * + * @func: Call-back to handle the command. * @user_allow: Whether allowed from the execbuf ioctl. * @gb_disable: Whether disabled if guest-backed objects are available. * @gb_enable: Whether enabled iff guest-backed objects are available. + * @cmd_name: Name of the command. */ struct vmw_cmd_entry { int (*func) (struct vmw_private *, struct vmw_sw_context *, @@ -203,6 +206,7 @@ static void vmw_bind_dx_query_mob(struct vmw_sw_context *sw_context) * * @dev_priv: Pointer to the device private: * @sw_context: The command submission context + * @res: Pointer to the resource * @node: The validation node holding the context resource metadata */ static int vmw_cmd_ctx_first_setup(struct vmw_private *dev_priv, @@ -509,7 +513,7 @@ static int vmw_resource_context_res_add(struct vmw_private *dev_priv, /** * vmw_resource_relocation_add - Add a relocation to the relocation list * - * @list: Pointer to head of relocation list. + * @sw_context: Pointer to the software context. * @res: The resource. * @offset: Offset into the command buffer currently being parsed where the id * that needs fixup is located. Granularity is one byte. @@ -639,7 +643,7 @@ static int vmw_resources_reserve(struct vmw_sw_context *sw_context) * @converter: User-space visisble type specific information. * @id_loc: Pointer to the location in the command buffer currently being parsed * from where the user-space resource id handle is located. - * @p_val: Pointer to pointer to resource validalidation node. Populated on + * @p_res: Pointer to pointer to resource validalidation node. Populated on * exit. */ static int @@ -1700,7 +1704,7 @@ static int vmw_cmd_check_define_gmrfb(struct vmw_private *dev_priv, * * @dev_priv: Pointer to a device private struct. * @sw_context: The software context being used for this batch. - * @val_node: The validation node representing the resource. + * @res: Pointer to the resource. * @buf_id: Pointer to the user-space backup buffer handle in the command * stream. * @backup_offset: Offset of backup into MOB. @@ -3739,7 +3743,7 @@ static int vmw_resize_cmd_bounce(struct vmw_sw_context *sw_context, return 0; } -/** +/* * vmw_execbuf_fence_commands - create and submit a command stream fence * * Creates a fence object and submits a command stream marker. @@ -3939,9 +3943,9 @@ static int vmw_execbuf_submit_cmdbuf(struct vmw_private *dev_priv, * On successful return, the function returns a pointer to the data in the * command buffer and *@header is set to non-NULL. * - * If command buffers could not be used, the function will return the value of - * @kernel_commands on function call. That value may be NULL. In that case, the - * value of *@header will be set to NULL. + * @kernel_commands: If command buffers could not be used, the function will + * return the value of @kernel_commands on function call. That value may be + * NULL. In that case, the value of *@header will be set to NULL. * * If an error is encountered, the function will return a pointer error value. * If the function is interrupted by a signal while sleeping, it will return From patchwork Fri Jan 15 18:12:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366113 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16DB6C433E0 for ; Fri, 15 Jan 2021 18:15:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6D7623A58 for ; Fri, 15 Jan 2021 18:15:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387544AbhAOSOk (ORCPT ); Fri, 15 Jan 2021 13:14:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733304AbhAOSOi (ORCPT ); Fri, 15 Jan 2021 13:14:38 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC857C061798 for ; Fri, 15 Jan 2021 10:13:22 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id w5so10179630wrm.11 for ; Fri, 15 Jan 2021 10:13:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=A6joXVovshGu0VUNPPEN8i/itJp2RBRid6Z1nZigsRg=; b=EXlvQ1xkuYaB0Z7MdEmm5WdvyxotwscXh8F9NHedDJhTWXPeZU2gdBVPYu2OMHO23K dJ1ancfIwxMzShrNifaoMD53u0iTsFUFLLs6DAH9RK+2Q52Dm1lQUbrkxG0psDGfvKZQ 1q23GTqrN2ZlUI1/IGj7veXKtmNjfJrkK8xDHtZ4QHbvzK4yxaf0me/Bu1PmlP/rH1D5 HjTLgfrnW1un6iLvAUuHfNUXBa5aGyYYh68Akri/+EqvSmQqc3TTb0ka82S/NodzUXbi 50Fpepn8Iu6zfCgWWi5e2tJ4pPnKvyPkYTsgOxqzq3X5UIpDk/eC4DdZt0G0SexixD7z o0kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=A6joXVovshGu0VUNPPEN8i/itJp2RBRid6Z1nZigsRg=; b=kGn6SM2jR6xwM+/qgH2J1Akjbg2ZPlAvf0qj5/fe0LBPXp1+Loo8hOs9BU3BUA9BnC hlqsWOZRUppDIW0dZzpQJI163ppjvlhtYOObq58MlNMYHdS2lL/lxn2eeSAYCsMCe0VV H2/nVY2o7fqKlUaeaNAry63xUqfRP4Ht1pAWpFkEEbcvXKPiTpqH4UBvnXRYnz72PWKQ mTmumbf3EINIw+d/t7sD2ShyaofhJ3WBAfBBJNgZwsmGPMQXjRv0pG0wFhJsQHWNJ/bt 6boaGuw34YVI9KC2atI/EmuTiem5/9z/wQ4jGt1kSU2879IR6+dY5sk0oCNbxC90vQGY H30g== X-Gm-Message-State: AOAM532/JOFqv/h986dkEtdVo55kW/MqNUy5Ot8IAkGyswEtx6hgRw1c p8eA7wGAuaFiBYx7dX87YxHXSw== X-Google-Smtp-Source: ABdhPJzBkaanuNrwj5IIxpOf2GYlr9KoLi6NwQlWpRiq8dPyjtOk8hCZpIdDhOd8/ew2D5/WlxQr4A== X-Received: by 2002:adf:eac7:: with SMTP id o7mr14550950wrn.23.1610734401637; Fri, 15 Jan 2021 10:13:21 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:21 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 04/40] drm/vmwgfx/vmwgfx_kms: Remove unused variable 'ret' from 'vmw_du_primary_plane_atomic_check()' Date: Fri, 15 Jan 2021 18:12:37 +0000 Message-Id: <20210115181313.3431493-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_kms.c: In function ‘vmw_du_primary_plane_atomic_check’: drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:460:31: warning: variable ‘vcs’ set but not used [-Wunused-but-set-variable] Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index 9a89f658e501c..9293dc19a7683 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c @@ -453,10 +453,9 @@ int vmw_du_primary_plane_atomic_check(struct drm_plane *plane, if (!ret && new_fb) { struct drm_crtc *crtc = state->crtc; - struct vmw_connector_state *vcs; struct vmw_display_unit *du = vmw_crtc_to_du(crtc); - vcs = vmw_connector_state_to_vcs(du->connector.state); + vmw_connector_state_to_vcs(du->connector.state); } From patchwork Fri Jan 15 18:12:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366114 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68AFFC43381 for ; Fri, 15 Jan 2021 18:15:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4159E23A58 for ; Fri, 15 Jan 2021 18:15:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387674AbhAOSOn (ORCPT ); Fri, 15 Jan 2021 13:14:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733306AbhAOSOi (ORCPT ); Fri, 15 Jan 2021 13:14:38 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BAF4C061799 for ; Fri, 15 Jan 2021 10:13:24 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id m4so10183264wrx.9 for ; Fri, 15 Jan 2021 10:13:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=K2J3GjpOO3HekYRLC9b6PVtgl9N3gd4w+azAVwpWeog=; b=LxwyehuC8GrWwvLbGs+Rh5yjqTjMc92zt0+XsCWcB2L6OviLjYZJ+vhBjbplszNCXn g6TyGID0z2rgR55jgd2irYjclgl+gS0Jqnisd8W2QFF8g1EtL6hZu2p57vGbErjXtCbh FQB1weosVOThVbi05jFtscL+11qNHfhw1DZfFu4Rqp22rz+Q2TxSRx9vgqHlaaH2pQjx r5LyEptMvzxNzv/Au4o2h/UsGeDxr/p7tv9/ip9axINBqq9d/tuojLnV4JwHHFYOgL67 zn36WMzXqgJ+z8DBDANHuLJcsV4OOEsOCWwOYWfeoRnL6u0C1MZjtX0kdt8k8KHMCIs8 gGGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=K2J3GjpOO3HekYRLC9b6PVtgl9N3gd4w+azAVwpWeog=; b=kcN3Jox6QGv68VghttYtDK1GvuLOAxvwTweU8GovXOWLx+ruP/OqXhuB1+abEhCeS/ zs3A9PmVNrac86hIB2WLIS2gwxs2+YwnRpQYoHdd1T1Y2kr9M4ck6CU5qgV0WwhgA09O L1kO4TWdRamn3E6JOU90m2m5wtrApWuL7FArJk9WkPCNoQKNljNLdEFEkF/7q5uPAIw3 hpRWfXpcmcFdf9Y126qFL+U0L1NWBe80NG4i5g/1Wn9E1HbwCsPzikuacqdLp2H3A7L1 dsKYRVhbK4N0r98Hc3rde8TD3Q4NiznPHOfhkK+809MeRJbmc5BpHj+NHqVdZKHgmpEN cQ5w== X-Gm-Message-State: AOAM530Ibvo6ccYf2+ZIxF7g9C4UaIcOIFubQ2J/QnqelXRVF9fIJ5yn 09DqbCI4JH2nlX01zUo+W5g4aA== X-Google-Smtp-Source: ABdhPJwFsstq3kKhxXDJeD6jx43iN+/htYNp695e9BAORta+J3PbuXxbkAN7oi9iI0hB/Ug9WYwRQw== X-Received: by 2002:a5d:6884:: with SMTP id h4mr14406677wru.174.1610734403031; Fri, 15 Jan 2021 10:13:23 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:22 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 05/40] drm/r128/r128_ioc32: Fix formatting issues in 'r128_compat_ioctl()'s header Date: Fri, 15 Jan 2021 18:12:38 +0000 Message-Id: <20210115181313.3431493-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/r128/r128_ioc32.c:182: warning: Function parameter or member 'filp' not described in 'r128_compat_ioctl' drivers/gpu/drm/r128/r128_ioc32.c:182: warning: Function parameter or member 'cmd' not described in 'r128_compat_ioctl' drivers/gpu/drm/r128/r128_ioc32.c:182: warning: Function parameter or member 'arg' not described in 'r128_compat_ioctl' Cc: David Airlie Cc: Daniel Vetter Cc: Lee Jones Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/r128/r128_ioc32.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/r128/r128_ioc32.c b/drivers/gpu/drm/r128/r128_ioc32.c index 187bdc435cb54..cdeb1db872226 100644 --- a/drivers/gpu/drm/r128/r128_ioc32.c +++ b/drivers/gpu/drm/r128/r128_ioc32.c @@ -170,13 +170,13 @@ drm_ioctl_compat_t *r128_compat_ioctls[] = { }; /** - * Called whenever a 32-bit process running under a 64-bit kernel - * performs an ioctl on /dev/dri/card. + * r128_compat_ioctl - Called whenever a 32-bit process running under + * a 64-bit kernel performs an ioctl on /dev/dri/card. * - * \param filp file pointer. - * \param cmd command. - * \param arg user argument. - * \return zero on success or negative number on failure. + * @filp: file pointer. + * @cmd: command. + * @arg: user argument. + * return: zero on success or negative number on failure. */ long r128_compat_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) { From patchwork Fri Jan 15 18:12:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366174 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F809C433E9 for ; Fri, 15 Jan 2021 18:20:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F22323B09 for ; Fri, 15 Jan 2021 18:20:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387630AbhAOSOm (ORCPT ); Fri, 15 Jan 2021 13:14:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733311AbhAOSOi (ORCPT ); Fri, 15 Jan 2021 13:14:38 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C84CC06179A for ; Fri, 15 Jan 2021 10:13:25 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id w5so10179738wrm.11 for ; Fri, 15 Jan 2021 10:13:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gpHmuC5+6mrLTxCF96eU2jys1HshdL5VNQtWWDrXTEc=; b=xZIH7SwI6Fbbu2RKOQ3Emd0mDzyDXntheoo+T/kqfqEo8d5VJgHNI0gYye37CB7WwI T6Fqnprv+zHjajpyH+7J0eE5X89LiDsWKh5p43VT1uK9niZVeF6c2ks6yd0LI0mwPPv8 /tL+KSim+ajMJwBegccStwEHWZ1+94Afsz2yZfzsFiY62lLvOwgL8K1v0HSWBV639nfT Mg3WUxmoypi+KvEVm8XlnUdWMmqkKeZPi8NjMHjMZl1XahqRv9TuxFvWZmGVUZH4pRoN 6RfeHl6eHVpW7LExiU4xc1myTcYTPV+jR+p/7A6R3RYscZAwo9BMPmDKFkZoqkQesHRV FeLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gpHmuC5+6mrLTxCF96eU2jys1HshdL5VNQtWWDrXTEc=; b=sLs6laTDC5WRPkx1AudbfX4Zjp9Bmd1x0E2UhjTJoembB3onrOmFbqiFMFIt6TzTvX zTMIF7HUdt9uNXtd7LMK7M74oQ68oH5uMMDSP2UlTnwaucSxCo9bwsxNdZq7vYYAfa+l kkxYKH4f4JWFUFgKK56Dkup8b5bMAxI/pOa+AIzx0kKp0BhqrtxaQ/Bky0fT/QOPpPaZ 65GJDNHMl6gFPbzdaenk3qL5qidRh/EibGCjKJPlEWpdVEblO6mnS7D30GfV/1Ul+vXg slWOT1KZtSD58noQHITvFQH9IwAhujecJvLsus/DZL4rbAqkUlQnP8u1VYv6L3QAQrRk sMXQ== X-Gm-Message-State: AOAM530qNuRqyhYJ7tR/lmsFEFY2OE5wcHDoE/L1g1Hpr+y/gs60UY3l hNurGtYv3Btj8CHl0ySzjHVUs+4VyXcojfPI X-Google-Smtp-Source: ABdhPJz1rIOt/fxVq/kJAg8SWgzfhLOw/V4zUIlwuFz/czfyJGKZv2ghuwQDTzYqMiJpet5Er7cJwg== X-Received: by 2002:adf:c444:: with SMTP id a4mr10945203wrg.164.1610734404198; Fri, 15 Jan 2021 10:13:24 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:23 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 06/40] drm/mga/mga_ioc32: Fix some formatting issues in 'mga_compat_ioctl's header Date: Fri, 15 Jan 2021 18:12:39 +0000 Message-Id: <20210115181313.3431493-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/mga/mga_ioc32.c:171: warning: Function parameter or member 'filp' not described in 'mga_compat_ioctl' drivers/gpu/drm/mga/mga_ioc32.c:171: warning: Function parameter or member 'cmd' not described in 'mga_compat_ioctl' drivers/gpu/drm/mga/mga_ioc32.c:171: warning: Function parameter or member 'arg' not described in 'mga_compat_ioctl' Cc: David Airlie Cc: Daniel Vetter Cc: Lee Jones Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/mga/mga_ioc32.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/mga/mga_ioc32.c b/drivers/gpu/drm/mga/mga_ioc32.c index fd2160ea71fe1..4fd4de16cd328 100644 --- a/drivers/gpu/drm/mga/mga_ioc32.c +++ b/drivers/gpu/drm/mga/mga_ioc32.c @@ -159,13 +159,13 @@ static struct { }; /** - * Called whenever a 32-bit process running under a 64-bit kernel - * performs an ioctl on /dev/dri/card. + * mga_compat_ioctl - Called whenever a 32-bit process running under + * a 64-bit kernel performs an ioctl on /dev/dri/card. * - * \param filp file pointer. - * \param cmd command. - * \param arg user argument. - * \return zero on success or negative number on failure. + * @filp: file pointer. + * @cmd: command. + * @arg: user argument. + * return: zero on success or negative number on failure. */ long mga_compat_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) { From patchwork Fri Jan 15 18:12:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366175 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC799C433E0 for ; Fri, 15 Jan 2021 18:20:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8018423AA7 for ; Fri, 15 Jan 2021 18:20:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387593AbhAOSOm (ORCPT ); Fri, 15 Jan 2021 13:14:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387406AbhAOSOi (ORCPT ); Fri, 15 Jan 2021 13:14:38 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4E91C06179B for ; Fri, 15 Jan 2021 10:13:26 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id 6so2903798wri.3 for ; Fri, 15 Jan 2021 10:13:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8fzZ9731GhrMXMJmVGpMkWndZV2lCJZqnwJ5TjxPTSs=; b=VLv18T//m35e1+2dIqkH1SvDm6ep+u85+YiYVoBayhkJq0Fo5kGhkzJednDi3CEhS7 MQMCgq3ZXwij7qecAqGBES8zNlTtzDwbYxWmLwEVtInsV/7/5s8HK9SYgD0+YImGxUZa d4zqkA/OoYXoywIjLGYOiLiTdT/4vjUgOPBlhH+jOShM1ppshX1o44aHw0lgrwwS8R2b oSXF5ldU70vZ/ypBG955toEAbw+ie77kqQE90uSIs1cywTgldkiFsA8Isapd7EhNL2n7 zsQg/SAPRlcjSRyJlBVIRYvUCkm3Cn0ipnW5cE3CWA0KLOnp18viSfxPwMGN1JZ3r3/O 2M9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8fzZ9731GhrMXMJmVGpMkWndZV2lCJZqnwJ5TjxPTSs=; b=hdL92i3e6NKuuGfmYD9gCqPwFu2lRm04ViNNzxwpWcG5aoUl79mqP8pXw8vcUmQCJZ ZtMrFdT+0DroYR5mNk/UbAUOTjR32UpO2vkpvxCXsduDngIGhC9UFN4JePnWqkB75f+f L07wj3VsDSo/Wu+iBomlVKWfsUeQVmCW8QRDGmINKtIUNGwCjO1RnKUU1x9QCDKXIvR+ DZxSf8V01LGmxm5murTpRAv9UPgmK13gg37Elhh6BPUlgcrFRm96pIMaU5KMqGeLVc2b 5+gzrfo3++TKvkbUbcM9fiAKiCrmiU7OkLwujJ/ACoroDSMl06ElCdoH4RVceJoHr3v1 0KNA== X-Gm-Message-State: AOAM530E4QW5qBYqkCcwIDULfVPtL2VdBBnnrZ60j/OWB3dmEv/fM8Ia /KUrP5eN+f6ZWl8kPFEUJmL7nw== X-Google-Smtp-Source: ABdhPJznA2Wl1YFrtzDKMYW3dwJozKm8ADSN2o2+NRpfU8ADN4jG/jJu9XTqYIIxlotvF69iQ1C55Q== X-Received: by 2002:adf:ab56:: with SMTP id r22mr14631360wrc.351.1610734405570; Fri, 15 Jan 2021 10:13:25 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:24 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 07/40] drm/vmwgfx/vmwgfx_kms: Mark vmw_{cursor,primary}_plane_formats as __maybe_unused Date: Fri, 15 Jan 2021 18:12:40 +0000 Message-Id: <20210115181313.3431493-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:256:23: warning: ‘vmw_cursor_plane_formats’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:248:23: warning: ‘vmw_primary_plane_formats’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:256:23: warning: ‘vmw_cursor_plane_formats’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:248:23: warning: ‘vmw_primary_plane_formats’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:256:23: warning: ‘vmw_cursor_plane_formats’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:248:23: warning: ‘vmw_primary_plane_formats’ defined but not used [-Wunused-const-variable=] Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.h b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.h index 03f3694015cec..6267ccf54944e 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.h +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.h @@ -245,7 +245,7 @@ struct vmw_framebuffer_bo { }; -static const uint32_t vmw_primary_plane_formats[] = { +static const uint32_t __maybe_unused vmw_primary_plane_formats[] = { DRM_FORMAT_XRGB1555, DRM_FORMAT_RGB565, DRM_FORMAT_RGB888, @@ -253,7 +253,7 @@ static const uint32_t vmw_primary_plane_formats[] = { DRM_FORMAT_ARGB8888, }; -static const uint32_t vmw_cursor_plane_formats[] = { +static const uint32_t __maybe_unused vmw_cursor_plane_formats[] = { DRM_FORMAT_ARGB8888, }; From patchwork Fri Jan 15 18:12:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366179 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EB3FC4332B for ; Fri, 15 Jan 2021 18:20:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E62923A5E for ; Fri, 15 Jan 2021 18:20:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388573AbhAOSUf (ORCPT ); Fri, 15 Jan 2021 13:20:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387484AbhAOSOj (ORCPT ); Fri, 15 Jan 2021 13:14:39 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C091C061757 for ; Fri, 15 Jan 2021 10:13:28 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id h17so8028338wmq.1 for ; Fri, 15 Jan 2021 10:13:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eZ4SXqHjDfEhTUNGWQvOBhYeab3UcCqVCuaDiiVfWAQ=; b=fSoRh3q4uz6YIds/3B+belP3eN9OBqn0u5m7KCnG8CbRMmEvaqB7U80UUa6QIW3gTh kjqT2NQYZK2IbR+DpvFCnwsVGmUveVCyBZYD6Dyr212ln1LTaB2qGLUx2J5d8EutCb/p fVS8KDR4Dg2VQ+mK6CRyyfsRi/s5yrSTcl4jKymczHxftpNGvUcODxvmxtTJk0ph3XO1 LohbVA6FPotDa1Hq2Dqj9DUrzWgCaSynqxdoHmVrt8dEmxtfuidOplLkYDk2zJ87+D4E Hh7hHNDbC85FOcWHYZYJKcgJOcs0Pdhd1i85xa66akt6YUzqQ/0jFcH+/aDf8gBFU2Vi DOyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eZ4SXqHjDfEhTUNGWQvOBhYeab3UcCqVCuaDiiVfWAQ=; b=uNCLvSNi3PbYGUZ1+NZdSbJHJxF8sUOIg6T+D5fqo2Q01vmOlaY5zDwkGuuJ5IRp5g 9whgDUTtNAfXMThwqKzxZ0oYhS+qVALWm76j8ZbLYYpPm3wyzeao9LjiNJuOr/J7JExN y7nR5HMPieavlB4wr4hVFqqvfbzebSgbHtXKF8zVnRcrg4P5PDgbWfggQu7UiJB86863 TUm2nP8GRk99mHv17ch/JPRu+zfgrIVV7LGuDF54bx9sM9iF6wKCMoffX0thFgegBSHc rPlzfuLEAcxPHLC1+/1spoA/QZ1xXzXxBf2lK1zpGdtBMOio6Qikilef2Ih0BtwkQ95u 1DoA== X-Gm-Message-State: AOAM530+i+SodJFUum3DYLYwcxCYR2Lb2wtd/UnL+WwVicxGveiR2qOV wVcgUEl0E4K8rzVPtUvNlYZ0hg== X-Google-Smtp-Source: ABdhPJyaMwGma3U8BAl3CJHR4ESpN+NLARQ+4qCjJY0g6+kivNVYS2BSZ8FkjhlA05W7/6smJjC3uQ== X-Received: by 2002:a7b:ce92:: with SMTP id q18mr9611096wmj.113.1610734407001; Fri, 15 Jan 2021 10:13:27 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:26 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 08/40] drm/vmwgfx/vmwgfx_drv: Fix some kernel-doc misdemeanours Date: Fri, 15 Jan 2021 18:12:41 +0000 Message-Id: <20210115181313.3431493-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:164: warning: Function parameter or member 'ioctl' not described in 'VMW_IOCTL_DEF' drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:164: warning: Function parameter or member 'func' not described in 'VMW_IOCTL_DEF' drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:164: warning: Function parameter or member 'flags' not described in 'VMW_IOCTL_DEF' drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:170: warning: cannot understand function prototype: 'const struct drm_ioctl_desc vmw_ioctls[] = ' drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:542: warning: Function parameter or member 'dev_priv' not described in 'vmw_get_initial_size' drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:611: warning: Function parameter or member 'dev_priv' not described in 'vmw_dma_masks' drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:611: warning: Excess function parameter 'dev' description in 'vmw_dma_masks' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c index 8c3eb00e8b54d..a77b70347aab0 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c @@ -153,7 +153,7 @@ DRM_IOWR(DRM_COMMAND_BASE + DRM_VMW_MSG, \ struct drm_vmw_msg_arg) -/** +/* * The core DRM version of this macro doesn't account for * DRM_COMMAND_BASE. */ @@ -161,7 +161,7 @@ #define VMW_IOCTL_DEF(ioctl, func, flags) \ [DRM_IOCTL_NR(DRM_IOCTL_##ioctl) - DRM_COMMAND_BASE] = {DRM_IOCTL_##ioctl, flags, func} -/** +/* * Ioctl definitions. */ @@ -526,7 +526,7 @@ static void vmw_release_device_late(struct vmw_private *dev_priv) vmw_fifo_release(dev_priv, &dev_priv->fifo); } -/** +/* * Sets the initial_[width|height] fields on the given vmw_private. * * It does so by reading SVGA_REG_[WIDTH|HEIGHT] regs and then @@ -599,7 +599,7 @@ static int vmw_dma_select_mode(struct vmw_private *dev_priv) /** * vmw_dma_masks - set required page- and dma masks * - * @dev: Pointer to struct drm-device + * @dev_priv: Pointer to struct drm-device * * With 32-bit we can only handle 32 bit PFNs. Optionally set that * restriction also for 64-bit systems. From patchwork Fri Jan 15 18:12:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366178 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F9F0C4332E for ; Fri, 15 Jan 2021 18:20:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07B2B23A58 for ; Fri, 15 Jan 2021 18:20:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388293AbhAOSUe (ORCPT ); Fri, 15 Jan 2021 13:20:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387486AbhAOSOj (ORCPT ); Fri, 15 Jan 2021 13:14:39 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C14D6C06179C for ; Fri, 15 Jan 2021 10:13:29 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id m187so1957167wme.2 for ; Fri, 15 Jan 2021 10:13:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sDWfHFckN6NRo0EoYWwvHoK4Npcgdey+k/hT6ivHjRc=; b=SjYJ2xl8Kpk+haoC/WNAe19ka70TzQyHnukPq1XElB5bfIleTUP+UyDJS8Gh4FQj5Z Kl2nKN4tGIrvVbBS1KuO9xZxIrei4eyCFBrW4gl5Y0oDQr0EY0no4iJLSEtH6jmo9qo3 LDjQcjt2A3sPpH5f5PMAgHzA68Hz1sCGX6dL9/S/J+1zUi6h6DsewtD6AiabgNcx7w7D 7XMzT1titKw7oaDP9ZWGVFoddv0NNblbjqZXv6KKEXg2ZOrsSu1d8j9RLIz5Hon1OCHR /4Er5YRgwio31zKplqQDl3c9YYzA2n9JYh1VcNUDjKs5HO2nkEDlcJ+iXzcxXz2RqvFx ZAJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sDWfHFckN6NRo0EoYWwvHoK4Npcgdey+k/hT6ivHjRc=; b=RTZZL1KuMk2dsSoDU6qUSJRjhXBby7VJubyBMhW9VUqVYn5C5n2PEzGlNoTbRzXgSP 4s/aB0z08PZkI8AiVpAquanffbqPeo5ia3gJSdztA4J7RLUp3DnRNtY8bzTm7rVuS4x8 2bmDEg88b3abPxTKy3ONwECs4WvhShZciGxdEdN15XXXdp8UjmkdZxBI0mlvK1wK+69W F8X8U4tSWNJYDeLuYzTAC7rxCag5I5OFFp0Tn4HxXYYMLfXjIv45qCb2ABrGpOkoe7rr O4g72/1cnYhTfZHyFqJE8vMXEeXARb1JKLM2Z+OORkYz/N0l1aoEAvZvGHIwdCn41St9 1Odg== X-Gm-Message-State: AOAM5327u3ryvEhv/A3uCWSHhK1Fu8NpkAEIs7Zg0PpbAKbR5doNsuH3 cXQMryuPCtD8Kx+aZkYUjsjd3A== X-Google-Smtp-Source: ABdhPJzUCTGJPA/AxjzKMvGf7/YaN9xsQPUWPThrY+PvTWZnODZjT1Fb00+0QiDkBK7HxjMNPb4d+A== X-Received: by 2002:a7b:c385:: with SMTP id s5mr9872346wmj.170.1610734408578; Fri, 15 Jan 2021 10:13:28 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:27 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 09/40] drm/vmwgfx/vmwgfx_ioctl: Provide missing '@' sign required by kernel-doc Date: Fri, 15 Jan 2021 18:12:42 +0000 Message-Id: <20210115181313.3431493-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c:30: drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c:448: warning: Function parameter or member 'offset' not described in 'vmw_fops_read' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c index 80af8772b8c24..b36032964b2fe 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c @@ -437,7 +437,7 @@ __poll_t vmw_fops_poll(struct file *filp, struct poll_table_struct *wait) * @filp: See the linux fops read documentation. * @buffer: See the linux fops read documentation. * @count: See the linux fops read documentation. - * offset: See the linux fops read documentation. + * @offset: See the linux fops read documentation. * * Wrapper around the drm_read function that makes sure the device is * processing the fifo if drm_read decides to wait. From patchwork Fri Jan 15 18:12:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366176 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60399C433E0 for ; Fri, 15 Jan 2021 18:20:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C98C222B3 for ; Fri, 15 Jan 2021 18:20:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388258AbhAOSUG (ORCPT ); Fri, 15 Jan 2021 13:20:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733304AbhAOSOl (ORCPT ); Fri, 15 Jan 2021 13:14:41 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37F56C06179E for ; Fri, 15 Jan 2021 10:13:31 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id e15so1995632wme.0 for ; Fri, 15 Jan 2021 10:13:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=o+NaOzslIuLS5J9pNZb4fvgzik/FyZn/jqm9ZPQuWdU=; b=gcPt2Yf87b/ShsbMtAB8DSJHWxzobsp+uEVJTJI8p8rCo2GuGHF5+eKwGBC0VlyZ90 KDq7HXSj5S5B5z9bM2lVkWFOT+UmimXzXqfmrecElufbv02xRhPOpxQg7CcLG8e+U+ah C9Kpj3hgXdSl0ykXUVVW9CjYz6qDFtjFEVaVW8Zgl+qJsPUsHaQV1vUkEgdMXHD1LMOS lkIXZiIMAMNE+cU+Ll0q/wWAvibFwPRmW6z7fGevaAskVyng7rIdQnkX1n86PRss8Bl5 RSwJ215w8Wz6Q1NxFC80W47W5e146q5CCR/k4Wc5N+wJNIFR+LA1WsGr9Jn2ZBSLwh3R R+JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=o+NaOzslIuLS5J9pNZb4fvgzik/FyZn/jqm9ZPQuWdU=; b=YpdndgHDc4+pELSDd8lHOhTI6RvLt4QOi1vFz3PfLo0VJGB7hZ2x5G18kt6XeWPcu+ iOds+3m9X5gFP+giQwuxdVxem8DSiaSbxdCRfmwc3V3trwvLZlhEI4NPmgp8yFbYQ8SR ZPObFSaS1Df3HKRBeJTiXS7mcToc2piL2O7HEtYbDc8BtaOBsKu5TtyV01XxJ5Vo7tCB Tv/VoeK10eFeXqa2Ffv3Baafqt2JeaiK/v3QJsLh5pVUV6FzZDYTNSq73x3xk9DjHQJL UxYt9Z+DMqHkB72kglHoWzvy9KnZnHYoweIjriZyB5RkMJgZkw5IGFy0BzNevaLNFfZA UKLQ== X-Gm-Message-State: AOAM5302atmc0tCX0Q8AIz/cGnKEW6NuzSCtPcJjPcXXHA3Ywc3zyO9U Mn9/vk2PpvX4fjhd3lLMN03K4g== X-Google-Smtp-Source: ABdhPJzGeywxTj78fCoWwOftGOvl39aKwyJAUaPf5IIxOSdz6of+4VeNXyJx53GaVOJfH7xZcWlJkw== X-Received: by 2002:a1c:de09:: with SMTP id v9mr10274031wmg.0.1610734409886; Fri, 15 Jan 2021 10:13:29 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:29 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 10/40] drm/vmwgfx/vmwgfx_resource: Fix worthy function headers demote some others Date: Fri, 15 Jan 2021 18:12:43 +0000 Message-Id: <20210115181313.3431493-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:215: warning: Excess function parameter 'obj_type' description in 'vmw_resource_init' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:303: warning: Excess function parameter 'p_res' description in 'vmw_user_resource_noref_lookup_handle' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:328: warning: Function parameter or member 'dev_priv' not described in 'vmw_user_lookup_handle' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:328: warning: Function parameter or member 'tfile' not described in 'vmw_user_lookup_handle' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:328: warning: Function parameter or member 'handle' not described in 'vmw_user_lookup_handle' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:328: warning: Function parameter or member 'out_surf' not described in 'vmw_user_lookup_handle' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:328: warning: Function parameter or member 'out_buf' not described in 'vmw_user_lookup_handle' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:398: warning: Function parameter or member 'dirtying' not described in 'vmw_resource_do_validate' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:601: warning: Function parameter or member 'interruptible' not described in 'vmw_resource_reserve' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:601: warning: Function parameter or member 'no_backup' not described in 'vmw_resource_reserve' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:987: warning: Function parameter or member 'interruptible' not described in 'vmw_resource_pin' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c b/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c index d1e7b9608145b..c4df51a2a9262 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c @@ -202,7 +202,6 @@ int vmw_resource_alloc_id(struct vmw_resource *res) * * @dev_priv: Pointer to a device private struct. * @res: The struct vmw_resource to initialize. - * @obj_type: Resource object type. * @delay_id: Boolean whether to defer device id allocation until * the first validation. * @res_free: Resource destructor. @@ -288,8 +287,6 @@ int vmw_user_resource_lookup_handle(struct vmw_private *dev_priv, * @tfile: Pointer to a struct ttm_object_file identifying the caller * @handle: The TTM user-space handle * @converter: Pointer to an object describing the resource type - * @p_res: On successful return the location pointed to will contain - * a pointer to a refcounted struct vmw_resource. * * If the handle can't be found or is associated with an incorrect resource * type, -EINVAL will be returned. @@ -315,7 +312,7 @@ vmw_user_resource_noref_lookup_handle(struct vmw_private *dev_priv, return converter->base_obj_to_res(base); } -/** +/* * Helper function that looks either a surface or bo. * * The pointer this pointed at by out_surf and out_buf needs to be null. @@ -388,6 +385,7 @@ static int vmw_resource_buf_alloc(struct vmw_resource *res, * @res: The resource to make visible to the device. * @val_buf: Information about a buffer possibly * containing backup data if a bind operation is needed. + * @dirtying: Transfer dirty regions. * * On hardware resource shortage, this function returns -EBUSY and * should be retried once resources have been freed up. @@ -586,7 +584,7 @@ vmw_resource_check_buffer(struct ww_acquire_ctx *ticket, return ret; } -/** +/* * vmw_resource_reserve - Reserve a resource for command submission * * @res: The resource to reserve. @@ -973,7 +971,7 @@ void vmw_resource_evict_all(struct vmw_private *dev_priv) mutex_unlock(&dev_priv->cmdbuf_mutex); } -/** +/* * vmw_resource_pin - Add a pin reference on a resource * * @res: The resource to add a pin reference on From patchwork Fri Jan 15 18:12:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366111 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40DCCC4332D for ; Fri, 15 Jan 2021 18:14:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 067B523A58 for ; Fri, 15 Jan 2021 18:14:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733296AbhAOSOY (ORCPT ); Fri, 15 Jan 2021 13:14:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728241AbhAOSOX (ORCPT ); Fri, 15 Jan 2021 13:14:23 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD04CC0617A0 for ; Fri, 15 Jan 2021 10:13:32 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id v15so6541463wrx.4 for ; Fri, 15 Jan 2021 10:13:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ja/1FFTGOv6AaggbEFEZcUW2YjyBuvrOQaBJpOOoCfs=; b=ghF0kG8rNEQVOXAUreNjXGcJ48KjNg9l5Ypq/mQHTLuOAZzim1Tgi51UYfBff6o/5k SqJZsUxrQ2OQ2MC4A/in2xeKuyglvlerxtbegG8LeZMZWP5cxJRHQK0X354kmcGB6Ran s9B8lpGNLa3wdOJvkz7ETmHhR9fgPWpeJ6rsQF3l8L7MsEelRNXwQqZqKso6zKDgNR8C e6DcT9hKAhYY+8mR7q/15hXGU0+6zlJjE1MoYm4ZEF8FQkcJxX1KOEhVNUBsIhSjt7kf cN1gw5k2GbmPbroZiq6Hv+zvbSvAQBcsJ4nrPDlKUVifSUUV8B8dCoQokTHyAQm3r3wt Qzsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ja/1FFTGOv6AaggbEFEZcUW2YjyBuvrOQaBJpOOoCfs=; b=gw2REoiNLRSii3xF8ixzOIBDts3utfvnM9g2hhSABfUsO0DUc4LUoFc2j5OHDp6FYB zVt3Hm7JoXEdnnksacoAzrUKnnLsD5dlaMLeelEBaM6gY4hYC/fuYyf7y1eczwp0y8Sn jAZFi1NV+sp8j52gbH9FuiYPz7d1MuCT81hLCCuVi9n1lbQ0LvlWop7nbY7MIlIE0Pxg SSmBfwmeukRW/QhhDh8aeqneKuG/ooPwlvfMheWAueYlU45PL74s4MFptMpj9JME/EXQ QBt1FXO9i+pfLJJv2rXVvWCOBPP3J2eYy9hMN14BnQheVa3V05HGF/SbAsqKjPWc8kY1 1pYA== X-Gm-Message-State: AOAM530La7K/jqf7Yoy3cbPqfBxW5XzgHOW+lxxv0yHjbC8knStrMQBs xnAFiUlb+OHcThwsCv1bJbkUb8NHsW8bZYvL X-Google-Smtp-Source: ABdhPJxs93jdlE+R+l0+00KbInYFz0hyGWh21RRCg+gQ2ikl2wjRWfhBWoZr6RR9J0t/xrD1VNYXrg== X-Received: by 2002:adf:ab5b:: with SMTP id r27mr14285129wrc.282.1610734411548; Fri, 15 Jan 2021 10:13:31 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:30 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 11/40] drm/vmwgfx/vmwgfx_ttm_buffer: Supply some missing parameter descriptions Date: Fri, 15 Jan 2021 18:12:44 +0000 Message-Id: <20210115181313.3431493-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c:275: warning: Function parameter or member 'p_offset' not described in 'vmw_piter_start' drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c:676: warning: Function parameter or member 'evict' not described in 'vmw_move_notify' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c index dbb068830d800..6a44567e4ba52 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c @@ -265,6 +265,7 @@ static dma_addr_t __vmw_piter_sg_addr(struct vmw_piter *viter) * * @viter: Pointer to the iterator to initialize * @vsgt: Pointer to a struct vmw_sg_table to initialize from + * @p_offset: Pointer offset used to update current array position * * Note that we're following the convention of __sg_page_iter_start, so that * the iterator doesn't point to a valid page after initialization; it has @@ -664,6 +665,7 @@ static int vmw_ttm_io_mem_reserve(struct ttm_bo_device *bdev, struct ttm_resourc * vmw_move_notify - TTM move_notify_callback * * @bo: The TTM buffer object about to move. + * @evict: Unused * @mem: The struct ttm_resource indicating to what memory * region the move is taking place. * From patchwork Fri Jan 15 18:12:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366110 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B24FC4332B for ; Fri, 15 Jan 2021 18:14:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF32A23A6C for ; Fri, 15 Jan 2021 18:14:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733234AbhAOSOX (ORCPT ); Fri, 15 Jan 2021 13:14:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730399AbhAOSOX (ORCPT ); Fri, 15 Jan 2021 13:14:23 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9022C0617A1 for ; Fri, 15 Jan 2021 10:13:34 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id 91so10212088wrj.7 for ; Fri, 15 Jan 2021 10:13:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fAAEuD3RlEr/SK+ua/zk+cZbQLwjXz0Jv5gG/pDSRFI=; b=RNlz61U66+BUG1s+nfI5teKJXRzuhAMcV/qAFVRXV+wo32MjqVdz82qZ+lAO7fU6y1 6AeYS8NZOV1XOpHbW/l8uDFRm91lwC39apk+K9velV1B1eYzstpRzlMpCDA8KTHqXr9w UKqvIVaChpMvb5Xu2BYeV67rF7W62o/haTbVgcfVDoNHWaS2uYXSsrYQuwtsaA7cFUD0 1d4o9RxUprSwq8f+2rKLEt1HiQFe3SzaQ+tFDP7FSt6o6cK8dxAjmEmaTxYFQuKq5WbD s1Im/XIHYHvruuyaGxAt3cLHIhdXy44KcuI/A0h5AKziCv8119TfPyA8Cbu5/MZhOwBg 4szw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fAAEuD3RlEr/SK+ua/zk+cZbQLwjXz0Jv5gG/pDSRFI=; b=ZSEqbxtQvHbNo93dxHEzuB8Bs2z6tQoe8FracPucd1lkDmAJiSIl2cNoPFPc2pdZo7 RFvHhFbH656LvBL5xnanZWOfS4JsiY19gVBr7L8I9egZB8u+ntFGwghzZjvSqY93xPhL wj2g2s9FzyXSMZXMWlVffhP8C83p4968Jq3TJt8O1JdsxtwVjykdepEzEeQKx+JNCaHn LvX2WS1PEH9IPcS6TPzbkmMpdlBxlNiReAcSKB7NXfJMOYUk/VZ5nhnQ+cPUGm5a6ibU yMW74gaAWrRb96yh/jurY46nkVDPxmfAhBNRe1VkD4rqNANvOLY7Ty4qz8YxBe4J+S1k XWdw== X-Gm-Message-State: AOAM531o9QaGP9YOHpZFOlMNTDSVqsZCpZwBkefnRTrWnOhERzLPe0Rr 7q0aERsICo+4FWGZ46uofRi+nw== X-Google-Smtp-Source: ABdhPJzlmSdMVzlgQMNkUxNs186KSUwDnAnO4SsNgnPYTbXf9gsWuDYH8x8BWmMJW6fVGztzH9DU9A== X-Received: by 2002:a5d:4c45:: with SMTP id n5mr14777366wrt.396.1610734413540; Fri, 15 Jan 2021 10:13:33 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:32 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 12/40] drm/vmwgfx/vmwgfx_fifo: Demote non-conformant kernel-doc header Date: Fri, 15 Jan 2021 18:12:45 +0000 Message-Id: <20210115181313.3431493-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c:299: warning: Function parameter or member 'dev_priv' not described in 'vmw_local_fifo_reserve' drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c:299: warning: Function parameter or member 'bytes' not described in 'vmw_local_fifo_reserve' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_cmd.c b/drivers/gpu/drm/vmwgfx/vmwgfx_cmd.c index 7400d617ae3cc..20246a7c97c9d 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_cmd.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_cmd.c @@ -276,7 +276,7 @@ static int vmw_fifo_wait(struct vmw_private *dev_priv, return ret; } -/** +/* * Reserve @bytes number of bytes in the fifo. * * This function will return NULL (error) on two conditions: From patchwork Fri Jan 15 18:12:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366117 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC7ECC4332B for ; Fri, 15 Jan 2021 18:15:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79EF423A58 for ; Fri, 15 Jan 2021 18:15:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387785AbhAOSOt (ORCPT ); Fri, 15 Jan 2021 13:14:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387709AbhAOSOs (ORCPT ); Fri, 15 Jan 2021 13:14:48 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23BDEC0617A2 for ; Fri, 15 Jan 2021 10:13:37 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id a9so6747155wrt.5 for ; Fri, 15 Jan 2021 10:13:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jvyHS8XiQc1oAzz859zgo3XkDd1Co0kNwC7up5M68+w=; b=XhjjfcqbMACLLu1UbUwoqoD/8t48q+La60pp5xe4eCTr0EMZJnWkSTnd6IyBDzec+Q RHflyw7Qx5MObqDYdfUNRRhZb5tcQlDS93CBk9n8BvSp//3B3HXS7yDQ20yIBhpDjm7J CJecEL0ZPE8v+KQyGPehSrFI59nJ68dHfp6WhLpKaprgpNczqjT2o6uR2IhUfx7Oi11t SHGVxSBkHz1lL/PVJIlI2NtCTuHfxTPAzO+7XDJYkI017xs7WIYnJz9Of+IQrLWENyS9 LWVqRaqiy+jGvXeOmpQa99Xoe8wK0qekcEgWyk62TXSV6S75tLeGP5zkpNenv8umJU4L rIPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jvyHS8XiQc1oAzz859zgo3XkDd1Co0kNwC7up5M68+w=; b=t4ONHYboMJXPX/C10TazL1Lan96KC6HMW8bBGpZXu61DtbmVtu1YrHSnXyf+66IFaA cddtIiKEQQb75a1+I5aKvkoJZGycEekgghphiT5CNmQZ6nPuoXcPH64ooHXMyS7odbJP R1WWKWo4LFr6rGDbxVaSI6yEYPS/OOt/7o71E0lNXq117urTFg1+A8x7OdIDKYl8JcDm zH6aAlG65eBevWsEm/BVnqSBDpYYPpmu2/nw3msILqFKf/+S6UyfHpUOiznZyBAu0Ysp 97vkV7y1S8PBvhRBuUFlRGNbxxvjHl1VVlU7axvYwsJlSCGRYrgxpxYQeml4zBeJF6FX SWUw== X-Gm-Message-State: AOAM531v5iF3n3AMlhbRaxe/JKX+4xHVidlgNS13+6QoerflNBj0cWRL X3k3ZzZSF2BVjqr874UAC+MpLg== X-Google-Smtp-Source: ABdhPJzM3pePojoBobuolex7+uztZaeYfeUOxi34s4vdEqInkukJV1C7p5vxVqa/UR1IIxgjiE02JQ== X-Received: by 2002:adf:902a:: with SMTP id h39mr14398191wrh.147.1610734415837; Fri, 15 Jan 2021 10:13:35 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:34 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 13/40] drm/vmwgfx/vmwgfx_ldu: Supply descriptions for 'state' function parameter Date: Fri, 15 Jan 2021 18:12:46 +0000 Message-Id: <20210115181313.3431493-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c:55: warning: cannot understand function prototype: 'struct vmw_legacy_display_unit ' drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c:218: warning: Function parameter or member 'state' not described in 'vmw_ldu_crtc_atomic_enable' drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c:228: warning: Function parameter or member 'state' not described in 'vmw_ldu_crtc_atomic_disable' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c index 9a9508edbc9ed..acae92a07f4f3 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c @@ -49,7 +49,7 @@ struct vmw_legacy_display { struct vmw_framebuffer *fb; }; -/** +/* * Display unit using the legacy register interface. */ struct vmw_legacy_display_unit { @@ -206,6 +206,7 @@ static void vmw_ldu_crtc_mode_set_nofb(struct drm_crtc *crtc) * vmw_ldu_crtc_atomic_enable - Noop * * @crtc: CRTC associated with the new screen + * @state: Unused * * This is called after a mode set has been completed. Here's * usually a good place to call vmw_ldu_add_active/vmw_ldu_del_active @@ -221,6 +222,7 @@ static void vmw_ldu_crtc_atomic_enable(struct drm_crtc *crtc, * vmw_ldu_crtc_atomic_disable - Turns off CRTC * * @crtc: CRTC to be turned off + * @state: Unused */ static void vmw_ldu_crtc_atomic_disable(struct drm_crtc *crtc, struct drm_atomic_state *state) From patchwork Fri Jan 15 18:12:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366116 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E21AC433E9 for ; Fri, 15 Jan 2021 18:15:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55E7523A59 for ; Fri, 15 Jan 2021 18:15:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387747AbhAOSOs (ORCPT ); Fri, 15 Jan 2021 13:14:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387713AbhAOSOs (ORCPT ); Fri, 15 Jan 2021 13:14:48 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28E93C0617A3 for ; Fri, 15 Jan 2021 10:13:39 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id 190so8223857wmz.0 for ; Fri, 15 Jan 2021 10:13:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xM/nZ90UZtBcAp5QNv/pK0XIOjFNxIv5JhwEyUdhjVM=; b=jjY6jrbjNmOrQiQDYOGRkAAIiAp/6KDE3vmYhx4DqYAVJjpaPO83rezynTkZus38Qc t4wRn0YT/RSRwfnRTuWoEOpz/oXXr745uuuvPdCu+12MhIBHFSt2gJEvgsBLyW/9NYTv ly0ALvUs7CphR/MaClnLwLV8D5t+U1d613DS5Ggu7iVr21IFw0AJkn2+X1AVVVnIYVy7 g5brib7pVjxVa/FshrKlb7Rwar9BQtK7rSn4J+HPC4TEdSofTkNVdXk5EfoJXoj/pd6L QoZ0ZMeczQrR7iFB5Q3YWBBBQnw5ClVzOK+CTQ2dAlRZP7Yi5bldSl6piHZfCrjplOtm eoDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xM/nZ90UZtBcAp5QNv/pK0XIOjFNxIv5JhwEyUdhjVM=; b=Gg/VJ98CfOKNrm5zn7Kv9LohJ5I9aEFkpuzOi62wkQ2YYecAJovlkPSaBkRaCjdbXt lpFuJKAIgEwC9cgyI2jQu7Ro4hf0AMEWTGFaYtO1Eivui/OjTNfOj6ZWDEQEn3xyuKzg kKtoYy1pl7qAH4EpspWdOFe3QFWGwnJ6LLF4hoGzY2D6Hd4THyuo/cHktwBA036Sf4FS lNH3IpdeG+5KIm0/sZY9HjiZ67AtSkVuOgG0FPjw54OhBWJHABu6pz81ge7p49lv3BpD 4IwfS5nVWVO7Rzyg5Ukv8a+kBEQQ7JOWPASf/Gui5vaQJgNymauqaWcysVFWIuA91vhW GtaQ== X-Gm-Message-State: AOAM530K1wAUMo5fxb4Yhvr3DuU/X/1WsDQojxFwIgensgSkYIbUqrMy 9yAK3Bac+IdqiSr2AJcuOX+Oag== X-Google-Smtp-Source: ABdhPJyz6t3vpry+yHHvZkuxg824UAQtjwFbNBG9Psqyj5I2KEjDtM4i6aE0P4Q7B9LdiEt4kTRXPg== X-Received: by 2002:a1c:356:: with SMTP id 83mr10209410wmd.31.1610734417929; Fri, 15 Jan 2021 10:13:37 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:36 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 14/40] drm/gma500/framebuffer: Fix some possible doc-rot issues Date: Fri, 15 Jan 2021 18:12:47 +0000 Message-Id: <20210115181313.3431493-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/framebuffer.c:171: warning: Function parameter or member 'obj' not described in 'psb_framebuffer_init' drivers/gpu/drm/gma500/framebuffer.c:171: warning: Excess function parameter 'gt' description in 'psb_framebuffer_init' drivers/gpu/drm/gma500/framebuffer.c:212: warning: Function parameter or member 'obj' not described in 'psb_framebuffer_create' drivers/gpu/drm/gma500/framebuffer.c:212: warning: Excess function parameter 'gt' description in 'psb_framebuffer_create' drivers/gpu/drm/gma500/framebuffer.c:262: warning: Function parameter or member 'fb_helper' not described in 'psbfb_create' drivers/gpu/drm/gma500/framebuffer.c:262: warning: Excess function parameter 'fbdev' description in 'psbfb_create' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/framebuffer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c index 22c80e87aeb41..ebe9dccf2d830 100644 --- a/drivers/gpu/drm/gma500/framebuffer.c +++ b/drivers/gpu/drm/gma500/framebuffer.c @@ -159,7 +159,7 @@ static const struct fb_ops psbfb_unaccel_ops = { * @dev: our DRM device * @fb: framebuffer to set up * @mode_cmd: mode description - * @gt: backing object + * @obj: backing object * * Configure and fill in the boilerplate for our frame buffer. Return * 0 on success or an error code if we fail. @@ -197,7 +197,7 @@ static int psb_framebuffer_init(struct drm_device *dev, * psb_framebuffer_create - create a framebuffer backed by gt * @dev: our DRM device * @mode_cmd: the description of the requested mode - * @gt: the backing object + * @obj: the backing object * * Create a framebuffer object backed by the gt, and fill in the * boilerplate required @@ -252,7 +252,7 @@ static struct gtt_range *psbfb_alloc(struct drm_device *dev, int aligned_size) /** * psbfb_create - create a framebuffer - * @fbdev: the framebuffer device + * @fb_helper: the framebuffer helper * @sizes: specification of the layout * * Create a framebuffer to the specifications provided From patchwork Fri Jan 15 18:12:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366115 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62538C433E6 for ; Fri, 15 Jan 2021 18:15:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29D0A23A5A for ; Fri, 15 Jan 2021 18:15:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387705AbhAOSOn (ORCPT ); Fri, 15 Jan 2021 13:14:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727726AbhAOSOi (ORCPT ); Fri, 15 Jan 2021 13:14:38 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FAE5C0617A4 for ; Fri, 15 Jan 2021 10:13:40 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id o10so2358692wmc.1 for ; Fri, 15 Jan 2021 10:13:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J8jnXbYZh9fQLGbXGQ/O0REzwyF7YhVgi5AkTd6twPI=; b=uF/0vIlBVC846lYN4HISdxnnS7K8yJ+3K/lfoibQMwkvdkdW1pKP/jh6fQ3gVoS9DA VIwmyj5LSrRc/XtozbDaXoUExRLAfyrQOFdiV/o1k3v32UjqQXeZ02YrXYIwbJ418a7X KGMiWIg3PhKnYEnxeDp94ruSxvdzn1VRb2iUPR1NKnkGlOcnpOgbvmHn7jucnhF/CO1X Vv8mqhwmgXj78y3TC0NcSG6YV3Udw6VRK6/89Hp2/XetCnbN5nVwvc4e7racI41l8zAW Y3CFATlEdyGbecMlUCoVJ6U5yJMiFQvDwf/ziz8hJ0s/wpbJe6M9MEfGlReSz0+cFrDn q2IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J8jnXbYZh9fQLGbXGQ/O0REzwyF7YhVgi5AkTd6twPI=; b=ePjn0TUT+mM4R3Cr/psxLtEBcDUsj4RzvDEYcrLWwvx+JaDEkjGpttF6ihAyL/2qoZ +cIGVeZIw09Q+RyHRwgHbl717sifkuCxQy5c+ZAimr7OhJjIq5YvuFu4Xl7vTv7lRlRM VhYYKD04hmZYD0YhAbVTpgGO/otCcNrchOoKT5zJD/Wl3UMM2kNn7N08K4Vylh5qMHSr IGhmG3Jhs53Z6EiUw4WKhO3r/8G3rC9M1cDTVasFhaNJoA3LBI2TGidhvtH6vU3VIo0O vgcM1qwGDFeeBbMaoV4d6/ILvbkCizkdMf7Sn3TRPdh4EIeb49g5DqWx7mbZa/Cs8ehR MBNw== X-Gm-Message-State: AOAM532aKDUGkVExDEKBVF0c/6EQV9a2psGRT0Hr0XrGvXyheFMXnmwP M4L1kZFVA4pMsaH5NQs9g9qSglIFmfkT3Om4 X-Google-Smtp-Source: ABdhPJwnCR0Nzz3e0c6LzffEGLK2o6EAODTUN633CFgBq6cZO9FrWPi92VhlIb0jckP0HwOwMQr3lQ== X-Received: by 2002:a7b:cf08:: with SMTP id l8mr10045620wmg.189.1610734419371; Fri, 15 Jan 2021 10:13:39 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:38 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 15/40] drm/gma500/gem: Add and rename some function parameter descriptions Date: Fri, 15 Jan 2021 18:12:48 +0000 Message-Id: <20210115181313.3431493-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/gem.c:57:5: warning: no previous prototype for ‘psb_gem_create’ [-Wmissing-prototypes] drivers/gpu/drm/gma500/gem.c:59: warning: Function parameter or member 'stolen' not described in 'psb_gem_create' drivers/gpu/drm/gma500/gem.c:59: warning: Function parameter or member 'align' not described in 'psb_gem_create' drivers/gpu/drm/gma500/gem.c:110: warning: Function parameter or member 'file' not described in 'psb_gem_dumb_create' drivers/gpu/drm/gma500/gem.c:110: warning: Excess function parameter 'drm_file' description in 'psb_gem_dumb_create' drivers/gpu/drm/gma500/gem.c:135: warning: Excess function parameter 'vma' description in 'psb_gem_fault' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/gem.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c index db827e591403c..5ef5480f999e9 100644 --- a/drivers/gpu/drm/gma500/gem.c +++ b/drivers/gpu/drm/gma500/gem.c @@ -49,6 +49,8 @@ const struct drm_gem_object_funcs psb_gem_object_funcs = { * @dev: our device * @size: the size requested * @handlep: returned handle (opaque number) + * @stolen: unused + * @align: unused * * Create a GEM object, fill in the boilerplate and attach a handle to * it so that userspace can speak about it. This does the core work @@ -97,7 +99,7 @@ int psb_gem_create(struct drm_file *file, struct drm_device *dev, u64 size, /** * psb_gem_dumb_create - create a dumb buffer - * @drm_file: our client file + * @file: our client file * @dev: our device * @args: the requested arguments copied from userspace * @@ -116,7 +118,6 @@ int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev, /** * psb_gem_fault - pagefault handler for GEM objects - * @vma: the VMA of the GEM object * @vmf: fault detail * * Invoked when a fault occurs on an mmap of a GEM managed area. GEM From patchwork Fri Jan 15 18:12:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366177 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3E9BC433E0 for ; Fri, 15 Jan 2021 18:20:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F809222B3 for ; Fri, 15 Jan 2021 18:20:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387493AbhAOSOk (ORCPT ); Fri, 15 Jan 2021 13:14:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729312AbhAOSOi (ORCPT ); Fri, 15 Jan 2021 13:14:38 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74E34C0617A5 for ; Fri, 15 Jan 2021 10:13:42 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id w5so10180559wrm.11 for ; Fri, 15 Jan 2021 10:13:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fYtw8GzoU8Bqr/iSnXTLs/UzdpcC7+8OaiBwfsZ40Oc=; b=U8irOcupICW0AmAfXBUsHfVL2wyDZgSXZaObAH//1x1fRMn1cg1To4KbPNc5oTas1c apyd8AV8gA6lEiNxVwlntq8O/K6LORf9JQhFMZ18wqw2aYzxYeHPD69K5vZ7lLX3pWf3 9KrGDXnG8CKL/7C0pIiBtaML3+s/HHkifHwl3ZCSwnQLeqXuU+k/A6BrZmP7BUWf9iJx Gw0bof7iS/mi53tvZmrFuhxB8rPE8DwM3m3P325uwrmUYMF2vXLq+3QZZU5kEN74w9bT zL7O8AojKXlr0DS1tU3U5WOy4IU/UJizeFIaJWuvtY0Ls/UrPhlKLFZ13UOquviqGxem JuOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fYtw8GzoU8Bqr/iSnXTLs/UzdpcC7+8OaiBwfsZ40Oc=; b=IlbLokmAdRUqWgjkzZ/q9pMX8qwEDkLdQXSLDWDqdiz6t77au2QQ79SXI6MUwnSO18 xYzVLQzbzGCdkahWzjqSXanZaez1sdECMJzhO1Wz67zjJS0bcQz7Znj4vRblj+LCDNeh EhTFSAiDfDyntzQa27OXcTrr/9CB5gpmfyYVEKsNJCDcTY3a5XDS5rkf2J9ApTYahTMC xIw7Fa2GqX8rCvLWdoFPYYQnUn2V+k7IvyVNiMOBX5nfxvRPgo/U5aiBSmEwAKNfa6vw k8fMBYxSAXtItH+6aVeEH72XVGfSLoBJHsZwjiBraikUYLKktJCH4u97bq5u1B13ieSV PM4A== X-Gm-Message-State: AOAM530Jgxky/v06na7dJAnS6nCLTmgEDTN/RkumK771YhNgaDPHylM5 SF9ZswCqmQqy1BVc1Z0rVTk/Gw== X-Google-Smtp-Source: ABdhPJzOfZs8jm74WsjZlxRA+7WSux0MsT67QoSS9lraOoJ6f+Z54JPLseMY3Fajw43W4AUhQrbFDA== X-Received: by 2002:adf:c444:: with SMTP id a4mr10946428wrg.164.1610734421283; Fri, 15 Jan 2021 10:13:41 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:40 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , Eric Anholt , dri-devel@lists.freedesktop.org Subject: [PATCH 16/40] drm/gma500/intel_bios: Demote non-conformant kernel-doc header Date: Fri, 15 Jan 2021 18:12:49 +0000 Message-Id: <20210115181313.3431493-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/intel_bios.c:581: warning: Function parameter or member 'dev' not described in 'psb_intel_destroy_bios' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Eric Anholt Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/intel_bios.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/intel_bios.c b/drivers/gpu/drm/gma500/intel_bios.c index a3b843316f4e5..d838369f01194 100644 --- a/drivers/gpu/drm/gma500/intel_bios.c +++ b/drivers/gpu/drm/gma500/intel_bios.c @@ -574,7 +574,7 @@ int psb_intel_init_bios(struct drm_device *dev) return 0; } -/** +/* * Destroy and free VBT data */ void psb_intel_destroy_bios(struct drm_device *dev) From patchwork Fri Jan 15 18:12:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366123 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A7D6C433E0 for ; Fri, 15 Jan 2021 18:15:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E241C23A59 for ; Fri, 15 Jan 2021 18:15:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388088AbhAOSPN (ORCPT ); Fri, 15 Jan 2021 13:15:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387937AbhAOSPD (ORCPT ); Fri, 15 Jan 2021 13:15:03 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4072FC0617A6 for ; Fri, 15 Jan 2021 10:13:44 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id v15so6541970wrx.4 for ; Fri, 15 Jan 2021 10:13:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2Sf7UxFKe3Y/0LIWjexcpC2JdFLtpHY5KwvFx7/VFjA=; b=w9NoGSZ/l11wfSZSeAI4t499CVHwCdmjQnsIudKi0BoQ1Qmcl/PevP5g/9yIqF1VZI zNb7qldTqI8Z8+nqxO3I0vxh6xYD4hsB/C1KIT71zz1hTeHDc3e1oztvaUrGon+1UwRd wPbyfic0PGsGSerU7GReFRPZW0JhETAtUZYpzyB/nM76gZBnlCXcJH4OZsu6Pslu+mha gjkrHspJ9en30gn8UHW92S0gUfchzdIRqmXAMzN+iJqizZAEc9UftalWpWiYmcZE6+/l 23zmbg3+KPPZKhAiwhCoWV1v56PowvyZ96BIZLbFruHIadxswgoFKCDU85BHETPzOlmB 6LBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2Sf7UxFKe3Y/0LIWjexcpC2JdFLtpHY5KwvFx7/VFjA=; b=UXtP5hf9Db5fOgSa2bgjqs5WJ5kaC3SJfz5T9Y+SVBXHqXjafW5qMVAjYq2Hf050ht OW/+3g+POECZKruoOGv7VciUV3nxn6sk7JZBVZ7apndvwuky6hJPDqywiybp2vxpy6sr Z+b/fE/mAEZCwSXSMWtaYJmngchm+uvcWpZPPK76h4XIS4iRJn7bneC4oyxwOxV4oBT7 eQBowdoRqxiXJyS7YWzWq95sOV3toixM4U9aBHNKANRRxtCqvwLchPjFwOQF4rj81cn9 Nw6/U/enoR8u2CdkSaZ09JBnsaInJZmDQTEKG60wOgz+pFsPFh4n2sZ5aN1SEQMwqfMv S/Xg== X-Gm-Message-State: AOAM530EpQvua1z9BRrlcX/vgOW2uiTwfCos28+JRApVMencTtKRbbII eYdFMVT5Ek2xxfim+qLxxDB9QnD9OFBoyY7Q X-Google-Smtp-Source: ABdhPJz6d+j7wki717P/WkT8b7Lqmx9P4yQ4dPmJKhA70mj3ZUr77wv0gL0gUdiALFkMDnci8VO2oA== X-Received: by 2002:adf:b1db:: with SMTP id r27mr4599002wra.125.1610734423051; Fri, 15 Jan 2021 10:13:43 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:42 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , Eric Anholt , dri-devel@lists.freedesktop.org Subject: [PATCH 17/40] drm/gma500/intel_i2c: Remove superflouous parameter description and rename another Date: Fri, 15 Jan 2021 18:12:50 +0000 Message-Id: <20210115181313.3431493-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/intel_i2c.c:108: warning: Excess function parameter 'output' description in 'psb_intel_i2c_create' drivers/gpu/drm/gma500/intel_i2c.c:153: warning: Function parameter or member 'chan' not described in 'psb_intel_i2c_destroy' drivers/gpu/drm/gma500/intel_i2c.c:153: warning: Excess function parameter 'output' description in 'psb_intel_i2c_destroy' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Eric Anholt Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/intel_i2c.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gma500/intel_i2c.c b/drivers/gpu/drm/gma500/intel_i2c.c index cb92f24e6f1c5..5e1b4d70c3171 100644 --- a/drivers/gpu/drm/gma500/intel_i2c.c +++ b/drivers/gpu/drm/gma500/intel_i2c.c @@ -85,7 +85,6 @@ static void set_data(void *data, int state_high) /** * psb_intel_i2c_create - instantiate an Intel i2c bus using the specified GPIO reg * @dev: DRM device - * @output: driver specific output device * @reg: GPIO reg to use * @name: name for this bus * @@ -145,7 +144,7 @@ struct psb_intel_i2c_chan *psb_intel_i2c_create(struct drm_device *dev, /** * psb_intel_i2c_destroy - unregister and free i2c bus resources - * @output: channel to free + * @chan: channel to free * * Unregister the adapter from the i2c layer, then free the structure. */ From patchwork Fri Jan 15 18:12:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366127 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AC98C4332B for ; Fri, 15 Jan 2021 18:15:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20BF823A5A for ; Fri, 15 Jan 2021 18:15:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388136AbhAOSPU (ORCPT ); Fri, 15 Jan 2021 13:15:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387941AbhAOSPD (ORCPT ); Fri, 15 Jan 2021 13:15:03 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1351EC0617A7 for ; Fri, 15 Jan 2021 10:13:45 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id o10so2358819wmc.1 for ; Fri, 15 Jan 2021 10:13:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1yMxGlPEfyzvXa2UJQqEx7ekNRCoKDflK8zni2fkeUs=; b=Si13WZnjdkXdJogyfDIMI1YTp5PsWFLMpQMp5+G1UHdeypDKUAtv7h1aQEV+fImecK ivSNlCJIoBYyFxMYvF1bmuFw1vIxMuj4SR40JJeDLZlAs6g64j6LnFt4NvHwvcgEXMOW ENqxiXMpECNBXjjUQGYMobSUGV+OaIWcCeoOlBdlJpAxvfKp84rV1MLqS6vr6wlsWtm7 PejC1um/TxCI8YN3jCuYMgatzgnru0/ZU+o1W4uLWLXLXZKw/076lH/ZMRK7Kw4kbqY8 Afdk/FKH7TM76838J/DvbxysuQMyJrWeU70SfyL19qyQhEy0/8EKcpxgfbdtvNqDOrL9 F5bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1yMxGlPEfyzvXa2UJQqEx7ekNRCoKDflK8zni2fkeUs=; b=U4/tX8H/kfTR2tBv17bcy7sv/3UV9i6V/6Nqmu8MZZpohMjCyinbdZLMgtgOtG9+1P uxhmI0grB18qLq5iMW2FYqf2gB4bosvLbALNjQRlzAi3x7HWA61V9aD0eG+Uw8PxYqPL I7SKN56dsaO0IILlVNb9YC0ZNzGpqlpStElez/mpGZ3GslQDu5NKsFTMYEgWQ4gGLOLe SPmr77YhBqSEsVHKLxQU/wiUkpkIklZ+O84ZW3oq2RTEOGavAaFZ/Akt58rVveB96VbS UWlb7Mu1Q8Auw80oERAoKCG5xoCzIAUibB53VZYgKwHNCt+G6Uxlrkm4BlqNdKPDtfZ0 JU5g== X-Gm-Message-State: AOAM530ot/JvSuI0TrDWmeFAL9O61uqKS+4j5dU/F2NEzEoC3QHnw5Y3 U5iZ9lgqo1hF6jVEzGd7bM2TOFlACJ1H+gIv X-Google-Smtp-Source: ABdhPJwvrXbHb+AjgLmUtqHU2FArfA74YAGB6r+5CFCOegLEs12lu6XvOUjwl+crbP8tjV88Jwb4gg== X-Received: by 2002:a1c:68d5:: with SMTP id d204mr9861675wmc.178.1610734424527; Fri, 15 Jan 2021 10:13:44 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:43 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 18/40] drm/gma500/mmu: Make local function 'psb_mmu_pt_alloc_map_lock()' static Date: Fri, 15 Jan 2021 18:12:51 +0000 Message-Id: <20210115181313.3431493-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/mmu.c:316:20: warning: no previous prototype for ‘psb_mmu_pt_alloc_map_lock’ [-Wmissing-prototypes] Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/mmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gma500/mmu.c b/drivers/gpu/drm/gma500/mmu.c index 505044c9a6732..42b53c01b79f4 100644 --- a/drivers/gpu/drm/gma500/mmu.c +++ b/drivers/gpu/drm/gma500/mmu.c @@ -313,8 +313,8 @@ static struct psb_mmu_pt *psb_mmu_alloc_pt(struct psb_mmu_pd *pd) return pt; } -struct psb_mmu_pt *psb_mmu_pt_alloc_map_lock(struct psb_mmu_pd *pd, - unsigned long addr) +static struct psb_mmu_pt *psb_mmu_pt_alloc_map_lock(struct psb_mmu_pd *pd, + unsigned long addr) { uint32_t index = psb_mmu_pd_index(addr); struct psb_mmu_pt *pt; From patchwork Fri Jan 15 18:12:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366140 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 014ADC43381 for ; Fri, 15 Jan 2021 18:16:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7DC023A58 for ; Fri, 15 Jan 2021 18:16:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387945AbhAOSPD (ORCPT ); Fri, 15 Jan 2021 13:15:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727726AbhAOSOx (ORCPT ); Fri, 15 Jan 2021 13:14:53 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 135B2C0617A9 for ; Fri, 15 Jan 2021 10:13:47 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id y187so8408813wmd.3 for ; Fri, 15 Jan 2021 10:13:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JrCpsOWXkuV27y08h0Q+/ggDFvdkszKPoUD+Vqs5v1w=; b=eVFjcBEjg45hUFWoVNeBlMVtPQHjgY33qJV2wsQfY8RkMAyofnRpc0YZ1XYm+r0A7Y Zbtu3nTeYVVwJ0jgnSciJOe2iz1iAebYEOimoRIIy5WqtDESpunxBekCZ7xDMWEMoHdZ rLV9mZvOvRDJ/dBtu6HIjJtJSljsv2pn9y+p2be/yBdsXEG3llyBDmQekQKxQLHH9D0i CfIbL+qXIcylUVdMz/dkHb1N+PS3jTYTpb45WnOA47U6ex0lSL88A2NUfuFPAH8eaqOV 4nzXINrDwQoCI00pVGUjquUOFC4sguTTyQTZ6+iOqwYnnbKhsXefFRKH/xVaCVWYkCKc YLlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JrCpsOWXkuV27y08h0Q+/ggDFvdkszKPoUD+Vqs5v1w=; b=azr5Zkj/H+VPozaVjf660N5gTKt9Wn8RAZ10hNotiJn5Dz3NjkO/10tNdFLhArmX3c WcBNlbsIKkSysO46cOvwOk7zCQ5kZb7PeTwTSeqRk/69+5sn5HwWM0cG734w8lTrTKIw svQ/ENoAoVdnkovlppXsZzZmWDPOTw3dRTIoZdAj+gjB7WBwM41E2b/G6hgUIrlWn+QT b8fTurOb3CKwFRWWSr+OODBCddcMBmxopQ1F0remF5qpYpVbDWIxmf3bTSOQ8yDVtc61 Wany8bwTRH0NNlIxapURrV4QhfAWpDwGa25szednfl+I6U42oXphlGsPxCjLBMqYUDNC I4+A== X-Gm-Message-State: AOAM531g2FcwLA+62S6hKSeaLowLp/M2jSOewN3I1SEFoAHE9lpXGiZO +Vz2jNoCP8GonoZmO1P0zMXlMA== X-Google-Smtp-Source: ABdhPJweojZ0h6yHoiV/u4YZr4avFre/S61l1Q1UIOKC9yloexr0L9KKgA+LNR50Re7apQpMu0NL8w== X-Received: by 2002:a1c:4c14:: with SMTP id z20mr9997363wmf.149.1610734426511; Fri, 15 Jan 2021 10:13:46 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:45 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , Benjamin Defnet , Rajesh Poornachandran , Alan Cox , dri-devel@lists.freedesktop.org Subject: [PATCH 19/40] drm/gma500/power: Fix a bunch of *dev documentation issues Date: Fri, 15 Jan 2021 18:12:52 +0000 Message-Id: <20210115181313.3431493-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/power.c:101: warning: Function parameter or member 'pdev' not described in 'gma_resume_display' drivers/gpu/drm/gma500/power.c:155: warning: Function parameter or member 'pdev' not described in 'gma_resume_pci' drivers/gpu/drm/gma500/power.c:155: warning: Excess function parameter 'dev' description in 'gma_resume_pci' drivers/gpu/drm/gma500/power.c:189: warning: Function parameter or member '_dev' not described in 'gma_power_suspend' drivers/gpu/drm/gma500/power.c:189: warning: Excess function parameter 'pdev' description in 'gma_power_suspend' drivers/gpu/drm/gma500/power.c:189: warning: Excess function parameter 'state' description in 'gma_power_suspend' drivers/gpu/drm/gma500/power.c:216: warning: Function parameter or member '_dev' not described in 'gma_power_resume' drivers/gpu/drm/gma500/power.c:216: warning: Excess function parameter 'pdev' description in 'gma_power_resume' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Benjamin Defnet Cc: Rajesh Poornachandran Cc: Alan Cox Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/power.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/gma500/power.c b/drivers/gpu/drm/gma500/power.c index f0fc171e6705e..89842e09cd2aa 100644 --- a/drivers/gpu/drm/gma500/power.c +++ b/drivers/gpu/drm/gma500/power.c @@ -93,6 +93,7 @@ static void gma_suspend_display(struct drm_device *dev) /** * gma_resume_display - resume display side logic + * @pdev: PCI device * * Resume the display hardware restoring state and enabling * as necessary. @@ -146,7 +147,7 @@ static void gma_suspend_pci(struct pci_dev *pdev) /** * gma_resume_pci - resume helper - * @dev: our PCI device + * @pdev: our PCI device * * Perform the resume processing on our PCI device state - rewrite * register state and re-enable the PCI device @@ -178,7 +179,7 @@ static bool gma_resume_pci(struct pci_dev *pdev) /** * gma_power_suspend - bus callback for suspend - * @pdev: our PCI device + * @_dev: our device * @state: suspend type * * Called back by the PCI layer during a suspend of the system. We @@ -208,7 +209,7 @@ int gma_power_suspend(struct device *_dev) /** * gma_power_resume - resume power - * @pdev: PCI device + * @_dev: our device * * Resume the PCI side of the graphics and then the displays */ From patchwork Fri Jan 15 18:12:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366130 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DDE9C43333 for ; Fri, 15 Jan 2021 18:15:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75DC623A58 for ; Fri, 15 Jan 2021 18:15:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388214AbhAOSP3 (ORCPT ); Fri, 15 Jan 2021 13:15:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388118AbhAOSPT (ORCPT ); Fri, 15 Jan 2021 13:15:19 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 546F2C0617AA for ; Fri, 15 Jan 2021 10:13:49 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id 91so10212756wrj.7 for ; Fri, 15 Jan 2021 10:13:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DX8peXw6vQkx3jgWc3AcDMwXWV0VAjfbUs3tjUz1hsU=; b=ueBZVZqMr1lRsNLHjtgml8MUHZ8WPI5E1fhSjTu3fXUJMjMMvwHI/uSOLq9dNiDaBZ l8D48/8MD8sGUTJ7ok+RfTlAepBXTN0/ReLbpyiQ1n5RfIrI7AU71FkZBZlsTKbFbl9C GX699dS+59SbIwW+me01VcUegxQz5X+mAv7xP7fiqrUmFKVcuWVZuN5rxP/oyPjX3Xmb N4jiZhb9Y3K5PK6yRxA1B+pKsXR7dGiJ+EJyQsUhFa7erqWQesY0p9ab6HkI1sTX/xCW pKLVT6RzBila8u6b82o61DhEIKLiKLrfc20PA2LnNCSJ/9d8omqrEejSGYsA5Uprv/26 pQfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DX8peXw6vQkx3jgWc3AcDMwXWV0VAjfbUs3tjUz1hsU=; b=l+6s7B1Edisx6citRyktQIAVBTdl+a3MkwN8lNqejNi4KeFQqvlTet06j/uC6TRbhy rmMYqh0fzqvJ8vjDVZrakEUt1nszKklKWe0LArOVuUk6H1oFr2Z1XgfNAxOyIpJ/7SoO yXm5XgGS5V0NEL0ILJAU2ONsgsEMU2508Ow4TTAFqaheZ3MnWsHmaF6GHmsGhO9T/Xhv pSaYD6IC7r481qeDSY/ZNh92DcM9Wc1Y2Df8p75nF3VPDb1Yh+znDh8V10s1UoEtHXyW RAixt5Ay/MVPCBR6sLGu57BjnvlAIo88S/pPLxWpOL7YE6pWSej88mMqyFdn5uiIpBxC fLyQ== X-Gm-Message-State: AOAM532dLXZynWkvRZDyjB9++3JAARj8kD2yTyAUCSDyOEcpLNB3+omg b8I26Jj8TtaiQ0aeOPA0CfgFwOc2oB2P1IEo X-Google-Smtp-Source: ABdhPJwpTvCHhrRMhMhC083vAOcxnBNtkEy10vvuPrBOfIVJBD37uYFht6hVp6TUpt/pPyifOrjx+w== X-Received: by 2002:a5d:6607:: with SMTP id n7mr14020998wru.206.1610734428099; Fri, 15 Jan 2021 10:13:48 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:47 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 20/40] drm/vmwgfx/vmwgfx_kms: Update worthy function headers and demote others Date: Fri, 15 Jan 2021 18:12:53 +0000 Message-Id: <20210115181313.3431493-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:37: drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:483: warning: Function parameter or member 'new_state' not described in 'vmw_du_cursor_plane_atomic_check' drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:483: warning: Excess function parameter 'state' description in 'vmw_du_cursor_plane_atomic_check' drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1069: warning: Function parameter or member 'vfb' not described in 'vmw_framebuffer_pin' drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1281: warning: Function parameter or member 'dev_priv' not described in 'vmw_kms_srf_ok' drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1907: warning: Function parameter or member 'crtc' not described in 'vmw_get_vblank_counter' drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1915: warning: Function parameter or member 'crtc' not described in 'vmw_enable_vblank' drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1923: warning: Function parameter or member 'crtc' not described in 'vmw_disable_vblank' drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:2131: warning: Function parameter or member 'mode' not described in 'vmw_guess_mode_timing' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index 9293dc19a7683..84143b707cd32 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c @@ -467,7 +467,7 @@ int vmw_du_primary_plane_atomic_check(struct drm_plane *plane, * vmw_du_cursor_plane_atomic_check - check if the new state is okay * * @plane: cursor plane - * @state: info on the new plane state + * @new_state: info on the new plane state * * This is a chance to fail if the new cursor state does not fit * our requirements. @@ -1057,7 +1057,7 @@ static const struct drm_framebuffer_funcs vmw_framebuffer_bo_funcs = { .dirty = vmw_framebuffer_bo_dirty_ext, }; -/** +/* * Pin the bofer in a location suitable for access by the * display system. */ @@ -1267,6 +1267,7 @@ static int vmw_kms_new_framebuffer_bo(struct vmw_private *dev_priv, /** * vmw_kms_srf_ok - check if a surface can be created * + * @dev_priv: Pointer to device private struct. * @width: requested width * @height: requested height * @@ -1896,7 +1897,7 @@ bool vmw_kms_validate_mode_vram(struct vmw_private *dev_priv, } -/** +/* * Function called by DRM code called with vbl_lock held. */ u32 vmw_get_vblank_counter(struct drm_crtc *crtc) @@ -1904,7 +1905,7 @@ u32 vmw_get_vblank_counter(struct drm_crtc *crtc) return 0; } -/** +/* * Function called by DRM code called with vbl_lock held. */ int vmw_enable_vblank(struct drm_crtc *crtc) @@ -1912,7 +1913,7 @@ int vmw_enable_vblank(struct drm_crtc *crtc) return -EINVAL; } -/** +/* * Function called by DRM code called with vbl_lock held. */ void vmw_disable_vblank(struct drm_crtc *crtc) @@ -2120,7 +2121,7 @@ static struct drm_display_mode vmw_kms_connector_builtin[] = { * vmw_guess_mode_timing - Provide fake timings for a * 60Hz vrefresh mode. * - * @mode - Pointer to a struct drm_display_mode with hdisplay and vdisplay + * @mode: Pointer to a struct drm_display_mode with hdisplay and vdisplay * members filled in. */ void vmw_guess_mode_timing(struct drm_display_mode *mode) From patchwork Fri Jan 15 18:12:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366139 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFE7EC433E6 for ; Fri, 15 Jan 2021 18:16:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8205423A58 for ; Fri, 15 Jan 2021 18:16:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387969AbhAOSPE (ORCPT ); Fri, 15 Jan 2021 13:15:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728241AbhAOSOy (ORCPT ); Fri, 15 Jan 2021 13:14:54 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FE7EC0617AB for ; Fri, 15 Jan 2021 10:13:50 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id h17so8029278wmq.1 for ; Fri, 15 Jan 2021 10:13:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dP3O8GvG4KjVneRsCzuySK+Xofh1JQYhFAzp9Cmygd0=; b=NvYZ7daMri4pWwZQmsX5ru4VU0SpWalBIl53yLzN3/Cv4z4K9Il8axaTUtk/Mlvcau +1zefGgSce+JpOwuRVKR3bjhjjlic21dn6xpsJbCJKdmtIUTgynojMfsyD1RiRLzRcOS BUazqGqqSbbAxNfZw4rLZ1d+zkIPJuftk5Y/Van2ipPmeFYkmxf5jYJHtfiDr2togNJ5 busT5EsVamr7PP37HD9pDJ//Ea6+P+0UPXBKsSTwXk304J/xX2a3ngh/9eaGz9wRpcMu MW83FaYOeNLaGah3GsQPDVsikgx72qqFoQ4+YNRiBI3lwcFC9yojl5gaQtTx6w54zp3P Vy8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dP3O8GvG4KjVneRsCzuySK+Xofh1JQYhFAzp9Cmygd0=; b=IcQ3buRb27muR/iN253V6ptg88Y4Lv14/p6Jq5Tdr7dA6jzQc1sW50CDy+Ub7VWcmF 28YczxcQaFVdI0MFOT0nLKCXQmO4r2x4JHLL8XjEqj2vZSYypRQZZC4fKS6+a4x46Ue6 V6oAJ7dBvVAj+8kcup97Pdg6nY/i4RXJtOsoM1sNi1tHJwr3G502X6E7EfqZyEQa4yj+ tVBntlVcd1HjQPMxN6R7XwJAKuEhA8nhC1XNc8PC4wSa/b9k2WVCdIqKfgMmjEtz8Ejn X5vtDnNDkpvAou+7/hLgyW4i2Irc7dhAIMq8QZcIDZq6deCgPZAVK76PnMXDO3IaXd42 k9MA== X-Gm-Message-State: AOAM532FSeQmsXWuZ3uOcuBLpGdGE8ld8H6IYwyDyzPHgusZTODhq3TP sY2yuh1Xtnz+94Lho+6IXRhEgw== X-Google-Smtp-Source: ABdhPJylLVYhZtPQf2lvdbnpBfE2TpTiOfADIk0wEfZBOn1gHRWMAPa8rKFyyYAyBG8ecnMgxD3D8g== X-Received: by 2002:a7b:c385:: with SMTP id s5mr9873876wmj.170.1610734429439; Fri, 15 Jan 2021 10:13:49 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:48 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , Eric Anholt , dri-devel@lists.freedesktop.org Subject: [PATCH 21/40] drm/gma500/gma_display: Demote kernel-doc abuses to standard comment blocks Date: Fri, 15 Jan 2021 18:12:54 +0000 Message-Id: <20210115181313.3431493-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/gma_display.c:27: warning: Function parameter or member 'crtc' not described in 'gma_pipe_has_type' drivers/gpu/drm/gma500/gma_display.c:27: warning: Function parameter or member 'type' not described in 'gma_pipe_has_type' drivers/gpu/drm/gma500/gma_display.c:190: warning: Function parameter or member 'crtc' not described in 'gma_crtc_dpms' drivers/gpu/drm/gma500/gma_display.c:190: warning: Function parameter or member 'mode' not described in 'gma_crtc_dpms' drivers/gpu/drm/gma500/gma_display.c:573: warning: Function parameter or member 'crtc' not described in 'gma_crtc_save' drivers/gpu/drm/gma500/gma_display.c:616: warning: Function parameter or member 'crtc' not described in 'gma_crtc_restore' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Eric Anholt Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/gma_display.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c index cadae842a0e9e..b03f7b8241f2b 100644 --- a/drivers/gpu/drm/gma500/gma_display.c +++ b/drivers/gpu/drm/gma500/gma_display.c @@ -20,7 +20,7 @@ #include "psb_intel_drv.h" #include "psb_intel_reg.h" -/** +/* * Returns whether any output on the specified pipe is of the specified type */ bool gma_pipe_has_type(struct drm_crtc *crtc, int type) @@ -180,7 +180,7 @@ int gma_crtc_gamma_set(struct drm_crtc *crtc, u16 *red, u16 *green, u16 *blue, return 0; } -/** +/* * Sets the power management mode of the pipe and plane. * * This code should probably grow support for turning the cursor off and back @@ -566,7 +566,7 @@ int gma_crtc_set_config(struct drm_mode_set *set, return ret; } -/** +/* * Save HW states of given crtc */ void gma_crtc_save(struct drm_crtc *crtc) @@ -609,7 +609,7 @@ void gma_crtc_save(struct drm_crtc *crtc) crtc_state->savePalette[i] = REG_READ(palette_reg + (i << 2)); } -/** +/* * Restore HW states of given crtc */ void gma_crtc_restore(struct drm_crtc *crtc) From patchwork Fri Jan 15 18:12:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366118 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 043C6C43331 for ; Fri, 15 Jan 2021 18:15:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D054023A59 for ; Fri, 15 Jan 2021 18:15:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387887AbhAOSPA (ORCPT ); Fri, 15 Jan 2021 13:15:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728306AbhAOSOy (ORCPT ); Fri, 15 Jan 2021 13:14:54 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BA1FC0617B0 for ; Fri, 15 Jan 2021 10:13:52 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id a9so6747905wrt.5 for ; Fri, 15 Jan 2021 10:13:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4aoNCmjio9l+rvMx1zGsBoMkbgJVfYu39oKJNZ/3uls=; b=oO4p2Qt7e2zzJjwbtmcEgQslHf38O4Ll5XneLSPcedcp/U955WUp7OBBo6XiOUrCQR 9bHWdzJcJe3/sydkNSJNTJOreeX4oOTwpUTCktEaWWW8sttfSHXciVTMy22hD9F3+Z7u dla+xlHuqn4W6StDx1+0ZvM8+HJevlmInFOs5KwEZ7Rb6VUMPb9aqqL+XHDsjQMlQlMz a0CdfQ38BCdPa9Y/pkBO7Wo2o6ZeA4Opq/q7PR2FSheFdYQdiLgVB44MHFLilMYiYVG9 ZysciPyZ2KEm1ky3FthuachRs994pMprRdfD9QOSZiWP6Eez1kOX5QFHhyk9YwJhmTEl acgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4aoNCmjio9l+rvMx1zGsBoMkbgJVfYu39oKJNZ/3uls=; b=dvo0GjKt/Cx6ogjTdAvsupfnvfuozGxhlY/xorGO3rgrt+whhGsz4w3HY6313lgD/4 gtdzcB2JvKGbSbHmX1QqAEDGwYoVkJbZaoAHpog8nYTyIi60p2FJYsSULY+k7WK9IObx /NenF4XPrqF0zP3mCvm6F0z8fOnSJ1WEeK1r7ZuZWXRTuG0/QpUMPnw3g36YJtTCTm+l /GBhllQb78BnInkjDvARET2symDywpkCX6YgcZZcXZy+6O0uGnyDYumX1ixM57ctqsRk ZvnfQUjOFKMZK5lMZW1o4PtnVcLTJUf1XB4eVQX6703lzAp36s/rOduRYJU74IaZKMIM hM4w== X-Gm-Message-State: AOAM530nJgDuF944UoO4aEGkPD+VYjxVhOVWgabzTlqXQKyqR+x6pQZJ qhw39wlSIhz74f7Ta9Kx2KM/Hw== X-Google-Smtp-Source: ABdhPJyPDU+rAWr+95CjBqCha9HFpSx3cJkKiSRB/6/qt1lCEMkfnxYyUnFr5HtNk7VsyimbxHcgyw== X-Received: by 2002:a5d:4c45:: with SMTP id n5mr14778574wrt.396.1610734431166; Fri, 15 Jan 2021 10:13:51 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:50 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 22/40] drm/gma500/gma_device: Include our own header containing prototypes Date: Fri, 15 Jan 2021 18:12:55 +0000 Message-Id: <20210115181313.3431493-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/gma_device.c:10:6: warning: no previous prototype for ‘gma_get_core_freq’ [-Wmissing-prototypes] Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/gma_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/gma500/gma_device.c b/drivers/gpu/drm/gma500/gma_device.c index cfbeb010ede0d..4c91e86f4b142 100644 --- a/drivers/gpu/drm/gma500/gma_device.c +++ b/drivers/gpu/drm/gma500/gma_device.c @@ -6,6 +6,7 @@ **************************************************************************/ #include "psb_drv.h" +#include "gma_device.h" void gma_get_core_freq(struct drm_device *dev) { From patchwork Fri Jan 15 18:12:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366136 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71304C433E6 for ; Fri, 15 Jan 2021 18:16:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 412DB23A5A for ; Fri, 15 Jan 2021 18:16:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388297AbhAOSP7 (ORCPT ); Fri, 15 Jan 2021 13:15:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388123AbhAOSPT (ORCPT ); Fri, 15 Jan 2021 13:15:19 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DE00C0617B1 for ; Fri, 15 Jan 2021 10:13:54 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id 7so2966928wrz.0 for ; Fri, 15 Jan 2021 10:13:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MJ7KZtujQH+M7WYSfXjbrtwaSb8NJHqNOy8ewxmrog0=; b=OSCRWS4K/ajKw4Zi62PGwkpsViCnA1HR+jyZqd33c/Gif+UcKSsDy8nuLWTbb3ulgG Rj1cIl3zLmJhOQ3MJPneCnt9fDjPHh5TAsfxE+72eyp+SUxRNiB4p2PuxgDlimgbLUfa plzZs5+VpWcoElqvf5DLn2vTz/22SVU+wUWqit2ToY3K6EJV9XUQ+ph5uPLgHKMhFqgc ABpG/zvcdfEn+mOSiw5xbsC8VcrnmFCCim8bHA8vH58iFKjf2Muercbsjc0M/Ij4NJnJ nPbsjeMoJUMrj12Y4ywpbkhGfEDkDECm04cazUNkd7SpfTE/ocAR7f2LFr2Qf1wjiVbl EQXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MJ7KZtujQH+M7WYSfXjbrtwaSb8NJHqNOy8ewxmrog0=; b=rH5SYQBV3x3DImBQC933QNcBxa1n+uo5v5TWYEaYv3nA8oy5Js5G2lGd5fXyB1TlbJ DZa8HPM7ZNUq7go1sAxfXU8FMqI01tA6EEBX7FincgrCVqEHE8AyGBxuE3DTgwYCgLpB pylVNh5e3yMzJnTCwFv5/FuIqol/oKtNLkxSRFNnKUqIG7w1IysDj/2wduZEyul+4k+K MNf33RqdRJZWwFAn7RXpcRqUy0lj6ywfr9nnr01hHW4lXXeoRNYma2aZHVvwvTkMHX6a dnM30vA8cE38Ia0bUywuo6yMCdyijiL5mR4E/zShSJzavGGwYh/Ggf7tzBVKKDDqbFvd nB1g== X-Gm-Message-State: AOAM533/aAkuT7hue5n2IguBScs187kXnJBwqceHZ8D7IVKPQhh01/bM iv+XOf02/ux+1qyOrXSlvYMnEQ== X-Google-Smtp-Source: ABdhPJwTmbb/YEI7MMSglrxGwfHJHkweU2le7lzyioimqu7GtEcCKqgv4qCRYVcve28UlB7pszj7eA== X-Received: by 2002:adf:dc84:: with SMTP id r4mr14097827wrj.232.1610734433220; Fri, 15 Jan 2021 10:13:53 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:52 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 23/40] drm/vmwgfx/vmwgfx_overlay: Demote kernel-doc abuses to standard comment blocks Date: Fri, 15 Jan 2021 18:12:56 +0000 Message-Id: <20210115181313.3431493-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:48: warning: cannot understand function prototype: 'struct vmw_overlay ' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:98: warning: Function parameter or member 'dev_priv' not described in 'vmw_overlay_send_put' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:98: warning: Function parameter or member 'buf' not described in 'vmw_overlay_send_put' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:98: warning: Function parameter or member 'arg' not described in 'vmw_overlay_send_put' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:98: warning: Function parameter or member 'interruptible' not described in 'vmw_overlay_send_put' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:186: warning: Function parameter or member 'dev_priv' not described in 'vmw_overlay_send_stop' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:186: warning: Function parameter or member 'stream_id' not described in 'vmw_overlay_send_stop' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:186: warning: Function parameter or member 'interruptible' not described in 'vmw_overlay_send_stop' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:228: warning: Function parameter or member 'dev_priv' not described in 'vmw_overlay_move_buffer' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:228: warning: Function parameter or member 'buf' not described in 'vmw_overlay_move_buffer' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:228: warning: Function parameter or member 'pin' not described in 'vmw_overlay_move_buffer' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:228: warning: Function parameter or member 'inter' not described in 'vmw_overlay_move_buffer' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:253: warning: Function parameter or member 'dev_priv' not described in 'vmw_overlay_stop' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:253: warning: Function parameter or member 'stream_id' not described in 'vmw_overlay_stop' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:253: warning: Function parameter or member 'pause' not described in 'vmw_overlay_stop' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:253: warning: Function parameter or member 'interruptible' not described in 'vmw_overlay_stop' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:301: warning: Function parameter or member 'dev_priv' not described in 'vmw_overlay_update_stream' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:301: warning: Function parameter or member 'buf' not described in 'vmw_overlay_update_stream' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:301: warning: Function parameter or member 'arg' not described in 'vmw_overlay_update_stream' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:301: warning: Function parameter or member 'interruptible' not described in 'vmw_overlay_update_stream' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:364: warning: Function parameter or member 'dev_priv' not described in 'vmw_overlay_resume_all' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:398: warning: Function parameter or member 'dev_priv' not described in 'vmw_overlay_pause_all' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c b/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c index d6d282c13b7f7..ac4a9b7222795 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c @@ -42,7 +42,7 @@ struct vmw_stream { struct drm_vmw_control_stream_arg saved; }; -/** +/* * Overlay control */ struct vmw_overlay { @@ -85,7 +85,7 @@ static inline void fill_flush(struct vmw_escape_video_flush *cmd, cmd->flush.streamId = stream_id; } -/** +/* * Send put command to hw. * * Returns @@ -174,7 +174,7 @@ static int vmw_overlay_send_put(struct vmw_private *dev_priv, return 0; } -/** +/* * Send stop command to hw. * * Returns @@ -216,7 +216,7 @@ static int vmw_overlay_send_stop(struct vmw_private *dev_priv, return 0; } -/** +/* * Move a buffer to vram or gmr if @pin is set, else unpin the buffer. * * With the introduction of screen objects buffers could now be @@ -235,7 +235,7 @@ static int vmw_overlay_move_buffer(struct vmw_private *dev_priv, return vmw_bo_pin_in_vram_or_gmr(dev_priv, buf, inter); } -/** +/* * Stop or pause a stream. * * If the stream is paused the no evict flag is removed from the buffer @@ -285,7 +285,7 @@ static int vmw_overlay_stop(struct vmw_private *dev_priv, return 0; } -/** +/* * Update a stream and send any put or stop fifo commands needed. * * The caller must hold the overlay lock. @@ -353,7 +353,7 @@ static int vmw_overlay_update_stream(struct vmw_private *dev_priv, return 0; } -/** +/* * Try to resume all paused streams. * * Used by the kms code after moving a new scanout buffer to vram. @@ -387,7 +387,7 @@ int vmw_overlay_resume_all(struct vmw_private *dev_priv) return 0; } -/** +/* * Pauses all active streams. * * Used by the kms code when moving a new scanout buffer to vram. From patchwork Fri Jan 15 18:12:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366120 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C63CAC4332E for ; Fri, 15 Jan 2021 18:15:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98C2D23A59 for ; Fri, 15 Jan 2021 18:15:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387819AbhAOSOz (ORCPT ); Fri, 15 Jan 2021 13:14:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387709AbhAOSOy (ORCPT ); Fri, 15 Jan 2021 13:14:54 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A1D6C0617B9 for ; Fri, 15 Jan 2021 10:13:56 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id h17so8029565wmq.1 for ; Fri, 15 Jan 2021 10:13:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hkjVIWYW/KwOeSMeepZX/DgNoniQl+ISNQgSsOehQ7w=; b=e8cdNWXBmpQJjHdYaGaiiOV72MbqMOAfosJeSNF2+rOWE8iWHIL8KpTY/GJYgidnKE jj7e8KOn3o+IrhJJErokkJ6Nh7YalhwnOrzgXCHFsVgT7ZvATMqt5GiH/eQqypt57fof bHVB12h2oBpCsG8i6tABHi6sPliAU29Q5rjklZHnZYgGvYrdAT5kIJA/vjOp86Tq8GMo 0PLTSpVqJsDh3evacDad2VliCH+v9s2Qwy6smrPGG46xrBI1yWNnhtVFBfjDa++xLgcA F5X7jbVQWJMHPG9tx8gotkTh8xa8ikP9QThNviQpccrExUvz+tq/kf+AYixxBEzTfBBv 6vvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hkjVIWYW/KwOeSMeepZX/DgNoniQl+ISNQgSsOehQ7w=; b=XUiLGuf2NnMsZPN4X8KXmWaYvU+/dudNy+Pf6CfYo/ECLxM3OJ+CLCsDQx8iHgpF7D rdpfsErouu4EUG8C44jQkFYYLVNCc7T2VBZVsYX+Mw7w0LCpUJmuOR5Em5mOZkCujCR2 8T+RpTjzDXau1EvdXnTKOyemwuBOYpDX/9kBuJDr8fLmLtWGc6PbPyKPUIiFgnBGrwua hpcXn8Euv/2dm3p4/I2MzPPhoLPdsqhk3NnZwUctcc8F2kSxVRhcsAYK4UWLzgho8JKS /9nF6PYItqWgr1oFlCQ1R6QEQ1r7bTQ5lSZBXxcMN7qfpM/tmpQJ3wLFEeJrp39qv5+Y LStA== X-Gm-Message-State: AOAM533fEz0afFh1CvRq2ktCCpfFlAwwU6AY210Csg2xtxfRbtH2F12s Cjhrf45PFpcpIJoruquB2K48nA== X-Google-Smtp-Source: ABdhPJxFzNsNFSsSnvoi1hcE7mQAkrSmJha8bR1Hw+CmHAFQ6ayTeWQ9uEK39Q3r/nueb1EHW6SMwA== X-Received: by 2002:a1c:df85:: with SMTP id w127mr10178071wmg.166.1610734435308; Fri, 15 Jan 2021 10:13:55 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:54 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , Eric Anholt , dri-devel@lists.freedesktop.org Subject: [PATCH 24/40] drm/gma500/psb_intel_display: Demote kernel-doc formatting abuse Date: Fri, 15 Jan 2021 18:12:57 +0000 Message-Id: <20210115181313.3431493-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/psb_intel_display.c:79: warning: Function parameter or member 'dev' not described in 'psb_intel_panel_fitter_pipe' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Eric Anholt Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/psb_intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c index 531c5485be172..9c3cb1b80bbdb 100644 --- a/drivers/gpu/drm/gma500/psb_intel_display.c +++ b/drivers/gpu/drm/gma500/psb_intel_display.c @@ -71,7 +71,7 @@ static void psb_intel_clock(int refclk, struct gma_clock_t *clock) clock->dot = clock->vco / clock->p; } -/** +/* * Return the pipe currently connected to the panel fitter, * or -1 if the panel fitter is not present or not in use */ From patchwork Fri Jan 15 18:12:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366143 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F4E3C433DB for ; Fri, 15 Jan 2021 18:16:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1929823A58 for ; Fri, 15 Jan 2021 18:16:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387912AbhAOSPC (ORCPT ); Fri, 15 Jan 2021 13:15:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387720AbhAOSOy (ORCPT ); Fri, 15 Jan 2021 13:14:54 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1C11C0617BA for ; Fri, 15 Jan 2021 10:13:57 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id u14so4192485wmq.4 for ; Fri, 15 Jan 2021 10:13:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sVt/rdeEBQJxQhCHaNNlJJAtPDszt4A5bvtFCOyl0bM=; b=Sc/GUxuyiRJdn91hjCasO8KQhK49SFIeOpJhYv2lzYtBvkAlPg1J9p06riSFlV52cg eqjong14hahD5tYf/SWgSY7FTLqjwLxFVOQjhZ0A+bLdZoOhW2Rj0yBMVKNunVjwC99i xCLJjxjHEERinfZ3cVdz25AdxZEv+UgtMEx58Klerqd/p/6PojbafmMNGuwavXsFq3gp oJlKuBoiUgKuDAyMrUQCXNfEDG0G/PbqoiELOZ07j1YQtFVQF1VQKS+1m5/THHK3ORhh 4VnaEpCaBLqdVagjmeOKsx6g5zEOkqRVnilaL3kZpSR6ZuTJuVZQx8HHBuv0Ho6CTIHE DG6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sVt/rdeEBQJxQhCHaNNlJJAtPDszt4A5bvtFCOyl0bM=; b=notFu0gcf3EkMEe9l460JOkohtQKBAh0XlYod2njxzQ3qg9ObHEhnEOKUxEKc95BJJ 3+3YN2s/e/MGB/hEAOVdNGDJbsfjUKGT0wHL6iIxkfXA4rJy4wPIC0mLaV9qB1ETF29u fKVL2v8fvnm+KhFXBAhIx6xH1vdKvNw7awBTeMS3kaLoMlPXn32oW5Clum9/6Aa6pRr3 /TI9GVsTQ66TVqHApvlOP5vzVo7v69nsULHtHvkUH0oxn9wCnOXD8l6gcDK37WWirjIE +b10PrNcf4S/jn160cG0cdIwdcaQPsQE+ENGNhh7EOY3iNSiKZw+whqNuglJ4/99zQu/ YN3g== X-Gm-Message-State: AOAM533gM9JMfszsIXiMA30VsRE21yFMHQsPSg9y0EnJfmpOGd7Hx2oe TJ/ZP4Jd3tPG6DorTFxAJYPmNQ== X-Google-Smtp-Source: ABdhPJzNu8NawRYjrPv3ZUrXYULqlHq3ph+lO3U+klIyj/QTDgnxMgxhqUqT5ChkSfSse1V3ZfphXA== X-Received: by 2002:a7b:c2e8:: with SMTP id e8mr9708669wmk.103.1610734436402; Fri, 15 Jan 2021 10:13:56 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:55 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , Eric Anholt , Jesse Barnes , dri-devel@lists.freedesktop.org Subject: [PATCH 25/40] drm/gma500/psb_intel_lvds: Supply description for 'mode_dev' Date: Fri, 15 Jan 2021 18:12:58 +0000 Message-Id: <20210115181313.3431493-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/psb_intel_lvds.c:635: warning: Function parameter or member 'mode_dev' not described in 'psb_intel_lvds_init' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Eric Anholt Cc: Jesse Barnes Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/psb_intel_lvds.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/gma500/psb_intel_lvds.c b/drivers/gpu/drm/gma500/psb_intel_lvds.c index f65a6f386caed..ace95d4bdb6f8 100644 --- a/drivers/gpu/drm/gma500/psb_intel_lvds.c +++ b/drivers/gpu/drm/gma500/psb_intel_lvds.c @@ -626,6 +626,7 @@ const struct drm_connector_funcs psb_intel_lvds_connector_funcs = { /** * psb_intel_lvds_init - setup LVDS connectors on this device * @dev: drm device + * @mode_dev: mode device * * Create the connector, register the LVDS DDC bus, and try to figure out what * modes we can display on the LVDS panel (if present). From patchwork Fri Jan 15 18:12:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366119 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4A81C4332D for ; Fri, 15 Jan 2021 18:15:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B705823A58 for ; Fri, 15 Jan 2021 18:15:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387867AbhAOSO6 (ORCPT ); Fri, 15 Jan 2021 13:14:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387790AbhAOSOy (ORCPT ); Fri, 15 Jan 2021 13:14:54 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4A16C0613C1 for ; Fri, 15 Jan 2021 10:13:58 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id y17so10190758wrr.10 for ; Fri, 15 Jan 2021 10:13:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YdGEIo0hl2Rfpl/h+Jq0+PenJy8U5mbtMlzqWbcxCkg=; b=nn+YQQ3tBavKBlOFL7sT7bojtBwspT5MdJqIVfqTvMbPS+d2dEqAdBTVblOgzuynOQ Olk3p9M/630y78Ld02C5b4c2E1yI/CegVOo0NaSyJtAcPz1l3o0q4R5R3R9iIRuOn77r kxrI9Zwdd4q3BS9xicvx8dfaNIuzw3CoE9v2aObzi/BiIN8qVM6nCVaQXl+pIU9nxsya O4/5uD8YtnZJ1rj3KZJsnJ8wHzNbOQfDmlS1/7bIW1dGKnk2aqMM/npcyjg7b6vVqE1S jxW3enZtU+ZYPgAUpoXU9klmE3OVP67lIRz99VbnxcfhwDsy7TPk5Ojc3EAfpVqLU24B 5xCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YdGEIo0hl2Rfpl/h+Jq0+PenJy8U5mbtMlzqWbcxCkg=; b=qK9tFcgN2lSqD6RlaeTiHLNDuKZcMaLU3MU+9VCsmMJ2heh/VJBxWOqFiw+UUwvrnn suicKqpnHszbqN3bMmuWdszP1v2+JcP/3oftvsui31U/qcKaPArwTEsYWpTflmWaZQ1L mIcvpM2H2rQel1bhkT5QgCwv7u86sX+thXfeTpOzfZOjF7L7GrK4SZMsOSPQcP30cHDg WF0ASyhxAGfdqcbsvhFOSaj8PTZX9Es3CedLb1od8onv9JxeGrZVXg+KgU/7xRvW+W+9 3pXrgrlcQRa0dd79Uep81bBqhMYYo4MycWfdEjFQLZ2Ds1xU1rfW7Mm+0iRElBjgeDSk e1GQ== X-Gm-Message-State: AOAM530+xLfUG9YLshS0LUS/M15lmd0t7T9uBcr7TXwhOCdgFbFRBtvv RAKOWlcUn+8ydWIalqmEk6s+VA== X-Google-Smtp-Source: ABdhPJwoFUexa7yf+5Xx+spu+w33pAquyESNB70QCWuq5Md9/k32C45VD2bWHG3JLcExMyxXr6tD3w== X-Received: by 2002:adf:eac7:: with SMTP id o7mr14553458wrn.23.1610734437578; Fri, 15 Jan 2021 10:13:57 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:56 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH 26/40] drm/vmwgfx/vmwgfx_fence: Add, remove and demote various documentation params/headers Date: Fri, 15 Jan 2021 18:12:59 +0000 Message-Id: <20210115181313.3431493-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:82: warning: Function parameter or member 'event' not described in 'vmw_event_fence_action' drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:113: warning: Function parameter or member 'f' not described in 'vmw_fence_obj_destroy' drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:261: warning: Function parameter or member 'work' not described in 'vmw_fence_work_func' drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:720: warning: Function parameter or member 'fman' not described in 'vmw_fence_fifo_down' drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:963: warning: Function parameter or member 'fence' not described in 'vmw_fence_obj_add_action' drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:963: warning: Function parameter or member 'action' not described in 'vmw_fence_obj_add_action' drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:1021: warning: Function parameter or member 'tv_sec' not described in 'vmw_event_fence_action_queue' drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:1021: warning: Function parameter or member 'tv_usec' not described in 'vmw_event_fence_action_queue' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c index 378ec7600154b..23523eb3cac2a 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c @@ -58,13 +58,11 @@ struct vmw_user_fence { /** * struct vmw_event_fence_action - fence action that delivers a drm event. * - * @e: A struct drm_pending_event that controls the event delivery. * @action: A struct vmw_fence_action to hook up to a fence. + * @event: A pointer to the pending event. * @fence: A referenced pointer to the fence to keep it alive while @action * hangs on it. * @dev: Pointer to a struct drm_device so we can access the event stuff. - * @kref: Both @e and @action has destructors, so we need to refcount. - * @size: Size accounted for this object. * @tv_sec: If non-null, the variable pointed to will be assigned * current time tv_sec val when the fence signals. * @tv_usec: Must be set if @tv_sec is set, and the variable pointed to will @@ -87,7 +85,7 @@ fman_from_fence(struct vmw_fence_obj *fence) return container_of(fence->base.lock, struct vmw_fence_manager, lock); } -/** +/* * Note on fencing subsystem usage of irqs: * Typically the vmw_fences_update function is called * @@ -250,7 +248,7 @@ static const struct dma_fence_ops vmw_fence_ops = { }; -/** +/* * Execute signal actions on fences recently signaled. * This is done from a workqueue so we don't have to execute * signal actions from atomic context. @@ -708,7 +706,7 @@ int vmw_wait_dma_fence(struct vmw_fence_manager *fman, } -/** +/* * vmw_fence_fifo_down - signal all unsignaled fence objects. */ @@ -948,8 +946,8 @@ static void vmw_event_fence_action_cleanup(struct vmw_fence_action *action) /** * vmw_fence_obj_add_action - Add an action to a fence object. * - * @fence - The fence object. - * @action - The action to add. + * @fence: The fence object. + * @action: The action to add. * * Note that the action callbacks may be executed before this function * returns. @@ -1001,6 +999,10 @@ static void vmw_fence_obj_add_action(struct vmw_fence_obj *fence, * @fence: The fence object on which to post the event. * @event: Event to be posted. This event should've been alloced * using k[mz]alloc, and should've been completely initialized. + * @tv_sec: If non-null, the variable pointed to will be assigned + * current time tv_sec val when the fence signals. + * @tv_usec: Must be set if @tv_sec is set, and the variable pointed to will + * be assigned the current time tv_usec val when the fence signals. * @interruptible: Interruptible waits if possible. * * As a side effect, the object pointed to by @event may have been From patchwork Fri Jan 15 18:13:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366133 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BFBBC433E9 for ; Fri, 15 Jan 2021 18:15:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5576323A5A for ; Fri, 15 Jan 2021 18:15:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388282AbhAOSPr (ORCPT ); Fri, 15 Jan 2021 13:15:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388126AbhAOSPT (ORCPT ); Fri, 15 Jan 2021 13:15:19 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0113AC061793 for ; Fri, 15 Jan 2021 10:14:00 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id d26so10188181wrb.12 for ; Fri, 15 Jan 2021 10:13:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Clem9oGlYEGrbDU0lDjY42b02EcBqg1/k29GPavGgpg=; b=w7kJiKffb+UC6FN4MbUl3hcif4Ao5PrzLRGEJBPBjkUCSG9AJgdTwQm0TtB3bhU4eC 2E5zcBTxMAM9x7bVsuwBM4gxxzPdYkRkC9mJ7Yyl0LUZpwSFrevFqHUQ11rXy7O1CcjA huRymOZyg36Fs7ojzhz66e0zhryoc5NCBAj+WSUBIsDLS4H2oemqmnZC3w+C/RYBvLdV SYf6iz35K1ReS5FwE6GOuzYP0ISGJsazo9iwFUl/U0MJn9GPMmHZaK8HrTQbRNTbvaG1 do7wy1cbFdwiVT2Zns7YE2MWRne9n7I9qENsTVzKjBYzZL++G+XG6qXkQ6oykegTYwjj eQ9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Clem9oGlYEGrbDU0lDjY42b02EcBqg1/k29GPavGgpg=; b=kssPw4DsNwGlwj/5EDDxQGwsVgcl18pHh9aURTxN0NSr4zvmM73QdT+g1es0jjm6NW OhSkdUjlPMEQmEwA1P1CRyLUFC5uK+RdJawHn5iMzxDDHaEqYHTrtsLepPMdkOT55KEX KwQS4w0A7WeJNmKCqt9c026TFgNb7gGRuP/S8NJJsotm3AuPvSxVAUViRAiKXZBlonTR 4jVc/L3/HD9jY5RcMulxoLSWUPAsD3mixBEETBy2Ulcg4Hp6nFXqxRAxxvT3hSyAxcPY Z9Jyn+dq6PDysoopXSUNwBa7dYv9oU/bO4hBn1MRbzYzukVrmqBcpndouAJDyFXyGydl gVjQ== X-Gm-Message-State: AOAM533SaZeWxD8cyNXaCUPY4DfPa2rXI9jPJpMMv4HvuE6nbMITDdh7 bIex+qBj7M2YFUjDfMky3mf2fw== X-Google-Smtp-Source: ABdhPJyv/fDErsavQlK/fWf8PXQiUArsAlsCjCiC/JaSrC/YrLefouSMJ01A21nPnYQKjJDUWtgXCg== X-Received: by 2002:adf:d187:: with SMTP id v7mr73152wrc.50.1610734438759; Fri, 15 Jan 2021 10:13:58 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:58 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 27/40] drm/vmwgfx/vmwgfx_bo: Remove superfluous param description and supply another Date: Fri, 15 Jan 2021 18:13:00 +0000 Message-Id: <20210115181313.3431493-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_bo.c:142: warning: Excess function parameter 'pin' description in 'vmw_bo_pin_in_vram_or_gmr' drivers/gpu/drm/vmwgfx/vmwgfx_bo.c:647: warning: Function parameter or member 'p_base' not described in 'vmw_user_bo_alloc' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c index 63dbc44eebe0b..ab0844b47d4d7 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c @@ -131,7 +131,6 @@ int vmw_bo_pin_in_placement(struct vmw_private *dev_priv, * * @dev_priv: Driver private. * @buf: DMA buffer to move. - * @pin: Pin buffer if true. * @interruptible: Use interruptible wait. * Return: Zero on success, Negative error code on failure. In particular * -ERESTARTSYS if interrupted by a signal @@ -635,6 +634,7 @@ static void vmw_user_bo_ref_obj_release(struct ttm_base_object *base, * @handle: Pointer to where the handle value should be assigned. * @p_vbo: Pointer to where the refcounted struct vmw_buffer_object pointer * should be assigned. + * @p_base: The TTM base object pointer about to be allocated. * Return: Zero on success, negative error code on error. */ int vmw_user_bo_alloc(struct vmw_private *dev_priv, From patchwork Fri Jan 15 18:13:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366135 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C57EC433E6 for ; Fri, 15 Jan 2021 18:15:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E25823A5E for ; Fri, 15 Jan 2021 18:15:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388248AbhAOSPo (ORCPT ); Fri, 15 Jan 2021 13:15:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388129AbhAOSPT (ORCPT ); Fri, 15 Jan 2021 13:15:19 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FD4FC061794 for ; Fri, 15 Jan 2021 10:14:01 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id u14so4192639wmq.4 for ; Fri, 15 Jan 2021 10:14:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eAMyYaaj1VFxGbNOafp+nzJ0Q2eH0I8k2Xo9CJpOSL4=; b=yVjWmOGvJzeDni3tCIMOzMmMGeotfx0zrqnDbf4Clmyd04/rjS+q0vmqap5y7zg4Io 7h1D4HYxOw/emRxXYKSS0UPCw+YELiJjQhMGu6Fy0Uj+H1b1v6SEx18+huC92+skY/oE ysSeaM6p0n4eY95XH9EEsl1HIJT0gd5ayHE8di3BTOfP4imM+Ivsp8UyOqj7f4SECp8T naf24hYPEYQWtTPW3tTd4cbe0Y1G8nanx71tnqR/WsoDLa2c2NVoI7n/nf+Yv+wa5XPc CImYGw6BvnacySDNght925HnYU893MxmOQbdVzZhvA0BUaQXeAuUjkStV7Rn3CMAm7HK t/NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eAMyYaaj1VFxGbNOafp+nzJ0Q2eH0I8k2Xo9CJpOSL4=; b=V0U018jEPf7yge/5CmBj/KWLznARfa4CymnvHeg7qx6kfOOzE1mGs4/nKIe7Ucrkxc qX8SBxLiMSvluBdXkDEc5nYtvHZxq9QsvbV2eHS39RntqxkopThphkDPsUirim7RaNfE JPA0C6NSwHj3Yo9glzQLIoGcBoYD4CNn4p4DjBk/r0UMXANEqm8sfuOItJfELKtZLyhy z1pyZvm3JEJRaxQXR0urk3wtbf/axt+ucwDhthqH9cU28lVhrQ+pxjrC0z7ZwP1K4RRe AhFvpInqB6+YqYTtW4bEettY4despsz0Ps3PJkxDYZkY3Q71o/j29WjbLqDK0NeE8j+p 69GA== X-Gm-Message-State: AOAM530sXnLAqcc37KgmTV+gk5h9LFc0GVDwOdhhfYKtJYmjwYumTmqZ Qp5k3tbzaS7nSgjxYrVXfzorvw== X-Google-Smtp-Source: ABdhPJwe9r4nkJlVMT4urFaM/FAN0HUOKO2Kd3dORP++jhEf8U1Dg6bSWhgp5TG+hNJ3w3cTCkA9Rw== X-Received: by 2002:a7b:ce96:: with SMTP id q22mr10104491wmj.165.1610734439880; Fri, 15 Jan 2021 10:13:59 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.13.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:13:59 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 28/40] drm/vmwgfx/vmwgfx_context: Demote kernel-doc abuses Date: Fri, 15 Jan 2021 18:13:01 +0000 Message-Id: <20210115181313.3431493-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_context.c:121: warning: Function parameter or member 'dev_priv' not described in 'vmw_context_cotables_unref' drivers/gpu/drm/vmwgfx/vmwgfx_context.c:121: warning: Function parameter or member 'uctx' not described in 'vmw_context_cotables_unref' drivers/gpu/drm/vmwgfx/vmwgfx_context.c:681: warning: Function parameter or member 'base' not described in 'vmw_user_context_base_to_res' drivers/gpu/drm/vmwgfx/vmwgfx_context.c:707: warning: Function parameter or member 'p_base' not described in 'vmw_user_context_base_release' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_context.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_context.c b/drivers/gpu/drm/vmwgfx/vmwgfx_context.c index 6f4d0da11ad87..4a5a3e246216d 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_context.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_context.c @@ -112,7 +112,7 @@ static const struct vmw_res_func vmw_dx_context_func = { .unbind = vmw_dx_context_unbind }; -/** +/* * Context management: */ @@ -672,7 +672,7 @@ static int vmw_dx_context_destroy(struct vmw_resource *res) return 0; } -/** +/* * User-space context management: */ @@ -698,7 +698,7 @@ static void vmw_user_context_free(struct vmw_resource *res) vmw_user_context_size); } -/** +/* * This function is called when user space has no more references on the * base object. It releases the base-object's reference on the resource object. */ From patchwork Fri Jan 15 18:13:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366134 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69640C43381 for ; Fri, 15 Jan 2021 18:15:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 390ED23A59 for ; Fri, 15 Jan 2021 18:15:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388266AbhAOSPp (ORCPT ); Fri, 15 Jan 2021 13:15:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388130AbhAOSPT (ORCPT ); Fri, 15 Jan 2021 13:15:19 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACD75C0617BB for ; Fri, 15 Jan 2021 10:14:02 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id q18so10221363wrn.1 for ; Fri, 15 Jan 2021 10:14:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4hRh93h6Ap5slKiR2lojMOAMN9uOZEFE9uCUxTKVOZ0=; b=L0fqAYHr8HLZtGjdqMD143kc5XmQf/YmOSw8lmVA5+T5CRtjE9urWP4t6hYR+S6CAO ztAgllI0d8M0uqueieIkohfp9oCqK27wJMQhv8bkCxXCJ5RYYmhzJXcFdvWuFzxYHzzE GTz6bJ3ekyz3tyS+3yR/RaMYzkpnFo8ZVCJpPlczC6hiddMbhW+OxqJHAGqF04pnhtSv twSm+JNMxuLSqH0/7Bj4Uk0YgMHzX+eRqY3oaK8oNZIOhixgAZM1kuQV4o7B8BzC8epj HAwePLUZBut2Qg0JMkUIPR4Vc5VFau5RnU/7pha5iK+oPtgoqGMtP7QDgn45Wb55z8MT NhZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4hRh93h6Ap5slKiR2lojMOAMN9uOZEFE9uCUxTKVOZ0=; b=nGm6wDbEGE6EdX54+fZFXjTZpD/XPgd4c3+jpuQxC6OI2syvbnMa6xD6quQs3qlTrn cLidVnpbptTFDGpq+dVvaQnRtYeJtNZ9ZDnEV3CIGgmFLepltevnAMe6QpWEts0lImDm DgNVnuYR/uBlVlkOnng5sp3TmyJ9yeSifrLbLkJeMjMpiUYLtLOJkOVUs61AypZrXxIB z/KtSf9dmpP2gGtE5LcTf/MCzzY9ahF2SpmIZeQhnVJp98YsQmncTD92xBTPnW13uPUc F9eCDlJ/kKIEoc5/jDithPzddtvtenL9kSj5mNAW+AXOpx8BbQEGc4AoeBUVKHZTnHpH V7BQ== X-Gm-Message-State: AOAM532u/dIf+Tf97eZcMurkI2+nhDuoKBztAjjFels+haQkff6o6Q2a YP9fhf6NQgJhrat2sYvKjJcf6Q== X-Google-Smtp-Source: ABdhPJwC47WOemGmAPk2kis09Wl6b15wqaHG88CkeWRKRwzEE16uui9xQCF4DGMAYfV5I1KkHL5FtQ== X-Received: by 2002:a5d:6749:: with SMTP id l9mr14597082wrw.395.1610734441481; Fri, 15 Jan 2021 10:14:01 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.14.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:14:00 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 29/40] drm/vmwgfx/vmwgfx_scrn: Demote unworthy kernel-doc headers and update others Date: Fri, 15 Jan 2021 18:13:02 +0000 Message-Id: <20210115181313.3431493-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:90: warning: cannot understand function prototype: 'struct vmw_screen_object_unit ' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:122: warning: Function parameter or member 'dev_priv' not described in 'vmw_sou_fifo_create' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:122: warning: Function parameter or member 'sou' not described in 'vmw_sou_fifo_create' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:122: warning: Function parameter or member 'x' not described in 'vmw_sou_fifo_create' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:122: warning: Function parameter or member 'y' not described in 'vmw_sou_fifo_create' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:122: warning: Function parameter or member 'mode' not described in 'vmw_sou_fifo_create' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:168: warning: Function parameter or member 'dev_priv' not described in 'vmw_sou_fifo_destroy' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:168: warning: Function parameter or member 'sou' not described in 'vmw_sou_fifo_destroy' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:283: warning: Function parameter or member 'state' not described in 'vmw_sou_crtc_atomic_enable' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:293: warning: Function parameter or member 'state' not described in 'vmw_sou_crtc_atomic_disable' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c index b0db059b8cfbe..6feb61a1a3041 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c @@ -84,7 +84,7 @@ struct vmw_kms_sou_define_gmrfb { SVGAFifoCmdDefineGMRFB body; }; -/** +/* * Display unit using screen objects. */ struct vmw_screen_object_unit { @@ -112,7 +112,7 @@ static void vmw_sou_crtc_destroy(struct drm_crtc *crtc) vmw_sou_destroy(vmw_crtc_to_sou(crtc)); } -/** +/* * Send the fifo command to create a screen. */ static int vmw_sou_fifo_create(struct vmw_private *dev_priv, @@ -160,7 +160,7 @@ static int vmw_sou_fifo_create(struct vmw_private *dev_priv, return 0; } -/** +/* * Send the fifo command to destroy a screen. */ static int vmw_sou_fifo_destroy(struct vmw_private *dev_priv, @@ -263,7 +263,7 @@ static void vmw_sou_crtc_mode_set_nofb(struct drm_crtc *crtc) /** * vmw_sou_crtc_helper_prepare - Noop * - * @crtc: CRTC associated with the new screen + * @crtc: CRTC associated with the new screen * * Prepares the CRTC for a mode set, but we don't need to do anything here. */ @@ -275,6 +275,7 @@ static void vmw_sou_crtc_helper_prepare(struct drm_crtc *crtc) * vmw_sou_crtc_atomic_enable - Noop * * @crtc: CRTC associated with the new screen + * @state: Unused * * This is called after a mode set has been completed. */ @@ -287,6 +288,7 @@ static void vmw_sou_crtc_atomic_enable(struct drm_crtc *crtc, * vmw_sou_crtc_atomic_disable - Turns off CRTC * * @crtc: CRTC to be turned off + * @state: Unused */ static void vmw_sou_crtc_atomic_disable(struct drm_crtc *crtc, struct drm_atomic_state *state) From patchwork Fri Jan 15 18:13:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366121 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB96AC433E6 for ; Fri, 15 Jan 2021 18:15:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A219F23A59 for ; Fri, 15 Jan 2021 18:15:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388007AbhAOSPI (ORCPT ); Fri, 15 Jan 2021 13:15:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387805AbhAOSOz (ORCPT ); Fri, 15 Jan 2021 13:14:55 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9D61C0617BC for ; Fri, 15 Jan 2021 10:14:03 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id s24so1401015wmj.0 for ; Fri, 15 Jan 2021 10:14:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+0p9zOjVy0LRiK477P9KUaWrIsEvH1MWK05iKsSjHrQ=; b=lmFcqa/mseKa8mnML6PJecGiZ8SxOYeYWnTqqbYBatmO8biGq7K8RpAi7Jz52YFDyx KSxyAT5AFEIc3znyzbwr9qVzmkNpw9QTm15wvCS3PtQSz9EbPruetbXiahzjZbFskPE3 fB2eRAKEX33jhUxXKdnEF4SZOxkUoaRka1IsBxfgLYS4x7aePWvQWE8qWmpFOK0M2oJy zIoB8FRwKWh4QU0seZ6LwXxELNznUrvnUhD6a6opaZt0TXRdAmK3aKk7Bg150QoHORU5 oQ/QCkclp5Pi2InvETySTFtnJR3Cgh5hOu9J4dB5YzmpZj/DTPBMi701y7pfX6h9of0f kzlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+0p9zOjVy0LRiK477P9KUaWrIsEvH1MWK05iKsSjHrQ=; b=Gj7PqC4GtCUETCBryuYDkDnyUYBE+r9MNlSzWEDNBNU+45SWNZfqQexY3Dcat9KY/s vMC8wk4p/O5ZsRDmQcdEAzk3xXSgehax5Uz1G+7LHbh3g3y+RNaPgdFUJ8Xju9reVO/Y 2Sy9xhiEFVg7IAaN5oRpMC8wyvhpsHKBLhcoOVOCSzOcCFBsp4k7n2aVkMTBW2qSf7TS VtQNbaDuWumtsdJEmExzfO5PCDGZs2Tut4TCZ8p03WCjuGl+5c3gLLqRq6ho3MpW7eVg QOtjvbFowAeg9/mdS1wBdMslFV3+SqqeuqVKMXlnL/ZCIUnfR/AlfV3BAycz8NIv3TWg YLwA== X-Gm-Message-State: AOAM5328VKSoDdAKH7rDlZp1pLi2EPKvQUE1EXwnDEuPJGtxJQJQzmMq IaoM3kpez4+NYFOp56JnJxubpg== X-Google-Smtp-Source: ABdhPJxwcEN3TY5oIWcCMU0IpVvqUC2z82+4QsITRQHihwoLctM4iYytSxJx/v5qpT/6dxCkZMwiZQ== X-Received: by 2002:a1c:608b:: with SMTP id u133mr9766353wmb.140.1610734442619; Fri, 15 Jan 2021 10:14:02 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.14.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:14:02 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , Jesse Barnes , dri-devel@lists.freedesktop.org Subject: [PATCH 30/40] drm/gma500/psb_intel_modes: Provide missing descriptions for function param 'adapter' Date: Fri, 15 Jan 2021 18:13:03 +0000 Message-Id: <20210115181313.3431493-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/psb_intel_modes.c:17: warning: Function parameter or member 'adapter' not described in 'psb_intel_ddc_probe' drivers/gpu/drm/gma500/psb_intel_modes.c:51: warning: Function parameter or member 'adapter' not described in 'psb_intel_ddc_get_modes' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Jesse Barnes Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/psb_intel_modes.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_modes.c b/drivers/gpu/drm/gma500/psb_intel_modes.c index 88653a40aeb5c..60306780e16cd 100644 --- a/drivers/gpu/drm/gma500/psb_intel_modes.c +++ b/drivers/gpu/drm/gma500/psb_intel_modes.c @@ -11,7 +11,7 @@ /** * psb_intel_ddc_probe - * + * @adapter: Associated I2C adaptor */ bool psb_intel_ddc_probe(struct i2c_adapter *adapter) { @@ -43,6 +43,7 @@ bool psb_intel_ddc_probe(struct i2c_adapter *adapter) /** * psb_intel_ddc_get_modes - get modelist from monitor * @connector: DRM connector device to use + * @adapter: Associated I2C adaptor * * Fetch the EDID information from @connector using the DDC bus. */ From patchwork Fri Jan 15 18:13:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366122 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDD99C433DB for ; Fri, 15 Jan 2021 18:15:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D3BB23A58 for ; Fri, 15 Jan 2021 18:15:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387985AbhAOSPF (ORCPT ); Fri, 15 Jan 2021 13:15:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387803AbhAOSOz (ORCPT ); Fri, 15 Jan 2021 13:14:55 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F15B0C0617BD for ; Fri, 15 Jan 2021 10:14:04 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id m187so1958711wme.2 for ; Fri, 15 Jan 2021 10:14:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JPqjkgIRJp+MRlYiJIdOLESmtI1+G3x8A3c4gbTlrp8=; b=URYUQikT1ubIBypdWNn5JgBBuXlql29P1qAbd5qPje/NQfeENl1ULvQa//CbMbYFoF b20uBNi16xepfMRbzFAyJRUVZ5MqivZm/jQ3qlfN7rnn+QWmxkY2iaz8w1vQ2BgJSII3 0FwKk8O6S4fT3G1jrL1Nm0znrOhkfTzKQcuxjdDJigTEszxLz87IAitAEMwf4C97U6AX KHGWLXJiXGxqvJNLPK3vjQ0+TiasqtTYfpbhyX8g1IJOabVyiiW4vHc7/d9vvvMkRYZT bAG0gZZTYzUgwzxPPL+V2uepaHxF6vv6mwTy6iwe+9FlYsL9SGj8WiBBjMMNQZgSFKdY uCEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JPqjkgIRJp+MRlYiJIdOLESmtI1+G3x8A3c4gbTlrp8=; b=YgH4PY8FGAPgjoJ30gWIXCTXW119btdbfc0Ehvy+Mtdv2v6VGq2R65LI9gvKf7y7Ab yyTOK2pqK2+KR+bDSwncSHz7wagtiExIdRct1p+xwXPPQ6MOnDeTjDraGFnjFiZVPv1Q Fgw08jNmecBIYWStfA4BvxE8aIRsT79g0Uu0JbvVj6ce85xHYeK7FwR0/bG8qMKcKAoy fLTPUfukRL8gCF63YFYNiq+KGtpZJkZetRAWhBb74IGjjsIPwcp088KnltBokvkFmZ2k fxETVtv+NQkzlcoPtIfJA6k0QRQxzVY214cVkqf0TRS9t6fGjQeb1zieu201naVhfK9t QBPA== X-Gm-Message-State: AOAM532J25/qEUbcjbqUyMEQmPqW4WC0LlejhyQGr1Uh8QFsQkTnDFUQ A2gC1fF6atzIo818sbSGPlFzRw== X-Google-Smtp-Source: ABdhPJw2MMzpvaVQAHHCh49HDDbQw3JQpBE0IuwjQPFWWV6qwKFryTl5zZIFzmE6Gxwu+wLm18l++w== X-Received: by 2002:a1c:2d48:: with SMTP id t69mr9677839wmt.124.1610734443715; Fri, 15 Jan 2021 10:14:03 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.14.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:14:03 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 31/40] drm/gma500/gem: Do not rely on consumers to include drm/drm_device.h before gem.h Date: Fri, 15 Jan 2021 18:13:04 +0000 Message-Id: <20210115181313.3431493-32-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/gem.h:13:57: warning: ‘struct drm_device’ declared inside parameter list will not be visible outside of this definition or declaration Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/gem.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/gma500/gem.h b/drivers/gpu/drm/gma500/gem.h index 3741a711b9fde..bae6454ead292 100644 --- a/drivers/gpu/drm/gma500/gem.h +++ b/drivers/gpu/drm/gma500/gem.h @@ -8,6 +8,8 @@ #ifndef _GEM_H #define _GEM_H +struct drm_device; + extern const struct drm_gem_object_funcs psb_gem_object_funcs; extern int psb_gem_create(struct drm_file *file, struct drm_device *dev, From patchwork Fri Jan 15 18:13:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366125 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E597DC433E9 for ; Fri, 15 Jan 2021 18:15:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B62B623A5A for ; Fri, 15 Jan 2021 18:15:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388042AbhAOSPJ (ORCPT ); Fri, 15 Jan 2021 13:15:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728176AbhAOSO4 (ORCPT ); Fri, 15 Jan 2021 13:14:56 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E26DC0617BE for ; Fri, 15 Jan 2021 10:14:06 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id a9so6748494wrt.5 for ; Fri, 15 Jan 2021 10:14:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H7kqjYWcwKGFjqciQAFyPifJs/CUQ6UusnBVQQ2LEnA=; b=t8+Z985NiQCY1D2zCsot42xG+heah2+ELntWWsNu+kvRMZrmlPFjA3v7RNx9mNzsCx b5cOetQ27f2+guT1vjTkoArcvLofqdC/MEegEdNu/UgYngo4vnnSj2WP3ia83B6v2Kak bCNp/Wh8cbGI9GRGzsJ+GUeWUgIl8gRoxkOltUr9gaoeAhAY072+Fd8mB+OY/7JWahJr jlF8/C6crPHmhJSJIXGyErUptJSdMmu5vIta/Tpown103vkIfV/3YFKoLh24N7FN0AS7 aOFsxPShtl3VSluamHIZ9cYl+lcSKMEwV9w87zjtWc1Di5stNLjRZTF9G5JO9YtUzhfb xPRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H7kqjYWcwKGFjqciQAFyPifJs/CUQ6UusnBVQQ2LEnA=; b=rADvRg3IKGhEkibLhe9MiqLhcymTwjMuH0L4W25kulXaBoVOZ1rj1+xuil96+pIDJB nIn5o/u0uOFwaA1aBTUwfpBCFy6iQ+Tp2WTwkqk09HcQhttFrXPWWlt83wwU6YCDRCXw XdX297aqidC7nnYUmuwVPjgD3wmf9j1qidMMIXz8Y3fWvws5cO/QZ/PwYziBQNWrGxtd EjJ6AOVyc7ysXiyq3emrHifN/kjmREHcYbiPAJxXt8kmu/dR9WaibTxTsMLkrmtbf8ul Rkt4zp9oxVPVDAnA2huI+CSJIVPgca4SSxBxQRph+vjO3gQuvIGkdswg10eYhs78T2MM Gpww== X-Gm-Message-State: AOAM531+Zj+HrsERYHQJiIVGt+meeUaoLQ5lLn1M6gquaEa+w3gOIUJa n6+nwI5eQ2NjAUojDEh38yuvxQ== X-Google-Smtp-Source: ABdhPJzlqzn/CqhwXTx8+dBCcy5NljeBmibdEvqIGWxowfd/wAnWSzYrCIXXS92X76e/88dLB2k35w== X-Received: by 2002:adf:c444:: with SMTP id a4mr10948115wrg.164.1610734444892; Fri, 15 Jan 2021 10:14:04 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.14.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:14:04 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 32/40] drm/gma500/gem: Include our own header containing prototypes Date: Fri, 15 Jan 2021 18:13:05 +0000 Message-Id: <20210115181313.3431493-33-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/gem.c:59:5: warning: no previous prototype for ‘psb_gem_create’ [-Wmissing-prototypes] Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/gem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c index 5ef5480f999e9..fbf420051ef5f 100644 --- a/drivers/gpu/drm/gma500/gem.c +++ b/drivers/gpu/drm/gma500/gem.c @@ -16,6 +16,7 @@ #include #include +#include "gem.h" #include "psb_drv.h" static vm_fault_t psb_gem_fault(struct vm_fault *vmf); From patchwork Fri Jan 15 18:13:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366124 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEB9FC43381 for ; Fri, 15 Jan 2021 18:15:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDD8623A58 for ; Fri, 15 Jan 2021 18:15:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388068AbhAOSPL (ORCPT ); Fri, 15 Jan 2021 13:15:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387821AbhAOSO4 (ORCPT ); Fri, 15 Jan 2021 13:14:56 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DE58C0617BF for ; Fri, 15 Jan 2021 10:14:07 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id 190so8225181wmz.0 for ; Fri, 15 Jan 2021 10:14:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VgdN0p+9AgauwlBNqjDX7pzGp2g9M32RauIGJ4AYbRc=; b=i2F9vJU29UmIkMrVeNmOEvrBiEDn+LqthGClGyh9B3Jod0f/J1EXtUwx0US6OXDk9D r9gqrt1MI0ARJGo8ozkLG+E9nVGMm47Kb4Xsg06qGQi5C8srGBS3T93dWnd8QXH+Qasx iQ/mJUpJtPz2/YRXTQgBud8r5U9mnKe/DKI32KjtRV5xF15jm24cGMpFQkCNNBOC/dTh 6Aev2ZPmNoEs/pQ3vnMkTTwQei7bYaAetIDgVl7Vp/6wZGEnG6RQiATQE0q71Vh3htwR tDbueFONUOs9np+F+6vgJ4B9KwNSVSAxFMkWRuHMYe9e5gjky6hep/W9QLvQCzDCDqnR CM1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VgdN0p+9AgauwlBNqjDX7pzGp2g9M32RauIGJ4AYbRc=; b=CEYDR/yD7JwrGFPjpn5/zKPPABc2bgGCtqtI1jVt04vxG5BkEp9/jHmmRK+64XPzAu 5iHQj+3SaX3Po2KwRDwdy5/Iwy/LbJRaSxEwWwQLCtTL/JGi2/O3/Pxo1xsTY76HT/Vo sBrtPGzswBJ4zhAUxazCVUn59aQPYOBiYKqY7H3HDaHanoYSBPPNHz6T/NXWrhSVYS5/ X85LYtKcDPWv9Evhkh/5KxiYiy0qWjBqGQkJ0F0eoctaEdcBA1MAaj3oNhelMsr0/nQi IU+UljxHjxzqhXhWVBIVioG/mP5sYI+fKeNJnMNXZKl59LKME8xltBkSWQpaCYRSUHcU FLkw== X-Gm-Message-State: AOAM533VTqjVcubWPhdz0Y0Kew6uqVAJxTiIkaXZDEEBocM19LF3EQkg 8dV7Mo/p8fMj67IJwSiGE6+m5G6w476g9+M0 X-Google-Smtp-Source: ABdhPJyaF23bN/RVQAfvgVkV76AdvEQ423UVLbsTMdtr/c4fN/ZfEyAVy5log7dRXgTvHOBLPEEpbg== X-Received: by 2002:a1c:68d5:: with SMTP id d204mr9863246wmc.178.1610734446131; Fri, 15 Jan 2021 10:14:06 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.14.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:14:05 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 33/40] drm/vmwgfx/vmwgfx_surface: Fix some kernel-doc related issues Date: Fri, 15 Jan 2021 18:13:06 +0000 Message-Id: <20210115181313.3431493-34-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:55: warning: Function parameter or member 'prime' not described in 'vmw_user_surface' drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:55: warning: Function parameter or member 'backup_base' not described in 'vmw_user_surface' drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:78: warning: cannot understand function prototype: 'struct vmw_surface_dirty ' drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:173: warning: Function parameter or member 'header' not described in 'vmw_surface_dma' drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:173: warning: Function parameter or member 'body' not described in 'vmw_surface_dma' drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:173: warning: Function parameter or member 'cb' not described in 'vmw_surface_dma' drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:173: warning: Function parameter or member 'suffix' not described in 'vmw_surface_dma' drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:181: warning: Function parameter or member 'header' not described in 'vmw_surface_define' drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:181: warning: Function parameter or member 'body' not described in 'vmw_surface_define' drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:189: warning: Function parameter or member 'header' not described in 'vmw_surface_destroy' drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:189: warning: Function parameter or member 'body' not described in 'vmw_surface_destroy' drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:555: warning: Function parameter or member 'readback' not described in 'vmw_legacy_srf_unbind' drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:1067: warning: Function parameter or member 'res' not described in 'vmw_gb_surface_create' drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:1067: warning: Excess function parameter 'srf' description in 'vmw_gb_surface_create' drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:1067: warning: Excess function parameter 'cmd_space' description in 'vmw_gb_surface_create' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c index f6cab77075a04..c3e55c1376eb8 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c @@ -41,10 +41,12 @@ /** * struct vmw_user_surface - User-space visible surface resource * + * @prime: The TTM prime object. * @base: The TTM base object handling user-space visibility. * @srf: The surface metadata. * @size: TTM accounting size for the surface. - * @master: master of the creating client. Used for security check. + * @master: Master of the creating client. Used for security check. + * @backup_base: The TTM base object of the backup buffer. */ struct vmw_user_surface { struct ttm_prime_object prime; @@ -69,7 +71,7 @@ struct vmw_surface_offset { }; /** - * vmw_surface_dirty - Surface dirty-tracker + * struct vmw_surface_dirty - Surface dirty-tracker * @cache: Cached layout information of the surface. * @size: Accounting size for the struct vmw_surface_dirty. * @num_subres: Number of subresources. @@ -162,7 +164,7 @@ static const struct vmw_res_func vmw_gb_surface_func = { .clean = vmw_surface_clean, }; -/** +/* * struct vmw_surface_dma - SVGA3D DMA command */ struct vmw_surface_dma { @@ -172,7 +174,7 @@ struct vmw_surface_dma { SVGA3dCmdSurfaceDMASuffix suffix; }; -/** +/* * struct vmw_surface_define - SVGA3D Surface Define command */ struct vmw_surface_define { @@ -180,7 +182,7 @@ struct vmw_surface_define { SVGA3dCmdDefineSurface body; }; -/** +/* * struct vmw_surface_destroy - SVGA3D Surface Destroy command */ struct vmw_surface_destroy { @@ -544,6 +546,7 @@ static int vmw_legacy_srf_bind(struct vmw_resource *res, * * @res: Pointer to a struct vmw_res embedded in a struct * vmw_surface. + * @readback: Readback - only true if dirty * @val_buf: Pointer to a struct ttm_validate_buffer containing * information about the backup buffer. * @@ -1060,8 +1063,8 @@ int vmw_surface_reference_ioctl(struct drm_device *dev, void *data, /** * vmw_surface_define_encode - Encode a surface_define command. * - * @srf: Pointer to a struct vmw_surface object. - * @cmd_space: Pointer to memory area in which the commands should be encoded. + * @res: Pointer to a struct vmw_resource embedded in a struct + * vmw_surface. */ static int vmw_gb_surface_create(struct vmw_resource *res) { From patchwork Fri Jan 15 18:13:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366126 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 205B1C4332D for ; Fri, 15 Jan 2021 18:15:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04DF323A58 for ; Fri, 15 Jan 2021 18:15:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388101AbhAOSPP (ORCPT ); Fri, 15 Jan 2021 13:15:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387936AbhAOSPD (ORCPT ); Fri, 15 Jan 2021 13:15:03 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 993A6C061795 for ; Fri, 15 Jan 2021 10:14:08 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id v184so4173106wma.1 for ; Fri, 15 Jan 2021 10:14:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e4bk6qPXM66REGe7AKVzGIJtGtbIBYeQRfbgzaiwlYw=; b=fbb83iZMimVayaujWI7iqzvQdiDkC19anKbQzeQLH9LqVfAVeEbBkPQu4blHEoLKev i3i3zIQCkHlJGER+MRp3TWy9xSSMDlpvtIy+T8YazOBmD33GNLsZnl7rNXojiajHELwb cfXqzHGIWk5gyOSmMyiNZe/p2nKDoGO67Drb4QHc7MZVy5K6Y05wlwy1LkXtY/7aTZX5 s6NjqotAtkTBef5VABXoZTQFMfwN/VaHFPoi2Pgt2WgYoCyKJqnPkAehJwXPmsHli5Z+ 6JX3/EkQaeQjxG+o00JgKm8ma0pfZza2tMXHL+iJTR7bI7/yGXY8jSVIv97xynJUvCuo xupw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e4bk6qPXM66REGe7AKVzGIJtGtbIBYeQRfbgzaiwlYw=; b=ogGDHABQKnXawLmyK3/nfsb2g9lYtf3eEpRYJUmDSE67cLj+HnK8o+nk1gtpzsBlq9 3libI5LGFDrOKxXkdeuJxIrEOFXBGTs1nA2T5YrSxmzgU58xvpPHE2IQVMtuAYJcpkQe udx9pe0SpPCmKBMiwIQqRWgB/0BkAjfia1FBbr7cwMx/OjnujmDznydjOukA17a6uV6C EJXG9/BFiFBsT+RPWGQ3cHGv0cN+vNmdOUwzLYn+58W6nwD6+s7sHvfaFmrRDLTDWrDC 0N5PaH7XWSV4fyqyAN3Qac1C1osydL7jhUzmzrEgShs+kWusncIxj7fRyuu++mRrLKtF WMGw== X-Gm-Message-State: AOAM532+x93GhA/JS8+lEwLIRxSvAi0omoCCnNAzwTekIEZ8f7ey7fBI PPJ++6yvw469TmuX93kEJsztSQ== X-Google-Smtp-Source: ABdhPJyC90DXJbQi68KM16rzl+PXjOw/34j6vjAGEAnISOreJODFMHF+Ahf6R8hUIqHswTaf/dZF7A== X-Received: by 2002:a1c:9684:: with SMTP id y126mr10136669wmd.2.1610734447408; Fri, 15 Jan 2021 10:14:07 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.14.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:14:06 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 34/40] drm/gma500/mmu: Remove unused function 'psb_get_default_pd_addr' Date: Fri, 15 Jan 2021 18:13:07 +0000 Message-Id: <20210115181313.3431493-35-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/mmu.c:420:10: warning: no previous prototype for ‘psb_get_default_pd_addr’ [-Wmissing-prototypes] Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/mmu.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/gma500/mmu.c b/drivers/gpu/drm/gma500/mmu.c index 42b53c01b79f4..014daf0280485 100644 --- a/drivers/gpu/drm/gma500/mmu.c +++ b/drivers/gpu/drm/gma500/mmu.c @@ -416,15 +416,6 @@ struct psb_mmu_pd *psb_mmu_get_default_pd(struct psb_mmu_driver *driver) return pd; } -/* Returns the physical address of the PD shared by sgx/msvdx */ -uint32_t psb_get_default_pd_addr(struct psb_mmu_driver *driver) -{ - struct psb_mmu_pd *pd; - - pd = psb_mmu_get_default_pd(driver); - return page_to_pfn(pd->p) << PAGE_SHIFT; -} - void psb_mmu_driver_takedown(struct psb_mmu_driver *driver) { struct drm_device *dev = driver->dev; From patchwork Fri Jan 15 18:13:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366142 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F2E2C4332B for ; Fri, 15 Jan 2021 18:16:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E62B423A7C for ; Fri, 15 Jan 2021 18:16:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388347AbhAOSQl (ORCPT ); Fri, 15 Jan 2021 13:16:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387939AbhAOSPD (ORCPT ); Fri, 15 Jan 2021 13:15:03 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFEE5C061796 for ; Fri, 15 Jan 2021 10:14:09 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id a12so10180031wrv.8 for ; Fri, 15 Jan 2021 10:14:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rAHTpQV67+yi8IQrXKtmnaLMIm66ZFnUBK29ghZYvfc=; b=Nhj14BJzABYIFqNisKEiHe7Xysxmd1ToE7+1Z1jwpfJT2WG2FjxKeE1v5ohYi1M+u2 PwptNNWwEs2UT1csoXAAnC8d+x+92BeB9CpbKasePwnJu7qcmvY6/3Dwp0fPi7p0C2/m 0wfu9hHvHgb3mY7ErQ5OX3aBEj80z8N0W1o5wrVgIbIhWRIF2UARd+crx/VxL2myuKKV CaeJK6h4Wb0OScZBmCHbxBE5exHnFWRlXf+KIt/E+T3lOB9y+7mof02reoPT6TAMmOfM cmcD3b2dpRs5adKgFBRo3x4OfAnRy5275lq9GH6pLyego75IXwUDd0X5LOJ70l6D8X0N gI4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rAHTpQV67+yi8IQrXKtmnaLMIm66ZFnUBK29ghZYvfc=; b=BwE7w1Z9m5vqMiGxdZzobD2yNj1PuQrbodre0eMlPo7HlZGSn6vD0uYf96zFQj4d0E H1E8q1gDYzjHy2yjbd0Hwyk2VyxdhTaraAmQNo8mmxeUTGy6XjBdgP4LkrhDs0hZlZvc 7retEGe7TEkeoR7D0QZS0LLvGXP1T1WEchAKLQMCaN306pO18PDczqFoJHhW9tFfGWot Wfy1yUHuw928ZamZv3CHD3mrNrTS6v2OMOKwuULJRwEY66EzBAYTfJ/WWJv6+/zABIh1 QFT3zEcZ9Ixxg16Mu5l3S3kymSEwOmSgyharo7JRRZVP23R6JHyZEauZvEt/5QWjyuhd uTCA== X-Gm-Message-State: AOAM530flJmUd8LUwJHFuhh6Bu2Xcha6uL4vuBo0TUuf6PYt6k8/LIyC JEIxnfV11LYemPdFatcKocDn9w== X-Google-Smtp-Source: ABdhPJya07h3DVptEeRHtjRpX4ZhUhiKUWJNJfS7SRBdQy1whh2AMhi6JfbWr5rUIdQF/chrtL/tsg== X-Received: by 2002:adf:92c2:: with SMTP id 60mr14645619wrn.266.1610734448617; Fri, 15 Jan 2021 10:14:08 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.14.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:14:07 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 35/40] drm/vmwgfx/vmwgfx_cmdbuf_res: Rename param description and remove another Date: Fri, 15 Jan 2021 18:13:08 +0000 Message-Id: <20210115181313.3431493-36-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Also fix a small formatting issue. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c:83: warning: Function parameter or member 'res_type' not described in 'vmw_cmdbuf_res_lookup' drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c:83: warning: Excess function parameter 'resource_type' description in 'vmw_cmdbuf_res_lookup' drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c:161: warning: Excess function parameter 'man' description in 'vmw_cmdbuf_res_revert' drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c:330: warning: Cannot understand * Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c index 44d858ce4ce7f..92509fbf2fd1d 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c @@ -69,7 +69,7 @@ struct vmw_cmdbuf_res_manager { * vmw_cmdbuf_res_lookup - Look up a command buffer resource * * @man: Pointer to the command buffer resource manager - * @resource_type: The resource type, that combined with the user key + * @res_type: The resource type, that combined with the user key * identifies the resource. * @user_key: The user key. * @@ -148,7 +148,6 @@ void vmw_cmdbuf_res_commit(struct list_head *list) /** * vmw_cmdbuf_res_revert - Revert a list of command buffer resource actions * - * @man: Pointer to the command buffer resource manager * @list: Caller's list of command buffer resource action * * This function reverts a list of command buffer resource @@ -327,7 +326,6 @@ void vmw_cmdbuf_res_man_destroy(struct vmw_cmdbuf_res_manager *man) } /** - * * vmw_cmdbuf_res_man_size - Return the size of a command buffer managed * resource manager * From patchwork Fri Jan 15 18:13:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366131 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BC48C433E0 for ; Fri, 15 Jan 2021 18:15:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE4F523A59 for ; Fri, 15 Jan 2021 18:15:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388156AbhAOSPX (ORCPT ); Fri, 15 Jan 2021 13:15:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388024AbhAOSPJ (ORCPT ); Fri, 15 Jan 2021 13:15:09 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11943C061381 for ; Fri, 15 Jan 2021 10:14:11 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id a9so6748701wrt.5 for ; Fri, 15 Jan 2021 10:14:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Zk69YegOGJqysgGJbDn5xfrwzKa0lDxp7+yp3s1Kj6U=; b=dseFE4l/a7Wm6ykCQlC4gaq/QvUbmlCUt5gKH0q+IywCOX3NvEoX4BwK6m03B9VDXs 1SuhGTsHQqMW0lwqBNgvjdN6LqP7wXL1vty08oacmKr1HNMacqDFja6hyg1EryPPh1Wz qxo4jjbHw3Knhoig20reJn2pzkM4e+gTMiKwBwz+tD53xJEA7BIKhGYysAKbmkH7jH+O WDtWvkXFDI9vzX74EWQET78aNV2d7JIUsoqMic7S/ma0eYZ/UQJ/vieSlU8W+dk4aI2q LPwi5vp8uhWFUS0YL6n0QoHiQBFn1GzjkjfIzCTrXXa8w2WQCfN3EI3TW/ycUM2X8gYj NPEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Zk69YegOGJqysgGJbDn5xfrwzKa0lDxp7+yp3s1Kj6U=; b=FXVCprjo03nF1V7FmrqiRYKdMDTSs8kevpqTOnJ6TUZRt99iqxEql241ohU1dLcNPo knw49II3llx93lYAnSQqPs8Dm3KragXw1f4ahjzB2P3gSMB24SjoHy/4NH2ujlA4J4R0 j/5YRNsZvyfdEDIqFE/SBigusCWVZo1jNcnvqthvLd26FCIGxxd/5ryrK3IekRtSrGtE RbRU09XSxPYG2I13wJYiH2Gck7NU4NfW9ETDsCSkvgcXs/rGsSRO89OPossnIuM2XxrM 6TkLwKG1Y9lf8Uv1zLdkFaGp1oZQfsRJzB+EaiCEWWpX38AtdQobq1QdKeZG+U5Ovx8q aKHw== X-Gm-Message-State: AOAM531xtC+3Z8FFPxcfUR6lKVUr+DIaUhTXYXC3TlADRAI65/1tecIh jYWY07mIrf4twIw2/Z/EUQpN2A== X-Google-Smtp-Source: ABdhPJxJn2M/cVUxIKsLXpE4PrVC/2KvRxL71cjUJKAp6k49EoS6r2Bcuo7xn4BEbu5GHJcv4KxSgw== X-Received: by 2002:a5d:4c45:: with SMTP id n5mr14779840wrt.396.1610734449759; Fri, 15 Jan 2021 10:14:09 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.14.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:14:09 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 36/40] drm/vmwgfx/vmwgfx_shader: Demote kernel-doc abuses and fix-up worthy headers Date: Fri, 15 Jan 2021 18:13:09 +0000 Message-Id: <20210115181313.3431493-37-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_shader.c:134: warning: Function parameter or member 'res' not described in 'vmw_res_to_shader' drivers/gpu/drm/vmwgfx/vmwgfx_shader.c:663: warning: Function parameter or member 'base' not described in 'vmw_user_shader_base_to_res' drivers/gpu/drm/vmwgfx/vmwgfx_shader.c:695: warning: Function parameter or member 'p_base' not described in 'vmw_user_shader_base_release' drivers/gpu/drm/vmwgfx/vmwgfx_shader.c:965: warning: Function parameter or member 'dev_priv' not described in 'vmw_compat_shader_add' drivers/gpu/drm/vmwgfx/vmwgfx_shader.c:965: warning: Function parameter or member 'size' not described in 'vmw_compat_shader_add' drivers/gpu/drm/vmwgfx/vmwgfx_shader.c:965: warning: Excess function parameter 'tfile' description in 'vmw_compat_shader_add' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_shader.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c b/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c index 905ae50aaa2ae..a0db065640131 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c @@ -125,7 +125,7 @@ static const struct vmw_res_func vmw_dx_shader_func = { .commit_notify = vmw_dx_shader_commit_notify, }; -/** +/* * Shader management: */ @@ -654,7 +654,7 @@ int vmw_dx_shader_add(struct vmw_cmdbuf_res_manager *man, -/** +/* * User-space shader management: */ @@ -686,7 +686,7 @@ static void vmw_shader_free(struct vmw_resource *res) vmw_shader_size); } -/** +/* * This function is called when user space has no more references on the * base object. It releases the base-object's reference on the resource object. */ @@ -945,13 +945,13 @@ int vmw_shader_remove(struct vmw_cmdbuf_res_manager *man, * vmw_compat_shader_add - Create a compat shader and stage it for addition * as a command buffer managed resource. * + * @dev_priv: Pointer to device private structure. * @man: Pointer to the compat shader manager identifying the shader namespace. * @user_key: The key that is used to identify the shader. The key is * unique to the shader type. * @bytecode: Pointer to the bytecode of the shader. * @shader_type: Shader type. - * @tfile: Pointer to a struct ttm_object_file that the guest-backed shader is - * to be created with. + * @size: Command size. * @list: Caller's list of staged command buffer resource actions. * */ From patchwork Fri Jan 15 18:13:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366137 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E661DC433E6 for ; Fri, 15 Jan 2021 18:16:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6A0123A6C for ; Fri, 15 Jan 2021 18:16:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388319AbhAOSQV (ORCPT ); Fri, 15 Jan 2021 13:16:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388029AbhAOSPJ (ORCPT ); Fri, 15 Jan 2021 13:15:09 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3155CC061382 for ; Fri, 15 Jan 2021 10:14:12 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id v15so6543255wrx.4 for ; Fri, 15 Jan 2021 10:14:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Am4t8b9En1HIfsclMg+25TY7LAvRdlrz1SUTzn1fYz4=; b=M77jBSyJi06eqwSb0fQBTfnZ6ireTJ4ExXO9TEhHwoQ0gXWo1v183KS92TUeVaZNun YaX4duc8tuj90M1fTQ98u9PMbQ7Bejo7m/hnKIcm49IzS1dh3qyft6nJFFvkFkYBiNry 1Q/zs3xW7pMSKqv/lq/YTh6y5aZnafrgpq2vVAWsmVe0Q+UNzzL0nacr2TGkrdOlb/eq T3pzb174ylDgVUTO5QSkquN67H3RgsAoicWZOaTge4rkS7bE4D0HJRPNMF+NSBzgHaLx ZrQpEF7vifXb2dfhbkakdeZikPe+eIitwHnJCTNbbkkaP9BR8tNBrZemhTmDcmOFhh0g kzyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Am4t8b9En1HIfsclMg+25TY7LAvRdlrz1SUTzn1fYz4=; b=RFwhzZ38QL6XYbyH2KZSHDO0251dccgSm31Jk8+5Pm2aywnzV7dFiTI9vRXB7em4U6 j+j+XxCdf/fltvRP/YE+ocqJXtL8ESuIl/nUEsXPG90DEvQ7dBNbnZZCp3dZHYak5rP8 VCcdZE0GnKi3RC7UH43LYXOpDIpJKUpwgKk8lH+fBDh2UZpq4H5Bpk+PETt0+Gc9kA2n 4TwAh6pnZvV79VK2TH9lJ0mGlfbkpx059mLMqTAAMiJfkX0R/iBDYcS2jehyfnuDDoxy QVjiEkEv+n34VbJNXm6FcZE+ks/ShDPcHGK2LEjOWYM9sd+NsEsEsn9THym+lb6qvMHA beKQ== X-Gm-Message-State: AOAM532061JfsfT6tw2JpvG8YAzCiFD4SOmPFv8FuS77CRvvi2LjHd3v z/m4k1lVOZ97M1d+HOSvItY1vg== X-Google-Smtp-Source: ABdhPJxzcvRMerU+KtZl29WVJZPfR54Qpi1F+qdlK8hpl724S36xxPcQ89RHjXLf3mqalXSZNoQr5g== X-Received: by 2002:adf:902a:: with SMTP id h39mr14400546wrh.147.1610734450977; Fri, 15 Jan 2021 10:14:10 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.14.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:14:10 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 37/40] drm/vmwgfx/vmwgfx_cmdbuf: Fix a bunch of missing or incorrectly formatted/named params Date: Fri, 15 Jan 2021 18:13:10 +0000 Message-Id: <20210115181313.3431493-38-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:58: warning: Function parameter or member 'block_submission' not described in 'vmw_cmdbuf_context' drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:109: warning: cannot understand function prototype: 'struct vmw_cmdbuf_man ' drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:164: warning: Function parameter or member 'handle' not described in 'vmw_cmdbuf_header' drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:257: warning: Function parameter or member 'header' not described in '__vmw_cmdbuf_header_free' drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:380: warning: Function parameter or member 'notempty' not described in 'vmw_cmdbuf_ctx_process' drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1168: warning: Function parameter or member 'context' not described in 'vmw_cmdbuf_preempt' drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1193: warning: Function parameter or member 'context' not described in 'vmw_cmdbuf_startstop' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c index 45fbc41440f1e..3158924ffa852 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c @@ -48,6 +48,7 @@ * @hw_submitted: List of command buffers submitted to hardware. * @preempted: List of preempted command buffers. * @num_hw_submitted: Number of buffers currently being processed by hardware + * @block_submission: Identifies a block command submission. */ struct vmw_cmdbuf_context { struct list_head submitted; @@ -58,7 +59,7 @@ struct vmw_cmdbuf_context { }; /** - * struct vmw_cmdbuf_man: - Command buffer manager + * struct vmw_cmdbuf_man - Command buffer manager * * @cur_mutex: Mutex protecting the command buffer used for incremental small * kernel command submissions, @cur. @@ -143,7 +144,7 @@ struct vmw_cmdbuf_man { * @cb_context: The device command buffer context. * @list: List head for attaching to the manager lists. * @node: The range manager node. - * @handle. The DMA address of @cb_header. Handed to the device on command + * @handle: The DMA address of @cb_header. Handed to the device on command * buffer submission. * @cmd: Pointer to the command buffer space of this buffer. * @size: Size of the command buffer space of this buffer. @@ -249,7 +250,7 @@ static void vmw_cmdbuf_header_inline_free(struct vmw_cmdbuf_header *header) * __vmw_cmdbuf_header_free - Free a struct vmw_cmdbuf_header and its * associated structures. * - * header: Pointer to the header to free. + * @header: Pointer to the header to free. * * For internal use. Must be called with man::lock held. */ @@ -365,10 +366,11 @@ static void vmw_cmdbuf_ctx_submit(struct vmw_cmdbuf_man *man, } /** - * vmw_cmdbuf_ctx_submit: Process a command buffer context. + * vmw_cmdbuf_ctx_process - Process a command buffer context. * * @man: The command buffer manager. * @ctx: The command buffer context. + * @notempty: Pass back count of non-empty command submitted lists. * * Submit command buffers to hardware if possible, and process finished * buffers. Typically freeing them, but on preemption or error take @@ -1161,6 +1163,7 @@ static int vmw_cmdbuf_send_device_command(struct vmw_cmdbuf_man *man, * context. * * @man: The command buffer manager. + * @context: Device context to pass command through. * * Synchronously sends a preempt command. */ @@ -1184,6 +1187,7 @@ static int vmw_cmdbuf_preempt(struct vmw_cmdbuf_man *man, u32 context) * context. * * @man: The command buffer manager. + * @context: Device context to start/stop. * @enable: Whether to enable or disable the context. * * Synchronously sends a device start / stop context command. From patchwork Fri Jan 15 18:13:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366138 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5D64C433DB for ; Fri, 15 Jan 2021 18:16:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CDDC23A59 for ; Fri, 15 Jan 2021 18:16:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727229AbhAOSQO (ORCPT ); Fri, 15 Jan 2021 13:16:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388031AbhAOSPJ (ORCPT ); Fri, 15 Jan 2021 13:15:09 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C3D0C061383 for ; Fri, 15 Jan 2021 10:14:13 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id m187so1959074wme.2 for ; Fri, 15 Jan 2021 10:14:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lUllZlLn2aeKUdYiVAeIic/5IUxXot0e1d7nGV4+J9E=; b=xHzJWvUBBvuWc4Xl5VACsWf7N/b0v4PM+Qxj0aEVX4T/Ialsfqoba2uENutm20zcbe SaHvLTlmH58mQ6cFwjcCCodq/QHt72Iu43Xb329LXWojJa7oAy5FXhy2ROEXFtld/q0I 6Bkq0aU2nuUl1WAISSsKA03rO1HtN7OS/vQAo0Mu59atH1sWKQ0BOJRGdqbbI/AxDYJa mKMP7dh/5SkXbKhLTNWDNw72XJlZ69B4cfYOT2tlqPa+14eFXTZ3+232t6Gh/e4fD3UI 5beVeeQ+z6ZFxtKsL6isJU1T08spSkRPfoQeca1f2M5VIPsgFuCTmP1gzibzEXNMEy+/ sPCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lUllZlLn2aeKUdYiVAeIic/5IUxXot0e1d7nGV4+J9E=; b=SJYfABakZ5yqRtbiIdGwvm7S3qzc4a+4EwC2zkzcVSM83KFoWSILsZn+r2egIJPxiR 5FuyfcksFxgIFl7qnbzvNMKQ76vkzckyvjGCBs/SSbFWljhBtm5V18Tc1pLEWmlK2Jra Fj0sP1z8PMaQBBJw08ReFZbVf2XpniyGu4xUR2WuDsNIClPLdHbnvmA4yWp8jMDs8+ir vRHBrvTw9T9FPpHJTDv3r8mSrsg5TqxfDgIWqFQBq9XToUqre1fy16Lq6y4PIgKnD+3/ AT1ZTyESU991sccdyq7VQ2LEGzVrkk284yGZq2Tmg+NlsDQ1z6uWEaUmuWKsAV1qo3kc s5aw== X-Gm-Message-State: AOAM532grQeZPbzmpFhtNd7z8ZfqUN/aNCzSJ8kzQHcTXKl3Uq+cdh9s cxjsnmRHMgJt+8LmlYPDnJ4oNA== X-Google-Smtp-Source: ABdhPJynbLDNvhU7p2qnSMtIi5F12pD7Q5un3SKOf86x40VZpdtU+jnB7rT+88JShOlhxgtI/k3xDw== X-Received: by 2002:a1c:e2c3:: with SMTP id z186mr9844691wmg.144.1610734452136; Fri, 15 Jan 2021 10:14:12 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.14.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:14:11 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , Benjamin Defnet , Rajesh Poornachandran , Alan Cox , dri-devel@lists.freedesktop.org Subject: [PATCH 38/40] drm/gma500/power: Remove excess param description 'state' Date: Fri, 15 Jan 2021 18:13:11 +0000 Message-Id: <20210115181313.3431493-39-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/power.c:190: warning: Excess function parameter 'state' description in 'gma_power_suspend' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Benjamin Defnet Cc: Rajesh Poornachandran Cc: Alan Cox Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/power.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/power.c b/drivers/gpu/drm/gma500/power.c index 89842e09cd2aa..56ef88237ef66 100644 --- a/drivers/gpu/drm/gma500/power.c +++ b/drivers/gpu/drm/gma500/power.c @@ -180,7 +180,6 @@ static bool gma_resume_pci(struct pci_dev *pdev) /** * gma_power_suspend - bus callback for suspend * @_dev: our device - * @state: suspend type * * Called back by the PCI layer during a suspend of the system. We * perform the necessary shut down steps and save enough state that From patchwork Fri Jan 15 18:13:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366129 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F7CC43331 for ; Fri, 15 Jan 2021 18:15:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B89823A59 for ; Fri, 15 Jan 2021 18:15:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388194AbhAOSP0 (ORCPT ); Fri, 15 Jan 2021 13:15:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388036AbhAOSPJ (ORCPT ); Fri, 15 Jan 2021 13:15:09 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EEF7C061384 for ; Fri, 15 Jan 2021 10:14:14 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id k10so8214019wmi.3 for ; Fri, 15 Jan 2021 10:14:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eQaT8O9XxcsJgVKni1h0yZPLQZvOBcm7ZwMWNBkJiNk=; b=qGaHgBNTx/fmF+7Ais7Ufdt9dmQbs5EWdBbcb57RTL+tsSdSG4dLYqS9cxfLbabOBM G7I9mfukkMai6ee/f1y806pY54Bn5Spyy/lJ+0gebGjME7nRSZhwig9Ab/PU/kMiYg76 mzI5bP3uYAC1BJWW096JxqScQIA4ZkiEe9M5zfTyTJBhTf6QXjhDL+HacORBsYZv3rW3 FeJ+dEqcpLZUwtxPPWorSiauOcrk5TU9ew+/7T0tr/u7+w/wvoZK5pd85sOSdZdHs3Sf 1oorr/AZEqW+GB/mtVJMRy6oiv2AWntCCnTYB8gOg/kWttSVJvcSMHlBtdvydQBhyfR1 eoYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eQaT8O9XxcsJgVKni1h0yZPLQZvOBcm7ZwMWNBkJiNk=; b=XUK/Qp8vXxI1SSty/x2PKhVYOCVyEQa0k6rlvdUmW1CdcS+xqOArt0q6aLu49xis8U sWkk/vu0bDvee4s7c6OecewArLTjh/Ctp4E54Jl7Mr7gnxWyrcMLKuAaBojEvHh8XAEW LnnLyyXf1on7MXfh9mEULLbkIXnDCxEZhRL+5WlzpTJAlfFetzDEUjHU7fVrKnSkH/+E G5g1oFrBXKn20i4wVSgAPRLTRZ063kXw510ueL7rDNFpMTnp86YizkD2DlEBn4lEmn1m X8TcpiI0tv+srZbM1Qur6qp9y0fU5iodMF10cOsb6Np0zTYdYPL/5KZghq+aX2iOMzeW VPxQ== X-Gm-Message-State: AOAM532662bv8N9GmYCih1F8mF32zDJRr9pM4Rw7UIeCInFmRcxtT4Sr WZ9MbLEKlQPo05t7e9Vk7H8wvQ== X-Google-Smtp-Source: ABdhPJxIi81NmcZ3eJUbgrKPBLwd7qw1Vv7O/IAtMiKJeBKW0LklxrjADuKqEt0hUyewqgWE0ZqQ8g== X-Received: by 2002:a1c:cc14:: with SMTP id h20mr9966183wmb.180.1610734453384; Fri, 15 Jan 2021 10:14:13 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.14.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:14:12 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , Zack Rusin , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 39/40] drm/vmwgfx/vmwgfx_cmdbuf_res: Remove unused variable 'ret' Date: Fri, 15 Jan 2021 18:13:12 +0000 Message-Id: <20210115181313.3431493-40-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c: In function ‘vmw_cmdbuf_res_revert’: drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c:162:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c index 92509fbf2fd1d..b262d61d839d5 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c @@ -159,7 +159,6 @@ void vmw_cmdbuf_res_commit(struct list_head *list) void vmw_cmdbuf_res_revert(struct list_head *list) { struct vmw_cmdbuf_res *entry, *next; - int ret; list_for_each_entry_safe(entry, next, list, head) { switch (entry->state) { @@ -167,8 +166,7 @@ void vmw_cmdbuf_res_revert(struct list_head *list) vmw_cmdbuf_res_free(entry->man, entry); break; case VMW_CMDBUF_RES_DEL: - ret = drm_ht_insert_item(&entry->man->resources, - &entry->hash); + drm_ht_insert_item(&entry->man->resources, &entry->hash); list_del(&entry->head); list_add_tail(&entry->head, &entry->man->list); entry->state = VMW_CMDBUF_RES_COMMITTED; From patchwork Fri Jan 15 18:13:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366128 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A478C4332E for ; Fri, 15 Jan 2021 18:15:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37ED723A58 for ; Fri, 15 Jan 2021 18:15:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388181AbhAOSPY (ORCPT ); Fri, 15 Jan 2021 13:15:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388033AbhAOSPJ (ORCPT ); Fri, 15 Jan 2021 13:15:09 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E203BC061385 for ; Fri, 15 Jan 2021 10:14:15 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id r4so8374085wmh.5 for ; Fri, 15 Jan 2021 10:14:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dkKAWRNMkHThiFz1M9uddp3Rd+YUVjBVQ8G0RRd1tPg=; b=o7PuaCI40GcwIe5PjjeOUWjBVVmNduFjVrX6LvSBREgDSRwEdcNazPXmpCSJJ3Abqp jHvxty8xwYtPpKoc8z0rMM48pZooE9DKPitlXD33YwkvNDAxgNfkzj2mDrBh2Z2o1FMo hPV/x2CCq7i4Jk5E7vLIuVQG8MfdtET82/eo1sYvUXNGPgNynkqb2VEZdnTcVRjFaECE VA6D/pnRGbVutsRAQDoVguz3v4iUPTtJFq7Jtx6ClYl3xKwV9kmQRHguoB/YAAtgkVYq xmNd+4nEIrsGksJR0dszRBUb7U8iqVNiILWrdJB1Pr3DcAo+GE8dKXLPiM3qthrpjTzS QUtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dkKAWRNMkHThiFz1M9uddp3Rd+YUVjBVQ8G0RRd1tPg=; b=cQo0B96yO4lSIljnKhG7mjCKQyPeLFlKQ2EalJgyWgqK6Gvk1Uv9m/iV1T0PqcMjU1 ojyiJ/hSEskGGAKs9e80L/DVpgDl+t49qiyyXB/vNHwKuA/OXJBneEtoxfUXm83DM0HQ PkZBNoYrY23QAmwH/SM59LJYetabRkcy+Oei8vo+ClsOnMuRkmws4F6qXx+Yn2DrLHhE +e5q4Lqvnww8sGi7JU0XG9WQqm4LOCXU+Dw2r02RoxZgwzXoC4KTH/XzGlRzrn1aHuhS a1P/5rAH7EmOewTy0fdqqZtCUI9F7v9QPT6RLeyRAbctFhrad1RcNf/ry7Q7siz8xUyL IkEQ== X-Gm-Message-State: AOAM531k1Y5xc/JfY6VdOc6rlC7y78PNe9XwDKPOK6Qi9lH8rsmqKxIB 9gnr0+FQ9x4y9AeOsCFoPmBn1A== X-Google-Smtp-Source: ABdhPJyKfyhmRu1cvc+Cry6amUJ6hGG93mmiVURVcRG8yFp5kRHmojpm3WIR7qhof1KcethsJwFtcQ== X-Received: by 2002:a7b:c2e8:: with SMTP id e8mr9709934wmk.103.1610734454715; Fri, 15 Jan 2021 10:14:14 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id j2sm16123484wrh.78.2021.01.15.10.14.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:14:14 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , Zack Rusin , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 40/40] drm/vmwgfx/vmwgfx_stdu: Add some missing param/member descriptions Date: Fri, 15 Jan 2021 18:13:13 +0000 Message-Id: <20210115181313.3431493-41-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181313.3431493-1-lee.jones@linaro.org> References: <20210115181313.3431493-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:77: warning: Function parameter or member 'pitch' not described in 'vmw_stdu_dirty' drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:125: warning: Function parameter or member 'content_fb_type' not described in 'vmw_screen_target_display_unit' drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:125: warning: Function parameter or member 'display_width' not described in 'vmw_screen_target_display_unit' drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:125: warning: Function parameter or member 'display_height' not described in 'vmw_screen_target_display_unit' drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:125: warning: Function parameter or member 'cpp' not described in 'vmw_screen_target_display_unit' drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:682: warning: Function parameter or member 'user_fence_rep' not described in 'vmw_kms_stdu_dma' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c index fbe9778813648..01567534f4fae 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c @@ -61,6 +61,7 @@ enum stdu_content_type { * @bottom: Bottom side of bounding box. * @fb_left: Left side of the framebuffer/content bounding box * @fb_top: Top of the framebuffer/content bounding box + * @pitch: framebuffer pitch (stride) * @buf: buffer object when DMA-ing between buffer and screen targets. * @sid: Surface ID when copying between surface and screen targets. */ @@ -109,8 +110,11 @@ struct vmw_stdu_update_gb_image { * content_vfbs dimensions, then this is a pointer into the * corresponding field in content_vfbs. If not, then this * is a separate buffer to which content_vfbs will blit to. - * @content_type: content_fb type - * @defined: true if the current display unit has been initialized + * @content_fb_type: content_fb type + * @display_width: display width + * @display_height: display height + * @defined: true if the current display unit has been initialized + * @cpp: Bytes per pixel */ struct vmw_screen_target_display_unit { struct vmw_display_unit base; @@ -652,6 +656,7 @@ static void vmw_stdu_bo_cpu_commit(struct vmw_kms_dirty *dirty) * @file_priv: Pointer to a struct drm-file identifying the caller. May be * set to NULL, but then @user_fence_rep must also be set to NULL. * @vfb: Pointer to the buffer-object backed framebuffer. + * @user_fence_rep: User-space provided structure for fence information. * @clips: Array of clip rects. Either @clips or @vclips must be NULL. * @vclips: Alternate array of clip rects. Either @clips or @vclips must * be NULL.