From patchwork Fri Jan 15 18:15:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366146 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8D38C433E0 for ; Fri, 15 Jan 2021 18:17:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8852923A58 for ; Fri, 15 Jan 2021 18:17:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388408AbhAOSQz (ORCPT ); Fri, 15 Jan 2021 13:16:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388358AbhAOSQt (ORCPT ); Fri, 15 Jan 2021 13:16:49 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6808C061794 for ; Fri, 15 Jan 2021 10:16:08 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id k10so8219254wmi.3 for ; Fri, 15 Jan 2021 10:16:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d2FyQ5jLhIdHZJD6YWNJEO3BdrWd8ejeRewtSriPKvY=; b=oo8H3DQngcMqzuyQv+p0ndzTcx2a6xa46E1LV17pUiKJmFYB/HLEV/rZzoO2TuB5Rf WlggPv9nQYUiOsj4KyUx0khpoZNaWM6Dj+FyMlf7zxiRftfs0AXqTWSDDhT/9JdcxuZp tCxeL7ReDwA/x1dZXTqfgIrQki9sQW0m3eqOzvSvIZuNEgesuZVukjlYcR+9kFOvW4a7 BWhUcye5v59wpx3O/6PrS31N3SZPmIH1Ahzoh39Lxz5rFSX3JhzQhqVT5MKc0uETdAsx Tl7YjhMnuu+37Hv2pSNoIlTS2lmZoGJiGbYXAjdJfEfIdeThyga1i04Poq2MH3kQIjP6 Q0GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d2FyQ5jLhIdHZJD6YWNJEO3BdrWd8ejeRewtSriPKvY=; b=NUdY/BhMKmkR39+b9nK/vbwqLunDusuJPhrfsX1DirEUY7oFo7RecieEp6IZFhVnPv qjRK02+GMFogzvTwp2ocS+CYma0wbKsFiY2IQoVOq4kXQBw99jKalZo10xap+yp5Rwts GJM/ugtjpZ1/jLZx5SiEKD1+P90CSfVAYoFai2bOVg/OwGz9y7CaP5EBTISus2hiXiyS BZa/y4/0GORfTr6IuiUvL3occBsqnwUm0DQBrCjZiN43CVJ5WIQZHihuiDv9sCqXJyvN s2uuEXiwUSEKItuhdn2LECqxVcVcQCNGISWUFVwuDLreoPtq+havp30wcjbhdmgHxI1P iwww== X-Gm-Message-State: AOAM530v0EYLaIbQAtkVFoproQfKitPEUlaRITB2dplfnJsiMkHXw8AC Ir5oOQaIDITNNJYBeyNk7cQW4w== X-Google-Smtp-Source: ABdhPJwcwyOAr0PXhJz2jEx6tQz9gFzPXrNLH0m28OazHlbt4inlSogSJGqy1K3YHg7BHui7FtTezw== X-Received: by 2002:a1c:c90c:: with SMTP id f12mr5656814wmb.98.1610734567515; Fri, 15 Jan 2021 10:16:07 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:06 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , Zack Rusin , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 01/29] drm/vmwgfx/vmwgfx_cmdbuf: Fix misnaming of 'headers' should be plural Date: Fri, 15 Jan 2021 18:15:33 +0000 Message-Id: <20210115181601.3432599-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:137: warning: Function parameter or member 'headers' not described in 'vmw_cmdbuf_man' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c index 3158924ffa852..2e23e537cdf52 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c @@ -89,7 +89,7 @@ struct vmw_cmdbuf_context { * @max_hw_submitted: Max number of in-flight command buffers the device can * handle. Immutable. * @lock: Spinlock protecting command submission queues. - * @header: Pool of DMA memory for device command buffer headers. + * @headers: Pool of DMA memory for device command buffer headers. * Internal protection. * @dheaders: Pool of DMA memory for device command buffer headers with trailing * space for inline data. Internal protection. From patchwork Fri Jan 15 18:15:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366145 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6812C433DB for ; Fri, 15 Jan 2021 18:17:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C70C23A5E for ; Fri, 15 Jan 2021 18:17:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388453AbhAOSRN (ORCPT ); Fri, 15 Jan 2021 13:17:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733221AbhAOSRL (ORCPT ); Fri, 15 Jan 2021 13:17:11 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E24CBC061795 for ; Fri, 15 Jan 2021 10:16:09 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id c124so8210504wma.5 for ; Fri, 15 Jan 2021 10:16:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CRnDlHVa12JoDS+1Cu3+Ec4HFRbAYSztolaDSiDve+E=; b=e7F9l+/dUV6ABxBCDtb/BidpEhKGM4UyqXYYkGDUNjAhYHxnuY9f3ElU0sjsZtNelV x/yJl6ti64qxc2h+OnEbh2MwY8KBYmeJZKU2yuyfvID0Yx8V2d/uBWhGXmYMDnmhmys9 6UYpMRgXvHThOA49/yJSUvpYCLe0wk3zbUQuvpSPknEt9y/sQjN98kjXlrLp64GlqGpG 7KMt6pJP/fyQkFaUKSl6k5RN94/I+jEnP4VsteeAk6fpsjH49xwIfPJABsJyaZ4YN4iv ZKfmjn/l98cpku1bSU5Kz7MEKHFBEw/hAVSZN1IAA7Fepu0nwoScJdvHIfXlFviqWmG1 B/cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CRnDlHVa12JoDS+1Cu3+Ec4HFRbAYSztolaDSiDve+E=; b=FqDf2aNtoShzzNz+084Izij23W/Y4oiTerJ42cv+Na9mDqoStP8LoKTCq4iu4pKpJb JijeQH1IHe+F/YpdZCByaBHSMBgZp39v4fEGBMgUAi2mC9puXKKC2IU8Hcgn3HbVPryL uA6TrDOvfJaFVNVohlr/nTVvRoqh11tA+vIS4lkAXdy0az4+vWq0ONq/a6TX2V2k6w3H FjVPf3HNC6AXC9YQN2U81udW4EYBJ+vDUwORJAe7bjMQohMXQYPddmMeNjts1g//Muc7 LAUdrupx1hloJeIsVF+lVGS2dFFe6A/krHhE3bH+l1QLXgNlXK70E1+U/McuF1hjutj0 9Kkw== X-Gm-Message-State: AOAM533DJeyRLStA9kPvtT8b3FAvhCkMlVc5AAhSaI0TCzTLIbQlBgUH lp8TUz+RtHVaZ71JoKorgxMXwA== X-Google-Smtp-Source: ABdhPJwIyOV6NzKrLV231nC6Q0q+ZFXfNYtZgTm4tQRyqu2f2dD4dK1RNYIlr9iv2Ic1kMUN2xmJXQ== X-Received: by 2002:a1c:4b10:: with SMTP id y16mr10129104wma.73.1610734568698; Fri, 15 Jan 2021 10:16:08 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:08 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , Zack Rusin , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 02/29] drm/vmwgfx/vmwgfx_cotable: Fix a couple of simple documentation problems Date: Fri, 15 Jan 2021 18:15:34 +0000 Message-Id: <20210115181601.3432599-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c:72: warning: Function parameter or member 'unbind_func' not described in 'vmw_cotable_info' drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c:308: warning: Function parameter or member 'val_buf' not described in 'vmw_cotable_unbind' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c b/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c index ba658fa9cf6c6..42321b9c8129f 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c @@ -63,6 +63,7 @@ struct vmw_cotable { * @min_initial_entries: Min number of initial intries at cotable allocation * for this cotable type. * @size: Size of each entry. + * @unbind_func: Unbind call-back function. */ struct vmw_cotable_info { u32 min_initial_entries; @@ -297,7 +298,7 @@ int vmw_cotable_scrub(struct vmw_resource *res, bool readback) * * @res: Pointer to the cotable resource. * @readback: Whether to read back cotable data to the backup buffer. - * val_buf: Pointer to a struct ttm_validate_buffer prepared by the caller + * @val_buf: Pointer to a struct ttm_validate_buffer prepared by the caller * for convenience / fencing. * * Unbinds the cotable from the device and fences the backup buffer. From patchwork Fri Jan 15 18:15:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366147 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC446C433E6 for ; Fri, 15 Jan 2021 18:17:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4B3923A6C for ; Fri, 15 Jan 2021 18:17:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387552AbhAOSRP (ORCPT ); Fri, 15 Jan 2021 13:17:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388349AbhAOSRL (ORCPT ); Fri, 15 Jan 2021 13:17:11 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 934CEC061798 for ; Fri, 15 Jan 2021 10:16:11 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id w5so10186979wrm.11 for ; Fri, 15 Jan 2021 10:16:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JlEOg7Zszo3ldqPVK/e9O2X0GMgkDBvEfp3oSty5OZg=; b=ti7uQ0hCTPPxB9beBVtUZ4SzOifYKrXMyvwtnJOZCMb3piPKWkCgRTtMToHUtDW4m3 4WXWjh1OaQVCg+r/ZvpIYeHfusCUkZUj7brQ8Z6i2KqCDkvkgefT3VSB4cfgBpnT9l7d fZTtBeOOXIaCL+tnKJYqVgYdIQvNtf8WdZhYmuDlPcWgAM/BTOSLyk2cNPYPGa7p5IOE fqT1nQGdfJIi7q3R1OCk+kzBt61lMtJXPbziIht+qigatuOJfxVVF+URzLNJeHhozO3g mocvqhE4OctWN5LLKk+smzy//CbEyENiGJN2PJnimVwPeKAr1Ufu/v7i+akBwSaVbbGI 8FYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JlEOg7Zszo3ldqPVK/e9O2X0GMgkDBvEfp3oSty5OZg=; b=i+n3bgkStd+c7icyscCmlL3YtfeJchVV3j6V7cAaQwTrZdHI5T5gA8VutDAZwV5N58 ly9D9OrX5Vm5dMLfvChiPXS24czBAp/Iqo8yvJugLRaMKE3RvY/8O1gJ32QYhOmzUXK4 ZUh4niCUpFaNrxZx7STWl5HXc786IvnT9OdRgU+lTZm112pZa3Ml5NMCPlwjoshUJPsx wyDn+xhEctAy7sn+D72FyWVbTrNCeRtHIIuG3Q82RqBXRy1zJvsmidIkvwcIHfDs5ajB 5EezoC4AgRohkWGAvNLynnEJBgTtoin1F+WkLZqZwDprn66B9KWnZFNV4jP4ee/8URDY nMSA== X-Gm-Message-State: AOAM532RmyfYWK9+3rSxO6054RkkHs/jgQQqsj7PrSEcZBJ8Z0MXoSEE iKl2gx23ucTWzRaLb0sotqIMxg== X-Google-Smtp-Source: ABdhPJyn4QddbfxLAegv+OX8NnX4aenp5m0W9RYEo8aeaDslhCWzAZbZOuRU1WhBNg3JBgAGTD1cCQ== X-Received: by 2002:adf:8285:: with SMTP id 5mr14062860wrc.289.1610734570384; Fri, 15 Jan 2021 10:16:10 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:09 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , Zack Rusin , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 03/29] drm/vmwgfx/vmwgfx_so: Add description for 'vmw_view's 'rcu' member Date: Fri, 15 Jan 2021 18:15:35 +0000 Message-Id: <20210115181601.3432599-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_so.c:73: warning: Function parameter or member 'rcu' not described in 'vmw_view' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_so.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_so.c b/drivers/gpu/drm/vmwgfx/vmwgfx_so.c index 7369dd86d3a9c..2877c7b43bd78 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_so.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_so.c @@ -42,6 +42,7 @@ /** * struct vmw_view - view metadata * + * @rcu: RCU callback head * @res: The struct vmw_resource we derive from * @ctx: Non-refcounted pointer to the context this view belongs to. * @srf: Refcounted pointer to the surface pointed to by this view. From patchwork Fri Jan 15 18:15:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366148 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2BECC433E9 for ; Fri, 15 Jan 2021 18:17:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC60C23A58 for ; Fri, 15 Jan 2021 18:17:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388507AbhAOSRS (ORCPT ); Fri, 15 Jan 2021 13:17:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387939AbhAOSRL (ORCPT ); Fri, 15 Jan 2021 13:17:11 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06730C061799 for ; Fri, 15 Jan 2021 10:16:13 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id k10so8219445wmi.3 for ; Fri, 15 Jan 2021 10:16:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7KYIRZUMjvLyRUbCXd5tQbvxw5rYCxBLXlaIwYega2M=; b=cTyl8yMKBSAZ/N4WjkxQV07ASPFJSu6cXq/VF6UavPGKyKj9xHoyv1C9SnOJI2EP+D QXX4nloc+pgoc/fRoNjV5hsa5nE7Hv1mp8iFj/rzBJ1Z0Hw2PBVhJNm+ct2ECGxivHiX zRHyN+UUp8nxQqkLrLkzaHWGW+jc5yZXthAM2JAh1LBD1yaKQeGBDcw3Ro9YupeEhqAx d7gbPjmPIfjs2KG+Mu/Q0wa5Z+LuODjn0Qpq6f173gwZAqeQXgFsFaxPgX9hLZi69fO3 iBPC7PvSJ3Bf37KxOS9ZcM7don7A7lyZ70Xx0tjmUI2xI7H9mMFrNUMx/H5GiFai0E1r ARsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7KYIRZUMjvLyRUbCXd5tQbvxw5rYCxBLXlaIwYega2M=; b=hVGbFrYMR0WhpFm/RY9PEEDv7h3RJ7QeyWsdoCDyQjd3yzu2wcqHNmOx/ynfaF1TVP Y46m5Z6oz2go+ovBhUy487TlB2Ci41uJCM2H62tZIULRHUel/b+oTie6PxZOP5anh1H6 G5cRzpnMD1XwNdhhd/Na9eTVuMujGFCNpVUHFviEmFF7KpCjpp6ZCeMaWOCAt6uxcL2v rs9L2vL6kF2+Nm/YF88QpHd1XgyrO3ixBM09RWCiWY3t3hh91QgyOLYgH1pzEN470Bc5 WvT1UgTVIpCe+nwMqqWZEot1DRRapwjBsBy4PDrmOpLHQ3Vvvwao7R6/xceSwHzBEqIm V77A== X-Gm-Message-State: AOAM530iIej8asoDLckH88ymGNN9b919fxRwbThmvHlZrtxJNgHNUY11 Fk5S9sp78HDbdxy3FBe58iaHNg== X-Google-Smtp-Source: ABdhPJzib4ExSirn3o55kUR1rs78it0ufIN6Hyy67qU+KiaF5tSw6dgVq0LjBf4ReP+FWzqYltO5zQ== X-Received: by 2002:a1c:7213:: with SMTP id n19mr9963732wmc.14.1610734571743; Fri, 15 Jan 2021 10:16:11 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:11 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , Zack Rusin , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 04/29] drm/vmwgfx/vmwgfx_binding: Provide some missing param descriptions and remove others Date: Fri, 15 Jan 2021 18:15:36 +0000 Message-Id: <20210115181601.3432599-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:340: warning: Function parameter or member 'shader_slot' not described in 'vmw_binding_add' drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:340: warning: Function parameter or member 'slot' not described in 'vmw_binding_add' drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:376: warning: Function parameter or member 'from' not described in 'vmw_binding_transfer' drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:498: warning: Function parameter or member 'to' not described in 'vmw_binding_state_commit' drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:498: warning: Excess function parameter 'ctx' description in 'vmw_binding_state_commit' drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:498: warning: Excess function parameter 'scrubbed' description in 'vmw_binding_state_commit' drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:520: warning: Function parameter or member 'cbs' not described in 'vmw_binding_rebind_all' drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:520: warning: Excess function parameter 'ctx' description in 'vmw_binding_rebind_all' drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:795: warning: Function parameter or member 'shader_slot' not described in 'vmw_emit_set_sr' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_binding.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_binding.c b/drivers/gpu/drm/vmwgfx/vmwgfx_binding.c index 180f6dbc9460d..81f525a82b77f 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_binding.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_binding.c @@ -330,6 +330,8 @@ static void vmw_binding_drop(struct vmw_ctx_bindinfo *bi) * * @cbs: Pointer to the context binding state tracker. * @bi: Information about the binding to track. + * @shader_slot: The shader slot of the binding. + * @slot: The slot of the binding. * * Starts tracking the binding in the context binding * state structure @cbs. @@ -367,6 +369,7 @@ void vmw_binding_add_uav_index(struct vmw_ctx_binding_state *cbs, uint32 slot, * vmw_binding_transfer: Transfer a context binding tracking entry. * * @cbs: Pointer to the persistent context binding state tracker. + * @from: Staged binding info built during execbuf * @bi: Information about the binding to track. * */ @@ -484,9 +487,8 @@ void vmw_binding_res_list_scrub(struct list_head *head) /** * vmw_binding_state_commit - Commit staged binding info * - * @ctx: Pointer to context to commit the staged binding info to. + * @to: Staged binding info area to copy into to. * @from: Staged binding info built during execbuf. - * @scrubbed: Transfer only scrubbed bindings. * * Transfers binding info from a temporary structure * (typically used by execbuf) to the persistent @@ -511,7 +513,7 @@ void vmw_binding_state_commit(struct vmw_ctx_binding_state *to, /** * vmw_binding_rebind_all - Rebind all scrubbed bindings of a context * - * @ctx: The context resource + * @cbs: Pointer to the context binding state tracker. * * Walks through the context binding list and rebinds all scrubbed * resources. @@ -789,6 +791,7 @@ static void vmw_collect_dirty_view_ids(struct vmw_ctx_binding_state *cbs, * vmw_binding_emit_set_sr - Issue delayed DX shader resource binding commands * * @cbs: Pointer to the context's struct vmw_ctx_binding_state + * @shader_slot: The shader slot of the binding. */ static int vmw_emit_set_sr(struct vmw_ctx_binding_state *cbs, int shader_slot) From patchwork Fri Jan 15 18:15:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366151 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B62A2C43381 for ; Fri, 15 Jan 2021 18:17:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CFFC23A58 for ; Fri, 15 Jan 2021 18:17:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388558AbhAOSRg (ORCPT ); Fri, 15 Jan 2021 13:17:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388349AbhAOSR1 (ORCPT ); Fri, 15 Jan 2021 13:17:27 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDE1AC06179A for ; Fri, 15 Jan 2021 10:16:14 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id e15so2002068wme.0 for ; Fri, 15 Jan 2021 10:16:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ei80Fpi/NHdpNAUZshztT153p4/37OmShz52J4NwQ9Q=; b=ez6/pCbgjiKbH4YqZyRmCG45Xt9FGesqfWhDVvuPZ+dCPSnfDTjbRXy/tYcmnfSRdE c2xoWUyDioc5kwwAeyghLoAe5ZKaInjA+xlyjex+ynmNz6AZH1lOvHW0rEf3ZfB6KdV9 rP7eH36pLUBUvSeUgtxjaCLvMILiD/ZffnIIwddomGp1Dcf/E3WE7byM9VcmEZiXwx87 W6MO0F0mtbI6FS5xzmQzHc3xc3O2e5X2t7RUuiX0lbGWNqITuvup72EyyM6BnbPSeJgk dNAxIqCQgnxZqrW+27ceCASfZCWQZSAw1vfd5txLzmkP8wi5l5ANmuF/SQBAW0JHj2ej MkAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ei80Fpi/NHdpNAUZshztT153p4/37OmShz52J4NwQ9Q=; b=egubHM/6qrAPcUOgr6S5cfLGYqHUSdCfjmhVpNQN+1I1H4kJmLJGBSIj4GdkcCu+Db /9O3dYmkt5Beva0sCUEqWeVaQULAJ2mO5B0DepvMpIxsExGzSNFF4TpGWxt2IL9PhaMt wCwpzohkgQdR5VBWkf5fgT9UrNa+vQMojw3W2KiKLnMDP4YepgiRNqgY8Pd4ZBf15bfp /ii7NsLvdMlLAk3Q9jYNQsNk38kHIhpcxPeWYQdYELRSBUXRabT5S9D4bp0khecPNYY1 RkLsunFy+h5MLbjZ+LEA7ac4q/DRopHhfn885WcPhOyfHnmtv5DaSBPcR6vIvrauR0Og 1Nog== X-Gm-Message-State: AOAM5332IycAkv5HzpkK8jA1slffMvrZ8a5AjhyVOqfayiUu48xnigE0 q6bElS0Ef7E+4ql7RXZUYIGNfQ== X-Google-Smtp-Source: ABdhPJwX4CxBwGr2oULRklZN0T24FZWYVkHWccYV92xPLHUZgBvZqYcBfBuuEtgEw1nWmEEcKHBktQ== X-Received: by 2002:a7b:cc0f:: with SMTP id f15mr9903003wmh.29.1610734573560; Fri, 15 Jan 2021 10:16:13 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:12 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , Zack Rusin , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 05/29] drm/vmwgfx/vmwgfx_msg: Fix misspelling of 'msg' Date: Fri, 15 Jan 2021 18:15:37 +0000 Message-Id: <20210115181601.3432599-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_msg.c:261: warning: Function parameter or member 'msg' not described in 'vmw_send_msg' drivers/gpu/drm/vmwgfx/vmwgfx_msg.c:261: warning: Excess function parameter 'logmsg' description in 'vmw_send_msg' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_msg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c b/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c index 15b5bde693242..609269625468d 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c @@ -253,7 +253,7 @@ static unsigned long vmw_port_hb_in(struct rpc_channel *channel, char *reply, * vmw_send_msg: Sends a message to the host * * @channel: RPC channel - * @logmsg: NULL terminated string + * @msg: NULL terminated string * * Returns: 0 on success */ From patchwork Fri Jan 15 18:15:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366172 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70D81C433E6 for ; Fri, 15 Jan 2021 18:20:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D1C423AA8 for ; Fri, 15 Jan 2021 18:20:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388196AbhAOSTg (ORCPT ); Fri, 15 Jan 2021 13:19:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388358AbhAOSR1 (ORCPT ); Fri, 15 Jan 2021 13:17:27 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14487C06179B for ; Fri, 15 Jan 2021 10:16:16 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id 6so2911319wri.3 for ; Fri, 15 Jan 2021 10:16:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GmnTQYGZFT8V4aHtRElOATkEuVPQEpEkCVYessHQgb4=; b=ao9i4vgDHHQIUekQ87MHFQREuE2D0YpI1oA3cL0opjewp4Err83XY74KoQW+PUQcRb 5/OpZ0hdYs3gjXlaP4yjSWRMs8fpNjQkP5N5s+0qHuSdnNtrQNkslDD5dTRBpdk81T82 4WPof4xIye7KPIpjykKw+as/Cvbr9v1Rl35atrE3W11DRTGEVwpo/EwHgUrj5ekuqI7L UUn7enAqQxpHwWjStPF8uo8DaTyvkZ9pdHdvzPePM1Q8OkvY0mpwg96l4+z6Iw6+1tC0 bxLNZbk/UNcrrkbxvO9Xtzv6XjYJ/EbZQr8gLmniTqceS+jGGfITIBLFZYamuuJSqY2e Qc5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GmnTQYGZFT8V4aHtRElOATkEuVPQEpEkCVYessHQgb4=; b=VZ2gFM1s2oqBiW55bJLdRH6lV9nUAWhjwxWgOjLtfmMoeVhyQYdS8l+0EV8VyTqYCv VG3bUUjEkXR9kefbPmmBXj6suChZ2YKCq9rfiPH8GvF4dU2H9tYqdWDNMvN/0fs3pbFe ctBK5RtlvcpolC9XV4W9U4A1zN78FFP3nShB9D6fUNUxlC5N1flISmRmBkjUUHkQiYLz VdJTp5/gXKrU562Er0ZJHj6iUN/bBZD5bA2rUx+isHKSGLDxR7TSUdzYT9uhTYkvoGv4 eBYeuPI0BkkHo/mloeC/Z6aD9SR0K0op/QvaL7SQb/l4D+e2NSQLau7B5yAADkiiB+dn DhLA== X-Gm-Message-State: AOAM5338A3PbsYbOvBClyzObpnDJWePAUt56xw3hwKfqB8OHmfRGulrq mtHCCoSq9mEMqcVDkjO6L6SgBQ== X-Google-Smtp-Source: ABdhPJym4/tW0/UVxoaeFRN8gzoR+0lDT/OQGytPzdRqN6VKamUOSS/5kWdr2iqHm14l/DYCyWCijA== X-Received: by 2002:adf:92a4:: with SMTP id 33mr14241917wrn.347.1610734574855; Fri, 15 Jan 2021 10:16:14 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:14 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 06/29] drm/gma500/mmu: Actually return an error if one occurs Date: Fri, 15 Jan 2021 18:15:38 +0000 Message-Id: <20210115181601.3432599-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/mmu.c: In function ‘psb_mmu_insert_pfn_sequence’: drivers/gpu/drm/gma500/mmu.c:651:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/mmu.c b/drivers/gpu/drm/gma500/mmu.c index 014daf0280485..13aff19aae9ba 100644 --- a/drivers/gpu/drm/gma500/mmu.c +++ b/drivers/gpu/drm/gma500/mmu.c @@ -681,7 +681,7 @@ int psb_mmu_insert_pfn_sequence(struct psb_mmu_pd *pd, uint32_t start_pfn, if (pd->hw_context != -1) psb_mmu_flush(pd->driver); - return 0; + return ret; } int psb_mmu_insert_pages(struct psb_mmu_pd *pd, struct page **pages, From patchwork Fri Jan 15 18:15:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366171 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51749C433E0 for ; Fri, 15 Jan 2021 18:19:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08A5323A7C for ; Fri, 15 Jan 2021 18:19:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387836AbhAOSTc (ORCPT ); Fri, 15 Jan 2021 13:19:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388438AbhAOSR1 (ORCPT ); Fri, 15 Jan 2021 13:17:27 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9197DC06179C for ; Fri, 15 Jan 2021 10:16:17 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id g10so8398697wmh.2 for ; Fri, 15 Jan 2021 10:16:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PL3TvnHahiyQuBH3untCsJLaGNo3fbz0WaK+zME/+EY=; b=DIyCrhYGYpbXTN/gNG8S4708V0wlTtUJC0rGazGsRTPd8I7Lur/eKogJ36AAd6DXEU ewwzCVyEE21qQSsWcf5plqzyE+RsxPNRu/lRYI5mjSCBiukzvIaqxkLovyoMg6KuJHUC 33oMhCOJJHO6rQCRUTYYA09SwaqrlQt3JDS8zJUgJPnAdDylZQiumxdVQ1wcJbY+ndTU eo4zJ0KYDXlQx8LqvG2k1FURlLljqinFUK8lxoxFB9Nbmc1ltw1FbDjfkcoa9uBOLPMg qR1EAoERH0wS8BTz96BZVS+1uUmDxe79lN58F9Etiu7y5cEg9Nwvf2EXXQLLT2YMVq2p 2aZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PL3TvnHahiyQuBH3untCsJLaGNo3fbz0WaK+zME/+EY=; b=q1NzO+F92LBdYO/LMdNv2/tfRI+53mg3AScGo+lXi4jZRUCbTLriWItea1oS4S2x99 QA5/WGmJ8lciBxaBsBKVZAiyU0BIZJTcPE1JpY9Xw29fWV15n1UDOUv2+1R9aFrxsHiJ S4bSJSRDkZww0kvmyz+QW6Mogup2C0p83izjtkDEE/I8IV2X8+ijtNEKGdJYtuU6bSNq F3OP4kOlfF8p+C2I8Q2JBAsk3krdgQNNpUKFvAZ0N/vU5rXyeBF6q1NY/09B1d8cFPp0 F9JrtuLv2Yzrkc21etxpP+y49oeqA3pSe6Lli6tNa20V2WzqyAZ049NUSgKcGH50T6sL YGwA== X-Gm-Message-State: AOAM532tN8RO4EcM3JKqt4pghWCPEQor1rcOOgPxeDkEdmnyzq6Ozv0W DnkipVbmADIWQj8WmRsZYN5KIA== X-Google-Smtp-Source: ABdhPJxGZsrxVnwaIHrrLxYumnCMb0fqwZs+ZBfd4wceHVmtJ3dsHgOV2CMExFctwoFBRy0gTF+Mfw== X-Received: by 2002:a1c:a145:: with SMTP id k66mr9751532wme.11.1610734576376; Fri, 15 Jan 2021 10:16:16 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:15 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , Zack Rusin , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 07/29] drm/vmwgfx/vmwgfx_blit: Add description for 'vmw_bo_cpu_blit's 'diff' param Date: Fri, 15 Jan 2021 18:15:39 +0000 Message-Id: <20210115181601.3432599-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:452: warning: Function parameter or member 'diff' not described in 'vmw_bo_cpu_blit' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c index 9f2779ddcf083..118db24eb756c 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c @@ -431,6 +431,7 @@ static int vmw_bo_cpu_blit_line(struct vmw_bo_blit_line_data *d, * @src_stride: Source stride in bytes. * @w: Width of blit. * @h: Height of blit. + * @diff: The struct vmw_diff_cpy used to track the modified bounding box. * return: Zero on success. Negative error value on failure. Will print out * kernel warnings on caller bugs. * From patchwork Fri Jan 15 18:15:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366173 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C385C433DB for ; Fri, 15 Jan 2021 18:20:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20DC123AA7 for ; Fri, 15 Jan 2021 18:20:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388108AbhAOSTf (ORCPT ); Fri, 15 Jan 2021 13:19:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388436AbhAOSR1 (ORCPT ); Fri, 15 Jan 2021 13:17:27 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0AC8C06179E for ; Fri, 15 Jan 2021 10:16:18 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id y187so8414807wmd.3 for ; Fri, 15 Jan 2021 10:16:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JdzYhU96phNVr/cQmxntosfoEfrUPlI8/6w18TG83mk=; b=TgDPtz5OvXkvw5Kk9fA2xhsW71qTJ9nYJUgdLHH5EdsH+0RK/3EQ6dpwnKsx95hrKT 2NFRLoQ2wNRsll1ImY+Eb83/QcJDfxPVKvKy2h7sSp13zL4UOUv9eBJvnJoXM5mLbgCP +jYHH/dPinV1RgllXaAYNLMVRpK8iV00cfHsW2kmDYxA2/nb6ljeeZmFMjX0A0/Vl8wz Swytj0YA1VCE58u+SRc09oFwc1jtE2W+zl2kQdPZ/I/+6Kb8zuw6NZwmd7H4KQCzVMg6 SrZxc1Kr0wnWa/zW8WK/VRDyWYgg+Td4hVQawOpdIfsMQ9xu7Rc+D2V7CHcCQbFWd0B1 ab0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JdzYhU96phNVr/cQmxntosfoEfrUPlI8/6w18TG83mk=; b=PuKqfUbmUebk6BSiXrY9zr4KxEmkKz6dBNryyvpWqzshEm0qOPZvJN0BwtnAsQqekp 9gfghXhNWUgGpKmA0dcDN1LMwzt9zlbIMpdGzJ5weJkQ+VFZ70Y3mUAnZQvCIjjlusAQ 1z2rWWancoU7NZoxXQ94TCtAMc42CHxiM16C/M31pSMiDuOzx8GpAbDWvZDSyJl637fs VGK0WTYc5mrDKN8MZJF+qFALfKPG6DIjQOPAD6HRLEvToNRdylr4fl+cYqNCvgHTQAhp DpFn19+zN+cbEPsEM6ge34QtveYGn453WVCxzhf5NEC0rg5c9dC9gttKdv829Yj1x6Pt 1ZWQ== X-Gm-Message-State: AOAM530YGVWKSk6k5oMI2QzmtNbFniy2866JuizjGwX+tMgYtMGvAD7Q Xh1HZCD/LRzdEjCEBl2ungXRKA== X-Google-Smtp-Source: ABdhPJy21scXSg9Gt64WbnwT54rQj3vczsfR+JtkjO+2ZBJ0m98nx3kMeC4U5h6q1waF82ERzsOFQQ== X-Received: by 2002:a1c:4b14:: with SMTP id y20mr2837058wma.6.1610734577506; Fri, 15 Jan 2021 10:16:17 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:16 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , Zack Rusin , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 08/29] drm/vmwgfx/vmwgfx_validation: Add some missing struct member/function param descriptions Date: Fri, 15 Jan 2021 18:15:40 +0000 Message-Id: <20210115181601.3432599-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:85: warning: Function parameter or member 'dirty' not described in 'vmw_validation_res_node' drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:85: warning: Function parameter or member 'dirty_set' not described in 'vmw_validation_res_node' drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:216: warning: Function parameter or member 'res' not described in 'vmw_validation_find_res_dup' drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:216: warning: Excess function parameter 'vbo' description in 'vmw_validation_find_res_dup' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_validation.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c b/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c index f2e2bf6d1421f..e7570f422400d 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c @@ -48,7 +48,6 @@ struct vmw_validation_bo_node { u32 as_mob : 1; u32 cpu_blit : 1; }; - /** * struct vmw_validation_res_node - Resource validation metadata. * @head: List head for the resource validation list. @@ -64,6 +63,8 @@ struct vmw_validation_bo_node { * @first_usage: True iff the resource has been seen only once in the current * validation batch. * @reserved: Whether the resource is currently reserved by this process. + * @dirty_set: Change dirty status of the resource. + * @dirty: Dirty information VMW_RES_DIRTY_XX. * @private: Optionally additional memory for caller-private data. * * Bit fields are used since these structures are allocated and freed in @@ -205,7 +206,7 @@ vmw_validation_find_bo_dup(struct vmw_validation_context *ctx, * vmw_validation_find_res_dup - Find a duplicate resource entry in the * validation context's lists. * @ctx: The validation context to search. - * @vbo: The buffer object to search for. + * @res: Reference counted resource pointer. * * Return: Pointer to the struct vmw_validation_bo_node referencing the * duplicate, or NULL if none found. From patchwork Fri Jan 15 18:15:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366169 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBC59C43381 for ; Fri, 15 Jan 2021 18:19:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A08B523A58 for ; Fri, 15 Jan 2021 18:19:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728264AbhAOSTT (ORCPT ); Fri, 15 Jan 2021 13:19:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388517AbhAOSRb (ORCPT ); Fri, 15 Jan 2021 13:17:31 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91F14C06179F for ; Fri, 15 Jan 2021 10:16:20 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id m4so10190756wrx.9 for ; Fri, 15 Jan 2021 10:16:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=klcbd1e9WNIfeT7Kw/V+fGmeHX8/YIMOVJeu6cqS6p8=; b=Jeva4W7b5GmkLma0e0Xq2LyelIdviMQ5Xtdc74BWOdiUZov1iTUGSs4RdBxLNmQI6C xZ9R5zA0dodI3/TxwKcWEepE4zEOvD40upf9vjbHymNQhp+QdNYGPJzgJIKkQbocLbc8 cE32+iJI5yVLlTDqLJI9VzVuWhPNvOuhdmUMumzV9EXyb2S83X1nTD0CtHsod8AmpZYQ L6y8sevlrSKQa0OomUujlM4Vl0UDvZ7LIStc5x9v9qb62+xiBlnUDNgiirVMuLMGkv1d OTqR4QgreqpMCp2pOorq5hOFyE5Pklwlns+yu4dxl3V7HNxbLo/QgIRVxAW56aXa1zOs G0qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=klcbd1e9WNIfeT7Kw/V+fGmeHX8/YIMOVJeu6cqS6p8=; b=nWLO9VoMMAEXn+j0l5CZgJsiytrqYhOuZ/WMV9JerINhhT+2arSWmyYabVAST7jL7b M3WOMKOZlg6OtQLVqsxDFjrmFMhMZmsbyNOapPlVd8qtCdE0/ubulXWrHOSTbRqu4faa zb62urQvJEI2yClXHSLnrtzCe9AWLucYR9vwrfO8UhEnLE4+gXvAHvScEh+OG0BZGQd9 vaz/9gd4adrSn2vzL65WW2HQFCQUz65VhMzNrs6txwEI3lNXcxYBcXW1ZnyTy4citXxE 8RMAvXyzGM6WgdpbZh3oRwXSeGQ21FcY/YaPZ0EYk/I7u7HAtdTAqnEsqTBNDFWhWZ+U 7ikQ== X-Gm-Message-State: AOAM532LgmK0amOk853tyMWcBOUiiv6YKMCFyAaJb9h5ohaA6SH5OBr3 7hQn/rS/IBRKo2A+aK+gpXWTCw== X-Google-Smtp-Source: ABdhPJySoMYDbbVCZgUWIxIqiX91GdBD0424m3xS2BiLVfk/hmUs+W5i3x0nPZ2KmzwAXV+nPvMwOw== X-Received: by 2002:a05:6000:2cf:: with SMTP id o15mr14224637wry.184.1610734579303; Fri, 15 Jan 2021 10:16:19 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:18 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , Zack Rusin , David Airlie , Daniel Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , Dave Airlie , Rob Clark , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH 09/29] drm/vmwgfx/ttm_object: Demote half-assed headers and fix-up another Date: Fri, 15 Jan 2021 18:15:41 +0000 Message-Id: <20210115181601.3432599-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/ttm_object.c:60: error: Cannot parse struct or union! drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'mem_glob' not described in 'ttm_object_device' drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'ops' not described in 'ttm_object_device' drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'dmabuf_release' not described in 'ttm_object_device' drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'dma_buf_size' not described in 'ttm_object_device' drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'idr' not described in 'ttm_object_device' drivers/gpu/drm/vmwgfx/ttm_object.c:128: warning: Function parameter or member 'rcu_head' not described in 'ttm_ref_object' drivers/gpu/drm/vmwgfx/ttm_object.c:128: warning: Function parameter or member 'tfile' not described in 'ttm_ref_object' drivers/gpu/drm/vmwgfx/ttm_object.c:582: warning: Function parameter or member 'dmabuf' not described in 'get_dma_buf_unless_doomed' drivers/gpu/drm/vmwgfx/ttm_object.c:582: warning: Excess function parameter 'dma_buf' description in 'get_dma_buf_unless_doomed' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: Dave Airlie Cc: Rob Clark Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/ttm_object.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/ttm_object.c b/drivers/gpu/drm/vmwgfx/ttm_object.c index 0fe869d0fad12..b3fdc630497cb 100644 --- a/drivers/gpu/drm/vmwgfx/ttm_object.c +++ b/drivers/gpu/drm/vmwgfx/ttm_object.c @@ -73,7 +73,7 @@ struct ttm_object_file { struct kref refcount; }; -/** +/* * struct ttm_object_device * * @object_lock: lock that protects the object_hash hash table. @@ -96,7 +96,7 @@ struct ttm_object_device { struct idr idr; }; -/** +/* * struct ttm_ref_object * * @hash: Hash entry for the per-file object reference hash. @@ -568,7 +568,7 @@ void ttm_object_device_release(struct ttm_object_device **p_tdev) /** * get_dma_buf_unless_doomed - get a dma_buf reference if possible. * - * @dma_buf: Non-refcounted pointer to a struct dma-buf. + * @dmabuf: Non-refcounted pointer to a struct dma-buf. * * Obtain a file reference from a lookup structure that doesn't refcount * the file, but synchronizes with its release method to make sure it has From patchwork Fri Jan 15 18:15:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366149 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8767FC433DB for ; Fri, 15 Jan 2021 18:17:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C09623A5A for ; Fri, 15 Jan 2021 18:17:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388487AbhAOSR2 (ORCPT ); Fri, 15 Jan 2021 13:17:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732557AbhAOSR0 (ORCPT ); Fri, 15 Jan 2021 13:17:26 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8C4DC0617A1 for ; Fri, 15 Jan 2021 10:16:21 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id 6so2911567wri.3 for ; Fri, 15 Jan 2021 10:16:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h0iVILfCe9Q5cRcFeOSW9WvBexCJRHav+Q3xWBDxDaM=; b=AVHrSt6WQH1H/WKVov8I+ShF2hDc7oVn8PibmE8jXXlDIrSpdtFjvTaFMYo7yQQh1E 8siLsj8/YVEJYu3SlMKDds60GTn6kRrDv7Dlna9STM5wkb9OMkYC+MJaHLUosF0P43T/ zI7Ex9gttZUjKfm64Ziyysc9tuz1dvmU2dLT+rX5YEY8XGJnteos5tn/dDZbva26EIg1 Fa2SAP1haIrUIn12LGx9p8prbF8HE3nWsmpsYoQcwFROY0QBT2XMfqlg4Z4rfkgLY8bB i7BKoGOneo4BauGuDDarqrJ37V6ttc+xTkiXBRsNolZoS7jZTmd4n1kjULeoyKddPwpm C6cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h0iVILfCe9Q5cRcFeOSW9WvBexCJRHav+Q3xWBDxDaM=; b=Oz4QNurIMSrnsN2ESx78EXrkoOTiRkqun/4Uudx7tIHb7YlQ5IjpYmtWPCgxBdcpCK SEhWK1NiLfpM/RKl2KInF6TxqMXx5ViWg6Xs+KvJk3X6KfNL3ymClj7hqdBuunwDBE9n 6wv39QwgyXOGmmEh6jHYl2VU5QBN3/5yRpr0+PV4DZym4q3Ak6tpLWkfjV5kRoLvysAh pgZb+fhynJVYL0m/D2p72YBXu2d33+prdLM5ozvKoRC9mkaSNxEQ4mqRaP8VBRqCZpSe QArtfnVkrZJfH0c6q5U24ZI4p/niig6R+aHFxXpS+b5HKMj3nWLKrIpP+cEbCzn4IoBH g6aA== X-Gm-Message-State: AOAM533tWdcCST7pkNtkeEHgqMRFBlIrjkYFtDGQOEnP1AKURS/Fa7Pg nL26qj5qjriLMulVDn9C9+2fNg== X-Google-Smtp-Source: ABdhPJzhVRxpTey/n7ZbeueuVV4J8bOk7G4YtYdQwoJ9VGq5SQ9VTTnokSb8dyvMnQOTsHVWMChPOg== X-Received: by 2002:adf:ec92:: with SMTP id z18mr14789883wrn.166.1610734580564; Fri, 15 Jan 2021 10:16:20 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:19 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , Zack Rusin , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 10/29] drm/vmwgfx/vmwgfx_thp: Add description for 'vmw_thp_manager's member 'manager' Date: Fri, 15 Jan 2021 18:15:42 +0000 Message-Id: <20210115181601.3432599-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_thp.c:21: warning: Function parameter or member 'manager' not described in 'vmw_thp_manager' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/vmwgfx_thp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_thp.c b/drivers/gpu/drm/vmwgfx/vmwgfx_thp.c index e8e79de255cf7..eb63cbe64909d 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_thp.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_thp.c @@ -11,6 +11,7 @@ /** * struct vmw_thp_manager - Range manager implementing huge page alignment * + * @manager: TTM resource manager. * @mm: The underlying range manager. Protected by @lock. * @lock: Manager lock. */ From patchwork Fri Jan 15 18:15:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366168 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6487C433E9 for ; Fri, 15 Jan 2021 18:19:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DA2A222B3 for ; Fri, 15 Jan 2021 18:19:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388528AbhAOSRd (ORCPT ); Fri, 15 Jan 2021 13:17:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731927AbhAOSR0 (ORCPT ); Fri, 15 Jan 2021 13:17:26 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23A9CC0617A2 for ; Fri, 15 Jan 2021 10:16:23 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id s24so1404338wmj.0 for ; Fri, 15 Jan 2021 10:16:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Pk5+6mRjwwMBA1oTZMeewA7tFyIHWI0+EL96CyzELJ8=; b=vXcak5ntquYDz653i1Vs6VN6dq47ysugV+cN1Mcv7e+2SbuXbmiq4gzzxa3qtSfJtP iDLpgM9bzc4m2lupyUGfbM3/WzGGvqGS7802m0E3Xa1FxP57gU/VLF/+uN+8qxvLE4ru tLDSbod3qxRpck5TB1Na64i43keLb2lC5M+YaOXe57EIqjZE0wnjXfPx5fBXmA7P1/Jg eYb5bj5G2/rwj3+MFStbGYvn/gQOKYCgG+NB8gL0m/14PVzYC/n0LaevwZHgvZnBC4uG 0/AH/tzlOU81Qpl6eBZ+JxqYYsd+wOAkTKfMZ55HzUixFp1CkhRmMBll2wLjnbYy22jC dIDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Pk5+6mRjwwMBA1oTZMeewA7tFyIHWI0+EL96CyzELJ8=; b=HO/U423B/MVuXtiu5ZLuN7U3+rY2mI+LdEIt7iq83K/rHA8rJKU2+mUFKgGSo95OXy rpKlxT3Vmiof5mXwK48QjqMNDaaUHs65TTQcrjHfdmuAv4oImNlKNwjlZTIJk7S5O4rB AhqSBS3HNhL5HTg74q+F1nSV5rT1VXNtqKYS2GXXijyn9j+UQzkhkyVIXhx/2Be4zQO7 DnaH5+WBJchFpE9SDlqh884k0CcIc9QIfmePF72VueICizYDvAWaYo7n9rfkxSwBS3PN rK6Ya9r8yqnflLO2PQkcsUdSsmqlAif8s62I1l4yeRWoiWYxlvIsC6FUHAEWmlg2wMu+ itCQ== X-Gm-Message-State: AOAM533GPdoN9/GuB4aqSPBOqC0fUEfT1zyRtghTlNrqn3LAlBDx/E10 ANUODn1Z+xJDirH/3xSvhp37Eg== X-Google-Smtp-Source: ABdhPJziSG5JNrmyeD/Cfd4CigulzEBuOBdQ6siz1iWXcp4UaNN7um1FPb2T4SUj0PnvdWvNa90U1g== X-Received: by 2002:a1c:358a:: with SMTP id c132mr9884433wma.157.1610734581782; Fri, 15 Jan 2021 10:16:21 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:21 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , Jesse Barnes , Eric Anholt , dri-devel@lists.freedesktop.org Subject: [PATCH 11/29] drm/gma500/psb_intel_sdvo: Demote kernel-doc abuses Date: Fri, 15 Jan 2021 18:15:43 +0000 Message-Id: <20210115181601.3432599-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/psb_intel_sdvo.c:230: warning: Function parameter or member 'psb_intel_sdvo' not described in 'psb_intel_sdvo_write_sdvox' drivers/gpu/drm/gma500/psb_intel_sdvo.c:230: warning: Function parameter or member 'val' not described in 'psb_intel_sdvo_write_sdvox' drivers/gpu/drm/gma500/psb_intel_sdvo.c:598: warning: Function parameter or member 'psb_intel_sdvo' not described in 'psb_intel_sdvo_get_trained_inputs' drivers/gpu/drm/gma500/psb_intel_sdvo.c:598: warning: Function parameter or member 'input_1' not described in 'psb_intel_sdvo_get_trained_inputs' drivers/gpu/drm/gma500/psb_intel_sdvo.c:598: warning: Function parameter or member 'input_2' not described in 'psb_intel_sdvo_get_trained_inputs' drivers/gpu/drm/gma500/psb_intel_sdvo.c:1831: warning: Function parameter or member 'dev_priv' not described in 'psb_intel_sdvo_select_ddc_bus' drivers/gpu/drm/gma500/psb_intel_sdvo.c:1831: warning: Function parameter or member 'sdvo' not described in 'psb_intel_sdvo_select_ddc_bus' drivers/gpu/drm/gma500/psb_intel_sdvo.c:1831: warning: Function parameter or member 'reg' not described in 'psb_intel_sdvo_select_ddc_bus' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Jesse Barnes Cc: Eric Anholt Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/psb_intel_sdvo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_sdvo.c b/drivers/gpu/drm/gma500/psb_intel_sdvo.c index 2ddf7e41aa5d4..355da28563891 100644 --- a/drivers/gpu/drm/gma500/psb_intel_sdvo.c +++ b/drivers/gpu/drm/gma500/psb_intel_sdvo.c @@ -221,7 +221,7 @@ static bool psb_intel_sdvo_create_enhance_property(struct psb_intel_sdvo *psb_intel_sdvo, struct psb_intel_sdvo_connector *psb_intel_sdvo_connector); -/** +/* * Writes the SDVOB or SDVOC with the given value, but always writes both * SDVOB and SDVOC to work around apparent hardware issues (according to * comments in the BIOS). @@ -588,7 +588,7 @@ static bool psb_intel_sdvo_set_target_input(struct psb_intel_sdvo *psb_intel_sdv &targets, sizeof(targets)); } -/** +/* * Return whether each input is trained. * * This function is making an assumption about the layout of the response, @@ -1818,7 +1818,7 @@ psb_intel_sdvo_guess_ddc_bus(struct psb_intel_sdvo *sdvo) #endif } -/** +/* * Choose the appropriate DDC bus for control bus switch command for this * SDVO output based on the controlled output. * From patchwork Fri Jan 15 18:15:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366158 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5E84C4332E for ; Fri, 15 Jan 2021 18:18:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8B0323A58 for ; Fri, 15 Jan 2021 18:18:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388612AbhAOSRy (ORCPT ); Fri, 15 Jan 2021 13:17:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387893AbhAOSRv (ORCPT ); Fri, 15 Jan 2021 13:17:51 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C737EC0617A3 for ; Fri, 15 Jan 2021 10:16:24 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id d13so10175849wrc.13 for ; Fri, 15 Jan 2021 10:16:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zEPxdikffcTW2XPBOoX0ED37z3NmpTHI0lnPWz6mmx4=; b=elNfSM6dpymdVu7cXnuqL/DyR6BGtAJr1JNqz//XpUL5XJAzQV5/ybGb5qx/p8vqkd eDpo+SxY14xZcS3DkqCIoGM/ppMnX50g9C+A0KjCvVHdTJwrUrfpRyUhQCl7rHqqIIv/ kzFFqsbookfXD72VlfD/4p/ixKXwsrx/l/Z8tVCR1ONjmeCdVMdGOK8LhKhm4tH3bnST NKGf5s6rEgwqlqLe3P1DWP9cFKUHn/HfYtkdjsMvkaXqTgaRU+iDWcK9BM33KpKTtOEs gk6Zo8Bs9IFT8Kt7v36mznUsmWa6uYU0fjD2nptZf0ThRXkPGfT2zmAn9B4egyZQYRm4 607A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zEPxdikffcTW2XPBOoX0ED37z3NmpTHI0lnPWz6mmx4=; b=cnp1DdkY4Zr1cvI1VII0G/kBPDZeACuEctj2696CqD2d8I2ZvFf4VbVvQGBAowthPp ngH7W9F7bgIdzZwUl0/33G6nr3zN35+j5XITglslBGPDxuSQoFt8vQfUCuXHMvS+bFQl pn/AAVWPnBHbEm/8GHq9slBJaqnI7pdbz+qnYiTz3zGiTNfD2fdWHrqCU7Vy0/N3klcK jt4GSTxkfUTDGkcgsWr8PYKM8zwRfgSL9tL7JZzYj9hHV+N4s7Re2sQ8FSFQpj4kGESm GTEETYj98xrMvfWSXF2pKFRd754ylY7GRukXCTLk02NWHyIUOIyzeP1WdGjFnlCXVkZo 9wgQ== X-Gm-Message-State: AOAM530EVSqqQJ4womwUrOxkca7DnJwPP0/89w6m4C0MXghTfyA8UNTF UvfdUqyHERKG1pNqzYaQy+8WDQ== X-Google-Smtp-Source: ABdhPJx9fUXhSGU2SF0jAgigDyWvaMoz7pHYrsOUFdwXDwpjlpmnzjzCUrVTtzojo8Xb3TAl/uMPIQ== X-Received: by 2002:a5d:56c3:: with SMTP id m3mr14531708wrw.419.1610734583554; Fri, 15 Jan 2021 10:16:23 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:22 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 12/29] drm/gma500/psb_irq: Demote kernel-doc abuse Date: Fri, 15 Jan 2021 18:15:44 +0000 Message-Id: <20210115181601.3432599-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/psb_irq.c:134: warning: Function parameter or member 'dev' not described in 'mid_pipe_event_handler' drivers/gpu/drm/gma500/psb_irq.c:134: warning: Function parameter or member 'pipe' not described in 'mid_pipe_event_handler' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/psb_irq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_irq.c b/drivers/gpu/drm/gma500/psb_irq.c index 361e3a0c5ab6b..5cceea9be5348 100644 --- a/drivers/gpu/drm/gma500/psb_irq.c +++ b/drivers/gpu/drm/gma500/psb_irq.c @@ -126,9 +126,8 @@ static void mid_disable_pipe_event(struct drm_psb_private *dev_priv, int pipe) } } -/** +/* * Display controller interrupt handler for pipe event. - * */ static void mid_pipe_event_handler(struct drm_device *dev, int pipe) { From patchwork Fri Jan 15 18:15:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366157 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96EC9C4332D for ; Fri, 15 Jan 2021 18:18:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 788CA23B02 for ; Fri, 15 Jan 2021 18:18:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388638AbhAOSR6 (ORCPT ); Fri, 15 Jan 2021 13:17:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388603AbhAOSRv (ORCPT ); Fri, 15 Jan 2021 13:17:51 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF1B1C0617A4 for ; Fri, 15 Jan 2021 10:16:25 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id 91so10219562wrj.7 for ; Fri, 15 Jan 2021 10:16:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xr/TlOQIPbbJBH63luKhm4AYMPttpvHdoQcinOdIcB8=; b=r665qRD55DKCi1zOw3JQLyj/yuHDdy5XWz6+iov23eG6Qdd3Ou2RgZPr/83oBEf2o+ 4rzUXjDIJxFS91pJSuuKjbW3s8HaVx7Rm7QAL36NI6gpE57a3p+CzU3uy/VluPW+jNae 7sdZBLdjkddIouTVDXdfOwsZNF0OMBP6hBc8LsBvQWXEs7N1fAIm4v+7PIh7mxJA0dlC bIvK8IuLS4SP4v22vCIP6O9Tcd20ZKsll1HRj2WQ/hLaTd1Dg1lLMdhChmBX3WDb0fet gks7rRepkkmjmWL7+nb9agT5oHUc1rmfUwwwHuI7qpJp+WGbv5Yvdd7o7gOoFeIMoiQg 1d9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xr/TlOQIPbbJBH63luKhm4AYMPttpvHdoQcinOdIcB8=; b=b1dnzQxfU66FuNh2suuSIBUm5Ekg73KXMAXKD5DgFJqJWJbg9E/9x7696MuWSLTdhx D577lk5dLPuqerTOXf04/5pvrIQw3sEHeSRc6rfFhlLjwmGy7DRRW780GzpHH20jXwdm 6pg6qCnfiW/Yxx6oWgDhhCErJFwTjHa/0T8RPXhA5UpQmfdmC/txKwdm05tQxDkWFtCo ZkOQm5QSkTfkrgcnahqU7fZP3QHdic1G7E8CVSEUxtLcR7OzkZquyMSgT0t5uYL79eaV OzgDbDnutW6zWeE1GrDk+VJp+4cCvhgYajdo9KBHAMWeW1xi9as6E5o8cO8PqoBz8PTh dEew== X-Gm-Message-State: AOAM532M7Ib0wgZciRsasqXGZH+Cenvs4OqK9MamM4JDmHdzIDw9Q8Bx kz5oHwdrsZO9FsSi0uLOzLyVtw== X-Google-Smtp-Source: ABdhPJyIqUDGRo287c/CoRsZQdx8gY8wQTE3x1mFLo+LVmJ8x8IULoKSWDYTOu8x3lcS8yBMhkv1Wg== X-Received: by 2002:adf:b359:: with SMTP id k25mr14766514wrd.98.1610734584764; Fri, 15 Jan 2021 10:16:24 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:24 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 13/29] drm/drm_dp_helper: Fix spelling issue and add missing description for 'enable_frl_ready_hpd' Date: Fri, 15 Jan 2021 18:15:45 +0000 Message-Id: <20210115181601.3432599-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/drm_dp_helper.c:965: warning: Function parameter or member 'color_spc' not described in 'drm_dp_downstream_rgb_to_ycbcr_conversion' drivers/gpu/drm/drm_dp_helper.c:965: warning: Excess function parameter 'colorspc' description in 'drm_dp_downstream_rgb_to_ycbcr_conversion' drivers/gpu/drm/drm_dp_helper.c:2678: warning: Function parameter or member 'enable_frl_ready_hpd' not described in 'drm_dp_pcon_frl_prepare' Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/drm_dp_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 3ecde451f5231..3c5b04abb66f1 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b/drivers/gpu/drm/drm_dp_helper.c @@ -954,7 +954,7 @@ EXPORT_SYMBOL(drm_dp_downstream_444_to_420_conversion); * RGB->YCbCr conversion capability * @dpcd: DisplayPort configuration data * @port_cap: downstream facing port capabilities - * @colorspc: Colorspace for which conversion cap is sought + * @color_spc: Colorspace for which conversion cap is sought * * Returns: whether the downstream facing port can convert RGB->YCbCr for a given * colorspace. @@ -2671,6 +2671,7 @@ EXPORT_SYMBOL(drm_dp_get_pcon_max_frl_bw); /** * drm_dp_pcon_frl_prepare() - Prepare PCON for FRL. * @aux: DisplayPort AUX channel + * @enable_frl_ready_hpd: Configure DP_PCON_ENABLE_HPD_READY. * * Returns 0 if success, else returns negative error code. */ From patchwork Fri Jan 15 18:15:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366150 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FCF9C433E6 for ; Fri, 15 Jan 2021 18:17:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74A0323A5E for ; Fri, 15 Jan 2021 18:17:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388515AbhAOSRb (ORCPT ); Fri, 15 Jan 2021 13:17:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387536AbhAOSR0 (ORCPT ); Fri, 15 Jan 2021 13:17:26 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D1ACC0617A5 for ; Fri, 15 Jan 2021 10:16:27 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id c124so8211283wma.5 for ; Fri, 15 Jan 2021 10:16:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Xb1YCvw4kaZw9lo4k2diSP0ZRuU7Xd8WppcxAl/MiDA=; b=uXazNko3Ye2A1AYNrjCLLq6bpwOE4mQ3fhAnSbVRy3tPzywmhYFHem+yunqZ87yneH s8CtKFvBmI7Fv4kX+gFnj6sm144bKSbUTSVopB6LjjLuc+F9IyhdfMRL/ldkxzbTX6ii ARDQ+2r+b+kRMKDqhpvG3RjtrfU+GaSZGcwOMnaxOh9zyRuyAbjk6ZFPwodt5Pzvan/a 4sE5ZdYFPgmgjqpSgG6kntQdsVdXRIx8/IVLyOPHWHzRE82z9E8B7FWWDecj6jllHJ50 O5qzM/Z9Bv+xVV72ain840kaDl2JAFSXhWAaAz+U6ciAzzdkyNrgZgbgK1CJ+zzRZCGd VF7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Xb1YCvw4kaZw9lo4k2diSP0ZRuU7Xd8WppcxAl/MiDA=; b=jcgMpVr9oRcpPjZ6gS9fHIqWENfT34ATuH4IykqivyeDqe0hzVKWu/hMlAKOwGILJO KZNDhMdVes5v4GhSx9ABdOAbNSV6yCZ46J69kdwdKI3r4r8LCwHele4toN9HkD/c19Eq bO0O1C/eTkZEnrKm7vEzTDxsbwMyPC5mBUufyK0C6UnDsyijHZGoHW90D0IUeV6M51oc L625WEZcfLF5ZnJdA3qpCdyhc749ZD5wpb641aQGsLR7djUXAUS7uW7ArifCOQTO+Swe 0FYj+EGfUlfUcvMp8WJsc49cri9+tNzdY5s4yiLbP2OFc6uZJfo9PPjhJd0tqUG+G3KQ UiTg== X-Gm-Message-State: AOAM532IQP/RhGi1JFfh2r/2A8wda/zY4aT95JCgIHZja1vxdPfU8n1W njEhVzYkyL7aMmO0+EiIsZw1Fw== X-Google-Smtp-Source: ABdhPJxW/+bf0aOgWlZYDE1g3TAxNc01NP5C9reyjW+xsDu0vazbM2CsWTjG8T7jj6kcJW2nFm5fZg== X-Received: by 2002:a1c:9684:: with SMTP id y126mr10147012wmd.2.1610734585915; Fri, 15 Jan 2021 10:16:25 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:25 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , Eric Anholt , dri-devel@lists.freedesktop.org Subject: [PATCH 14/29] drm/gma500/cdv_intel_crt: Demote kernel-doc abuse in 'cdv_intel_crt_detect_hotplug()'s header Date: Fri, 15 Jan 2021 18:15:46 +0000 Message-Id: <20210115181601.3432599-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/cdv_intel_crt.c:138: warning: Function parameter or member 'connector' not described in 'cdv_intel_crt_detect_hotplug' drivers/gpu/drm/gma500/cdv_intel_crt.c:138: warning: Function parameter or member 'force' not described in 'cdv_intel_crt_detect_hotplug' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Eric Anholt Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/cdv_intel_crt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_crt.c b/drivers/gpu/drm/gma500/cdv_intel_crt.c index fc58a73ed11d6..c48c9d322dfbd 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_crt.c +++ b/drivers/gpu/drm/gma500/cdv_intel_crt.c @@ -127,7 +127,7 @@ static void cdv_intel_crt_mode_set(struct drm_encoder *encoder, } -/** +/* * Uses CRT_HOTPLUG_EN and CRT_HOTPLUG_STAT to detect CRT presence. * * \return true if CRT is connected. From patchwork Fri Jan 15 18:15:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366152 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C35BDC433E9 for ; Fri, 15 Jan 2021 18:17:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A659523A5A for ; Fri, 15 Jan 2021 18:17:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388545AbhAOSRe (ORCPT ); Fri, 15 Jan 2021 13:17:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387681AbhAOSR0 (ORCPT ); Fri, 15 Jan 2021 13:17:26 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 799C5C0617A6 for ; Fri, 15 Jan 2021 10:16:28 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id v184so4178578wma.1 for ; Fri, 15 Jan 2021 10:16:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ist2qaMcFyPJ0b0T5b259LCtzdvkGcAXrLj6GtIUIKA=; b=VQCHrIKm7/CTiVE6GNmynsfACZnXKCYS24SYjRRSWQ+0E7tkdGKZR2D8B5JfDmP19u Sp7x6uR0JcsH+gX+hBMcorqNaWjt5kkEZWiq1KQ9sX80mKilNN2fcQdYDB0sj0gQdIDM xOTymz8SN/aWa8nc0cbTl1fEvoUQazZGZwRF+pIykVYFRwLr4ceFAj0jc00u2CNhRSCa nMpG+Pbs+uD4PaxoIBC+uFiuituSY2qRQkU6wEblTpNd45QpRZS5M75KS2r/21r8df35 p/BYCeY15O9TymDlEFBXeFShpazqpjehgB+1SSBuFRFbRNffl/gyA/2QXw3pZchw9M0n Tl3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ist2qaMcFyPJ0b0T5b259LCtzdvkGcAXrLj6GtIUIKA=; b=GtFzAaLLH0bBICywN5Hg6yTezZ+0M3UtRmjZ6sYwDTWEf8DqgeO7/irVwQBD+V9i0Y 8S3vzg+VOOb7HWvOC/DJFBfdSdgEb6//yvNfPPlOYReh0XbiFe5RkvWPMld6avC2RWpR WQ6nNQLoaymLCqIh0jbxdbIker3+lsOCk3Ujf5/Vre3IIGE5XiJNFELDUQEzF9hUwbDg Jmr/F4N9Q9RFIQhf4ND0kMUK3wit4JioVWIuKCJ/ZDDL5OdD8UBm49PU6ykWlsYl+wSi +8coS8dTRrSyCaQ4NtYUgDsoiNxZgk1+LJxqT7kjlEkFRq3mEZU02zqJLTQmzhocwvcr 7Nxw== X-Gm-Message-State: AOAM531vpyloiGb+e3GhU7pP0QUVSdtLRR84MgABBWHekmBvHjiASLsB eXQ18vlOQP+IorWnNde9II0IjQ== X-Google-Smtp-Source: ABdhPJwsR4sddknZLa7jcLTBaIuE7RjisKawBK3M+o+x1MC/HL2jnakWZ3qsJqRtEF6Kzb7QNJ2M+Q== X-Received: by 2002:a1c:3206:: with SMTP id y6mr9699299wmy.127.1610734587226; Fri, 15 Jan 2021 10:16:27 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:26 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , Eric Anholt , dri-devel@lists.freedesktop.org Subject: [PATCH 15/29] drm/gma500/cdv_intel_display: Demote kernel-doc abuse in 'cdv_intel_panel_fitter_pipe()'s header Date: Fri, 15 Jan 2021 18:15:47 +0000 Message-Id: <20210115181601.3432599-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/cdv_intel_display.c:559: warning: Function parameter or member 'dev' not described in 'cdv_intel_panel_fitter_pipe' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Eric Anholt Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/cdv_intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma500/cdv_intel_display.c index 686385a66167b..5d33022497793 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_display.c +++ b/drivers/gpu/drm/gma500/cdv_intel_display.c @@ -551,7 +551,7 @@ void cdv_update_wm(struct drm_device *dev, struct drm_crtc *crtc) } } -/** +/* * Return the pipe currently connected to the panel fitter, * or -1 if the panel fitter is not present or not in use */ From patchwork Fri Jan 15 18:15:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366154 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73949C433E6 for ; Fri, 15 Jan 2021 18:18:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B9FE23A5A for ; Fri, 15 Jan 2021 18:18:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388626AbhAOSR4 (ORCPT ); Fri, 15 Jan 2021 13:17:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388604AbhAOSRv (ORCPT ); Fri, 15 Jan 2021 13:17:51 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2344C0617A9 for ; Fri, 15 Jan 2021 10:16:29 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id m4so10191165wrx.9 for ; Fri, 15 Jan 2021 10:16:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ouF11XatezVbFMuPjsn7FwMINIqwkDbexOTfYg8EXx4=; b=Gk/bU3FB1IFDV8OfDg9iJegntzsA+v1LnclxDJt+hsb7B4CgA13LFMBZCzfJN+gsWX 4jHt/mC202CfahomgeLpBcXw0YKenaVlwcrOqoWo95y1alita7OLMMIC+RdNbS7Qnlme yyHeijNl3qu0QtHk9jO4YQ5oI7E2HOTmXVR3w88AFncHrcLrmwit+YFBZYpP7uEpwpgG ANejlTeY5nMYc3NEJMrYiVncAdkanlvh1jpcxOo58Rr/KdyXYyY6RYfgLJrjSrnFIHaP plEjM7ddJ8zkdB1439qXoEo6KAX5vVV4wmUA+W8vCa+yhZumnGW7wPFSBZtfA+6CKRMk KQtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ouF11XatezVbFMuPjsn7FwMINIqwkDbexOTfYg8EXx4=; b=thwcY7BHnmgz8Xz/BWW7yU0Y36eGh1CyTRoPDJ/Sdd+KBG0sMkdGt+ngqsBhm/9N77 1tfotHBgwkO5iGGjl8fUm5VNV0ek0BwXhxvXfPKOraMsR6XxgT4mpeBzA3xEh27jCX7B kQO0ebvhVpQz5wWWJngeuDNSKFZksGr1QFUh60IARne4oPWJ2F8trZ/9dLpcLoYLWU6f O8wQ3Q/mofWNKD91DLijbl3sn0HLobmMtXlshgwNHVPcvPjWByLvIrzgEGHgBAImJNI1 HTNjckW2k4hKTbAflKNGWfRaeRDb645ipItVCdwM/i75TLVfg/GfO8Xublk78tMv9Fgd RllA== X-Gm-Message-State: AOAM531BHJwn2qXcbRZIv4G3Necv1POQL4KGt9LVTeFgin7rrHYwyvbo dd5wqBzxSCSzk2AJ6tegwb9vYw== X-Google-Smtp-Source: ABdhPJxWIcNsX9CfW4n898DqqtkFvgS6ZiJ3Dm+q2aQO76ewoRPXBVCi8e54Aik3hGgwUT/JjGyNYA== X-Received: by 2002:adf:ef49:: with SMTP id c9mr10085990wrp.172.1610734588620; Fri, 15 Jan 2021 10:16:28 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:27 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , Eric Anholt , Jesse Barnes , dri-devel@lists.freedesktop.org Subject: [PATCH 16/29] drm/gma500/cdv_intel_lvds: Demote unworthy headers to standard blocks and fix another Date: Fri, 15 Jan 2021 18:15:48 +0000 Message-Id: <20210115181601.3432599-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/cdv_intel_lvds.c:83: warning: Function parameter or member 'dev' not described in 'cdv_intel_lvds_set_backlight' drivers/gpu/drm/gma500/cdv_intel_lvds.c:83: warning: Function parameter or member 'level' not described in 'cdv_intel_lvds_set_backlight' drivers/gpu/drm/gma500/cdv_intel_lvds.c:107: warning: Function parameter or member 'dev' not described in 'cdv_intel_lvds_set_power' drivers/gpu/drm/gma500/cdv_intel_lvds.c:107: warning: Function parameter or member 'encoder' not described in 'cdv_intel_lvds_set_power' drivers/gpu/drm/gma500/cdv_intel_lvds.c:107: warning: Function parameter or member 'on' not described in 'cdv_intel_lvds_set_power' drivers/gpu/drm/gma500/cdv_intel_lvds.c:298: warning: Function parameter or member 'connector' not described in 'cdv_intel_lvds_get_modes' drivers/gpu/drm/gma500/cdv_intel_lvds.c:480: warning: Function parameter or member 'mode_dev' not described in 'cdv_intel_lvds_init' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Eric Anholt Cc: Jesse Barnes Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/cdv_intel_lvds.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_lvds.c b/drivers/gpu/drm/gma500/cdv_intel_lvds.c index b62368962c219..5bff7d9e3aa6e 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_lvds.c +++ b/drivers/gpu/drm/gma500/cdv_intel_lvds.c @@ -74,7 +74,7 @@ static u32 cdv_intel_lvds_get_max_backlight(struct drm_device *dev) return retval; } -/** +/* * Sets the backlight level. * * level backlight level, from 0 to cdv_intel_lvds_get_max_backlight(). @@ -99,7 +99,7 @@ static void cdv_intel_lvds_set_backlight(struct drm_device *dev, int level) } } -/** +/* * Sets the power state for the panel. */ static void cdv_intel_lvds_set_power(struct drm_device *dev, @@ -291,7 +291,7 @@ static void cdv_intel_lvds_mode_set(struct drm_encoder *encoder, REG_WRITE(PFIT_CONTROL, pfit_control); } -/** +/* * Return the list of DDC modes if available, or the BIOS fixed mode otherwise. */ static int cdv_intel_lvds_get_modes(struct drm_connector *connector) @@ -471,6 +471,7 @@ static bool lvds_is_present_in_vbt(struct drm_device *dev, /** * cdv_intel_lvds_init - setup LVDS connectors on this device * @dev: drm device + * @mode_dev: PSB mode device * * Create the connector, register the LVDS DDC bus, and try to figure out what * modes we can display on the LVDS panel (if present). From patchwork Fri Jan 15 18:15:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366156 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 927C5C43381 for ; Fri, 15 Jan 2021 18:18:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62EA823A5E for ; Fri, 15 Jan 2021 18:18:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388648AbhAOSSA (ORCPT ); Fri, 15 Jan 2021 13:18:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388607AbhAOSRv (ORCPT ); Fri, 15 Jan 2021 13:17:51 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FF05C061757 for ; Fri, 15 Jan 2021 10:16:31 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id c5so10208437wrp.6 for ; Fri, 15 Jan 2021 10:16:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5LH1gDNEpa04mVmMwrdsnTHPuZadf7vRIYykG237nqs=; b=OoioVsm+TQx6nV7gS8EYVFvVJ1Fv6AK0ME2b/TTWZE6GVipp0qR5swgZ83FEbZ12hJ bHfLNqxGSPlvKS/kjMA6EFo0ABSEJZ7RxksriR+eL3aLaSRw+duGxMmfMFNZ/6DWKvR1 W10uIAzHzlddHv+JocGFwsSmxmEbLV0Tlhngr0vMllvQKG/JNDysKLzXv0AyOiKStki+ WjLofYAriQTZgUtIf2WYUjD/ue1rD7qJbI760ANCfyWYCqT4EUaiH+f56OdxXd2zqSut keQOIR2LCIAHQ4j+dA2EHerIqjTJF5JZ+VvUE4csnjttU6l1DvBN4KjjB/ingtnz4MwT z7Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5LH1gDNEpa04mVmMwrdsnTHPuZadf7vRIYykG237nqs=; b=Ds8eFMi0p4q8X6he00RMA+k8SiyMZLNKWKSEWjmzMFx7Dr8pqIwtQ0aNoSmFL4ZgxN KlpVD/kZ2MU0reXO2dx8+Z80jU0G/a7ouvhIbX5ESK2PjYPiN4FuMEyiFsC4XjqWxPMh M3TTIpI8nrh50Gl3y8Q9i+v9PwwiMZ5VY9Hk49UvB9GxeiHy63pu6f22YjppjXCHEzCr UF/LlooLfroSVQkXpg4qTmxeMtDbcdxUZTZz0pqdlvmuH7aZ6JbbrZG0t5NbOtQpG54q w5/kqFuQV6S4+sHIXfhUDgqRlAGc7lxjRTlfrE8oF2EiLogfpBUYcBF9S8upc1DLAqTS jdlA== X-Gm-Message-State: AOAM531KMY9gT/u8RkiScb9UHvNnp9TRIDU/tUYxqKqXsdIastlCuw94 tAlhTfUMKwExeZA2iw+7DU6yFA== X-Google-Smtp-Source: ABdhPJyKcUhDIemsychtub1SOGZ27ei+YoeVSS+BDyIF3O5uT+K79mKwPFMnaxURU7ZO+559zmOaNQ== X-Received: by 2002:adf:fdce:: with SMTP id i14mr14514805wrs.58.1610734589879; Fri, 15 Jan 2021 10:16:29 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:29 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , Keith Packard , dri-devel@lists.freedesktop.org Subject: [PATCH 17/29] drm/gma500/cdv_intel_dp: Demote one unworthy header fix another Date: Fri, 15 Jan 2021 18:15:49 +0000 Message-Id: <20210115181601.3432599-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/cdv_intel_dp.c:315: warning: Function parameter or member 'encoder' not described in 'is_edp' drivers/gpu/drm/gma500/cdv_intel_dp.c:315: warning: Excess function parameter 'intel_dp' description in 'is_edp' drivers/gpu/drm/gma500/cdv_intel_dp.c:1698: warning: Function parameter or member 'connector' not described in 'cdv_intel_dp_detect' drivers/gpu/drm/gma500/cdv_intel_dp.c:1698: warning: Function parameter or member 'force' not described in 'cdv_intel_dp_detect' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Keith Packard Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/cdv_intel_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c index bfd9a15d63b1a..6d3ada39ff867 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c @@ -306,7 +306,7 @@ static uint32_t dp_vswing_premph_table[] = { }; /** * is_edp - is the given port attached to an eDP panel (either CPU or PCH) - * @intel_dp: DP struct + * @encoder: GMA encoder struct * * If a CPU or PCH DP output is attached to an eDP panel, this function * will return true, and false otherwise. @@ -1687,7 +1687,7 @@ static enum drm_connector_status cdv_dp_detect(struct gma_encoder *encoder) return status; } -/** +/* * Uses CRT_HOTPLUG_EN and CRT_HOTPLUG_STAT to detect DP connection. * * \return true if DP port is connected. From patchwork Fri Jan 15 18:15:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366167 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82434C433E0 for ; Fri, 15 Jan 2021 18:19:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53EF523A58 for ; Fri, 15 Jan 2021 18:19:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388349AbhAOSTC (ORCPT ); Fri, 15 Jan 2021 13:19:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731073AbhAOSRm (ORCPT ); Fri, 15 Jan 2021 13:17:42 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62600C0613C1 for ; Fri, 15 Jan 2021 10:16:32 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id d26so10194873wrb.12 for ; Fri, 15 Jan 2021 10:16:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FGPhURrdAfrcr7PbpwjcxwF7QYiZtJ0ThRqyiooaDBM=; b=e7nYyY2nViynQVTw0qCPH1uZMBKoFpKPnEbk0loJLIxWeIm19aIa6t4zpZJUQ76qbH sETMQNR8y68prpyoYG+MZGgwksMFqvJ8Tk+6+qAKoECjWM5GBXHFkT4xG/f5UcF26YDY dM29Plji930ezBILTG/C9mpVQs4PekZWEwhawyZ4KAzqU7PQbuQHosuXLVQcxsccezFY TEab+zsqKdNhDBV5tfUW7KDA+Knmcw8e0nkRgMsdiK6f4d8893cp/8Bxl6rfjAfgIKs2 mpkefoeDaPbx+trLknAyGsJDIYEO2UUT04giz3JiS/QDsAYsoTvrAidVP1gYX/9sxFrw bLZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FGPhURrdAfrcr7PbpwjcxwF7QYiZtJ0ThRqyiooaDBM=; b=H5+6hdAm0VfHLTfQp395wpHoaiJFeuyuqrti1lazfLhI1K9fIPpAx4bIw8ZYFzD3dh I4o54XlT60F8Fdx6sGOyuNN025aOd4Zll+jdZbYvumN5TbAkkz0Tn/RuR5d4ORIPlI+e LVN8vm57epd6Y6IXfD1L0CVEHnKiyUr9SXujp7TJer5GsFu/FhkNtUEBNaCHBohibIwm CM3iq/3BdJ0+CUG/XZTAdx6cxWfI5imGdNiJMKNF1pJ5oULduXf/RHygBCvoMT3ilD7h /sPYdlZHTy2cqMK7KcSBiNBeQnRjppyf1rX0Ej97X4e88br8Q6BcER9j+GL0srwaaNZT 5qvA== X-Gm-Message-State: AOAM531l81TnPROpPcKD4EHUdLzivyP8dslOD/ywJHYQyjcnf3cg5VmE bSlxND1+BxBUHbVFYx7rJY44AnPPzgytnyjn X-Google-Smtp-Source: ABdhPJylJzUx60Mk4XLdT6I+iRaNomlyZqBNDJ+ZueJbh+Hos/sho8zalnVjR4hbAg+aDtTutRVoSQ== X-Received: by 2002:a05:6000:1088:: with SMTP id y8mr10266247wrw.380.1610734591117; Fri, 15 Jan 2021 10:16:31 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:30 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , Jan Safrata , dri-devel@lists.freedesktop.org Subject: [PATCH 18/29] drm/gma500/oaktrail_lvds_i2c: Remove unused variables 'tmp' Date: Fri, 15 Jan 2021 18:15:50 +0000 Message-Id: <20210115181601.3432599-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c: In function ‘get_clock’: drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c:69:11: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c: In function ‘get_data’: drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c:83:11: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Jan Safrata Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c b/drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c index d64aedc69845f..1d2dd6ea1c717 100644 --- a/drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c +++ b/drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c @@ -66,12 +66,12 @@ static int get_clock(void *data) { struct psb_intel_i2c_chan *chan = data; - u32 val, tmp; + u32 val; val = LPC_READ_REG(chan, RGIO); val |= GPIO_CLOCK; LPC_WRITE_REG(chan, RGIO, val); - tmp = LPC_READ_REG(chan, RGLVL); + LPC_READ_REG(chan, RGLVL); val = (LPC_READ_REG(chan, RGLVL) & GPIO_CLOCK) ? 1 : 0; return val; @@ -80,12 +80,12 @@ static int get_clock(void *data) static int get_data(void *data) { struct psb_intel_i2c_chan *chan = data; - u32 val, tmp; + u32 val; val = LPC_READ_REG(chan, RGIO); val |= GPIO_DATA; LPC_WRITE_REG(chan, RGIO, val); - tmp = LPC_READ_REG(chan, RGLVL); + LPC_READ_REG(chan, RGLVL); val = (LPC_READ_REG(chan, RGLVL) & GPIO_DATA) ? 1 : 0; return val; From patchwork Fri Jan 15 18:15:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366159 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5478C43331 for ; Fri, 15 Jan 2021 18:18:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B02F923A5E for ; Fri, 15 Jan 2021 18:18:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388660AbhAOSSM (ORCPT ); Fri, 15 Jan 2021 13:18:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387485AbhAOSSH (ORCPT ); Fri, 15 Jan 2021 13:18:07 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A331FC0617A7 for ; Fri, 15 Jan 2021 10:16:33 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id 91so10219959wrj.7 for ; Fri, 15 Jan 2021 10:16:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Wypu520/ZqfvAXznwR+SiEUfHGdGNRczeGZtn7BjKuI=; b=uklAgr3xItoJKlJFKyo5xlUgWSX86AVAJKpBlIAUHTTmJjmZdSCU3C0YIEToX62mDd K/q2X8OFUobZ9apHOg5lG1GBQGolXMVympwlmVmG744dMCd2dWaaFzva7ZHAC2rxe8ZT UYd32/gVhlXs0lrLcNrxzeaton9E3NJF68/fCh8AO+k1rR8iZlnQyaRWUplWqAmXNr75 R1hc5DJYvgH5jtjYE09AxYlUfEodnGMkrDo21uOE+kDFnsIPEEdGk6LB0CEApsChvvW6 AiH2mwlhtlzZXrsmBq8HiKT9MWeMVzDIZMfAkqtqASnMz40a8PRSoSG+ZdGHw377wRBE CaGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Wypu520/ZqfvAXznwR+SiEUfHGdGNRczeGZtn7BjKuI=; b=pZkFDWb0vKj1GsC66ggStFA/4rXAVfbdA6h+TcutZJTD5AWIvrS21m/Qn5db8d92pS CcK52f+o+iVXZEblpxCLjwziStJFnOdR4+F1yI4MwGU8dDejiQsFvyd1MW3Q/6I1NCIW 4Hv4VmIBK08RRqi61S1p1h8oURd3stkFP2kcUGOizOFAmkP/d3JmFSDi+O+xKxLDCbEc OMuLRj/HsZr574x2EJwhj5FMCo2oSjN0poXBLAOXt0/XVDUBXdpnDsK6nad26+LaBYjo xHUvuXSB1FBxZmGSjgV0pdfZrRG4+4LrkDhuJ7da8t9IokaHEiXY/eGL29mze5AkgyKS 1Zsg== X-Gm-Message-State: AOAM5326gL5E72qpJT2BIMfzT1azujbtls6/TB2xa/OfTXfNcYVh6Hym AhzjuJcP36t8AMVyEX7A6/bGyw== X-Google-Smtp-Source: ABdhPJyFfHc9cpBrLJAjZ1f8AMeApx1fDCkuNGMJmPVlsbqk/HoTtgo+IczuMWa9mDl+g0zmExLmVg== X-Received: by 2002:a5d:4dcd:: with SMTP id f13mr14488386wru.10.1610734592374; Fri, 15 Jan 2021 10:16:32 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:31 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , Eric Anholt , Jesse Barnes , dri-devel@lists.freedesktop.org Subject: [PATCH 19/29] drm/gma500/oaktrail_lvds: Demote one documentation header fix another Date: Fri, 15 Jan 2021 18:15:51 +0000 Message-Id: <20210115181601.3432599-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/oaktrail_lvds.c:38: warning: Function parameter or member 'dev' not described in 'oaktrail_lvds_set_power' drivers/gpu/drm/gma500/oaktrail_lvds.c:38: warning: Function parameter or member 'gma_encoder' not described in 'oaktrail_lvds_set_power' drivers/gpu/drm/gma500/oaktrail_lvds.c:38: warning: Function parameter or member 'on' not described in 'oaktrail_lvds_set_power' drivers/gpu/drm/gma500/oaktrail_lvds.c:291: warning: Function parameter or member 'mode_dev' not described in 'oaktrail_lvds_init' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Eric Anholt Cc: Jesse Barnes Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/oaktrail_lvds.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/oaktrail_lvds.c b/drivers/gpu/drm/gma500/oaktrail_lvds.c index 3abaedb01afc1..432bdcc57ac9e 100644 --- a/drivers/gpu/drm/gma500/oaktrail_lvds.c +++ b/drivers/gpu/drm/gma500/oaktrail_lvds.c @@ -29,7 +29,7 @@ #define MRST_BLC_MAX_PWM_REG_FREQ 0xFFFF #define BRIGHTNESS_MAX_LEVEL 100 -/** +/* * Sets the power state for the panel. */ static void oaktrail_lvds_set_power(struct drm_device *dev, @@ -282,6 +282,7 @@ static void oaktrail_lvds_get_configuration_mode(struct drm_device *dev, /** * oaktrail_lvds_init - setup LVDS connectors on this device * @dev: drm device + * @mode_dev: PSB mode device * * Create the connector, register the LVDS DDC bus, and try to figure out what * modes we can display on the LVDS panel (if present). From patchwork Fri Jan 15 18:15:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366165 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D197DC433E0 for ; Fri, 15 Jan 2021 18:18:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D34E23A58 for ; Fri, 15 Jan 2021 18:18:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388578AbhAOSRq (ORCPT ); Fri, 15 Jan 2021 13:17:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388562AbhAOSRm (ORCPT ); Fri, 15 Jan 2021 13:17:42 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7140C0617AA for ; Fri, 15 Jan 2021 10:16:34 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id y17so10197495wrr.10 for ; Fri, 15 Jan 2021 10:16:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KHlPUbSx+S7HaZ3WBED5ORmcl4UG0ks+269HCulT/zo=; b=bZYtpfaz0DYpixFzW6Nzd+4F9hPJRMtojlCsMlY2KnHYpvFtgakrDpSvM5GYx5XYZL asdSBMrkKKcnALNec1t0ZNf8pxjFeMP9dWq9N4KH0VSopwM8kPWS0muwwIdLg3Z+nju8 9slBiFnMdBmq5jZuQDSC9HAa5lU9d3tnywip2BURw0o8huKwWcetZNKpDVe3S1YfrL7u BKWnyQpECfsuEeTK6L6KgDmpTsDk8ubHBXnnaPHpeEYGZ8m6FBZQxUowWVFCz6+Bcs8C chRz5cw3Lg1/XaDVsudrPmPiW1ZIo7n09RV7QDTU7fm+mgOcaCqSTlno8rErPuIICv7C hFzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KHlPUbSx+S7HaZ3WBED5ORmcl4UG0ks+269HCulT/zo=; b=G080TEPqlQ+jzkcvUr2NUXhTKctkSeRB8VhGM0FmkFzx2TUT61/hJ0K1NnBwHjnAhE ICIRbniWgVYb7wxTmpSBkeMNiiqjTdkxIa3e7QQVW7PEOHef8Jw8rKMwm7LAloNHfpIQ dQp6AkCcdPGjmHZoKPVMKdmcjBng0zwa3+3Rykee3KXs60OJdqsJDQBeTnxJ5eUCLz63 IV8CQ4H+pLEwRlFQ7luxfGt81N6Uws9UN0gAe0YKj/Kqwj/viy/JSnTw+24VCWRw3a2v BcliYvC7YbLdrAWXu80xNhnYLPNz3GvxbzeMxxftZx/BoKKWzXwemLJvF0wffmKzYPyU L8xw== X-Gm-Message-State: AOAM5326A8bYfmT9nfVLZ864DXihtD/47sp5bEdcAesG92OMHBqmxmgs jbefyAvHJ47ni85dSsbo9oYGmg== X-Google-Smtp-Source: ABdhPJyhWz+GaUNosLHdwGA3LiH/FmN+J7ZpAI3lFu2pFreiu9/b2FNhjvUQAAukANQoSXVXodQXew== X-Received: by 2002:adf:8285:: with SMTP id 5mr14064349wrc.289.1610734593666; Fri, 15 Jan 2021 10:16:33 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:32 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH 20/29] drm/gma500/oaktrail_crtc: Demote unworthy kernel-doc headers Date: Fri, 15 Jan 2021 18:15:52 +0000 Message-Id: <20210115181601.3432599-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/oaktrail_crtc.c:184: warning: Function parameter or member 'limit' not described in 'mrst_lvds_find_best_pll' drivers/gpu/drm/gma500/oaktrail_crtc.c:184: warning: Function parameter or member 'crtc' not described in 'mrst_lvds_find_best_pll' drivers/gpu/drm/gma500/oaktrail_crtc.c:184: warning: Function parameter or member 'target' not described in 'mrst_lvds_find_best_pll' drivers/gpu/drm/gma500/oaktrail_crtc.c:184: warning: Function parameter or member 'refclk' not described in 'mrst_lvds_find_best_pll' drivers/gpu/drm/gma500/oaktrail_crtc.c:184: warning: Function parameter or member 'best_clock' not described in 'mrst_lvds_find_best_pll' drivers/gpu/drm/gma500/oaktrail_crtc.c:215: warning: Function parameter or member 'crtc' not described in 'oaktrail_crtc_dpms' drivers/gpu/drm/gma500/oaktrail_crtc.c:215: warning: Function parameter or member 'mode' not described in 'oaktrail_crtc_dpms' drivers/gpu/drm/gma500/oaktrail_crtc.c:345: warning: Function parameter or member 'dev' not described in 'oaktrail_panel_fitter_pipe' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/oaktrail_crtc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c index 900e5499249d5..129f879710022 100644 --- a/drivers/gpu/drm/gma500/oaktrail_crtc.c +++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c @@ -174,7 +174,7 @@ static bool mrst_sdvo_find_best_pll(const struct gma_limit_t *limit, return min_error == 0; } -/** +/* * Returns a set of divisors for the desired target clock with the given refclk, * or FALSE. Divisor values are the actual divisors for */ @@ -205,7 +205,7 @@ static bool mrst_lvds_find_best_pll(const struct gma_limit_t *limit, return err != target; } -/** +/* * Sets the power management mode of the pipe and plane. * * This code should probably grow support for turning the cursor off and back @@ -337,7 +337,7 @@ static void oaktrail_crtc_dpms(struct drm_crtc *crtc, int mode) gma_power_end(dev); } -/** +/* * Return the pipe currently connected to the panel fitter, * or -1 if the panel fitter is not present or not in use */ From patchwork Fri Jan 15 18:15:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366155 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E72F9C433E0 for ; Fri, 15 Jan 2021 18:18:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC2DD23A5A for ; Fri, 15 Jan 2021 18:18:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388591AbhAOSRs (ORCPT ); Fri, 15 Jan 2021 13:17:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388563AbhAOSRm (ORCPT ); Fri, 15 Jan 2021 13:17:42 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78A92C0617AB for ; Fri, 15 Jan 2021 10:16:36 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id a12so10186503wrv.8 for ; Fri, 15 Jan 2021 10:16:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y5b57SoAxHtBE8fuD7PasHO1SZ3n/WAQuB51kpZs09g=; b=rriSdpC5fDLxemjS3Am2r2KffU43TkGCeJu9m8OdsMcm8y/ebVSkzBUDFHfnkwR4uB aSwnLRROSDfnEeTaY2WBCoa7R1qbBcx5INFxovhPXjtBX5DnbVU1v+mupaoFEIt0m+sy DJZ3y71XrUAQoaZSNILkrHfh/zcD1yUmuyRku1oNv8+BpPJgMtik8tWYS1sf28+mQxoL K0gzlkodsZGeISrc+POlP3bp9lhge6TCYbk7XyCAKCqpxd1uhkUSuvrpduXACfSPE5Xs 7Wp7mczt8u7BWMZYdq05c11wjz4a7cF4k2vFYRa5/EPSZ6cnb2CwCXkcenb8rtowZ5nZ NC3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y5b57SoAxHtBE8fuD7PasHO1SZ3n/WAQuB51kpZs09g=; b=XPSPhy5j0dqFQTnFvs4A5DHT/kg543R4cQFu/mjmzYcM0nTJCw6hM5PSJC0N0WIVkh K+XlJrbLbp2DS3V+SpCMNv3K+2t0M8Cpev3bTpH8bkkHFxZPpXR48xSDKfPT3xiX93/0 b8IEhJDd5HyQc6pLkH9FqnDkFgX6C37rxYvC5CfwXDfpIv7w4PkzR5VW0rZbP3a9WGJ1 OcV1tsUbELxcN5SxrVe8fMyPageFjV8pC72Htx5tSS9zv08cIYiYZbI+NPHwfVcTVNd+ Wvr6odtZT+TPKD/CJpSzlBmzfjVcsQGdhFhfQYS+L9YpYxHXm5OFUI7CpILoC/sQcqrC KgDw== X-Gm-Message-State: AOAM53099nuV5uOM98QBY3W6xrjxRunokqIZAXFxoQJPso4WVPPVb1wf A8h3FcVdkPmUtS07vXKsg/kHrg== X-Google-Smtp-Source: ABdhPJyvzvw/m3xAKhEScihwt0ijVEjC0hHVLK7eHUfHVxiZ87NT0kkWWVNCXymnBq6TGY1atX1JMw== X-Received: by 2002:adf:92a4:: with SMTP id 33mr14243233wrn.347.1610734595212; Fri, 15 Jan 2021 10:16:35 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:34 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , jim liu , Jackie Li , dri-devel@lists.freedesktop.org Subject: [PATCH 21/29] drm/gma500/mdfld_dsi_output: Demote a couple of kernel-doc formatting abuses Date: Fri, 15 Jan 2021 18:15:53 +0000 Message-Id: <20210115181601.3432599-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/mdfld_dsi_output.c:71: warning: Function parameter or member 'dev' not described in 'mdfld_dsi_gen_fifo_ready' drivers/gpu/drm/gma500/mdfld_dsi_output.c:71: warning: Function parameter or member 'gen_fifo_stat_reg' not described in 'mdfld_dsi_gen_fifo_ready' drivers/gpu/drm/gma500/mdfld_dsi_output.c:71: warning: Function parameter or member 'fifo_stat' not described in 'mdfld_dsi_gen_fifo_ready' drivers/gpu/drm/gma500/mdfld_dsi_output.c:95: warning: Function parameter or member 'dsi_config' not described in 'mdfld_dsi_brightness_init' drivers/gpu/drm/gma500/mdfld_dsi_output.c:95: warning: Function parameter or member 'pipe' not described in 'mdfld_dsi_brightness_init' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: jim liu Cc: Jackie Li Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/mdfld_dsi_output.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_output.c b/drivers/gpu/drm/gma500/mdfld_dsi_output.c index 4aab76613bd9e..24105f45c1c4b 100644 --- a/drivers/gpu/drm/gma500/mdfld_dsi_output.c +++ b/drivers/gpu/drm/gma500/mdfld_dsi_output.c @@ -63,7 +63,7 @@ static int __init parse_LABC_control(char *arg) early_param("LABC", parse_LABC_control); #endif -/** +/* * Check and see if the generic control or data buffer is empty and ready. */ void mdfld_dsi_gen_fifo_ready(struct drm_device *dev, u32 gen_fifo_stat_reg, @@ -85,7 +85,7 @@ void mdfld_dsi_gen_fifo_ready(struct drm_device *dev, u32 gen_fifo_stat_reg, gen_fifo_stat_reg); } -/** +/* * Manage the DSI MIPI keyboard and display brightness. * FIXME: this is exported to OSPM code. should work out an specific * display interface to OSPM. From patchwork Fri Jan 15 18:15:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366163 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2F82C433E0 for ; Fri, 15 Jan 2021 18:18:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96E3A23A5A for ; Fri, 15 Jan 2021 18:18:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388689AbhAOSSY (ORCPT ); Fri, 15 Jan 2021 13:18:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388607AbhAOSSH (ORCPT ); Fri, 15 Jan 2021 13:18:07 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CA1AC0617B0 for ; Fri, 15 Jan 2021 10:16:37 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id 6so2912388wri.3 for ; Fri, 15 Jan 2021 10:16:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9TV73dkbBvGhpYcqV/fsQZ4aFFzm9GQ9Ij+MCJ8e6uM=; b=i/zt/gQYv4HPTEgigDPbzK2Sb8SUJRL7IwqdD7hFPeO2qkLDu/24pIG70vd9ZuU+W0 Lrt1mvkOYDRxnyF/lyOXZQb0rzpNTrg6ZveP1TgBgt9kmvke+hgoBO32HxZxumR4YCZa zUZGTIO9HG1xj882ENS2TIHmY9+A2zxLK8Ye1lrhQmT883lWNnk0R1tNA017KP0nJYMP j+8q3slLwIBZGqMuVQ9zi3yXZpQY2ku7RCQbe0r7xY0TpuA4JzdpR/34xFJ2uYQ3fFmY jjnb9vOYAlekN9XmQOLpqaJXHBX+y5de9746UbCjrPQOVtvNU/D+bACTMJ6JcRGL6Mwj 0P2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9TV73dkbBvGhpYcqV/fsQZ4aFFzm9GQ9Ij+MCJ8e6uM=; b=inezFpZL1DUObmH8bhZsmLuh45UkIVtPTFsywUiYPmDzHPK4Otn55MxuK4qLwsXb6O 9SfARBZx1zZ7HQwfKfi96TxgwTfwY3ElFn82Ym0AQoGtk5kWkoF2RThT4uWZslTIE5RC +iTauqKXxLPTy7VaO42hbSnhX54Dh2/6yfXE4FW3WhtXnESY/vdRZBwh1Poz3DAhqlKy XjiFiHpOATuloAGSuapX1LaEeLjwSeihYNw/5r8es4C4unaRrg4A6scqmty1rojfviaU 9tCi5J6RHZCa6s5x++AcSXLxUMrqEilOApFLPSbOB6mDJDDICGTIdQAY0HKhF7nU7iDJ sDPQ== X-Gm-Message-State: AOAM533Mo+oZYfYGulfWzExBLXLJ5hFyVPDWXaiLguQPW/7ibmo2Vt9x 57J7V7LuwAk+O6A5/EU1tQPDlQ== X-Google-Smtp-Source: ABdhPJwK2z9xj2/F+s3rA1SnN2if5sf5QYP+Lg9GwrBJGP1CMAO9YHgp3NNc8Tx34w+6hNana7B4QA== X-Received: by 2002:adf:e512:: with SMTP id j18mr14339992wrm.52.1610734596426; Fri, 15 Jan 2021 10:16:36 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:35 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , Eric Anholt , dri-devel@lists.freedesktop.org Subject: [PATCH 22/29] drm/gma500/mdfld_intel_display: Demote three kernel-doc formatting abuses Date: Fri, 15 Jan 2021 18:15:54 +0000 Message-Id: <20210115181601.3432599-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/mdfld_intel_display.c:103: warning: Function parameter or member 'dev' not described in 'psb_intel_panel_fitter_pipe' drivers/gpu/drm/gma500/mdfld_intel_display.c:273: warning: Function parameter or member 'crtc' not described in 'mdfld_crtc_dpms' drivers/gpu/drm/gma500/mdfld_intel_display.c:273: warning: Function parameter or member 'mode' not described in 'mdfld_crtc_dpms' drivers/gpu/drm/gma500/mdfld_intel_display.c:609: warning: Function parameter or member 'crtc' not described in 'mdfldFindBestPLL' drivers/gpu/drm/gma500/mdfld_intel_display.c:609: warning: Function parameter or member 'target' not described in 'mdfldFindBestPLL' drivers/gpu/drm/gma500/mdfld_intel_display.c:609: warning: Function parameter or member 'refclk' not described in 'mdfldFindBestPLL' drivers/gpu/drm/gma500/mdfld_intel_display.c:609: warning: Function parameter or member 'best_clock' not described in 'mdfldFindBestPLL' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Eric Anholt Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/mdfld_intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/gma500/mdfld_intel_display.c b/drivers/gpu/drm/gma500/mdfld_intel_display.c index aae2d358364cc..462aba8f75288 100644 --- a/drivers/gpu/drm/gma500/mdfld_intel_display.c +++ b/drivers/gpu/drm/gma500/mdfld_intel_display.c @@ -95,7 +95,7 @@ void mdfldWaitForPipeEnable(struct drm_device *dev, int pipe) } } -/** +/* * Return the pipe currently connected to the panel fitter, * or -1 if the panel fitter is not present or not in use */ @@ -263,7 +263,7 @@ void mdfld_disable_crtc(struct drm_device *dev, int pipe) } -/** +/* * Sets the power management mode of the pipe and plane. * * This code should probably grow support for turning the cursor off and back @@ -599,7 +599,7 @@ static void mdfld_clock(int refclk, struct mrst_clock_t *clock) clock->dot = (refclk * clock->m) / clock->p1; } -/** +/* * Returns a set of divisors for the desired target clock with the given refclk, * or FALSE. Divisor values are the actual divisors for */ From patchwork Fri Jan 15 18:15:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366170 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 920FEC433E6 for ; Fri, 15 Jan 2021 18:19:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6948523A59 for ; Fri, 15 Jan 2021 18:19:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388705AbhAOSTE (ORCPT ); Fri, 15 Jan 2021 13:19:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388564AbhAOSRm (ORCPT ); Fri, 15 Jan 2021 13:17:42 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9CD3C0617B9 for ; Fri, 15 Jan 2021 10:16:38 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id q18so10227910wrn.1 for ; Fri, 15 Jan 2021 10:16:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=W4lgvadJF0F6Eqo3TsN4IbMPwQEK3WYj/tmMeRVVJp8=; b=xlXITN0crvrSfNXAA3TYXbkG3biTTGWh/FeKcc0GwUfWToBTn1ZXsAlSAbSueg2VGo +xdTKtHkmYD4VLKzQ41PLO5LgxjNajgA8OiYgPCHvE18+WPzFxNqVrgzX48+8s90jXVm tdhh84IqxXC5EWBtLDwAiayJRWdFqc/fC1NbGjNc86XPp0MhXxyhwJf683KgKhTRFbUP Y+rwIuYviFsc4lI53HTwOaMC9bGDZb4XlLes1MFd3K2xpE5AvIRVKr9TMyy8+JW+DHW+ TR/6qjtTrr9bjhQQ6sqyLlu8erF2tlDZYgQJ4FvL6WY+vFG+5BC/zNo1iI80ohX8Nin0 oFFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=W4lgvadJF0F6Eqo3TsN4IbMPwQEK3WYj/tmMeRVVJp8=; b=OZF0rANlKlkX16KRRbTkXIbv7HtweA9qLkouPozB2fxB3lIulCkOKz9cIDkZ+9j95B feCbcvkGFHPDqLuf1EqRiaFGEg9lCfbAf9IIR5PF4S0h3vut+wD45tbBgmEO0NFPC/8r HoQrMSM0SG4WSodEeJF7nt0coJV+k0OCUgLRVn5w0fbtyxyoU+u9v64Ksb+hOhzN6Q/B 8lWqWoz6r4HebNK/fEInfQM60+9u8ZHL0c9/0j/AXjssPGftW7J8dMDj1+Vl1ndmKYMA bXgcxAvykljn5pWU6UtP7XS5arKFTY0Gbrj3SI+nz4XSnbChmI9R7WuB87dub1jdaZgE C1Eg== X-Gm-Message-State: AOAM531LVAfhcP4DBr/Ku0C1i8gffl8kzIfjt+m2N4HF3ColrwtlBpvi njONs1Zp5JrAdx8A6LDSRHW3rw== X-Google-Smtp-Source: ABdhPJwEvDmWbuyVUDSx+nnayljY66PPzuJiohq5lZ+voVXpmesn4219lFVLvwaeM8v/+T2zH2oZDQ== X-Received: by 2002:adf:f4d0:: with SMTP id h16mr14699029wrp.30.1610734597599; Fri, 15 Jan 2021 10:16:37 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:36 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Faith , Gareth Hughes , dri-devel@lists.freedesktop.org Subject: [PATCH 23/29] drm/drm_agpsupport: Strip out obviously wrong descriptions and demote to standard headers Date: Fri, 15 Jan 2021 18:15:55 +0000 Message-Id: <20210115181601.3432599-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/drm_agpsupport.c:61: warning: Function parameter or member 'dev' not described in 'drm_agp_info' drivers/gpu/drm/drm_agpsupport.c:61: warning: Function parameter or member 'info' not described in 'drm_agp_info' drivers/gpu/drm/drm_agpsupport.c:105: warning: Function parameter or member 'dev' not described in 'drm_agp_acquire' drivers/gpu/drm/drm_agpsupport.c:132: warning: Function parameter or member 'dev' not described in 'drm_agp_acquire_ioctl' drivers/gpu/drm/drm_agpsupport.c:132: warning: Function parameter or member 'data' not described in 'drm_agp_acquire_ioctl' drivers/gpu/drm/drm_agpsupport.c:132: warning: Function parameter or member 'file_priv' not described in 'drm_agp_acquire_ioctl' drivers/gpu/drm/drm_agpsupport.c:145: warning: Function parameter or member 'dev' not described in 'drm_agp_release' drivers/gpu/drm/drm_agpsupport.c:171: warning: Function parameter or member 'dev' not described in 'drm_agp_enable' drivers/gpu/drm/drm_agpsupport.c:171: warning: Function parameter or member 'mode' not described in 'drm_agp_enable' drivers/gpu/drm/drm_agpsupport.c:203: warning: Function parameter or member 'dev' not described in 'drm_agp_alloc' drivers/gpu/drm/drm_agpsupport.c:203: warning: Function parameter or member 'request' not described in 'drm_agp_alloc' drivers/gpu/drm/drm_agpsupport.c:256: warning: Function parameter or member 'dev' not described in 'drm_agp_lookup_entry' drivers/gpu/drm/drm_agpsupport.c:256: warning: Function parameter or member 'handle' not described in 'drm_agp_lookup_entry' drivers/gpu/drm/drm_agpsupport.c:279: warning: Function parameter or member 'dev' not described in 'drm_agp_unbind' drivers/gpu/drm/drm_agpsupport.c:279: warning: Function parameter or member 'request' not described in 'drm_agp_unbind' drivers/gpu/drm/drm_agpsupport.c:318: warning: Function parameter or member 'dev' not described in 'drm_agp_bind' drivers/gpu/drm/drm_agpsupport.c:318: warning: Function parameter or member 'request' not described in 'drm_agp_bind' drivers/gpu/drm/drm_agpsupport.c:363: warning: Function parameter or member 'dev' not described in 'drm_agp_free' drivers/gpu/drm/drm_agpsupport.c:363: warning: Function parameter or member 'request' not described in 'drm_agp_free' drivers/gpu/drm/drm_agpsupport.c:404: warning: Function parameter or member 'dev' not described in 'drm_agp_init' Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: Faith Cc: Gareth Hughes Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/drm_agpsupport.c | 46 ++++++++------------------------ 1 file changed, 11 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/drm/drm_agpsupport.c b/drivers/gpu/drm/drm_agpsupport.c index 8b690ef306dec..7ae446fb84ad2 100644 --- a/drivers/gpu/drm/drm_agpsupport.c +++ b/drivers/gpu/drm/drm_agpsupport.c @@ -45,13 +45,9 @@ #include "drm_legacy.h" -/** +/* * Get AGP information. * - * \param inode device inode. - * \param file_priv DRM file private. - * \param cmd command. - * \param arg pointer to a (output) drm_agp_info structure. * \return zero on success or a negative number on failure. * * Verifies the AGP device has been initialized and acquired and fills in the @@ -92,7 +88,7 @@ int drm_agp_info_ioctl(struct drm_device *dev, void *data, return 0; } -/** +/* * Acquire the AGP device. * * \param dev DRM device that is to acquire AGP. @@ -115,13 +111,9 @@ int drm_agp_acquire(struct drm_device *dev) } EXPORT_SYMBOL(drm_agp_acquire); -/** +/* * Acquire the AGP device (ioctl). * - * \param inode device inode. - * \param file_priv DRM file private. - * \param cmd command. - * \param arg user argument. * \return zero on success or a negative number on failure. * * Verifies the AGP device hasn't been acquired before and calls @@ -133,7 +125,7 @@ int drm_agp_acquire_ioctl(struct drm_device *dev, void *data, return drm_agp_acquire((struct drm_device *) file_priv->minor->dev); } -/** +/* * Release the AGP device. * * \param dev DRM device that is to release AGP. @@ -157,7 +149,7 @@ int drm_agp_release_ioctl(struct drm_device *dev, void *data, return drm_agp_release(dev); } -/** +/* * Enable the AGP bus. * * \param dev DRM device that has previously acquired AGP. @@ -187,13 +179,9 @@ int drm_agp_enable_ioctl(struct drm_device *dev, void *data, return drm_agp_enable(dev, *mode); } -/** +/* * Allocate AGP memory. * - * \param inode device inode. - * \param file_priv file private pointer. - * \param cmd command. - * \param arg pointer to a drm_agp_buffer structure. * \return zero on success or a negative number on failure. * * Verifies the AGP device is present and has been acquired, allocates the @@ -242,7 +230,7 @@ int drm_agp_alloc_ioctl(struct drm_device *dev, void *data, return drm_agp_alloc(dev, request); } -/** +/* * Search for the AGP memory entry associated with a handle. * * \param dev DRM device structure. @@ -263,13 +251,9 @@ static struct drm_agp_mem *drm_agp_lookup_entry(struct drm_device *dev, return NULL; } -/** +/* * Unbind AGP memory from the GATT (ioctl). * - * \param inode device inode. - * \param file_priv DRM file private. - * \param cmd command. - * \param arg pointer to a drm_agp_binding structure. * \return zero on success or a negative number on failure. * * Verifies the AGP device is present and acquired, looks-up the AGP memory @@ -301,13 +285,9 @@ int drm_agp_unbind_ioctl(struct drm_device *dev, void *data, return drm_agp_unbind(dev, request); } -/** +/* * Bind AGP memory into the GATT (ioctl) * - * \param inode device inode. - * \param file_priv DRM file private. - * \param cmd command. - * \param arg pointer to a drm_agp_binding structure. * \return zero on success or a negative number on failure. * * Verifies the AGP device is present and has been acquired and that no memory @@ -345,13 +325,9 @@ int drm_agp_bind_ioctl(struct drm_device *dev, void *data, return drm_agp_bind(dev, request); } -/** +/* * Free AGP memory (ioctl). * - * \param inode device inode. - * \param file_priv DRM file private. - * \param cmd command. - * \param arg pointer to a drm_agp_buffer structure. * \return zero on success or a negative number on failure. * * Verifies the AGP device is present and has been acquired and looks up the @@ -388,7 +364,7 @@ int drm_agp_free_ioctl(struct drm_device *dev, void *data, return drm_agp_free(dev, request); } -/** +/* * Initialize the AGP resources. * * \return pointer to a drm_agp_head structure. From patchwork Fri Jan 15 18:15:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366164 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A92EC43381 for ; Fri, 15 Jan 2021 18:18:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2E0F23A59 for ; Fri, 15 Jan 2021 18:18:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388706AbhAOSS2 (ORCPT ); Fri, 15 Jan 2021 13:18:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388624AbhAOSSH (ORCPT ); Fri, 15 Jan 2021 13:18:07 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EF32C0617B1 for ; Fri, 15 Jan 2021 10:16:40 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id u14so4198886wmq.4 for ; Fri, 15 Jan 2021 10:16:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J0MKcaQJg4qBHpqlKLqhoArao/P8hSXgM/s3rj7VTt0=; b=J172cC3Uyma0VckyFc9AxWG25drY1eDR3/CO7zKGtLnvPXc3QRyYBEZTk3wr/Oojdt MkXBZReGLj4d5du5UEuPAIX7iFhOX6Vp/xqc5CaimCjZSRf3tu+X2lx0zRUVU0sd/VqE J7k689wvnQ9GOfnh2QIXAOotKN4qzk9cE78Zs+gHvwX6sealI/MJlNafXOsJUNEO6q6q joQ57rLYh0mr85db9y/WWYUIMrefeocZ7Rixa1rmjqqOxJ2UUyHLrmCeBsDOkMWRXBJb MdaAdsRDDvgLImIUSWBGUW54fPXMROaN4hPMMy8GnqvniwL3os7PGOxpxKELQxSNQv4O jXlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J0MKcaQJg4qBHpqlKLqhoArao/P8hSXgM/s3rj7VTt0=; b=ch5m65vve62EdtpV7PEAagEkkMdiazoxMb//2W9VOcEZAoqppr0g/BFVMey2BFR8r3 mcg7uaIW2F6O6niAWICWHbdTyN/u/2raQd8UHlvLFd+XJgPWZPuum68V5oQGi0XfrSjK p1txRXLVZrkwN+WvF5n0mY0wlxdeypfQeGDhp0hM6ZYUEQv3In4evpDTIgS3rPUu1e/e u9hCe+2UdBoPZqLUfPJj/P+ERzYFypoXG7ftWaYeImcNLWg4FO6fzG0T3H8zcdvYUkwI 4pd9grj7eCFNN0z4zlouWSCX0EClFwOYcfMmecv0NixweYfwang/svGsHZ3wpnElG6bM H/rA== X-Gm-Message-State: AOAM5324NqCBJ1t6A6BUWEy9Af3jVhhyrtWcwTLgh4vu/qchxDNnYQB8 Bm9hbpVSjZ3dMum4mYJMCqM8W0oDxoI+atms X-Google-Smtp-Source: ABdhPJypKKRUbRWYCHxMnXoeZXHc/KsmeR5j7hQzz6Ji0P/sOn9WdxZugDa5oe2vQNPvr7o3cVICrg== X-Received: by 2002:a05:600c:4417:: with SMTP id u23mr10051589wmn.100.1610734599295; Fri, 15 Jan 2021 10:16:39 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:38 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Zhenyu Wang , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Kevin Tian , Eddie Dong , Zhiyuan Lv , Min He , Tina Zhang , Pei Zhang , Niu Bing , Ping Gao , intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH 24/29] drm/i915/gvt/handlers: Remove kernel-doc formatting from non-kernel-doc header Date: Fri, 15 Jan 2021 18:15:56 +0000 Message-Id: <20210115181601.3432599-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gvt/handlers.c:1666: warning: Function parameter or member 'vgpu' not described in 'bxt_ppat_low_write' drivers/gpu/drm/i915/gvt/handlers.c:1666: warning: Function parameter or member 'offset' not described in 'bxt_ppat_low_write' drivers/gpu/drm/i915/gvt/handlers.c:1666: warning: Function parameter or member 'p_data' not described in 'bxt_ppat_low_write' drivers/gpu/drm/i915/gvt/handlers.c:1666: warning: Function parameter or member 'bytes' not described in 'bxt_ppat_low_write' Cc: Zhenyu Wang Cc: Zhi Wang Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: David Airlie Cc: Daniel Vetter Cc: Kevin Tian Cc: Eddie Dong Cc: Zhiyuan Lv Cc: Min He Cc: Tina Zhang Cc: Pei Zhang Cc: Niu Bing Cc: Ping Gao Cc: intel-gvt-dev@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/gvt/handlers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c index eaba80975f42a..0d124ced5f940 100644 --- a/drivers/gpu/drm/i915/gvt/handlers.c +++ b/drivers/gpu/drm/i915/gvt/handlers.c @@ -1651,7 +1651,7 @@ static int edp_psr_imr_iir_write(struct intel_vgpu *vgpu, return 0; } -/** +/* * FixMe: * If guest fills non-priv batch buffer on ApolloLake/Broxton as Mesa i965 did: * 717e7539124d (i965: Use a WC map and memcpy for the batch instead of pwrite.) From patchwork Fri Jan 15 18:15:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366162 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08167C433E9 for ; Fri, 15 Jan 2021 18:18:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B70CA23A58 for ; Fri, 15 Jan 2021 18:18:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387741AbhAOSSc (ORCPT ); Fri, 15 Jan 2021 13:18:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388649AbhAOSSH (ORCPT ); Fri, 15 Jan 2021 13:18:07 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7376C0617BA for ; Fri, 15 Jan 2021 10:16:41 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id k10so8220680wmi.3 for ; Fri, 15 Jan 2021 10:16:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=o2fukyLsotnyIO21hCJ1A0IUQV1SfrYh5wzz8JhsiiM=; b=gkPe4zQRnTIJ91SOxape8cRj/kO69GrgNLCMZTar3f1vt1Iv3INiFfoVT/oT69muaj rHbC4MoocQB7oWOMyPqd0PhTRoQrUybhIJLleeThAjJh18c5LtKtkskEoMwL6Wuee68F 689gPeMLG2RIQCe4fo9R31pkp70ba6oPxfJqOwx6qAR47rC48hB4caKDT8H94DTWCTFM uxAQaIEviR4XWvzlJzuwiKcqwWIPfU3snEV7oGmY4Rjl/jAiKFLgX3o1KUw1MBF8HqeI HhcEfG6nCehTgn+SEwB9xYOy+m3bHhHzLpxfoK07S+mnsD04ZA9qMElbH3zWxlJrVoLZ eLDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=o2fukyLsotnyIO21hCJ1A0IUQV1SfrYh5wzz8JhsiiM=; b=D16EB31pd5AJw5HfPYuU1qRkXEU6HzyGYnoC6MESwXRd3eJrw+g3i0Zv9zkoMyOZu9 z+yAAB3JaMLWlg8e/fvX8hCPG27m1qFOVgGvHI3kt66l9JIuNB9y7QP7v2fbLf4VYwHO qxwreRhCItT18vGpXDQfAuuCUtaYofEq6/VpwUI3vYOfAIYI5UJ23kPw61SHAsq42rSb aQK0R5u3t12zPU7YkqAf+BVlaqrVeC2S7W1yxrApWuvUZn2LD8kBV7vNEm4hGikVXkq3 sT8Ym1UgVtDMegNU7poKI+hqHpGhjwj1eVZOmzZFNo4CJexQzuqsOaibC76aAUW0h4J5 vJJQ== X-Gm-Message-State: AOAM532NcSPHMwSKHbft/vuOiobeRZ4xak/4efM0UCxQzj3FPIR5SRLy 9TdcJy5h82z3H5nTg47qqGE5gg== X-Google-Smtp-Source: ABdhPJwzAFS7Be8VkrVoNQgvyVh8GdN8DIxgBCBCbQEv+K0i2fq9aZe2mXAbWJUOB6yMre/SnSy8Gg== X-Received: by 2002:a05:600c:2742:: with SMTP id 2mr9826336wmw.94.1610734600647; Fri, 15 Jan 2021 10:16:40 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:40 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Ben Skeggs , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org Subject: [PATCH 25/29] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc Date: Fri, 15 Jan 2021 18:15:57 +0000 Message-Id: <20210115181601.3432599-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_ioc32.c:2: warning: Cannot understand * file mga_ioc32.c Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/nouveau/nouveau_ioc32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ioc32.c b/drivers/gpu/drm/nouveau/nouveau_ioc32.c index adf01ca9e035d..8ddf9b2325a42 100644 --- a/drivers/gpu/drm/nouveau/nouveau_ioc32.c +++ b/drivers/gpu/drm/nouveau/nouveau_ioc32.c @@ -1,4 +1,4 @@ -/** +/* * \file mga_ioc32.c * * 32-bit ioctl compatibility routines for the MGA DRM. From patchwork Fri Jan 15 18:15:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366166 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70125C433DB for ; Fri, 15 Jan 2021 18:19:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B4A0222B3 for ; Fri, 15 Jan 2021 18:19:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387916AbhAOSTA (ORCPT ); Fri, 15 Jan 2021 13:19:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388567AbhAOSRn (ORCPT ); Fri, 15 Jan 2021 13:17:43 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B4C4C0617BB for ; Fri, 15 Jan 2021 10:16:43 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id 190so8232519wmz.0 for ; Fri, 15 Jan 2021 10:16:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sdXKnDa6lvIb811vAIyU+syK3ZIQA1yBtXwMvcVTZ1I=; b=NQSMyoh8n63rM3uQJJJSde6hMFXcBhFL3jjHN2XG3bUDERwDZuGBn6aChRJvncceeY Nl1812QytdqWcMvSlIWSZs3R/Dee0ZfLy+TxyNAcZlqt6u3FC25PoPHIIpzxaW3Etaew Je9/kvEYITSeRo+yfUIOy7BxqSCKpBZf6t8yfDvYcGiqz0B0zS6dHCvl6gyJtydwQxOH OtO89GlReKUeFDHPErBHe2G1TQ6xlV1T8MAB2twrcAPKywjZ5rSkCRwMMuD9WwvGjlNX NeHbSKC+bRET3FbGuC79UjlPm8Kydr/Uvx+Cp2uLfDQTA7IU/vKzsW39bEFUhAqIl9Gm cxTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sdXKnDa6lvIb811vAIyU+syK3ZIQA1yBtXwMvcVTZ1I=; b=RaNmWX9iV1o0xurZh2BLmycDQBcOk/N6v2+IvQxoJuJ0N25D1VFqHyTXnzRAMBIh4b mQ8B0QJTh693t22R7n7qzHYtM5ypGjh334LF8/iCtLdcwz1gx12IiP/Fhcl+8iX6ZM/x BuUE4WoP1wFTh/8ZYmyrdJOCCQ6T0qcSaSDyGuGqF2bQ3kTT32Sjk1MLRJ4XY/KE8kjj T/btnvx3IhV/wyS3sz5vknMcwzq0u/lleXVpS3O/4Mg8XV+dYzBvPtc3qG1XSigKns+H 2sbKzZZGk+RJTSQIXU3JnH8GD/QugL4PH3aCjujKcqcU7uCRknm99dmExIne9zMhajYT TVfQ== X-Gm-Message-State: AOAM532Lfvvc8UYnGabkYMRFzbrUZga/oXu7HxC3zetgF3+xcjNCWIeM WpHHssRlYILT5AMepPbKDdBBrQ== X-Google-Smtp-Source: ABdhPJx4NtGILv95iDZVo/kBmSY+uqOCH7ceKa8UeLHrPa4hZE9zW2fYatEf47XO+P2w6X6gSd5LyA== X-Received: by 2002:a1c:a145:: with SMTP id k66mr9753170wme.11.1610734602115; Fri, 15 Jan 2021 10:16:42 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:41 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Ben Skeggs , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org Subject: [PATCH 26/29] drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void function Date: Fri, 15 Jan 2021 18:15:58 +0000 Message-Id: <20210115181601.3432599-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_svm.c: In function ‘nouveau_pfns_map’: drivers/gpu/drm/nouveau/nouveau_svm.c:810:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/nouveau/nouveau_svm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c b/drivers/gpu/drm/nouveau/nouveau_svm.c index 4f69e4c3dafde..84c5bf53fe967 100644 --- a/drivers/gpu/drm/nouveau/nouveau_svm.c +++ b/drivers/gpu/drm/nouveau/nouveau_svm.c @@ -807,7 +807,6 @@ nouveau_pfns_map(struct nouveau_svmm *svmm, struct mm_struct *mm, unsigned long addr, u64 *pfns, unsigned long npages) { struct nouveau_pfnmap_args *args = nouveau_pfns_to_args(pfns); - int ret; args->p.addr = addr; args->p.size = npages << PAGE_SHIFT; @@ -815,8 +814,8 @@ nouveau_pfns_map(struct nouveau_svmm *svmm, struct mm_struct *mm, mutex_lock(&svmm->mutex); svmm->vmm->vmm.object.client->super = true; - ret = nvif_object_ioctl(&svmm->vmm->vmm.object, args, sizeof(*args) + - npages * sizeof(args->p.phys[0]), NULL); + nvif_object_ioctl(&svmm->vmm->vmm.object, args, sizeof(*args) + + npages * sizeof(args->p.phys[0]), NULL); svmm->vmm->vmm.object.client->super = false; mutex_unlock(&svmm->mutex); From patchwork Fri Jan 15 18:15:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366161 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACDD0C433E6 for ; Fri, 15 Jan 2021 18:18:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A23823A59 for ; Fri, 15 Jan 2021 18:18:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388675AbhAOSSV (ORCPT ); Fri, 15 Jan 2021 13:18:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388650AbhAOSSI (ORCPT ); Fri, 15 Jan 2021 13:18:08 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88613C0617BC for ; Fri, 15 Jan 2021 10:16:44 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id k10so8220798wmi.3 for ; Fri, 15 Jan 2021 10:16:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j+QQ91dB4nAV9iX95BjLXpaQb9N2TCvRIGQTNY+K7sU=; b=yL85iXlSpJyIEsW9uR5KjI1ME5UqZGtzQv4FY99XBi+FD088mPsLJUgEUFKevvrlE9 ksl9DXvhysqqBdDc7ZadLjyb25WhWQ3i98QOp0XqAdIZxIWspprCXgzshIS98HW4wMGh I+dGjog07idrdB7GQ459SKQnXFCQ4I9gK+KFnSmHEK1XhiM5kcv9UoCyCxCQC61JS0ll ++XOFxnTRs1eBVYdPEs8eE+RG4iiu7oN+whS/TdHU+B6/+ipOqkC164lqBL+udM5S+Pe D+5z0HQ/r2jtn0PRy9nwsj2+X61EY1IqPKGMyzXLvzaeE1LhdUG1dXwChy5gE9CV1QlA lmVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j+QQ91dB4nAV9iX95BjLXpaQb9N2TCvRIGQTNY+K7sU=; b=Bhr3uoe97FSDqezm/kGoTgbyrsIQ3nEur5k8XD81mF1wh8hONQA52h0DrLem/FnzNk qagI4r56+Tlq0aNa5v/e+bohy05OhHGw+jFt/5QgF3Opp00ciSQv5mL8nhbMM+7DuQTC xEQqWPFyUva3YSCYvN7jHTM64LRdxJ46cbN3HcF/o1szUBNwF9ZFmDh9XvI39AJIRzrg /Xmijc4ybbiB661WCzhI5BMg7K67fN0jl/gBBil7cdHKYXk4PBe9ojg5ZD9/OXITrWXa AqAPe3+jbx9K04UPa2/qDNERWMTv90aTfcK1WmTv7BoNYOgRhx/AGVRg4G+DpAIqkQUd qzdQ== X-Gm-Message-State: AOAM532g9B1Tccj6AgP3mjY7ljHONN7u5nYeLZMcnkSNUIQcp1/5bmPr WSCukFwNbCQaeUjV5o44d8W12A== X-Google-Smtp-Source: ABdhPJwD+S7K+2xo6XGPzpZWOm/R/Wcr70/IAr4BByEl7I7vZ/Ps4PA7dJVttdYLp/fDi5wADTpg5g== X-Received: by 2002:a1c:4b14:: with SMTP id y20mr2838766wma.6.1610734603340; Fri, 15 Jan 2021 10:16:43 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:42 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Ben Skeggs , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org Subject: [PATCH 27/29] drm/nouveau/nouveau_bios: Remove unused variable 'pdev' from 'nouveau_bios_init()' Date: Fri, 15 Jan 2021 18:15:59 +0000 Message-Id: <20210115181601.3432599-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_bios.c: In function ‘nouveau_bios_init’: drivers/gpu/drm/nouveau/nouveau_bios.c:2086:18: warning: variable ‘pdev’ set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/nouveau/nouveau_bios.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c index 7cc683b8dc7a6..e8c445eb11004 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bios.c +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c @@ -2083,13 +2083,11 @@ nouveau_bios_init(struct drm_device *dev) { struct nouveau_drm *drm = nouveau_drm(dev); struct nvbios *bios = &drm->vbios; - struct pci_dev *pdev; int ret; /* only relevant for PCI devices */ if (!dev_is_pci(dev->dev)) return 0; - pdev = to_pci_dev(dev->dev); if (!NVInitVBIOS(dev)) return -ENODEV; From patchwork Fri Jan 15 18:16:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366153 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED796C433E9 for ; Fri, 15 Jan 2021 18:18:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB4D523AC4 for ; Fri, 15 Jan 2021 18:18:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387567AbhAOSRu (ORCPT ); Fri, 15 Jan 2021 13:17:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388568AbhAOSRn (ORCPT ); Fri, 15 Jan 2021 13:17:43 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01B55C0617BD for ; Fri, 15 Jan 2021 10:16:46 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id c5so10209167wrp.6 for ; Fri, 15 Jan 2021 10:16:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uVp68mdiDdBXS5aeK/400FDUtXHrGa18qKz0SHB/q8Y=; b=FZ8N+MseSySo4v1ZYJtrG+RSruEOZbWyzJ1DhpH1v0o9O26kSKf9zYaVCXBCYmJ+EC VoxYOA5ngWznxOD7xhM2a0Pkaizwwul9w7Rfjcea5PZaJm1aoa0R4crh+20jESbp1kdK umz/oOgofPJ5OhfLo6ROYuKEi8ubJWt7mD7CclpQig1hod1srd6KCwkwIc7FESEoj9il zDkA2g6rDRYYmoOHUF5t8Lvf5nek8ri3xn0b2lRsszC/PWDWrDpS9axdl2fnukKBGjXd 5BhHxJV9fsMGGK2Pu3BvSUx0NH1avx4aYo88U1gblimRQ9gQnqZLnM3IMbWIRhg4VHl7 KkkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uVp68mdiDdBXS5aeK/400FDUtXHrGa18qKz0SHB/q8Y=; b=a9z3GMmWVJx5KUYHGL51A0yMJ1F+hV7dEroXfItCHrkZn45QcpZhQNyvbJMrk8eP/g S3VIlElVRUy4rTI9F3By/BEQEqcjWeiJbtqS0apjuOiphBywMJcuxTh5LCfIyMZ2Byxr 7LgP0/CcMG8Y+H+8TvxJSjWIO+R7btmfFGWvJcvycy+Ke+8ylpleliJG9uEC1E9jeDf4 FxAxmNnIQ2yK5cU70RQbSoUTJkyQ/aDFYJyp6GsmPoi3nzwFP2B1fy3kVw+o2BIbmBYv 78clJoz18IZhLncIAmQEtQ2V2NdQeNvCB/wAaSr+fW0SrcRR+N4XCf/FduWLvhypKovl PatA== X-Gm-Message-State: AOAM530ED8Tzg4r8mGd5HuFpLwm2/JuhUWSgSiKnNN1/E5kVsfhrvlff Bw/NAVqHCwZ86axPGkgSRMjhhw== X-Google-Smtp-Source: ABdhPJwrZlGGrGjAf3GMC7apd31gRe5Dhy4mYcG3vGI74Rt7B8oSthJtP0F4vFDP74WcZg3XO1aKvg== X-Received: by 2002:a5d:4fcf:: with SMTP id h15mr14103236wrw.323.1610734604791; Fri, 15 Jan 2021 10:16:44 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:43 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Ben Skeggs , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org Subject: [PATCH 28/29] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block Date: Fri, 15 Jan 2021 18:16:00 +0000 Message-Id: <20210115181601.3432599-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or member 'filp' not described in 'nouveau_compat_ioctl' drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or member 'cmd' not described in 'nouveau_compat_ioctl' drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or member 'arg' not described in 'nouveau_compat_ioctl' Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/nouveau/nouveau_ioc32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ioc32.c b/drivers/gpu/drm/nouveau/nouveau_ioc32.c index 8ddf9b2325a42..2af3615c5205c 100644 --- a/drivers/gpu/drm/nouveau/nouveau_ioc32.c +++ b/drivers/gpu/drm/nouveau/nouveau_ioc32.c @@ -38,7 +38,7 @@ #include "nouveau_ioctl.h" -/** +/* * Called whenever a 32-bit process running under a 64-bit kernel * performs an ioctl on /dev/dri/card. * From patchwork Fri Jan 15 18:16:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1366160 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91FEBC433DB for ; Fri, 15 Jan 2021 18:18:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F8F923A58 for ; Fri, 15 Jan 2021 18:18:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388671AbhAOSSR (ORCPT ); Fri, 15 Jan 2021 13:18:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388651AbhAOSSI (ORCPT ); Fri, 15 Jan 2021 13:18:08 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9946BC061381 for ; Fri, 15 Jan 2021 10:16:47 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id d13so10176973wrc.13 for ; Fri, 15 Jan 2021 10:16:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8ouoNyIGf3M12ncW8jNmga8ZhB/umTlAexno2+hm9vw=; b=PN4ofpG3AFQIY2HDhtrxDHd3v0+xd4onwEz7G2/zC+rhfE4HirmzmL3jcXLpUYXBOi 1hKzvGAxrSr6Dv8cDtBOLdA7LW3HUMbsDnWopgDjwrGvgzeyJHyJwJWkktXJjDTKYn5x 6sdobPOvJJIR/TrcLU+En4Nb4Sqr3ym2MpFPjZERoM0EqXn73uEydbCIdma4dh+mEVpS 9T/msFV3PGGbNj49yLhdVehCCKoHHScJgdSAS89oR4U37UhK/tfSoY4zcAxgsB3IEg6M gagHknlc1GH0nljzwa8FvQWUO/kBx3xMgu49tE3RqzKT+TqiG4u92puwvRgzcDEP2/vs 8tag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8ouoNyIGf3M12ncW8jNmga8ZhB/umTlAexno2+hm9vw=; b=Nnntc0ngCNWxyEA8r/K0mKG0Ao9ajJGKFI9aUuHVOz8xTzqQlcPfLp6w18K+FkFsKq m5qIOkIF3iM9kBg9HyVAmc+kdLzWUv40OL0D/PY01xqy2ybRtLbrB5j4M5ks0SOT2AcZ 1fpd36salz6R2Yl11s+xmgerqSf0XO6W7k9wKk8ecLJsIzBMNWXBfvwB634VzGtZpfSU zXv9+jE2BqLDAIGzkI2VIRtjatT6IJGXm/1BLZtIaTFW0WqmFq+rO5dWiEw4HwBNPz+Y jGBbrZ8o8NLABuoczw9mb0mbQY+XiO2jQLyxsDi+Qjpc63xytktFEn+DlMHC53OhD/ME BrJg== X-Gm-Message-State: AOAM531LvxNZVrHwzlzuMdC8ILakDwi24N9dQwHwYB9M+qctt9UYSE57 AvgqtPZ/iHuxZXsCn2SpmkLnMA== X-Google-Smtp-Source: ABdhPJypPfWiZJEwtJ8E9isJbQjNIe0ev/rxFYQX2OcbRtBc5hQl2j1aWEaiYzfS5p/hRAPbYrpcgA== X-Received: by 2002:adf:ef49:: with SMTP id c9mr10087109wrp.172.1610734606342; Fri, 15 Jan 2021 10:16:46 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:45 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , Roland Scheidegger , Zack Rusin , David Airlie , Daniel Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , Dave Airlie , Rob Clark , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH 29/29] drm/vmwgfx/ttm_object: Reorder header to immediately precede its struct Date: Fri, 15 Jan 2021 18:16:01 +0000 Message-Id: <20210115181601.3432599-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Also add missing description for 'refcount' Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/ttm_object.c:60: error: Cannot parse struct or union! Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: Dave Airlie Cc: Rob Clark Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vmwgfx/ttm_object.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/ttm_object.c b/drivers/gpu/drm/vmwgfx/ttm_object.c index b3fdc630497cb..112394dd0ab6a 100644 --- a/drivers/gpu/drm/vmwgfx/ttm_object.c +++ b/drivers/gpu/drm/vmwgfx/ttm_object.c @@ -42,6 +42,14 @@ */ +#define pr_fmt(fmt) "[TTM] " fmt + +#include +#include +#include +#include +#include "ttm_object.h" + /** * struct ttm_object_file * @@ -55,16 +63,9 @@ * * @ref_hash: Hash tables of ref objects, one per ttm_ref_type, * for fast lookup of ref objects given a base object. + * + * @refcount: reference/usage count */ - -#define pr_fmt(fmt) "[TTM] " fmt - -#include -#include -#include -#include -#include "ttm_object.h" - struct ttm_object_file { struct ttm_object_device *tdev; spinlock_t lock;